Posted	Nick	Remark
#openstack-nova - 2019-02-26
02:05:53	artom	mriedem_afk, alex_xu, I run https://review.rdoproject.org/r/#/c/18832/ against the Nova patch series
02:06:20	artom	It's a tempest plugin that massively subverts what tempest is for, but allows us to test stuff like this in an automated fashion
02:06:58	artom	In there I have 3 tests for now: test that CPU pinning information is updated, test that emulator thread pinning information is updated, and test that hugepages information is updated.
02:07:28	artom	The update I just pushed to the Nova patches passed all 3 tests
02:07:57	artom	I'll write an ML or something, to have it in writing in a more permanent fashion
02:08:07	artom	But for now, I'm gonna go get swole at the gym, then sleep
02:08:23	artom	To be back harder tomorrow morning
02:52:09	mriedem	yonglihe: alex_xu: comments in https://review.openstack.org/#/c/621474/ but i'm not sure why server_groups is a list - the server can only be in at most 1 server group
02:52:13	mriedem	returning a list is misleading
02:52:33	mriedem	so i would prefer to have just a key=value, e.g. server_group: <server_group_id or None>
02:52:52	mriedem	i've also added tssurya to the review because I think we can also return the server group in the down-cell case
02:52:52	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Add compute service support for attach/detach root volume https://review.openstack.org/614750
02:54:51	yonglihe	mriedem, that suggested by jaypipes, history in the spec review comments. basically idea is that the group should have belong to multi groups .
02:55:42	mriedem	"should have" is not "the way it is"
02:55:51	mriedem	you currently cannot have a server in more than one group
02:56:04	mriedem	i know people have tried to change the api to allow adding/removing servers to/from groups over time
02:56:07	mriedem	but that is not implemented today
02:56:27	mriedem	is this a list because windriver allows having a server in more than one group?
02:56:30	mriedem	*starlingx
02:56:44	yonglihe	no, it's not in starlingx,
02:58:22	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Add compute service support for attach/detach root volume https://review.openstack.org/614750
02:58:39	openstackgerrit	yenai proposed openstack/nova master: Disconnect volume when encryption is failed https://review.openstack.org/632598
02:58:58	yonglihe	should we switch to just one UUID?
03:00:33	mriedem	i'm also wondering why not return the server group name along with the uuid
03:00:38	mriedem	while we're looking up the server group
03:00:50	mriedem	i know you can get the name of the group via the GET /os-server-groups/{id} api
03:01:01	mriedem	anyway, i'm mostly -1 because of the list
03:01:07	mriedem	adding the name + uuid is just a thought
03:01:41	yonglihe	people think that is redundant, uuid is enough.
03:02:52	yonglihe	ok so we should patch the bp and rebase patch to return just UUID, along with address comments.
03:03:02	mriedem	ugh, i see jaypipes' comment in the spec now https://review.openstack.org/#/c/612255/11/specs/stein/approved/show-server-group.rst@67
03:03:07	mriedem	exactly the opposite of mine :)
03:03:31	yonglihe	should we align that?
03:04:32	mriedem	yonglihe: can you ask about it in the mailing list? i see that my last comment in the spec was https://review.openstack.org/#/c/612255/5/specs/stein/approved/list-server-group.rst@38
03:04:35	mriedem	which wasn't the direction taken
03:05:44	mriedem	i guess i was thinking something more like this based on what i just said in your patch https://review.openstack.org/#/c/612255/4/specs/stein/approved/list-server-group.rst@62
03:06:37	yonglihe	ok, i gonna re-open this on mail thead.
03:09:33	mriedem	yonglihe: thanks, and sorry - but this is pretty straight-forward otherwise and i don't see a problem with getting it merged once we decide on the format
03:10:30	yonglihe	sure, we do it as good as we can, that's good thing to go, i like it -:)
03:31:24	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Convert to raw format into rbd volume https://review.openstack.org/638080
03:51:09	openstackgerrit	Merged openstack/nova master: Create specialist set_macaddr_and_vlan helper. https://review.openstack.org/624227
03:51:58	openstackgerrit	Merged openstack/nova master: Move create_tap_dev into privsep. https://review.openstack.org/624228
05:13:09	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Fix changes-before values in an instance action test https://review.openstack.org/638849
05:40:57	openstackgerrit	yenai proposed openstack/nova master: Disconnect volume when encryption is failed https://review.openstack.org/632598
06:32:38	masber	good afternoon all, is this the right place to ask questions about SRIOV? for some reason nova-compute complains that it can't find the device, however I can't find "the device" in the libvirt device list
06:34:20	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Add compute service support for attach/detach root volume https://review.openstack.org/614750
06:45:43	openstackgerrit	melanie witt proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351
06:45:44	openstackgerrit	melanie witt proposed openstack/nova master: WIP Add get_counts() to InstanceMappingList https://review.openstack.org/638072
06:45:44	openstackgerrit	melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073
06:45:45	openstackgerrit	melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324
06:48:07	openstackgerrit	Yury Kulazhenkov proposed openstack/nova master: remove deprecated os_brick import from ScaleIO driver https://review.openstack.org/638592
06:49:46	openstackgerrit	Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476
07:02:19	openstackgerrit	Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476
07:16:11	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Convert to raw format into rbd volume https://review.openstack.org/638080
08:50:25	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981
08:59:34	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981
09:09:04	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981
09:09:04	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Convert to raw format into rbd volume https://review.openstack.org/638080
09:43:51	openstackgerrit	Michael Still proposed openstack/nova master: Move set_vf_interface_vlan to be with its only caller. https://review.openstack.org/624229
09:43:52	openstackgerrit	Michael Still proposed openstack/nova master: Move DHCP releasing to privsep. https://review.openstack.org/624230
09:43:52	openstackgerrit	Michael Still proposed openstack/nova master: Convert additional IP management calls to privsep. https://review.openstack.org/624231
09:43:53	openstackgerrit	Michael Still proposed openstack/nova master: Move route management to privsep. https://review.openstack.org/624232
09:43:53	openstackgerrit	Michael Still proposed openstack/nova master: Move additional IP address management to privsep. https://review.openstack.org/624591
09:43:54	openstackgerrit	Michael Still proposed openstack/nova master: Move slight bonkers IP management to privsep. https://review.openstack.org/624592
09:43:54	openstackgerrit	Michael Still proposed openstack/nova master: Move arping to privsep. https://review.openstack.org/624593
09:43:55	openstackgerrit	Michael Still proposed openstack/nova master: Move cleaning conntrack to privsep. https://review.openstack.org/624594
09:43:55	openstackgerrit	Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431
09:43:56	openstackgerrit	Michael Still proposed openstack/nova master: Move killing processes to privsep. https://review.openstack.org/635432
09:43:56	openstackgerrit	Michael Still proposed openstack/nova master: Move FP device creation and deletion to privsep. https://review.openstack.org/635433
09:43:57	openstackgerrit	Michael Still proposed openstack/nova master: Cleanup the exec_ebtables code a little. https://review.openstack.org/635434
09:43:57	openstackgerrit	Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435
09:43:58	openstackgerrit	Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436
09:43:58	openstackgerrit	Michael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.openstack.org/636508
09:43:59	openstackgerrit	Michael Still proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.openstack.org/639280
09:44:00	openstackgerrit	Michael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.openstack.org/639281
09:44:00	openstackgerrit	Michael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.openstack.org/639282
10:20:04	openstackgerrit	Stephen Finucane proposed openstack/os-vif master: docs: Use sphinx.ext.autodoc for VIF types https://review.openstack.org/638404
10:20:05	openstackgerrit	Stephen Finucane proposed openstack/os-vif master: docs: Use sphinx.ext.autodoc for profile, datapath offload types https://review.openstack.org/638405
10:29:56	aspiers	cfriesen: your suggestion exactly describes what I already pushed to Gerrit :-) https://review.openstack.org/#/c/638680/
10:30:37	aspiers	kashyap: I was told to ask your advice on this http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-02-25.log.html#t2019-02-25T23:18:05
10:30:50	kashyap	aspiers: Hi
10:31:04	kashyap	I'm deeply buried in a different context; will get back to you
10:31:25	aspiers	kashyap: ok np, thanks!
10:31:35	kashyap	aspiers: I lost all the IRC scrollback from yesterday, that's why I didn't see it.
10:31:49	kashyap	aspiers: So it's about machine types and AMD SEV detection
10:31:51	aspiers	kashyap: yeah, I noticed you were not in the channel
10:31:56	aspiers	correct
10:32:09	kashyap	aspiers: Which TZ are you in?
10:32:12	aspiers	and this stack of patches: https://review.openstack.org/#/c/638680/
10:32:18	aspiers	GMT (London, UK)
10:33:34	kashyap	Okido; will come back sometime in the afternoon to this.
10:33:46	kashyap	aspiers: I'll leave you with a related URL: https://review.openstack.org/#/c/631154/ ("WIP: Gracefully handle QEMU machine types for guests")
10:36:42	sean-k-mooney	stephenfin: looking at the other docs changes you pushed im more or less hapy with the final too in the series. ill take a look at them again when the ci reports back but do you want to include them in the release?
10:36:43	aspiers	kashyap: SEV requires q35 but I think that is only loosely related. The main point here is that virConnectGetDomainCapabilities was designed to be invoked just before booting an instance of a specific arch / machine type, not during initialisation of a hypervisor host which can potentially host multiple archs / machine types
10:37:02	aspiers	kashyap: but no rush, I will wait patiently ;-) thanks again!
10:37:05	stephenfin	sean-k-mooney: If you want, go for it. I'm reviewing ralonsoh's native OVSDB patch atm
10:37:46	kashyap	aspiers: Right. One more (couldn't resist), on getDomainCapabilities(), I mentioned it in this WIP spec too (for OVMF): https://review.openstack.org/#/c/506720/6/specs/rocky/approved/ovmf-with-secure-boot-and-smm.rst
10:38:04	aspiers	:)
10:38:33	sean-k-mooney	stephenfin: ok, cool let me know if you want me to respin the py3-functional patches. we might leave the +w of rodolfos change to jaypies
10:38:55	sean-k-mooney	*to jaypipes

Earlier   Later