| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-02-21 | |||
| 21:16:50 | efried | artom: add retrospective section with that line to https://etherpad.openstack.org/p/nova-ptg-train | |
| 21:17:17 | artom | mriedem, oh, I'm fully acknowledging my responsibility in this being massively late | |
| 21:17:45 | melwitt | yes, we do a retro each ptg and yep, just add info there. we usually have a separate etherpad we link to from the ptg pad, since the ptg pad ends up being ginormous | |
| 21:17:46 | mriedem | ok :) | |
| 21:17:55 | artom | I understand that I can't rock up and be like "y'all got 2 weeks to merge my shit" | |
| 21:19:10 | artom | But... it doesn't mean I'll stay silent and not push for it :) | |
| 21:19:32 | artom | That being said, if it doesn't merge I'll only have myself to blame | |
| 21:20:22 | sean-k-mooney | artom: by the way ill need to test this on my hadware setup. ubuntu crashes the l2 guest with nested virt. on centos booting the l2 guest crashes the l1 guest kernel... so i think i need to do a bios/micorcode upgrade before i can do nested ver on my new server :( | |
| 21:20:40 | artom | sean-k-mooney, devstack on fedora 29 works great for me | |
| 21:21:04 | sean-k-mooney | i might test it on my laptop actully nested virt works fine there | |
| 21:21:32 | melwitt | artom: yeah, I think we (or at least I) am just wondering what you mean by "better planning" in this case. not that you're trying to get review lately | |
| 21:21:53 | sean-k-mooney | that said i spent 1300 euro on the workstation to do nested virt ci so i need to fix it anyway | |
| 21:22:06 | melwitt | (and that's mostly rhetorical, we will discuss that on the retro) | |
| 21:22:18 | artom | melwitt, in the sense of committing to less, given our collectives bandwithes | |
| 21:22:23 | artom | (Band... wii?) | |
| 21:22:33 | melwitt | ah. yeah, the eternal issue | |
| 21:24:17 | sean-k-mooney | artom: if noting else there will be a number of low hanging fruit feautre that can land in early trian | |
| 21:24:26 | melwitt | I think if things were staggered more, it would mostly work. but life happens and many things end up coming in at the same time at the end of the cycle, at least that's what it seems to me | |
| 21:24:56 | artom | Heh, naturally, if there's only 1 deadline, everyone will procrastinate until that deadline | |
| 21:25:48 | melwitt | :) | |
| 21:26:54 | mriedem | we've had multiple feature freeze deadlines in the past mind you | |
| 21:26:58 | mriedem | priority and non-priority ff | |
| 21:27:07 | mriedem | and people don't like that either for similar reasons | |
| 21:27:23 | mriedem | can't really process your way out of these problems | |
| 21:27:50 | artom | A thing we do downstream is just punt waaaay early | |
| 21:28:00 | artom | So like, by upstream spec freeze if there's no code up it's punted | |
| 21:28:22 | sean-k-mooney | well that is what the the non priorot feature freeze used to do | |
| 21:28:36 | artom | The live migration stuff is sorta an exception because everyone wants it, so we both punted to Train *and* kept it around in Stein just in case | |
| 21:28:50 | sean-k-mooney | if it was not a priority feature and it was not done by m2 it got punted | |
| 21:29:53 | artom | Maybe not split into priority/non-priority? Just "no patches ready for review by spec freeze? Punt." | |
| 21:30:04 | artom | And then there's more collective bandwidth for the remaining stuff | |
| 21:30:14 | artom | I dunno, we can bikeshed more at the retro I guess | |
| 21:30:39 | melwitt | yeah. open to ideas there, we'll talk about it then in more detail | |
| 21:31:16 | sean-k-mooney | honestly any feature that misses FF i would hope we coudl just target at m1 and actully aim to get more stuff done at teh earliar milestones | |
| 21:31:53 | mriedem | ^ is why we have runways | |
| 21:32:30 | sean-k-mooney | that is true. | |
| 21:32:37 | artom | So, honest question, do they work? For instance, sean-k-mooney's SRIOV live migration stuff got a runway, and then no-one (and I'm just as guilty here) reviewed it | |
| 21:33:31 | mriedem | sure they do | |
| 21:33:42 | mriedem | plenty of stuff has been merged from runways b/c of runways | |
| 21:33:45 | mriedem | trusted certs for example | |
| 21:33:58 | sean-k-mooney | with the bandwith stuff in another runway and with the priority fo that im honestly not that surprised. i think they do help | |
| 21:34:05 | mriedem | there are some things that people just don't have as a priority to review, or comfort in reviewing | |
| 21:34:32 | sean-k-mooney | ya i think it more the latter with the numa stuff | |
| 21:34:44 | sean-k-mooney | few people feel comfortable to review it | |
| 21:34:56 | mriedem | ok i need to do this fup and move on | |
| 21:35:26 | melwitt | and I have to run to an appointment. bbl | |
| 22:04:38 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Follow up for I0c764e441993e32aafef0b18049a425c3c832a50 https://review.openstack.org/638517 | |
| 22:04:42 | mriedem | jaypipes: efried: ^ | |
| 22:05:27 | efried | way to go on that "about one line" thing. | |
| 22:06:05 | mriedem | i wasn't going to make all of the changes in his original patch | |
| 22:06:17 | mriedem | so i went with the full fup and todo's the provider trait cache thing for him :) | |
| 22:16:19 | sean-k-mooney | mriedem: by the way i started review your cross cell migration stuff but before i dig into that series to much is it complete. | |
| 22:17:50 | mriedem | there are still kinks i have to work out and more testing to be added | |
| 22:17:51 | sean-k-mooney | im planning on my sriov migration series and artoms numa migration series again next week. i could try and add your cell migration series to that list if i can make time | |
| 22:18:07 | sean-k-mooney | *planning on testing | |
| 22:18:19 | mriedem | i have no illusions that cross-cell resize is going to land in stein | |
| 22:18:48 | mriedem | but review would be useful nonetheless to get more than just my eyes on it, | |
| 22:18:57 | mriedem | Kevin_Zheng has been reviewing some of it along the way as well | |
| 22:19:14 | mriedem | functional tests start at the change that gets the server to VERIFY_RESIZE status | |
| 22:19:44 | mriedem | i have a known issue with volume attachment tracking as well | |
| 22:20:16 | mriedem | it's all from the bottom up though, so technically we can start merging things and none of it will be used until the very end of the series | |
| 22:20:44 | mriedem | if people need a review guide (like gibi did for the bw provider series) i can post something in the ML | |
| 22:20:44 | sean-k-mooney | ok well while i have at least some of the context of that code loaded i thikn it makes sense to spend my review time on it abit next sprint | |
| 22:23:37 | sean-k-mooney | mriedem: well i havent gotten to any of the involed code yet but sofar all your patches are fairly clear and too the point. you also tend to front load the context with a decent commit message so a review guide might be useful but so far the 2 or 3 patches i have looked at are pretty self evendely correct | |
| 22:25:26 | mriedem | honestly there is a shit load of documentation because i have to keep it straight myself | |
| 22:30:07 | sean-k-mooney | maybe my tastes are changing but while i like self documenting code as i have been looking at longer patchset lately i have found my self like self documetning code with comments and documentation more | |
| 22:31:27 | mriedem | i think you just said the same thing | |
| 22:31:32 | mriedem | "like i like A, i like A" | |
| 22:31:36 | mriedem | *while i like A, i like A | |
| 22:32:06 | mriedem | maybe i don't know what self-documenting code is | |
| 22:32:17 | mriedem | it's what research type people say when you ask what their code does :) | |
| 22:32:19 | mriedem | in my experience | |
| 22:32:56 | sean-k-mooney | for me it its code that is written in such a as the variable names and function make it clear what it should do without requiring a comment | |
| 22:34:03 | sean-k-mooney | but lately even when that is the case i have found that a comment explaining why it does X not how it does x which is obvios for the code is someting i have been thinking about more | |
| 22:35:11 | sean-k-mooney | its somethin i personally want to improve in my own code. | |
| 22:36:39 | sean-k-mooney | i know i can write good documetation and comment to explain why i did somethign but often dont until im asked but when i review your code i often find i dont need to ask | |
| 22:54:25 | aspiers | sean-k-mooney: +1, good variable and function naming is so important (and rare in a lot of projects ...) | |
| 23:11:48 | sean-k-mooney | with some code i have reviewed i woudl have been happier if there were functions. even if they were named badly. giving a name to the thing you are doing and the inputs it operates on helps so much. | |
| 23:12:56 | sean-k-mooney | aspiers: i find that happens more in c then python where peopel will put a comment before and after a pice of code say it does x with y | |
| 23:14:03 | sean-k-mooney | aspiers: instad of creating a function that does x with y and encurring the horror that is the cost of a function call. | |
| 23:14:24 | sean-k-mooney | at least in python that is not an excuse | |
| 23:52:16 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.openstack.org/631244 | |
| 23:52:16 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.openstack.org/631245 | |
| #openstack-nova - 2019-02-22 | |||
| 00:14:01 | openstackgerrit | Merged openstack/nova stable/queens: Note the aggregate allocation ratio restriction in scheduler docs https://review.openstack.org/623547 | |
| 00:30:22 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add description about sort order in API ref guideline https://review.openstack.org/627282 | |
| 00:30:38 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.openstack.org/566153 | |
| 00:31:03 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove deprecated 'os-server-groups' policy https://review.openstack.org/633672 | |
| 00:31:19 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove deprecated 'flavors' policy https://review.openstack.org/633664 | |
| 00:31:47 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add descriptions of numbered resource classes and traits https://review.openstack.org/621494 | |
| 00:32:06 | openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Fix warnings in the document generation https://review.openstack.org/631150 | |
| 02:25:59 | openstackgerrit | YI-JIE,SYU proposed openstack/nova stable/rocky: Remove deprecated nova-consoleauth reference from doc https://review.openstack.org/614055 | |
| 02:27:59 | openstackgerrit | melanie witt proposed openstack/nova master: Add user_id field to InstanceMapping https://review.openstack.org/633350 | |
| 02:28:00 | openstackgerrit | melanie witt proposed openstack/nova master: WIP Add online data migration for populating user_id https://review.openstack.org/633351 | |
| 02:28:00 | openstackgerrit | melanie witt proposed openstack/nova master: WIP Add get_counts() to InstanceMappingList https://review.openstack.org/638072 | |
| 02:28:01 | openstackgerrit | melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | |
| 02:28:01 | openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324 | |
| 02:28:02 | openstackgerrit | melanie witt proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574 | |
| 03:06:45 | alex_xu | artom: efried sorry, I only can say give a try. probably try to find out a time in weekend | |
| 03:13:49 | alex_xu | artom: efried and I definitely can't spell the full name of NUMA, so :) | |
| 03:16:55 | openstackgerrit | Merged openstack/nova stable/queens: Fix destination_type attribute in the bdm_v2 documentation https://review.openstack.org/626875 | |