Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-02-21
22:18:48 mriedem but review would be useful nonetheless to get more than just my eyes on it,
22:18:57 mriedem Kevin_Zheng has been reviewing some of it along the way as well
22:19:14 mriedem functional tests start at the change that gets the server to VERIFY_RESIZE status
22:19:44 mriedem i have a known issue with volume attachment tracking as well
22:20:16 mriedem it's all from the bottom up though, so technically we can start merging things and none of it will be used until the very end of the series
22:20:44 mriedem if people need a review guide (like gibi did for the bw provider series) i can post something in the ML
22:20:44 sean-k-mooney ok well while i have at least some of the context of that code loaded i thikn it makes sense to spend my review time on it abit next sprint
22:23:37 sean-k-mooney mriedem: well i havent gotten to any of the involed code yet but sofar all your patches are fairly clear and too the point. you also tend to front load the context with a decent commit message so a review guide might be useful but so far the 2 or 3 patches i have looked at are pretty self evendely correct
22:25:26 mriedem honestly there is a shit load of documentation because i have to keep it straight myself
22:30:07 sean-k-mooney maybe my tastes are changing but while i like self documenting code as i have been looking at longer patchset lately i have found my self like self documetning code with comments and documentation more
22:31:27 mriedem i think you just said the same thing
22:31:32 mriedem "like i like A, i like A"
22:31:36 mriedem *while i like A, i like A
22:32:06 mriedem maybe i don't know what self-documenting code is
22:32:17 mriedem it's what research type people say when you ask what their code does :)
22:32:19 mriedem in my experience
22:32:56 sean-k-mooney for me it its code that is written in such a as the variable names and function make it clear what it should do without requiring a comment
22:34:03 sean-k-mooney but lately even when that is the case i have found that a comment explaining why it does X not how it does x which is obvios for the code is someting i have been thinking about more
22:35:11 sean-k-mooney its somethin i personally want to improve in my own code.
22:36:39 sean-k-mooney i know i can write good documetation and comment to explain why i did somethign but often dont until im asked but when i review your code i often find i dont need to ask
22:54:25 aspiers sean-k-mooney: +1, good variable and function naming is so important (and rare in a lot of projects ...)
23:11:48 sean-k-mooney with some code i have reviewed i woudl have been happier if there were functions. even if they were named badly. giving a name to the thing you are doing and the inputs it operates on helps so much.
23:12:56 sean-k-mooney aspiers: i find that happens more in c then python where peopel will put a comment before and after a pice of code say it does x with y
23:14:03 sean-k-mooney aspiers: instad of creating a function that does x with y and encurring the horror that is the cost of a function call.
23:14:24 sean-k-mooney at least in python that is not an excuse
23:52:16 openstackgerrit Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.openstack.org/631244
23:52:16 openstackgerrit Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.openstack.org/631245
#openstack-nova - 2019-02-22
00:14:01 openstackgerrit Merged openstack/nova stable/queens: Note the aggregate allocation ratio restriction in scheduler docs https://review.openstack.org/623547
00:30:22 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add description about sort order in API ref guideline https://review.openstack.org/627282
00:30:38 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.openstack.org/566153
00:31:03 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove deprecated 'os-server-groups' policy https://review.openstack.org/633672
00:31:19 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove deprecated 'flavors' policy https://review.openstack.org/633664
00:31:47 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add descriptions of numbered resource classes and traits https://review.openstack.org/621494
00:32:06 openstackgerrit Takashi NATSUME proposed openstack/nova-specs master: Fix warnings in the document generation https://review.openstack.org/631150
02:25:59 openstackgerrit YI-JIE,SYU proposed openstack/nova stable/rocky: Remove deprecated nova-consoleauth reference from doc https://review.openstack.org/614055
02:27:59 openstackgerrit melanie witt proposed openstack/nova master: Add user_id field to InstanceMapping https://review.openstack.org/633350
02:28:00 openstackgerrit melanie witt proposed openstack/nova master: WIP Add online data migration for populating user_id https://review.openstack.org/633351
02:28:00 openstackgerrit melanie witt proposed openstack/nova master: WIP Add get_counts() to InstanceMappingList https://review.openstack.org/638072
02:28:01 openstackgerrit melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073
02:28:01 openstackgerrit melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324
02:28:02 openstackgerrit melanie witt proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574
03:06:45 alex_xu artom: efried sorry, I only can say give a try. probably try to find out a time in weekend
03:13:49 alex_xu artom: efried and I definitely can't spell the full name of NUMA, so :)
03:16:55 openstackgerrit Merged openstack/nova stable/queens: Fix destination_type attribute in the bdm_v2 documentation https://review.openstack.org/626875
03:34:59 openstackgerrit Merged openstack/nova stable/pike: Fix destination_type attribute in the bdm_v2 documentation https://review.openstack.org/626876
03:35:07 openstackgerrit Merged openstack/nova stable/pike: De-dupe subnet IDs when calling neutron /subnets API https://review.openstack.org/632480
03:44:26 alex_xu bryan_stephenson: tox -e docs
03:51:27 openstackgerrit Sundar Nadathur proposed openstack/nova master: WIP: Add Cyborg device profile groups to request spec. https://review.openstack.org/631243
03:51:27 openstackgerrit Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.openstack.org/631244
03:51:28 openstackgerrit Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.openstack.org/631245
03:53:36 openstackgerrit Merged openstack/nova stable/queens: Do not dump all instances in the scheduler https://review.openstack.org/629822
03:53:44 openstackgerrit Merged openstack/nova stable/queens: Fix os-simple-tenant-usage result order https://review.openstack.org/632516
04:54:14 openstackgerrit Merged openstack/os-vif master: Add function "has_table_columns" to OVSDB implementation API https://review.openstack.org/634967
05:33:57 openstackgerrit Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474
05:42:00 openstackgerrit Merged openstack/nova master: Fill the RequestGroup mapping during schedule https://review.openstack.org/619528
05:42:08 openstackgerrit Merged openstack/nova stable/rocky: Don't emit warning when ironic properties are zero https://review.openstack.org/608573
05:47:59 openstackgerrit Yongli He proposed openstack/nova master: Add server subresouce topology API https://review.openstack.org/621476
05:59:35 openstackgerrit Fan Zhang proposed openstack/nova master: Retry after hitting libvirt error VIR_ERR_OPERATION_INVALID in live migration. https://review.openstack.org/612272
06:02:40 openstackgerrit Asmita Singh proposed openstack/python-novaclient master: Handle unicode multi-byte characters https://review.openstack.org/632942
07:03:34 openstackgerrit Yury Kulazhenkov proposed openstack/nova master: remove deprecated os_brick import from ScaleIO driver https://review.openstack.org/638592
07:51:55 openstackgerrit Luyao Zhong proposed openstack/nova master: object: Add pmem_namespaces field to the NUMACell obj https://review.openstack.org/634547
07:51:55 openstackgerrit Luyao Zhong proposed openstack/nova master: object: Add virtual_pmems fields to the InstanceNUMACell obj https://review.openstack.org/634548
07:51:56 openstackgerrit Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configures PMEM namespace when initiating libvirt driver https://review.openstack.org/634549
07:51:56 openstackgerrit Luyao Zhong proposed openstack/nova master: libvirt: Update PMEM namespaces info and usage https://review.openstack.org/634550
07:51:57 openstackgerrit Luyao Zhong proposed openstack/nova master: libvirt: report pmem namespaces resources by provider tree https://review.openstack.org/634551
07:51:57 openstackgerrit Luyao Zhong proposed openstack/nova master: API: parse pmem related flavor extra spec https://review.openstack.org/634552
07:51:58 openstackgerrit Luyao Zhong proposed openstack/nova master: scheduler: translate virtual pmems request to placement request group https://review.openstack.org/634553
07:51:58 openstackgerrit Luyao Zhong proposed openstack/nova master: update _numa_fit_instance_cell for the support of virtual_pmems https://review.openstack.org/634554
07:51:59 openstackgerrit Luyao Zhong proposed openstack/nova master: libvirt: boot VM with vpmems and cleanup vpmems when destroying https://review.openstack.org/634555
07:51:59 openstackgerrit Luyao Zhong proposed openstack/nova master: support VM resizing with vpmem data migration https://review.openstack.org/634556
07:52:44 openstackgerrit ya.wang proposed openstack/nova master: Select cpu model from a list of cpu models https://review.openstack.org/637834
08:17:19 openstackgerrit Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474
09:27:35 openstackgerrit Mark Goddard proposed openstack/nova stable/queens: Don't emit warning when ironic properties are zero https://review.openstack.org/608611
09:47:29 stephenfin lyarwood: Could you do me the honours? https://review.openstack.org/636918
09:47:39 stephenfin Honour?
09:47:41 stephenfin Hmm...
09:50:20 openstackgerrit Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955
09:50:21 openstackgerrit Balazs Gibizer proposed openstack/nova master: cache neutron ports in heal allocation https://review.openstack.org/638207
09:57:20 openstackgerrit Balazs Gibizer proposed openstack/nova master: Follow up for I0c764e441993e32aafef0b18049a425c3c832a50 https://review.openstack.org/638517
09:59:42 lyaaaaarwood finucannot: will do
10:22:25 openstackgerrit Yongli He proposed openstack/nova master: Add server subresouce topology API https://review.openstack.org/621476
10:25:39 yonglihe Hi, jaypipes, you might want to comment https://review.openstack.org/#/c/621474/21, you working on that spec so much. And thanks.
10:51:16 openstackgerrit Luyao Zhong proposed openstack/nova master: object: Add pmem_namespaces field to the NUMACell obj https://review.openstack.org/634547
10:51:16 openstackgerrit Luyao Zhong proposed openstack/nova master: object: Add virtual_pmems fields to the InstanceNUMACell obj https://review.openstack.org/634548
10:51:17 openstackgerrit Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configures PMEM namespace when initiating libvirt driver https://review.openstack.org/634549
10:51:17 openstackgerrit Luyao Zhong proposed openstack/nova master: libvirt: Update PMEM namespaces info and usage https://review.openstack.org/634550
10:51:18 openstackgerrit Luyao Zhong proposed openstack/nova master: libvirt: report pmem namespaces resources by provider tree https://review.openstack.org/634551
10:51:18 openstackgerrit Luyao Zhong proposed openstack/nova master: API: parse pmem related flavor extra spec https://review.openstack.org/634552
10:51:19 openstackgerrit Luyao Zhong proposed openstack/nova master: scheduler: translate virtual pmems request to placement request group https://review.openstack.org/634553
10:51:19 openstackgerrit Luyao Zhong proposed openstack/nova master: update _numa_fit_instance_cell for the support of virtual_pmems https://review.openstack.org/634554
10:51:20 openstackgerrit Luyao Zhong proposed openstack/nova master: libvirt: boot VM with vpmems and cleanup vpmems when destroying https://review.openstack.org/634555
10:51:20 openstackgerrit Luyao Zhong proposed openstack/nova master: support VM resizing with vpmem data migration https://review.openstack.org/634556
11:04:50 openstackgerrit Andrey Volkov proposed openstack/nova master: Check hosts have no instances for AZ rename https://review.openstack.org/509206
11:09:49 openstackgerrit Surya Seetharaman proposed openstack/nova-specs master: Support adding the reason behind a server lock https://review.openstack.org/638629
11:21:53 openstackgerrit Stephen Finucane proposed openstack/os-vif master: docs: Add API docs for VIF types https://review.openstack.org/637009
11:21:54 openstackgerrit Stephen Finucane proposed openstack/os-vif master: docs: Add API docs for profile, datapath offload types https://review.openstack.org/638395
11:21:55 openstackgerrit Stephen Finucane proposed openstack/os-vif master: docs: Start using sphinx.ext.autodoc for VIF types https://review.openstack.org/638404
11:21:56 openstackgerrit Stephen Finucane proposed openstack/os-vif master: doc: Use sphinx.ext.todo for profile, datapath offload types https://review.openstack.org/638405
12:26:55 openstackgerrit Michal Arbet proposed openstack/nova master: Fix python3 compatibility of rbd get_fsid https://review.openstack.org/635220
12:38:46 openstackgerrit Artom Lifshitz proposed openstack/nova-specs master: Clarify upgrade situation in NUMA live migration https://review.openstack.org/638653

Earlier   Later