Earlier  
Posted Nick Remark
#openstack-nova - 2019-01-21
18:14:41 sean-k-mooney i assume it would be ok to add a _rollback_live_migration_at_source to the base driver interface that was a noop and implement it for the libvirt driver?
18:15:27 sean-k-mooney we have have rollback_live_migration_at_destination but that dose not help me.
18:35:34 cdent jaypipes: I believe this is for you: http://existentialcomics.com/comic/273
18:43:56 sean-k-mooney cdent: if only that was the calibar of converstations at a typical bar discussing such matters hehe
18:44:14 cdent i might actually go to bars if that were the case
18:45:15 edleafe sean-k-mooney: I prefer this: http://theincidentaleconomist.com/wordpress/wp-content/uploads/2014/11/sportsball.jpg
18:47:09 sean-k-mooney it is good but i can feel the heat of the browns burn in cdents link from here and i dont even follow american football
19:00:08 openstackgerrit sean mooney proposed openstack/nova master: libvirt: auto detach/attach sriov ports on migration https://review.openstack.org/629589
19:38:28 jaypipes cdent: that is friggin brilliant.
19:44:40 cdent jaypipes: isn't it delightful?
19:49:19 jaypipes cdent: it is indeed.
19:49:50 cdent jaypipes: you may be the Übermensch
19:58:19 jaypipes cdent: heh
20:03:41 sean-k-mooney https://review.openstack.org/#/c/631829/ well this is new. all post_failures and all i have check apparently passed...
21:52:38 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add TargetDBSetupTask https://review.openstack.org/627892
21:52:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581
21:52:39 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtDestTask https://review.openstack.org/627890
21:52:40 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtSourceTask https://review.openstack.org/627891
22:05:45 zzzeek mriedem: am I allowed to +2 + workflow my own sqlalhcemy-migrate patch ?
22:06:10 mriedem zzzeek: which one? the mysqlclient one?
22:06:20 zzzeek the "quote=force" one
22:06:27 mriedem i just approved it
22:06:50 mriedem i would like to avoid self approvals, but on that project i think a single +2/+W is probably OK given it's basically just you and me
22:07:28 zzzeek mriedem: that's what i was asking :)
22:07:46 zzzeek er where is verified coming from on that ? is there another zuul job ?
22:08:46 mriedem zuul will run the gate queue jobs on it
22:09:19 mriedem jobs for that project are defined here https://github.com/openstack-infra/project-config/blob/fcc974bf4c0dc324f93a2aec0520e6e4889c106d/zuul.d/projects.yaml#L8106
22:21:45 mriedem zzzeek: fyi i'm proposing a release for sqla-migrate https://review.openstack.org/632180
22:22:23 zzzeek mriedem: OK so if this does include the quote=force change, note that I bumped the minimum sqlalchemy vresion to 0.9
22:22:49 mriedem yup that's why i did a minor version bump
22:23:14 zzzeek mriedem: OK if that's what we need then that's great
22:23:20 zzzeek sqla 0.9 is like 5 years ago
22:29:04 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add description about sort order in API ref guideline https://review.openstack.org/627282
22:35:09 jaypipes mriedem: so I think I remember what that rebuild bug/issue I was asking you about last week was...
22:35:44 jaypipes mriedem: if we rebuild to same host but change the image from the original image, we do a full select_destinations-code-path again, right?
22:37:02 jaypipes mriedem: but we include a single destination host when doing the select_destinations(), yeah? In order to basically determine if the original destination host is still a match for the new image?
22:38:34 jaypipes mriedem: if this is the case, we're seeing a problem where we're getting NoValidHost back from the scheduler because the amount of resources "used" for the original host doesn't account for the original instance. In other words, we erroneously double-up the amount of requested resources when attempting to ask the scheduler if the original host is still a fit.
22:39:28 jaypipes mriedem: or rather, that we're not correctly subtracting the amount of used original instance resources from the amount we request in the "recreate" scheduler request.
22:39:51 jaypipes gawd, this stuff is hard to talk about in any sort of reasonably clear language, sorry :(
22:47:22 melwitt jaypipes: correct that we go through the scheduler for rebuilds, as of queens. fwiw, it looks like it will say NoValidHost when filters fail https://bugs.launchpad.net/nova/+bug/1744325 but I don't recall issues with doubling up allocations for rebuilds before
22:47:24 openstack Launchpad bug 1744325 in OpenStack Compute (nova) pike "If a rebuild is refused by the scheduler, the instance's imageref is not rolled back" [High,Fix committed] - Assigned to melanie witt (melwitt)
22:48:05 melwitt (that bug shows brief explanation of rebuild going through scheduler and what happens when there's a failure to schedule)
22:50:32 mriedem jaypipes: pretty sure that's been fixed by cfriesen and/or hongbin
22:50:38 mriedem maybe you don't have the backport
22:50:39 jaypipes melwitt: thx Melanie :) as you know, we're on Ocata currently for VMs and I'm seeing that the "solution" internally is "don't change the image when rebuilding"...
22:51:50 jaypipes Have I mentioned I hate the fact that rebuild is basically a crutch because people can't stand to lose their IP addresses because they hard-code them everywhere? :(
22:52:37 melwitt heh, yeah, good ol rebuild
22:53:03 melwitt so, if this is ocata, you wouldn't be going through scheduler for rebuild right?
22:54:17 jaypipes melwitt: yeah, it's been backported.
22:54:35 melwitt ah ok. I'm looking for a bug fix like mriedem mentioned
22:54:40 jaypipes melwitt: well, at least according to https://bugs.launchpad.net/nova/+bug/1744325 (and we have that code merged in our local ocata branch)
22:54:41 openstack Launchpad bug 1744325 in OpenStack Compute (nova) pike "If a rebuild is refused by the scheduler, the instance's imageref is not rolled back" [High,Fix committed] - Assigned to melanie witt (melwitt)
22:55:46 melwitt jaypipes: here we go https://review.openstack.org/561015
22:55:49 melwitt good memory mriedem
22:57:00 jaypipes melwitt: that's it! thank you!
22:57:05 melwitt \o/
#openstack-nova - 2019-01-22
00:13:53 openstackgerrit Merged openstack/os-vif master: do not always plug ovs ports. https://review.openstack.org/631829
04:55:00 openstackgerrit Merged openstack/os-vif master: Cleanup device at the end of 'test_iproute_object_closes_correctly' test https://review.openstack.org/629112
06:17:20 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add minimum value in max_concurrent_live_migrations https://review.openstack.org/632240
07:53:34 jangutter cdent, jaypipes: https://en.wikipedia.org/wiki/Action_Philosophers!
09:18:14 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Import IP implementation modules outside privsep context https://review.openstack.org/629025
09:19:10 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add test to check os_vif.internal.command.ip.exists https://review.openstack.org/632077
09:22:41 jangutter dansmith: remember I threatened some o.vo docs? https://review.openstack.org/#/c/632321
09:28:25 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Per-instance serial number https://review.openstack.org/619953
10:05:56 kashyap Anyone else seeing the StringException failures in the 'openstack-tox-lower-constraints' job?
10:06:00 kashyap http://logs.openstack.org/80/630980/6/check/openstack-tox-lower-constraints/aba7c59/testr_results.html.gz
10:09:25 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: A few miscellaneous items related to "native TLS" https://review.openstack.org/630980
10:09:26 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: docs: Update references to "QEMU-native TLS" document https://review.openstack.org/631283
10:10:28 kashyap gibi: stephenfin ^ When you get a moment, appreicate if you could re-ACK them.
10:14:10 bauzas gibi: morning
10:14:23 bauzas gibi: do you remember a bit of how works the affinity groups ?
10:14:50 bauzas gibi: I'm working on an internal bug about this, but I have a specific issue
10:15:18 bauzas gibi: when booting an instance asking for a group, the group UUID is just a hint
10:20:10 gibi kashyap: ack
10:20:31 gibi bauzas: yes, the group UUID is just a hint
10:21:18 bauzas gibi: do you remember when we transfrom the hint into some InstanceGroup object ?
10:22:45 gibi bauzas: https://github.com/openstack/nova/blob/f7252b586b4b9f5a098fedfa27715b8f7e662af6/nova/scheduler/utils.py#L902
10:23:19 bauzas gibi: yeah, that's what I remembered but I need to check where we call it
10:23:26 bauzas anyway, sorry for pinging you
10:23:40 bauzas gibi: thanks btw. for the help on functional tests for the reshape
10:23:48 gibi bauzas: yeah, I'm just tracing it backwards from there
10:23:57 bauzas I'm really sorry to be out of upstream for the moment
10:24:55 openstackgerrit caoxufeng proposed openstack/nova master: oslo.config>=6.1.0 which is a dependency of nova requires rfc3986>=1.2.0 https://review.openstack.org/632391
10:25:19 gibi bauzas: no worries
10:27:11 gibi bauzas: still not the right spot https://github.com/openstack/nova/blob/00b14a233886cbcaccf1576904571a59ca8b6535/nova/compute/api.py#L876
10:28:07 gibi bauzas: this is the place https://github.com/openstack/nova/blob/00b14a233886cbcaccf1576904571a59ca8b6535/nova/compute/api.py#L1180
10:30:57 gibi kashyap: done
10:32:06 kashyap gibi: Thank you very much. :-)
13:04:51 jaypipes jangutter: ha! that's awesome :)
13:07:06 jangutter jaypipes: I've got the hardcover, it most definitely is.
13:07:18 jaypipes :)
13:55:22 sean-k-mooney jaypipes: hi regarding teh libvirt min version. looking at https://wiki.openstack.org/wiki/LibvirtDistroSupportMatrix#Nova_release_min_version we had planned to set it to somthing in the 3.y.z seriese in stien. do you think setting it to 3.2.0 would be resonable?
13:58:42 mriedem ask kashyap he usually handles that now
13:58:55 mriedem and socializes the plan in the ML
13:59:15 sean-k-mooney well i also can avoid the need to increase the minium versions
13:59:27 kashyap Just finishing up late lunch; be here in 5 min
13:59:53 jaypipes sean-k-mooney: not up to me :) I'm cool with that particular patch, just thought it was worth mentioning that there is no specific MIN_VERSION_XXX for indicating which version is needed for the whole "can set mac to 00:00:00..." ability
14:01:25 sean-k-mooney jaypipes: just replied inline also https://review.openstack.org/#/c/624842/4/nova/network/linux_utils.py@a74
14:01:36 jaypipes sean-k-mooney: ack
14:01:40 sean-k-mooney i can skip removing the code and it will work

Earlier   Later