Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-01-22
10:27:11 gibi bauzas: still not the right spot https://github.com/openstack/nova/blob/00b14a233886cbcaccf1576904571a59ca8b6535/nova/compute/api.py#L876
10:28:07 gibi bauzas: this is the place https://github.com/openstack/nova/blob/00b14a233886cbcaccf1576904571a59ca8b6535/nova/compute/api.py#L1180
10:30:57 gibi kashyap: done
10:32:06 kashyap gibi: Thank you very much. :-)
13:04:51 jaypipes jangutter: ha! that's awesome :)
13:07:06 jangutter jaypipes: I've got the hardcover, it most definitely is.
13:07:18 jaypipes :)
13:55:22 sean-k-mooney jaypipes: hi regarding teh libvirt min version. looking at https://wiki.openstack.org/wiki/LibvirtDistroSupportMatrix#Nova_release_min_version we had planned to set it to somthing in the 3.y.z seriese in stien. do you think setting it to 3.2.0 would be resonable?
13:58:42 mriedem ask kashyap he usually handles that now
13:58:55 mriedem and socializes the plan in the ML
13:59:15 sean-k-mooney well i also can avoid the need to increase the minium versions
13:59:27 kashyap Just finishing up late lunch; be here in 5 min
13:59:53 jaypipes sean-k-mooney: not up to me :) I'm cool with that particular patch, just thought it was worth mentioning that there is no specific MIN_VERSION_XXX for indicating which version is needed for the whole "can set mac to 00:00:00..." ability
14:01:25 sean-k-mooney jaypipes: just replied inline also https://review.openstack.org/#/c/624842/4/nova/network/linux_utils.py@a74
14:01:36 jaypipes sean-k-mooney: ack
14:01:40 sean-k-mooney i can skip removing the code and it will work
14:01:58 sean-k-mooney we can do the removal later when we have a suffient min version
14:04:15 kashyap sean-k-mooney: Hey, so back here.
14:04:36 kashyap sean-k-mooney: To set it to 3.2.0, we need to ensure it is the "LCD"...
14:05:00 kashyap sean-k-mooney: Check out this Nova commit: 489b5f762e2c
14:05:59 kashyap And:
14:05:59 kashyap NEXT_MIN_LIBVIRT_VERSION = (4, 0, 0)
14:06:00 kashyap NEXT_MIN_QEMU_VERSION = (2, 11, 0)
14:06:29 kashyap sean-k-mooney: I'm not sure how did you arrive on libvirt 3.2.0
14:06:40 sean-k-mooney i was askign for stien
14:07:26 kashyap For Stein: 28d337b -- Pick next minimum libvirt / QEMU versions for "Stein"
14:07:31 sean-k-mooney 3.2.0 is needed to resovle a specific sriov issue but i can avoid the version bump by not cleaning up some code and allowing it to fail
14:08:11 kashyap sean-k-mooney: Okay, can do the version compat check across, and let you know in a bit
14:08:35 kashyap But it's normally not nice to "deviate from the plan", as we announced it to the mailing list as well
14:09:22 sean-k-mooney true but the wiki still states it as a draft and i had no idea it was tracked anywhere else
14:10:29 kashyap sean-k-mooney: So, actually I should bump it right now to:
14:10:30 kashyap +NEXT_MIN_LIBVIRT_VERSION = (3, 0, 0)
14:10:30 kashyap +NEXT_MIN_QEMU_VERSION = (2, 8, 0)
14:10:33 sean-k-mooney kashyap: anyway as i said in my reply to jay here https://review.openstack.org/#/c/624842/4/nova/network/linux_utils.py@a74 its not needed
14:11:29 openstackgerrit Matt Riedemann proposed openstack/nova master: Share snapshot image membership with instance owner https://review.openstack.org/630769
14:11:34 kashyap Thanks for the reminder! I lost this TODO item from my Org-Mode file, damn
14:12:24 tosky hi all, did anyone notice an issue when attaching volumes on a devstack/python3/bionic environment? (yes, it may be a cinder issue, but the relevant code is in lib/nova)
14:12:31 tosky I proposed a fix in https://review.openstack.org/#/c/632452/
14:14:24 sean-k-mooney tosky: we have been haveing some issue yes but not sure if its related to that
14:21:59 mriedem stephenfin: can you push through this simple change https://review.openstack.org/#/c/628205/
14:22:08 mriedem that will get the approved bp change on top merged
14:30:44 stephenfin mriedem: I can
14:44:02 openstackgerrit Elod Illes proposed openstack/nova stable/pike: De-dupe subnet IDs when calling neutron /subnets API https://review.openstack.org/632480
15:19:27 openstackgerrit sean mooney proposed openstack/os-vif master: make kuryr-kubernetes-tempest-daemon-octavia non voting https://review.openstack.org/632484
15:21:34 openstackgerrit sean mooney proposed openstack/os-vif master: make kuryr-kubernetes-tempest-daemon-octavia non voting https://review.openstack.org/632484
15:23:41 openstackgerrit sean mooney proposed openstack/os-vif master: make kuryr-kubernetes-tempest-daemon-octavia non voting https://review.openstack.org/632484
15:26:18 sean-k-mooney stephenfin: jaypipes ^ can ye take a look at that. 2 in every 3 ci runs seam to be failing for the k8s job and that is not really a new occurance
15:27:12 sean-k-mooney i have treatened to do this many times in the past and its finally at the point where it has annoyed me enought to right the patch.
15:29:52 jaypipes sean-k-mooney: is "ye" a reference to the fact that I am old(e) English?
15:30:43 sean-k-mooney no its the pluar of you
15:31:20 jangutter sean-k-mooney: y'all is singular, all y'all is plural
15:31:50 jaypipes sean-k-mooney: I'm not entirely sure what pluar is, but I have left a comment on said patch. :P
15:32:10 jaypipes sean-k-mooney: thou are most welcome.
15:32:26 sean-k-mooney y'all presuablly is a contraction of you all then
15:33:25 jaypipes sean-k-mooney: indeed it is. thine thoughts on the matter be correct.
15:34:50 sean-k-mooney ye is till common in ireland partly because in irish we do have distinct words for singualr and plural you so we still use the older english word "ye" for the plural form commonly
15:35:36 jaypipes sean-k-mooney: that's interesting, considering there are not distinct words for "three" and "tree". ;)
15:36:43 jaypipes I will never forget ildikov and I trying to find that town of Houth and all the Dubliners looking at us like we were morons for saying "hooth" like "tooth".
15:37:49 jaypipes sean-k-mooney: in any case, I blame stephenfin for all of it.
15:38:23 sean-k-mooney jaypipes: this might help if you are interested https://en.wikipedia.org/wiki/Hiberno-English
15:38:26 jaypipes (apparently stephenfin doesn't have a proper Irish accent, much to my surprise) :)
15:38:58 ildikov jaypipes: Ireland is a fun place :)
15:39:21 jaypipes ildikov: it is! especially when you miss your train stop!
15:39:48 ildikov jaypipes: yeah, I o
15:40:53 ildikov wouldn't recommend it :)
15:41:11 jaypipes sean-k-mooney, stephenfin: ooooh! on that wikipedia page I've officially found my new favorite Irish word derived from old English: "Eejit".
15:42:51 sean-k-mooney eejit is a great word
15:45:40 sean-k-mooney usually used to refer a harmless idoit or bafoon or equavlent to the irish Amadán pernounced "om a dawn"
15:45:50 jaypipes Also, I have gained some new knowledge: Irish lacks words that directly translate as "yes" or "no"
15:46:38 jangutter jaypipes: That's probably why Nancy Reagan's anti-drug campaign failed there.
15:47:17 mriedem jaypipes: did you sort out that rebuild with double allocation NoValidHost thing? like i said, i'm pretty sure that's been fixed but maybe you don't have the backport
15:49:19 jaypipes mriedem: yup, between yourself and melwitt, found the right patch and am applying it to our ocata downstream this morning. thank you!
15:49:25 jaypipes jangutter: lol!
15:52:13 jangutter sean-k-mooney: my favourite word there is "banjaxed", it's just under my all-time favourite word, "defenestration".
15:52:34 stephenfin `<jaypipes> sean-k-mooney: that's interesting, considering there are not distinct words for "three" and "tree"` :D
15:53:14 jangutter sean-k-mooney: The kuryr-kubernetes-tempest-daemon-octavia job is banjaxed, it should be defenestrated.
15:53:41 openstackgerrit Matt Riedemann proposed openstack/nova master: Convert port to str when validate console port https://review.openstack.org/626853
15:56:21 sean-k-mooney jangutter: stephenfin jangutter im adding some examples of the k8s jobs issue by the way.
15:56:52 jangutter sean-k-mooney: yeah, I've seen a number of them that really should not have been triggered by the os-vif changes.
15:59:36 jaypipes stephenfin: I see at least one person appreciated my joke :)
15:59:50 sean-k-mooney jaypipes: i did too :)
16:01:46 jaypipes sean-k-mooney: :)
16:01:54 jaypipes sean-k-mooney: well, that makes tree of us, then.
16:05:53 sean-k-mooney updated with 5 differnet issue that have required a recheck in the last week https://review.openstack.org/#/c/632484/3
16:09:50 sean-k-mooney huh the k8s schduler service failed to start on the patch to make it non voting... http://logs.openstack.org/84/632484/3/check/kuryr-kubernetes-tempest-daemon-octavia/4bcca98/job-output.txt.gz#_2019-01-22_15_55_22_393153
16:11:27 mriedem zzzeek: this should unblock the sqla-migrate release https://review.openstack.org/#/c/632470/
16:12:26 zzzeek +2ed
16:15:04 sean-k-mooney ralonsoh: jangutter by the way if the current recheck of https://review.openstack.org/#/c/629025/ and https://review.openstack.org/#/c/632077/2 fail can you leave them be until we decide what to do with the k8s job
16:15:34 jangutter sean-k-mooney: yah, not touching 'em.
16:16:09 sean-k-mooney ralonsoh: jangutter im watching them on the zuul status page si ill eiterh rebase or recheck depending on what we decide
16:21:28 jangutter sean-k-mooney: etcd is also not happy: http://logs.openstack.org/84/632484/3/check/kuryr-kubernetes-tempest-daemon-octavia/4bcca98/controller/logs/screen-etcd.txt.gz
16:22:04 sean-k-mooney jangutter: ya ectd proably is why the scheduler did not start
16:23:18 sean-k-mooney i check the logs everytime the job failes but i always seam to root cause it to a setup issue or something unrelated to the patch.
16:23:57 sean-k-mooney dont get me wrong we could break kuryr kubernetese with some change to the ovo but not unit test chagnes
16:24:50 sean-k-mooney i have a todo to add more non-voting jobs to os-vif which i hope to make voting after stien
16:33:57 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: [WIP] libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Stein" https://review.openstack.org/632507
16:35:46 kashyap (If anyone wonders why "WIP" (Work In Progress) and why not Workflow -1 — WIP spares people from clicking on the URL when they see it on IRC.)
16:36:48 kashyap (And putting the Workflow-1 will make the change not appear for those who use dashboards. So using both is good.)
16:36:54 stephenfin mriedem: That has to be a bug with PyPI
16:36:58 stephenfin mriedem: Wait, no. Commented

Earlier   Later