| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-01-18 | |||
| 16:58:40 | cdent | self-funded? It's only legit if its self-funded | |
| 16:59:10 | hansmoleman | it's funded via my non-profit yes | |
| 16:59:10 | gibi | bandwidth hangouts https://hangouts.google.com/call/oZAfCFV3XaH3IxaA0-ITAEEI | |
| 16:59:12 | sean-k-mooney | hi can i get some eye on the 3 os-vif change i just pushed i want to fast track them to do a release of os-vif today to unblock the gate | |
| 16:59:30 | cdent | hansmoleman: the depth you are able to carry a reference is impressive | |
| 16:59:40 | jaypipes | mrhillsman: yes | |
| 17:00:00 | jaypipes | doink, sorry mrhillsman, I meant hansmoleman | |
| 17:00:47 | hansmoleman | https://etherpad.openstack.org/p/bandwidth-way-forward | |
| 17:01:08 | mrhillsman | np | |
| 17:01:47 | hansmoleman | sean-k-mooney: we're on this call if you care | |
| 17:02:03 | sean-k-mooney | oh sorry yes i should join continue with out me | |
| 17:02:42 | sean-k-mooney | ill be there in a sec | |
| 17:03:06 | melwitt | guess no one cares about jgwentworth | |
| 17:04:34 | hansmoleman | so this is the functional test stub https://review.openstack.org/#/c/567268/43/nova/tests/functional/test_servers.py@5711 | |
| 17:04:47 | hansmoleman | to enable the code in functional tests even though the API doesn't allow the new stuff | |
| 17:05:10 | dansmith | hansmoleman: I think that grenade patch makes sense at first glance | |
| 17:08:39 | cdent | gerrit being restarted? | |
| 17:08:51 | cdent | guess so, better now | |
| 17:08:55 | fried_rice | They did threaten that that was going to happen about now. | |
| 17:09:00 | fried_rice | upgrading | |
| 17:09:27 | fried_rice | cdent: http://lists.openstack.org/pipermail/openstack-discuss/2019-January/001833.html | |
| 17:09:33 | cdent | my ability to keep track of things is broken | |
| 17:09:46 | cdent | thanks | |
| 17:10:00 | fried_rice | Crowdsourced thing tracking --^ | |
| 17:25:31 | openstackgerrit | Paul-Emile Element proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363 | |
| 17:30:02 | openstackgerrit | Elod Illes proposed openstack/nova stable/ocata: Make supports_direct_io work on 4096b sector size https://review.openstack.org/631843 | |
| 17:36:22 | leakypipes | mlavalle: mind having a look at my comment on https://review.openstack.org/#/c/631684/1/nova/network/neutronv2/api.py? | |
| 17:36:47 | mlavalle | leakypipes: sure, I'll look at it | |
| 17:38:52 | leakypipes | mlavalle: gracias | |
| 17:39:07 | mlavalle | de nada | |
| 17:47:25 | openstackgerrit | sean mooney proposed openstack/os-vif master: do not always plug ovs ports. https://review.openstack.org/631829 | |
| 17:56:11 | openstackgerrit | sean mooney proposed openstack/os-vif master: Cleanup device at the end of 'test_iproute_object_closes_correctly' test https://review.openstack.org/629112 | |
| 17:56:12 | openstackgerrit | sean mooney proposed openstack/os-vif master: Import IP implementation modules outside privsep context https://review.openstack.org/629025 | |
| 18:10:44 | gibi | melwitt sean-k-mooney hansmoleman leakypipes mlavalle: summary of the hangouts call about the bandwidth feature is on the ML http://lists.openstack.org/pipermail/openstack-discuss/2019-January/001879.html | |
| 18:11:08 | mlavalle | gibi: thanks. have a nice weekend | |
| 18:11:24 | melwitt | gibi: thanks, have a good weekend o/ | |
| 18:11:33 | gibi | same to you | |
| 18:19:47 | openstackgerrit | Merged openstack/nova master: Remove args(os=False) in monkey_patch https://review.openstack.org/568999 | |
| 18:28:45 | sean-k-mooney | melwitt: leakypipes i have submited a patch to release os-vif 1.14.0 to unblock the gates. https://review.openstack.org/#/c/631860/1 it depends on 3 patches that still need to be merged. when zuul comments back will ye be around later to review them? | |
| 18:30:56 | melwitt | sean-k-mooney: we usually use Depends-On in the release patch to hold it for specific things (so it won't pass CI until ready) | |
| 18:31:19 | sean-k-mooney | the release repo jobs dont actully support depends-on | |
| 18:31:28 | sean-k-mooney | i usually add it out of habit | |
| 18:31:35 | sean-k-mooney | but it will fail the validate job | |
| 18:31:41 | sean-k-mooney | until the depencys are merged | |
| 18:31:47 | melwitt | on the first patch, you +2ed your own patch | |
| 18:32:10 | melwitt | yeah, I meant validate job will hold it | |
| 18:32:22 | sean-k-mooney | ya i generally avoid that but im not goint to +w so im going to leave that to others. | |
| 18:32:45 | sean-k-mooney | if we want to have 2 +2 + mine that is fine too | |
| 18:36:35 | melwitt | sean-k-mooney: ok, if os-vif has a single +2 policy, or a self-approval-allowed policy, I haven't been aware of it | |
| 18:37:05 | sean-k-mooney | melwitt: but yes point taken i normally take more time but the neutron folks been pushing to fix this. | |
| 18:37:54 | leakypipes | sean-k-mooney: +2 on bottom patch. | |
| 18:38:42 | sean-k-mooney | self approval + one other has been what we did for quite a while before added nova-core to os-vif as there were 3 active reviews so usually the patch was written by one of those 3 | |
| 18:38:57 | sean-k-mooney | but as i said i generally avoid it | |
| 18:39:43 | melwitt | ok, I wasn't aware of that. thanks | |
| 18:45:25 | sean-k-mooney | leakypipes: since i need to resping the 3 change will i fix the typos in the first while im at it? | |
| 18:48:40 | sean-k-mooney | melwitt: by the way if you want to change to 2 independet +2s for os-vif we can. since nova-core has been added there are more peole that can review but its still mainly myself stephen and jay that do in pratice https://www.stackalytics.com/?module=os-vif | |
| 18:48:49 | leakypipes | sean-k-mooney: up to you. I'm happy to fast-+2 after | |
| 18:49:57 | sean-k-mooney | ok i might as well. it will delay the check jobs but we will have to wait for the gate jobs after anyway so it wont be much of a delay | |
| 18:50:06 | melwitt | sean-k-mooney: no, wasn't implying I want a change. I just didn't know the policy was different than the usual | |
| 19:07:40 | leakypipes | fried_rice: k, I'm +2 on all of https://review.openstack.org/#/q/topic:static-rt-in-compute-mgr | |
| 19:30:51 | sean-k-mooney | by the way for Depends-on are we ment to use ther gerrit url or change id now with zuul v3 | |
| 19:32:40 | sean-k-mooney | i think Depends-On: https://review.openstack.org/#/c/629025/8 is prefered over Depends-on: I1852038b8d40d4aa52c4f8e661bc78e54e0fc966 correct? | |
| 19:37:29 | melwitt | sean-k-mooney: yes, supposed to use gerrit url now i.e. https://review.openstack.org/629025 but you don't need to change it. I was just mentioning FYI for next time to make it easier to see what changes your release request depends on | |
| 19:39:07 | sean-k-mooney | melwitt: well i need to update the sha so ill add it. thanks. i was 90% sure but could not find it documented | |
| 20:06:36 | openstackgerrit | sean mooney proposed openstack/os-vif master: do not always plug ovs ports. https://review.openstack.org/631829 | |
| 20:06:37 | openstackgerrit | sean mooney proposed openstack/os-vif master: Cleanup device at the end of 'test_iproute_object_closes_correctly' test https://review.openstack.org/629112 | |
| 20:06:38 | openstackgerrit | sean mooney proposed openstack/os-vif master: Import IP implementation modules outside privsep context https://review.openstack.org/629025 | |
| 20:07:57 | hansmoleman | dansmith: yeah https://review.openstack.org/#/c/631811/ fixed that tracing once we upgrade | |
| 20:08:47 | dansmith | mriedem: cool, +1d | |
| 20:21:12 | hogepodge | melwitt: mriedem: Do you know if there's a workaround to this bug? https://bugs.launchpad.net/nova/+bug/1755756 | |
| 20:21:14 | openstack | Launchpad bug 1755756 in OpenStack Compute (nova) "ImageUnacceptable: Image is unacceptable: 'qemu-img info' parsing failed" [Undecided,New] - Assigned to pandatt (pandatt) | |
| 20:21:38 | hogepodge | I'm running in to it running a source build on CentOS | |
| 20:24:47 | mriedem | hogepodge: i've never looked at that bug before | |
| 20:25:32 | mriedem | comment from dansmith in there suggests newer qemu-utils might help | |
| 20:26:25 | dansmith | yup | |
| 20:26:40 | hogepodge | dansmith: how do I get those on CentOS? | |
| 20:26:44 | dansmith | it's a new argument that isn't in the older ones. nova always passes it, which means it fails if it's too old | |
| 20:26:48 | dansmith | hogepodge: dunnoski | |
| 20:27:20 | hogepodge | yes, there's a check that shouldn't allow that flag to be sent for older versions (centos install 1.53 by default) | |
| 20:27:20 | mriedem | looking at the nova code, we are doing a version check https://github.com/openstack/nova/blob/stable/queens/nova/virt/images.py#L49-L72 | |
| 20:27:43 | hogepodge | yup, which must be failing | |
| 20:28:17 | dansmith | noted on the bug I think | |
| 20:28:43 | mriedem | hogepodge: what version of nova? | |
| 20:29:01 | hogepodge | master | |
| 20:29:10 | mriedem | that's unpossible | |
| 20:29:25 | dansmith | might also be that backports caused that version calculus to be wrong either on ubuntu or centos | |
| 20:29:35 | dansmith | backports against the distro qemu package I mean | |
| 20:29:36 | mriedem | libvirt driver on master requires qemu >= 2.5 | |
| 20:29:56 | hogepodge | ah, ok. I wonder if I botched the qemu install | |
| 20:30:09 | mriedem | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L224 | |
| 20:30:10 | dansmith | mriedem: pretty sure that the issue was that we installed something, got qemu-utils=something, then upgraded to cloud archive, got a new qemu, but it was fine with the older qeu-utils, and didn't upgrade it | |
| 20:30:55 | mriedem | dansmith: ah ok, so qemu could be 2.10 but qemu-utils could be 2.5 or something | |
| 20:30:56 | dansmith | meaning qemu==N doesn't require qemu-utils==N, just qemu-utils==anything | |
| 20:30:59 | dansmith | right | |
| 20:31:00 | hogepodge | I think what's happening is I've installed centos-release-qemu-ev which has updated qemu in my libvirt container, but not in my compute containers | |
| 20:31:00 | mriedem | yeah | |
| 20:31:03 | mriedem | oh packaging fun | |
| 20:35:55 | hogepodge | Thanks for the info and helping me think through it. I'm going to patch what I think the problem is in Loci, rebuild, and try again. Still, if 2.5 is required I'd just remove that check rather than leave it in as buggy. I can send a patch up if you'd like. | |
| 20:37:30 | mriedem | well, if qemu-img version == qemu-utils version the check would be correct | |
| 20:38:12 | mriedem | i mean, we could instead run qemu-img version or something and try to parse that, but that sucks | |