Earlier  
Posted Nick Remark
#openstack-nova - 2019-01-18
20:26:48 dansmith hogepodge: dunnoski
20:27:20 hogepodge yes, there's a check that shouldn't allow that flag to be sent for older versions (centos install 1.53 by default)
20:27:20 mriedem looking at the nova code, we are doing a version check https://github.com/openstack/nova/blob/stable/queens/nova/virt/images.py#L49-L72
20:27:43 hogepodge yup, which must be failing
20:28:17 dansmith noted on the bug I think
20:28:43 mriedem hogepodge: what version of nova?
20:29:01 hogepodge master
20:29:10 mriedem that's unpossible
20:29:25 dansmith might also be that backports caused that version calculus to be wrong either on ubuntu or centos
20:29:35 dansmith backports against the distro qemu package I mean
20:29:36 mriedem libvirt driver on master requires qemu >= 2.5
20:29:56 hogepodge ah, ok. I wonder if I botched the qemu install
20:30:09 mriedem https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L224
20:30:10 dansmith mriedem: pretty sure that the issue was that we installed something, got qemu-utils=something, then upgraded to cloud archive, got a new qemu, but it was fine with the older qeu-utils, and didn't upgrade it
20:30:55 mriedem dansmith: ah ok, so qemu could be 2.10 but qemu-utils could be 2.5 or something
20:30:56 dansmith meaning qemu==N doesn't require qemu-utils==N, just qemu-utils==anything
20:30:59 dansmith right
20:31:00 hogepodge I think what's happening is I've installed centos-release-qemu-ev which has updated qemu in my libvirt container, but not in my compute containers
20:31:00 mriedem yeah
20:31:03 mriedem oh packaging fun
20:35:55 hogepodge Thanks for the info and helping me think through it. I'm going to patch what I think the problem is in Loci, rebuild, and try again. Still, if 2.5 is required I'd just remove that check rather than leave it in as buggy. I can send a patch up if you'd like.
20:37:30 mriedem well, if qemu-img version == qemu-utils version the check would be correct
20:38:12 mriedem i mean, we could instead run qemu-img version or something and try to parse that, but that sucks
20:38:25 mriedem or parse the output for "unrecognized option '--force-share'"
20:38:34 mriedem but that also kind of sucks when we're already doing a version check
20:40:54 dansmith or just log a better error message and not reinvent everything in the bowels
20:42:20 leakypipes mriedem: hey, I hate launchpad bug search :( do you remember the bug report about rebuild getting a NoValidHost cuz the rebuild wasn't taking into account the original instance's resources properly?
20:44:10 fried_rice leakypipes: Thanks. mriedem, you got https://review.openstack.org/#/q/topic:static-rt-in-compute-mgr in your queue (somewhere :P ) ?
20:53:34 mriedem leakypipes: that doesn't ring a bell - we'd only get novalidhost on rebuild if the image changes
20:53:49 mriedem are you saying something with the scheduler filters in that case isn't getting the original request spec or something?
20:53:55 mriedem like project/user or image id or something?
20:54:19 mriedem fried_rice: oh boy...
20:54:19 mriedem umm
21:07:11 leakypipes mriedem: I was certain there was a patch I reviewed recently-ish that had to do with capacity of a host being falsely exceeded when trying to rebuild a host. maybe it's just old age and I'm exhibiting dementia.
21:07:57 mriedem rebuild or evacuate?
21:10:50 mriedem fried_rice: i don't suppose cern was able to verify that series on their ironic cluster yet right?
21:11:15 mriedem i think their ironic compute service code is still queens
21:11:19 fried_rice mriedem: I don't think so, no.
21:11:24 fried_rice they were gonna, soon.
21:23:23 openstackgerrit Paul-Emile Element proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363
21:42:47 mriedem fried_rice: ok done
21:42:54 mriedem i will have to review the rest of the series next week
22:25:25 fried_rice mriedem_away: Thanks. There's more to the series, if you can. But in particular the top patch (https://review.openstack.org/#/c/620711/) is right near some of the report client singleton stuff you did.
22:46:53 fried_rice leakypipes: a moment of your time?
22:47:40 fried_rice On this RMD thing, I agree as written it's way overblown and crosses a number of lines in the sand.
22:48:13 fried_rice However, I think there are some nuggets of possibilities in there if it is scaled way back and framed in terms of the architecture we've got in place (and forthcoming).
22:52:33 fried_rice - update_provider_tree creates inventory in appropriate providers for ^ (for Train, since we don't have numa modeling, "appropriate providers" == the compute node RP) based on querying RMD or whatever
22:52:33 fried_rice - flavor can contain resource requests for those resource classes in the same way it does today
22:52:33 fried_rice - spawn can pass RMD the allocation information to get the real resources attached to the VM
22:52:33 fried_rice So like:
22:52:33 fried_rice - standard resource classes for just the hard guaranteed minimums, e.g. MIN_LL_CACHE_MB and MIN_MEMORY_BW_MBYTES_SEC
22:54:19 fried_rice None of this dynamic allocation BS; no "burst max" values; communication with RMD via something other than a REST interface to a new service (like via a special file system; maybe I'm misunderstanding, but I think that's a thing).
22:54:36 fried_rice Effectively it's just enabling a couple of new resource classes, plain and simple.
#openstack-nova - 2019-01-19
04:22:27 openstackgerrit Hesam Chobanlou proposed openstack/nova master: unused images are always deleted (add to in-tree hper-v code) https://review.openstack.org/628793
18:21:56 lvdombrkr hello folks
18:22:10 lvdombrkr trying inject root password to instance
18:22:14 lvdombrkr nova config
18:22:35 lvdombrkr [libvirt]
18:22:35 lvdombrkr cpu_mode = host-passthrough
18:22:35 lvdombrkr hw_disk_bus_model=virtio-scsi
18:22:35 lvdombrkr inject_partition = -1
18:22:35 lvdombrkr inject_password = True
18:22:38 lvdombrkr inject_key = True
18:22:55 lvdombrkr but when booting instance get errir on nova logs:
18:23:09 lvdombrkr artition: Please change permissions on /boot/vmlinuz-4.20.0-1.el7.elrepo.x86_64 to 0x644
18:23:09 lvdombrkr 2019-01-19 17:46:09.189 8 WARNING nova.virt.disk.api [req-1de3da23-d4a9-4b6a-bc34-38382d3923d9 a083e68210b6444e8acb66c40d79960b 01ee870b0de94b79a93d49fb43e0784b - default default] Ignoring error injecting data into image <LocalFileImage:{'path': u'/var/lib/nova/instances/ef82f997-2024-4cf0-ac40-0be30b47ba7b/disk', 'format': 'qcow2'}> (Please change permissions on /boot/vmlinuz-4.20.0-1.el7.elrepo.x86_64 to 0x644): LibguestfsCannotReadKernelinject_p
18:23:17 lvdombrkr any ideas how to reslove it?
23:03:31 openstackgerrit Matt Riedemann proposed openstack/nova master: Cleanup soft (anti)affinity weight multiplier options https://review.openstack.org/628205
#openstack-nova - 2019-01-20
02:12:34 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add microversion to expose virtual device tags https://review.openstack.org/631948
#openstack-nova - 2019-01-21
02:01:02 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Don't call begin_detaching when detaching volume from sheveld vm https://review.openstack.org/624959
02:01:20 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add support matrix for Delete (Abort) on-going live migration https://review.openstack.org/625781
03:51:48 openstackgerrit Yikun Jiang proposed openstack/nova master: Per aggregate scheduling weight https://review.openstack.org/628163
07:03:04 openstackgerrit Sagar Waghmare proposed openstack/nova master: Added new repo https://review.openstack.org/632031
08:46:14 openstackgerrit Bhagyashri Shewale proposed openstack/os-resource-classes master: Add PCPU standard resource class https://review.openstack.org/631711
08:53:32 openstackgerrit Merged openstack/gantt master: Retire gantt https://review.openstack.org/630138
08:53:45 openstackgerrit Merged openstack/python-ganttclient master: Retire python-ganttclient https://review.openstack.org/630154
12:01:42 openstackgerrit sean mooney proposed openstack/nova master: Libvirt: do not set mac when unplugging macvtap vf https://review.openstack.org/624842
12:01:42 openstackgerrit sean mooney proposed openstack/nova master: Add free for claimed, allocated devices https://review.openstack.org/616120
12:01:43 openstackgerrit sean mooney proposed openstack/nova master: Add get_instance_pci_request_from_vif https://review.openstack.org/619929
12:01:43 openstackgerrit sean mooney proposed openstack/nova master: Allow per-port modification of vnic_type and profile https://review.openstack.org/607365
12:01:44 openstackgerrit sean mooney proposed openstack/nova master: SR-IOV Live migration indirect port support https://review.openstack.org/620115
12:01:45 openstackgerrit sean mooney proposed openstack/nova master: [WIP] libvirt: auto detach/attach sriov ports on migration https://review.openstack.org/629589
12:05:01 openstackgerrit sean mooney proposed openstack/nova master: Libvirt: do not set mac when unplugging macvtap vf https://review.openstack.org/624842
12:05:02 openstackgerrit sean mooney proposed openstack/nova master: Add free for claimed, allocated devices https://review.openstack.org/616120
12:05:02 openstackgerrit sean mooney proposed openstack/nova master: Allow per-port modification of vnic_type and profile https://review.openstack.org/607365
12:05:03 openstackgerrit sean mooney proposed openstack/nova master: Add get_instance_pci_request_from_vif https://review.openstack.org/619929
12:05:03 openstackgerrit sean mooney proposed openstack/nova master: SR-IOV Live migration indirect port support https://review.openstack.org/620115
12:05:04 openstackgerrit sean mooney proposed openstack/nova master: [WIP] libvirt: auto detach/attach sriov ports on migration https://review.openstack.org/629589
12:38:54 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add test to check os_vif.internal.command.ip.exists https://review.openstack.org/632077
12:52:51 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Cleanup device at the end of 'test_iproute_object_closes_correctly' test https://review.openstack.org/629112
12:57:47 ralonsoh jaypipes, hi. I added the cleanup to avoid leaving any device created in the system if the test goes wrong
13:02:55 jaypipes ralonsoh: morning! :)
13:03:22 jaypipes ralonsoh: was I correct though, that line 183/4 is doing that delete?
13:03:58 ralonsoh jaypipes, yes, the device is being deleted in this line, but this cleanup is just for precaution
13:04:10 jaypipes ralonsoh: the delete of the link itself should be done with an addCleanup() call, but AFAICT, the self._del_device() is ensuring that the other device(s) are deleted appropriately, right?
13:04:36 jaypipes ralonsoh: sure, since the _delete_device() method is idempotent, it won't hurt.
13:05:35 ralonsoh jaypipes, yes, that's the point
13:09:09 jaypipes ralonsoh: ack, ok, I'll push it through.
13:10:04 jaypipes ralonsoh: done
13:10:21 ralonsoh jaypipes, thanks!

Earlier   Later