| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-01-15 | |||
| 18:31:48 | cdent | sean-k-mooney: for nova: https://review.openstack.org/#/c/613386/6 | |
| 18:33:37 | jaypipes | cdent: I'm giddy to get me some good ol' gabbi. | |
| 18:34:15 | cdent | you've installed your alliterative poet guise today | |
| 18:34:15 | sean-k-mooney | ah i see. can gabbi also be used to simulatate an api? e.g. can i write the gabbits locally without needing and openstack/tempest deployment | |
| 18:34:37 | melwitt | cdent: I was about the say the same thing. alliterations and rhymes today I see | |
| 18:35:31 | cdent | sean-k-mooney: something needs to host the api. it can either be "live" like that tempest stuff, or with wsgi-intercept, as the placement functional tests do it | |
| 18:36:15 | sean-k-mooney | cdent: ah yes that was basically my intendt e.g. could you test it with say a tox job or something | |
| 18:36:20 | sean-k-mooney | *env | |
| 18:36:35 | sean-k-mooney | but ya that seams cool | |
| 18:37:04 | jaypipes | cdent: I blame efried for that. | |
| 18:37:16 | cdent | sean-k-mooney: have a look at the placement functional test setup, in tox | |
| 18:37:32 | jaypipes | cdent: it was his surge to purge the scourge of safe_connect that pushed me over the verge. | |
| 18:37:44 | sean-k-mooney | in any case ya it will be nice to seperate out real api test form senario tests | |
| 18:39:02 | sean-k-mooney | the distiction in my head is if you need to ping or ssh to the vm to check something its a senario test. or in other words you should be able to execute the api tests using fake compute nodes but senario test need real instances | |
| 18:43:11 | sean-k-mooney | cdent: is the intent to eventurlly remove the current compute api test form tempest and migrate them to this? | |
| 18:44:00 | cdent | sean-k-mooney: I don't really have a plan or intent. I simply created that so people could see it and think about the options | |
| 18:45:08 | sean-k-mooney | ok the yaml format certenly seams simpler then the tempest python api to do the same. | |
| 18:45:32 | sean-k-mooney | that said im not that familar with tempest eiter so for someone who is that may not hold true | |
| 18:51:26 | stephenfin | sean-k-mooney, alex_xu: Yup, there's an issue there. It's a different bug though. Would have happened with/without sahid's patch http://paste.openstack.org/show/742676/ | |
| 18:53:07 | sean-k-mooney | the bug being https://bugs.launchpad.net/nova/+bug/1811870 | |
| 18:53:09 | openstack | Launchpad bug 1811870 in OpenStack Compute (nova) "libvirt reporting incorrect value of 4k (small) pages" [Undecided,New] | |
| 18:53:41 | stephenfin | sean-k-mooney: Nah, I'm saying it's different to https://launchpad.net/bugs/1810977 | |
| 18:53:42 | openstack | Launchpad bug 1810977 in OpenStack Compute (nova) "Oversubscription broken for instances with NUMA topologies" [Medium,In progress] - Assigned to Stephen Finucane (stephenfinucane) | |
| 18:53:53 | stephenfin | though it's also nothing to do with https://bugs.launchpad.net/nova/+bug/1811870 | |
| 18:53:59 | stephenfin | three bugs in the same piece of the code. Fun! | |
| 18:54:54 | sean-k-mooney | well the best things come in threes | |
| 18:55:30 | stephenfin | that's what they told me in Amsterdam | |
| 18:56:05 | sean-k-mooney | *read your paste... i cant type some times | |
| 18:56:16 | sean-k-mooney | agh reads.... | |
| 18:57:12 | mriedem | melwitt: ack | |
| 18:57:47 | mriedem | melwitt: so are you just going to work that into https://review.openstack.org/#/c/616777/ then? | |
| 18:57:57 | mriedem | with the new TooManyDiskDevices exception? | |
| 18:59:01 | melwitt | mriedem: yeah, that's what I was realizing. the problem is that the "Failure prepping block device" squashes everything in instance fault message. because, if I back out that one commit (the propagate commit) then I get InvalidBDM, but I don't get that message in the instance fault (where the user can see it) | |
| 19:00:45 | melwitt | mriedem: yeah, sorry, I guess if I just catch TooManyDiskDevices specifically (in the same area as the Exception catch-all that squashes), then I could do it | |
| 19:01:06 | mriedem | i left a comment in the top patch - if TooManyDiskDevices extends InvalidBDM then you get that handling for free | |
| 19:01:10 | mriedem | either works | |
| 19:01:15 | melwitt | yeah, I see that now. thanks | |
| 19:18:44 | openstackgerrit | melanie witt proposed openstack/nova master: Add method to generate device names universally https://review.openstack.org/573066 | |
| 19:18:45 | openstackgerrit | melanie witt proposed openstack/nova master: Add configuration of maximum disk devices to attach https://review.openstack.org/616777 | |
| 19:19:45 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Handle libvirt reporting incorrect 4k page quantities https://review.openstack.org/631038 | |
| 19:19:45 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Fix overcommit for NUMA-based instances https://review.openstack.org/629281 | |
| 19:19:46 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Make overcommit check for pinned instance pagesize aware https://review.openstack.org/631053 | |
| 19:19:50 | stephenfin | sean-k-mooney: Done | |
| 19:20:43 | stephenfin | and now I'm off home to watch the UK strap itself even tighter to that stake -_- | |
| 19:21:24 | sean-k-mooney | stephenfin: ya instead of popcorn maybe lyarwood should have grabed wiskey | |
| 19:23:09 | stephenfin | sean-k-mooney: indeed :) | |
| 19:23:10 | stephenfin | meanwhile, mriedem: you'll hate this https://review.openstack.org/#/c/631038/ cfriesen would no doubt be interested too, if he were around | |
| 19:27:34 | mriedem | commented | |
| 19:38:39 | openstackgerrit | Merged openstack/nova stable/rocky: Add links to summit videos in user/cells.rst https://review.openstack.org/627019 | |
| 19:53:27 | sean-k-mooney | a nice simple change for people to review https://review.openstack.org/#/c/573066/10 | |
| 19:54:15 | sean-k-mooney | that said i guess we are still waiting on zuul | |
| 20:10:54 | lyarwood | sean-k-mooney: all brexit related donations of whiskey welcome in the coming days ;) | |
| 20:13:41 | openstackgerrit | Jack Ding proposed openstack/nova master: [WIP] Flavor extra spec and image properties validation https://review.openstack.org/620706 | |
| 20:21:16 | openstackgerrit | Eric Fried proposed openstack/nova master: Reduce calls to placement from _ensure https://review.openstack.org/615677 | |
| 20:21:16 | openstackgerrit | Eric Fried proposed openstack/nova master: Consolidate inventory refresh https://review.openstack.org/615695 | |
| 20:21:17 | openstackgerrit | Eric Fried proposed openstack/nova master: Commonize _update code path https://review.openstack.org/615705 | |
| 20:21:17 | openstackgerrit | Eric Fried proposed openstack/nova master: Rip the report client out of SchedulerClient https://review.openstack.org/617042 | |
| 20:21:18 | openstackgerrit | Eric Fried proposed openstack/nova master: Rip out the SchedulerClient https://review.openstack.org/617049 | |
| 20:21:18 | openstackgerrit | Eric Fried proposed openstack/nova master: Use a static resource tracker in compute manager https://review.openstack.org/620711 | |
| 20:21:35 | efried | jaypipes, cdent, mriedem: Thanks for the reviews, these should be ready now ^^^ | |
| 20:23:19 | jaypipes | efried: np. will re-review tomorrow morn. | |
| 20:36:51 | efried | jaypipes: Thanks. | |
| 20:46:16 | cdent | thanks efried I'll also look tomorrow | |
| 20:46:36 | efried | cdent: Are you on your way out, or can you help me understand https://review.openstack.org/#/c/630745/ quick? | |
| 20:46:51 | cdent | I can look | |
| 20:47:05 | cdent | efried: what's the confusion? | |
| 20:47:24 | efried | first, the commit message makes it sound like there would be a conflict between zuul and tox somehow. I thought each ignored the other. | |
| 20:48:10 | cdent | the tox-siblings functionality used by zuul only works if the tox name and the tox env have he same name, becuse it does some digging around in the tox directory | |
| 20:48:30 | cdent | that was discussed in the change which extracted placement: | |
| 20:48:47 | cdent | (the functional test changes for that, I mean): | |
| 20:48:58 | efried | methinks stephenfin ought to be a reviewer on this patch... | |
| 20:49:17 | cdent | https://review.openstack.org/#/c/617941/ | |
| 20:49:32 | cdent | efried: it's literally: make functional-py37 the same as py36 | |
| 20:49:35 | cdent | py36 already works | |
| 20:49:38 | cdent | py37 does not | |
| 20:49:55 | cdent | py37 was merged at the same time as the placement external fixture stuff | |
| 20:50:13 | cdent | it's just a merge conflict that didn't get caught because we don't do functional-py37 in the gate | |
| 20:50:13 | efried | cdent: So yeah, that was #2: would the problem be exposed by changing .zuul.yaml to add the py37 job, then prove this "fixes" it by rebasing that change on this one? | |
| 20:50:56 | cdent | I didn't want to add the functional-py37 job becuase there isn't consensus to have that in nova yet, and mdbooth already confirmed it by hand | |
| 20:51:27 | efried | Okay. #3, is there (or should there be) a bug about this? | |
| 20:51:35 | cdent | #3: meh | |
| 20:51:56 | cdent | isn't that just overhead, especially since functional-py37 is a nice to have, not a thing we do in the gate that is impacting many | |
| 20:52:06 | cdent | it only showed up because mdbooth encountered some troubles | |
| 20:52:12 | cdent | why not just fix it and get it over with? | |
| 20:52:51 | efried | wfm, just ticking the boxes. | |
| 21:28:04 | melwitt | efried: came across this bug which has something to do with Power8. would you mind taking a look and commenting if any of it makes sense to you? https://bugs.launchpad.net/nova/+bug/1776929 | |
| 21:28:06 | openstack | Launchpad bug 1776929 in OpenStack Compute (nova) "Web Console for Power8 KVM guest sends mouse events to guest mouse instead of guest tablet?" [Undecided,New] | |
| 21:28:35 | efried | melwitt: Neat. We should talk to somebody at IBM about that. mmedvede? | |
| 21:29:11 | efried | melwitt: Even when I worked for IBM (lo those many days ago) I never knew squat about power *k*vm. | |
| 21:30:03 | mmedvede | efried: hehe, I'll take a look. I'll probably need to find someone who is more knowledgeable about this than me | |
| 21:30:24 | melwitt | ok. I don't know anything about power or power kvm so just looking for someone who knows more than me to help triage | |
| 21:30:30 | efried | mmedvede: I'm counting on six degrees here. For sure you'd be one degree closer than me. | |
| 21:30:31 | melwitt | thanks mmedvede | |
| 21:30:49 | efried | melwitt: you, me, mmedvede - three degrees to go. | |
| 21:37:37 | efried | #save | |
| 21:37:49 | efried | damn | |
| 21:42:51 | melwitt | mriedem: reading through your comments. when I said "returns 500" for the server create, I meant via the server fault message. correct that the API returns 202 | |
| 21:44:39 | mriedem | ok i read that as 500 response | |
| 21:45:29 | melwitt | yeah, I know. it needs more context to be clear | |
| 21:45:47 | melwitt | meaning the comment needs to be better or different | |