Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-01-15
21:30:24 melwitt ok. I don't know anything about power or power kvm so just looking for someone who knows more than me to help triage
21:30:30 efried mmedvede: I'm counting on six degrees here. For sure you'd be one degree closer than me.
21:30:31 melwitt thanks mmedvede
21:30:49 efried melwitt: you, me, mmedvede - three degrees to go.
21:37:37 efried #save
21:37:49 efried damn
21:42:51 melwitt mriedem: reading through your comments. when I said "returns 500" for the server create, I meant via the server fault message. correct that the API returns 202
21:44:39 mriedem ok i read that as 500 response
21:45:29 melwitt yeah, I know. it needs more context to be clear
21:45:47 melwitt meaning the comment needs to be better or different
21:46:41 mriedem some of my other comments are musing on side effects of this that could break other things, like rebuild/evacuate/unshelve, but that doesn't necessarily mean you need to change anything
21:46:56 mriedem if the operator f*s you by dropping the limit and then you rebuild and blow up, that's on the operator
21:49:27 melwitt yeah
21:51:17 melwitt I'll go through the comments in detail and add to the patch to have more information where you've pointed out
21:54:49 mriedem melwitt: were you going to abandon https://review.openstack.org/#/c/624832/ ?
21:55:18 melwitt mriedem: yeah. wanted to wait for feedback before doing. sounds like it's clear to abandon now
21:55:32 mriedem yeah i think what you have in the last patch in the series would be sufficient
21:55:50 mriedem thinking about that, you could work that as an assertion wrinkle into the functional test for bfv
21:55:56 mriedem assert that too many devices is in the fault
21:56:12 melwitt I thought I did already. /me looks again
21:56:17 mriedem yeah you did, nvm
21:56:19 mriedem just looked again
21:57:14 melwitt k
22:30:53 mriedem dansmith: random question: you know how the context loses it's cell targeting when it goes over rpc, and then in conductor methods like unshelve_instance we have the targets_cell decorator to re-target the context based on the instance - what happens with the instance._context that is also originally targeted to the cell when the instance is retrieved in the API and it goes over rpc?
22:30:57 openstackgerrit Eric Fried proposed openstack/nova master: Reduce calls to placement from _ensure https://review.openstack.org/615677
22:30:58 openstackgerrit Eric Fried proposed openstack/nova master: Consolidate inventory refresh https://review.openstack.org/615695
22:30:58 openstackgerrit Eric Fried proposed openstack/nova master: Commonize _update code path https://review.openstack.org/615705
22:30:59 openstackgerrit Eric Fried proposed openstack/nova master: Rip the report client out of SchedulerClient https://review.openstack.org/617042
22:30:59 openstackgerrit Eric Fried proposed openstack/nova master: Rip out the SchedulerClient https://review.openstack.org/617049
22:31:00 openstackgerrit Eric Fried proposed openstack/nova master: Use a static resource tracker in compute manager https://review.openstack.org/620711
22:31:10 mriedem does that retain the targeting? because i don't see is re-targeting the instance._context, but yet instance.save() works
22:31:16 mriedem *us
22:32:24 dansmith mriedem: the _context for the objects doesn't go over rpc either, if that's what you're asking
22:32:40 dansmith mriedem: you get a new context on de-serialize from whatever context was used for the rpc call
22:34:50 mriedem ok i'm lost on where that happens
22:34:54 mriedem for the instance._context i mean
22:35:18 dansmith where the _context gets rebuilt on deserialize?
22:35:22 mriedem yeah
22:35:36 dansmith it's deep, probably in ovo, but I can look
22:35:41 dansmith either way.. why?
22:35:51 dansmith I fear these questions come from a readiness to abuse something :)
22:36:24 mriedem because i was rebasing and looking at this again https://review.openstack.org/#/c/627890/2/nova/compute/manager.py@5990 where i'm sending an instance and context, targeted at the source cell, to a host in the target cell
22:36:27 mriedem and that won't work
22:36:57 mriedem i know about targets_cell to retarget the context in the conductor methods, but am wondering where the instance._context is re-targeted so it can continue to do things like instance.save() in conductor
22:37:03 mriedem and have those changes go back to the source cell db
22:37:43 dansmith it won't be re-targeted, it will be un-targeted
22:37:47 mriedem because of the cheating serializer in our tests, chances are i'll be writing a lot of code before i really find out in test if i'm screwing something up fundamental here
22:38:41 dansmith mriedem: the rpc layer calls, via the serializer and _process_object(), the obj_from_primitive, which does: https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L392
22:38:41 mriedem ok so if instance._context is untargeted, and you unshelve, which is in superconductor and presumably is configured for [database]/connection = cell0, where are those instance.save() updates going?
22:39:13 dansmith mriedem: they'd try to go to cell0 and just fail because save() can't find the instance to update
22:39:46 mriedem i'm not sure how tempest isn't blowing up then
22:40:32 dansmith surely because we run through an @targets_cell somewhere yeah?
22:41:32 mriedem ComputeTaskManager.unshelve_instance in conductor has targets_cell yeah
22:41:44 mriedem so that hits before we deserialize?
22:41:50 dansmith after
22:42:08 mriedem and instance._context is getting targeted by reference?
22:42:39 dansmith yeah because instance._context _is_ context
22:42:44 mriedem yeah ok
22:43:29 mriedem ok you can go back to watching jeapordy! now. i'll ask you about this again in another couple of years. :P
22:43:49 dansmith hah
22:43:57 dansmith is that when you're targeting cross-cell resize?
22:44:08 dansmith (to be done... in a couple years)
22:44:20 mriedem umm
22:44:27 dansmith just poking
22:44:30 mriedem i believe march 30 was my given deadline
22:44:37 dansmith I totes believe it
22:44:46 mriedem after which point i will be fired and working at our local video rental place
22:44:59 mriedem of which there is 1
22:45:29 mriedem or, the TSA, i hear things are going well for employees there
22:45:32 dansmith at least you have options
22:45:34 dansmith haha
#openstack-nova - 2019-01-16
00:08:47 openstackgerrit Merged openstack/nova stable/rocky: libvirt: Add workaround to cleanup instance dir when using rbd https://review.openstack.org/627958
00:34:45 openstackgerrit melanie witt proposed openstack/nova master: Use X-Forwarded-Proto as origin protocol if present https://review.openstack.org/631103
02:52:51 openstackgerrit Dakshina Ilangovan proposed openstack/nova-specs master: Nova changes to support Local Resource Management that uses Resource Management Daemon https://review.openstack.org/630817
02:57:08 openstackgerrit Fan Zhang proposed openstack/nova master: Send context.global_id on neutron calls https://review.openstack.org/627034
03:13:41 openstackgerrit Matt Riedemann proposed openstack/nova master: Isolate cell-targeting code in MigrationTask https://review.openstack.org/621310
03:13:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Extract compute API _create_image to compute.utils https://review.openstack.org/621311
03:13:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.openstack.org/614012
03:13:43 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.openstack.org/614035
03:13:43 openstackgerrit Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.openstack.org/614036
03:13:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Change HostManager to allow scheduling to other cells https://review.openstack.org/614037
03:13:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.openstack.org/614353
03:13:45 openstackgerrit Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313
03:13:45 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add initial cross-cell resize tasks https://review.openstack.org/627890
03:13:46 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Prep source host for cross-cell resize https://review.openstack.org/627891
03:13:46 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Create instance data in target cell prior to resize https://review.openstack.org/627892
03:13:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.openstack.org/631123
03:33:46 openstackgerrit Jack Ding proposed openstack/nova master: [WIP] Flavor extra spec and image properties validation https://review.openstack.org/620706
05:59:33 openstackgerrit Merged openstack/nova master: Add method to generate device names universally https://review.openstack.org/573066
06:10:23 openstackgerrit Jie Li proposed openstack/nova master: Support volume-backed server rebuild in compute https://review.openstack.org/625893
06:36:14 openstackgerrit Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474
07:20:43 openstackgerrit Takashi NATSUME proposed openstack/nova-specs master: Fix warnings in the document generation https://review.openstack.org/631150
07:40:18 openstackgerrit Kashyap Chamarthy proposed openstack/nova-specs master: WIP: Gracefully handle QEMU machine types for guests https://review.openstack.org/631154
08:08:00 kashyap What is "T" release named again?
08:08:01 kashyap Train?
08:09:58 kashyap I presume it's still under discussion.
08:24:19 takashin kashyap: It has already been decided officially.
08:24:39 kashyap takashin: What is it? "Train"?
08:24:41 takashin kashyap: See http://lists.openstack.org/pipermail/openstack-dev/2018-November/136464.html and http://lists.openstack.org/pipermail/openstack/2018-November/047172.html
08:24:56 kashyap Ah, thanks. I was looking on 'openstack-discuss' list

Earlier   Later