| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-01-15 | |||
| 15:06:42 | stephenfin | manually set | |
| 15:06:50 | stephenfin | shouldn't matter for hugepages though | |
| 15:06:50 | sean-k-mooney | your ram is set to 16 | |
| 15:06:54 | sean-k-mooney | true | |
| 15:07:15 | sean-k-mooney | do you have your patch applied or master | |
| 15:07:31 | stephenfin | my patch | |
| 15:09:51 | sean-k-mooney | with an explicit pagesize of small we expect https://github.com/openstack/nova/blob/89c2d1056b3f37bad243c7468d974ded71336a0f/nova/virt/hardware.py#L623-L649 to reject it correct | |
| 15:10:52 | stephenfin | Yes, that would be my expectation | |
| 15:11:25 | sean-k-mooney | so you have not modifed that in your patch so that is either broken and has always been or there is something else going on | |
| 15:12:03 | sean-k-mooney | well you changed the name of the fuction it calls but otherwise its the same | |
| 15:27:10 | openstackgerrit | Matt Riedemann proposed openstack/nova master: The field instance_name was added to InstanceCreatePayload https://review.openstack.org/627967 | |
| 15:36:12 | openstackgerrit | Jan Gutter proposed openstack/os-vif master: Clean up versioned object backlevelling code https://review.openstack.org/630976 | |
| 15:40:14 | sean-k-mooney | stephenfin: looks like i was wrong about pinning and memory oversubsription. https://github.com/openstack/nova/commit/892e4032acea379bac6d1ae18fc5271ea17c0131 the intel implementation did not prevent it and the spec did not appove that behavior as a result we do not document it https://docs.openstack.org/nova/pike/admin/cpu-topologies.html#customizing-instance-cpu-pinning-policies. i consider that a | |
| 15:40:16 | sean-k-mooney | long term but which i think we should resolve seperatly | |
| 15:49:04 | mdbooth | cdent: Don't suppose you submitted that tox.ini patch, did you? | |
| 15:50:04 | mdbooth | cdent: NM, some gerrit-fu was a match to the task | |
| 15:52:27 | mriedem | lyarwood: is the conflict in here still valid? https://review.openstack.org/#/c/627958/ | |
| 15:53:40 | lyarwood | mriedem: yeah it's actually due to I217fba9138132b107e9d62895d699d238392e761 landing in stable/rocky after the initial PS I posted | |
| 15:53:49 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: libvirt: Add workaround to cleanup instance dir when using rbd https://review.openstack.org/627958 | |
| 15:54:43 | mriedem | lyarwood: yeah fixe | |
| 15:54:45 | mriedem | *fixed | |
| 15:55:01 | lyarwood | huh, I don't get it anymore, weird. | |
| 15:55:19 | lyarwood | okay well it wasn't clean just after that landed but is now, meh! | |
| 16:20:09 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: docs: Secure live migration with QEMU-native TLS https://review.openstack.org/629627 | |
| 16:20:10 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: A few miscellaneous items related to "native TLS" https://review.openstack.org/630980 | |
| 16:20:44 | kashyap | (Okay, let's put the bikeshed paint back in the cellar.) | |
| 16:22:00 | openstackgerrit | Jan Gutter proposed openstack/os-vif master: Clean up versioned object backlevelling code https://review.openstack.org/630976 | |
| 16:53:41 | cdent | mdbooth: did you find (and then try) that py37 tox fix? I was on the wrong machine to be able to give it a totally robust check | |
| 16:57:46 | mdbooth | cdent: Yes. Tested locally, all good. | |
| 16:57:54 | cdent | mdbooth: great, thanks | |
| 16:58:03 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Send context.global_id on neutron calls https://review.openstack.org/627034 | |
| 16:58:17 | mdbooth | cdent: I rebased my current work on top of it for convenience. | |
| 16:59:46 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Send context.global_id on neutron calls https://review.openstack.org/627603 | |
| 17:01:02 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Send context.global_id on neutron calls https://review.openstack.org/627604 | |
| 17:03:08 | mdbooth | cdent: It breaks my 'testone' script, though, by not using the 'py37' env any more :/ I note that's by design, though. | |
| 17:03:30 | cdent | tis | |
| 17:06:11 | cfriesen | mriedem: so I guess the "specify timeout per live migration request" spec kind of died on the vine? | |
| 17:20:43 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Add a note in "nova service-delete" help about deleting computes https://review.openstack.org/627637 | |
| 17:39:21 | eandersson | It's still not possible to make weights plugins right? | |
| 17:42:58 | mriedem | stephenfin: does the latest version of https://review.openstack.org/#/c/623564/ fix your problem? | |
| 17:43:45 | stephenfin | mriedem: Knee deep in hugepage issues and don't want to unload that context. I can check first thing tomorrow though and post my feedback on the review | |
| 17:44:28 | sean-k-mooney | mriedem: that is in relate to sqlite | |
| 17:44:40 | sean-k-mooney | mriedem: i can test that locally with a docker container and comment back | |
| 17:44:55 | stephenfin | sean-k-mooney: *changes in sqlite highlighted by sqlalchemy-migrate | |
| 17:46:12 | sean-k-mooney | right so if i clone that change an pip install it into my test env i should be able to test it with sqlite 3.26 | |
| 17:46:45 | sean-k-mooney | so i can repoduce the bug locally again and manully test this since your busy | |
| 17:52:24 | jaypipes | gibi: sorry, when is the bw scheduling hangout? | |
| 17:53:08 | sean-k-mooney | jaypipes: ehterpad say jan 18th at 17:00 utc | |
| 17:53:14 | sean-k-mooney | https://etherpad.openstack.org/p/bandwidth-way-forward | |
| 17:53:15 | jaypipes | sean-k-mooney: danke | |
| 17:53:41 | sean-k-mooney | it was originally ment to be an hour ago but was moved | |
| 17:54:22 | jaypipes | ack, I remember it moved but couldn't remember the new time. now on my calendar. thx again | |
| 18:06:05 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Fix overcommit for NUMA-based instances https://review.openstack.org/629281 | |
| 18:06:05 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Handle libvirt reporting incorrect 4k page quantities https://review.openstack.org/631038 | |
| 18:06:32 | stephenfin | sean-k-mooney: ^ | |
| 18:06:40 | stephenfin | alex_xu: too ^ | |
| 18:09:22 | sean-k-mooney | stephenfin: mriedem: commented on https://review.openstack.org/#/c/623564/7. | |
| 18:10:10 | mriedem | thanks | |
| 18:10:22 | mriedem | zzzeek: are you ok with https://review.openstack.org/#/c/623564/ now? | |
| 18:12:22 | sean-k-mooney | stephenfin: looking. i assuem that with both applied the guest with explcit small pages now works? | |
| 18:13:07 | stephenfin | sean-k-mooney: Yeah, the second test case from paste.openstack.org/show/742644/ now does what I'd expect | |
| 18:13:10 | stephenfin | testing the first case now | |
| 18:13:20 | sean-k-mooney | ack | |
| 18:29:01 | sean-k-mooney | stephenfin: left a comment on https://review.openstack.org/#/c/631038/1 | |
| 18:30:27 | cdent | thanks for the review on the gabbi-tempest stuff jaypipes . your comment is exactly why I like it too | |
| 18:31:19 | sean-k-mooney | cdent: gabbi-tempest test for placemet? | |
| 18:31:25 | melwitt | mriedem: thanks for the comments on the potential to leak host-related info here https://review.openstack.org/#/c/624832/5/nova/compute/manager.py I think the approach similar to InvalidBDM sounds safer, so I'm gonna respin | |
| 18:31:48 | cdent | sean-k-mooney: for nova: https://review.openstack.org/#/c/613386/6 | |
| 18:33:37 | jaypipes | cdent: I'm giddy to get me some good ol' gabbi. | |
| 18:34:15 | cdent | you've installed your alliterative poet guise today | |
| 18:34:15 | sean-k-mooney | ah i see. can gabbi also be used to simulatate an api? e.g. can i write the gabbits locally without needing and openstack/tempest deployment | |
| 18:34:37 | melwitt | cdent: I was about the say the same thing. alliterations and rhymes today I see | |
| 18:35:31 | cdent | sean-k-mooney: something needs to host the api. it can either be "live" like that tempest stuff, or with wsgi-intercept, as the placement functional tests do it | |
| 18:36:15 | sean-k-mooney | cdent: ah yes that was basically my intendt e.g. could you test it with say a tox job or something | |
| 18:36:20 | sean-k-mooney | *env | |
| 18:36:35 | sean-k-mooney | but ya that seams cool | |
| 18:37:04 | jaypipes | cdent: I blame efried for that. | |
| 18:37:16 | cdent | sean-k-mooney: have a look at the placement functional test setup, in tox | |
| 18:37:32 | jaypipes | cdent: it was his surge to purge the scourge of safe_connect that pushed me over the verge. | |
| 18:37:44 | sean-k-mooney | in any case ya it will be nice to seperate out real api test form senario tests | |
| 18:39:02 | sean-k-mooney | the distiction in my head is if you need to ping or ssh to the vm to check something its a senario test. or in other words you should be able to execute the api tests using fake compute nodes but senario test need real instances | |
| 18:43:11 | sean-k-mooney | cdent: is the intent to eventurlly remove the current compute api test form tempest and migrate them to this? | |
| 18:44:00 | cdent | sean-k-mooney: I don't really have a plan or intent. I simply created that so people could see it and think about the options | |
| 18:45:08 | sean-k-mooney | ok the yaml format certenly seams simpler then the tempest python api to do the same. | |
| 18:45:32 | sean-k-mooney | that said im not that familar with tempest eiter so for someone who is that may not hold true | |
| 18:51:26 | stephenfin | sean-k-mooney, alex_xu: Yup, there's an issue there. It's a different bug though. Would have happened with/without sahid's patch http://paste.openstack.org/show/742676/ | |
| 18:53:07 | sean-k-mooney | the bug being https://bugs.launchpad.net/nova/+bug/1811870 | |
| 18:53:09 | openstack | Launchpad bug 1811870 in OpenStack Compute (nova) "libvirt reporting incorrect value of 4k (small) pages" [Undecided,New] | |
| 18:53:41 | stephenfin | sean-k-mooney: Nah, I'm saying it's different to https://launchpad.net/bugs/1810977 | |
| 18:53:42 | openstack | Launchpad bug 1810977 in OpenStack Compute (nova) "Oversubscription broken for instances with NUMA topologies" [Medium,In progress] - Assigned to Stephen Finucane (stephenfinucane) | |
| 18:53:53 | stephenfin | though it's also nothing to do with https://bugs.launchpad.net/nova/+bug/1811870 | |
| 18:53:59 | stephenfin | three bugs in the same piece of the code. Fun! | |
| 18:54:54 | sean-k-mooney | well the best things come in threes | |
| 18:55:30 | stephenfin | that's what they told me in Amsterdam | |
| 18:56:05 | sean-k-mooney | *read your paste... i cant type some times | |
| 18:56:16 | sean-k-mooney | agh reads.... | |
| 18:57:12 | mriedem | melwitt: ack | |
| 18:57:47 | mriedem | melwitt: so are you just going to work that into https://review.openstack.org/#/c/616777/ then? | |
| 18:57:57 | mriedem | with the new TooManyDiskDevices exception? | |
| 18:59:01 | melwitt | mriedem: yeah, that's what I was realizing. the problem is that the "Failure prepping block device" squashes everything in instance fault message. because, if I back out that one commit (the propagate commit) then I get InvalidBDM, but I don't get that message in the instance fault (where the user can see it) | |