Posted	Nick	Remark
#openstack-nova - 2019-01-09
17:41:54	openstackgerrit	Stephen Finucane proposed openstack/nova stable/queens: Fail to live migration if instance has a NUMA topology https://review.openstack.org/629597
18:11:47	sean-k-mooney	adrianc: by the way this https://review.openstack.org/#/c/609166/4 is not needed an i can abandon it right
18:14:03	adrianc	sean-k-mooney: yep, you can abandon
18:14:17	sean-k-mooney	cool its replaced by the code in https://review.openstack.org/#/c/619929/7
18:15:29	kashyap	Any rST gurus here, what is wrong here?
18:15:58	kashyap	Assuming a doc called 'live-migration-usage.rst' exists, if I do: "Refer to the :doc:`live-migration-usage`" from another .rst doc, it should Just Work?
18:16:02	sean-k-mooney	kashyap: i just ask stephenfin
18:16:30	sean-k-mooney	kashyap: im not sure if you need to use a relivie path
18:16:33	stephenfin	kashyap: the path is relative, so if it's in the same directory, yes
18:16:39	stephenfin	otherwise get those dots out
18:16:47	adrianc	sean-k-mooney: yes, also noticed you added a commit for the direct mode, ill take a look tomorrow
18:16:57	stephenfin	adrianc: been reviewing all those. On the last one
18:17:10	stephenfin	adrianc: Mostly +2 except for minor changes, mostly nits
18:17:13	stephenfin	just fyi :)
18:17:18	kashyap	stephenfin: You mean get those colons out, if it's (it is) in the same dir?
18:17:36	sean-k-mooney	adrianc: ya its still a work in progress ill need to test it properly tomorrow and then add unit tests and a release note
18:17:43	adrianc	stephenfin: :) great!
18:17:47	kashyap	Is this the `diff`?
18:17:47	kashyap	- Refer to the :doc:`live-migration-usage`
18:17:48	stephenfin	kashyap: heh, no. :doc:`../live-migration-usage` (if not same directory)
18:17:48	kashyap	+ Refer to the doc`live-migration-usage`
18:18:03	stephenfin	:doc:`path` is correct
18:18:03	kashyap	It _is_ in the same dir
18:18:07	stephenfin	then you're good
18:18:49	kashyap	stephenfin: Hmm, but look:
18:18:49	kashyap	$> rst2html secure-live-migration-with-qemu-native-tls.rst foo.html
18:18:49	kashyap	secure-live-migration-with-qemu-native-tls.rst:138: (ERROR/3) Unknown interpreted text role "doc".
18:19:01	kashyap	That's the _only_ error between me and dinner.
18:19:11	stephenfin	doc8?
18:19:17	stephenfin	Ignore it, if so
18:19:35	stephenfin	doc8 uses docutils, which doesn't know about doctrees and therefore doesn't have a doc role
18:19:48	stephenfin	doctrees are a purely Sphinx thing
18:20:33	kashyap	Aah, so it should be fine.
18:20:48	stephenfin	yup, all good
18:21:25	kashyap	Thanks!
18:43:49	openstackgerrit	Kashyap Chamarthy proposed openstack/nova master: docs: Secure live migration with QEMU-native TLS https://review.openstack.org/629627
18:45:48	kashyap	melwitt: dansmith ^ First cut
18:45:59	dansmith	cool
18:46:21	melwitt	kashyap: thanks
18:46:31	dansmith	I expect a review from stephenfin on that too
18:46:46	dansmith	which will yield a $number_of_lines count of nit changes
18:47:19	dansmith	I found an issue in the first line already :P
18:47:22	kashyap	Haha, yeah. Happy to get stephenfin's rST eyes
18:47:35	kashyap	dansmith: What is it?
18:47:46	dansmith	kashyap: you have to wait :)
18:48:00	kashyap	Nerves are wracking, dammit. I go better eat
19:23:52	openstackgerrit	Inbar Stolberg proposed openstack/nova master: Author: Inbar Stolberg https://review.openstack.org/629646
19:42:54	dansmith	kashyap fails the build
19:43:00	dansmith	some index thing, I'm sure stephenfin knows
19:54:11	melwitt	sean-k-mooney: I'm pretty sure anything that needs to add a flavor extra spec needs a spec https://blueprints.launchpad.net/nova/+spec/libvirt-disable-pmu-for-realtime-guests
19:54:39	melwitt	any other opinions?
21:56:31	openstackgerrit	Inbar Stolberg proposed openstack/nova master: Author: Inbar Stolberg https://review.openstack.org/629646
22:33:35	openstackgerrit	Jack Ding proposed openstack/nova master: [WIP] Flavor extra spec and image properties validation https://review.openstack.org/620706
22:41:56	openstackgerrit	Yongli He proposed openstack/nova-specs master: add spec "show-server-numa-topology" https://review.openstack.org/612256
22:59:26	openstackgerrit	Jack Ding proposed openstack/nova master: [WIP] Flavor extra spec and image properties validation https://review.openstack.org/620706
23:03:24	openstackgerrit	Inbar Stolberg proposed openstack/nova master: Fixes server rebuild if NumaTopologyFilter is used with CPU pinning https://review.openstack.org/629646
23:03:38	openstackgerrit	Jack Ding proposed openstack/nova master: [WIP] Flavor extra spec and image properties validation https://review.openstack.org/620706
#openstack-nova - 2019-01-10
00:28:37	yonglihe	alex_xu, small spec 'server group' is reviewed rounds, i worry it might need few more, we are so close to feature freeze, it's quite small. please put it on your work list
00:28:37	yonglihe	https://review.openstack.org/#/c/612255/12
01:59:47	openstackgerrit	Jie Li proposed openstack/nova master: Support volume-backed server rebuild in compute https://review.openstack.org/625893
02:20:27	openstackgerrit	Merged openstack/nova-specs master: add spec "show-server-numa-topology" https://review.openstack.org/612256
02:22:59	yonglihe	Thanks, Jay, alex_xu, i know this might be too pushy, it's run out of time, i wonder the server-group spec may also close enough. i'm here, could response quickly.
02:32:35	openstackgerrit	Merged openstack/nova-specs master: Propose counting quota usage from placement and API database https://review.openstack.org/509042
04:04:41	openstackgerrit	Jack Ding proposed openstack/nova master: [WIP] Flavor extra spec and image properties validation https://review.openstack.org/620706
05:47:29	openstackgerrit	Hesam Chobanlou proposed openstack/nova master: nova.exception._clean_dict should use oslo_utils.strutils https://review.openstack.org/629769
05:55:23	openstackgerrit	Merged openstack/nova-specs master: Per-instance serial number (spec) https://review.openstack.org/612531
08:13:30	jangutter	;
08:15:06	jangutter	bauzas: thanks for the review on https://review.openstack.org/567148 - did I address your query, or should I amend the spec to explicitly state "no impact in this case"?
08:36:38	openstackgerrit	Jie Li proposed openstack/nova master: Change compute api microversion to support for volume-backed server rebuild https://review.openstack.org/627518
08:54:09	kashyap	dansmith: Thanks for the review!
08:54:20	kashyap	dansmith: Yeah, forgot the index thingie; will fix.
09:06:35	openstackgerrit	Jie Li proposed openstack/nova master: Change compute api microversion to support for volume-backed server rebuild https://review.openstack.org/627518
09:21:59	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Add description about sort order in API ref guideline https://review.openstack.org/627282
09:43:53	openstackgerrit	Takashi NATSUME proposed openstack/nova stable/rocky: Add links to summit videos in user/cells.rst https://review.openstack.org/627019
10:10:05	openstackgerrit	Vlad Gusev proposed openstack/nova stable/queens: Do not dump all instances in the scheduler https://review.openstack.org/629822
10:20:18	openstackgerrit	Jie Li proposed openstack/nova master: Change api microversion to support for bfv https://review.openstack.org/627518
10:35:21	openstackgerrit	Stephen Finucane proposed openstack/nova stable/queens: Fail to live migration if instance has a NUMA topology https://review.openstack.org/629597
10:52:59	openstackgerrit	Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Add workaround to cleanup instance dir when using rbd https://review.openstack.org/627958
11:23:46	openstackgerrit	Jie Li proposed openstack/nova master: Bump API microversion to support rebuild bfv instances https://review.openstack.org/627518
11:30:16	openstackgerrit	Merged openstack/nova-specs master: Spec to implement vRouter HW offloads https://review.openstack.org/567148
11:30:18	openstackgerrit	Kashyap Chamarthy proposed openstack/nova master: docs: Secure live migration with QEMU-native TLS https://review.openstack.org/629627
11:30:27	kashyap	stephenfin: If you have a few minutes today, appreciate your rST (& general) eyes ^
11:30:38	stephenfin	kashyap: Already done
11:30:42	stephenfin	I think
11:30:51	kashyap	Darn, did I _just_ miss your feedback?
11:31:04	stephenfin	Think so
11:32:03	kashyap	Ah, yes. I addressed a few; will address the rest
11:32:10	kashyap	stephenfin: Before I go for lunuch
11:32:27	kashyap	stephenfin: ... on that "has" vs. "have" -- I was referring to Dan's correction of my mistake at the top of the file
11:32:50	kashyap	(So I was referring to )
11:32:58	kashyap	s/to/to my own mistake/
11:34:01	kashyap	stephenfin: Thanks for the comments
11:35:09	kashyap	stephenfin: And yes -- the doc _does_ render; I built locally before pushing
11:35:32	stephenfin	kashyap: render _correctly_?
12:23:27	jaypipes	yonglihe: morning.
12:23:33	jaypipes	yonglihe: or evening for you :)
12:23:44	jaypipes	yonglihe: I'm close on the server group spec. will review shortly.
12:24:57	jaypipes	yonglihe: you might want to reach out to gmann since he was -1 on the spec
12:29:52	jaypipes	yonglihe: ok, re-reviewing. Ghanshyam's suggestions are very good. If you could make those small changes, I'll +W it.
12:29:57	jaypipes	alex_xu: ^^

Earlier   Later