| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-01-10 | |||
| 02:20:27 | openstackgerrit | Merged openstack/nova-specs master: add spec "show-server-numa-topology" https://review.openstack.org/612256 | |
| 02:22:59 | yonglihe | Thanks, Jay, alex_xu, i know this might be too pushy, it's run out of time, i wonder the server-group spec may also close enough. i'm here, could response quickly. | |
| 02:32:35 | openstackgerrit | Merged openstack/nova-specs master: Propose counting quota usage from placement and API database https://review.openstack.org/509042 | |
| 04:04:41 | openstackgerrit | Jack Ding proposed openstack/nova master: [WIP] Flavor extra spec and image properties validation https://review.openstack.org/620706 | |
| 05:47:29 | openstackgerrit | Hesam Chobanlou proposed openstack/nova master: nova.exception._clean_dict should use oslo_utils.strutils https://review.openstack.org/629769 | |
| 05:55:23 | openstackgerrit | Merged openstack/nova-specs master: Per-instance serial number (spec) https://review.openstack.org/612531 | |
| 08:13:30 | jangutter | ; | |
| 08:15:06 | jangutter | bauzas: thanks for the review on https://review.openstack.org/567148 - did I address your query, or should I amend the spec to explicitly state "no impact in this case"? | |
| 08:36:38 | openstackgerrit | Jie Li proposed openstack/nova master: Change compute api microversion to support for volume-backed server rebuild https://review.openstack.org/627518 | |
| 08:54:09 | kashyap | dansmith: Thanks for the review! | |
| 08:54:20 | kashyap | dansmith: Yeah, forgot the index thingie; will fix. | |
| 09:06:35 | openstackgerrit | Jie Li proposed openstack/nova master: Change compute api microversion to support for volume-backed server rebuild https://review.openstack.org/627518 | |
| 09:21:59 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add description about sort order in API ref guideline https://review.openstack.org/627282 | |
| 09:43:53 | openstackgerrit | Takashi NATSUME proposed openstack/nova stable/rocky: Add links to summit videos in user/cells.rst https://review.openstack.org/627019 | |
| 10:10:05 | openstackgerrit | Vlad Gusev proposed openstack/nova stable/queens: Do not dump all instances in the scheduler https://review.openstack.org/629822 | |
| 10:20:18 | openstackgerrit | Jie Li proposed openstack/nova master: Change api microversion to support for bfv https://review.openstack.org/627518 | |
| 10:35:21 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/queens: Fail to live migration if instance has a NUMA topology https://review.openstack.org/629597 | |
| 10:52:59 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Add workaround to cleanup instance dir when using rbd https://review.openstack.org/627958 | |
| 11:23:46 | openstackgerrit | Jie Li proposed openstack/nova master: Bump API microversion to support rebuild bfv instances https://review.openstack.org/627518 | |
| 11:30:16 | openstackgerrit | Merged openstack/nova-specs master: Spec to implement vRouter HW offloads https://review.openstack.org/567148 | |
| 11:30:18 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: docs: Secure live migration with QEMU-native TLS https://review.openstack.org/629627 | |
| 11:30:27 | kashyap | stephenfin: If you have a few minutes today, appreciate your rST (& general) eyes ^ | |
| 11:30:38 | stephenfin | kashyap: Already done | |
| 11:30:42 | stephenfin | I think | |
| 11:30:51 | kashyap | Darn, did I _just_ miss your feedback? | |
| 11:31:04 | stephenfin | Think so | |
| 11:32:03 | kashyap | Ah, yes. I addressed a few; will address the rest | |
| 11:32:10 | kashyap | stephenfin: Before I go for lunuch | |
| 11:32:27 | kashyap | stephenfin: ... on that "has" vs. "have" -- I was referring to Dan's correction of my mistake at the top of the file | |
| 11:32:50 | kashyap | (So I was referring to ) | |
| 11:32:58 | kashyap | s/to/to my own mistake/ | |
| 11:34:01 | kashyap | stephenfin: Thanks for the comments | |
| 11:35:09 | kashyap | stephenfin: And yes -- the doc _does_ render; I built locally before pushing | |
| 11:35:32 | stephenfin | kashyap: render _correctly_? | |
| 12:23:27 | jaypipes | yonglihe: morning. | |
| 12:23:33 | jaypipes | yonglihe: or evening for you :) | |
| 12:23:44 | jaypipes | yonglihe: I'm close on the server group spec. will review shortly. | |
| 12:24:57 | jaypipes | yonglihe: you might want to reach out to gmann since he was -1 on the spec | |
| 12:29:52 | jaypipes | yonglihe: ok, re-reviewing. Ghanshyam's suggestions are very good. If you could make those small changes, I'll +W it. | |
| 12:29:57 | jaypipes | alex_xu: ^^ | |
| 12:41:53 | cdent | jaypipes: you wanna kick https://review.openstack.org/#/c/629299/ in , make cfriesen happy | |
| 12:48:28 | jaypipes | cdent: reviewed. | |
| 12:48:36 | cdent | thanks | |
| 12:49:00 | jaypipes | cdent: I would like at the very least a more descriptive comment and a link to some docs. | |
| 12:49:09 | cdent | seems reasonable | |
| 12:49:19 | jaypipes | ty sir | |
| 12:50:20 | cdent | jaypipes: you might also have some thoughts on https://review.openstack.org/#/c/626055/ , which seems to be a "why aren't you using placement for this" spec | |
| 12:50:46 | cdent | of course given the date, I'm not sure it matters | |
| 12:51:50 | jaypipes | cdent: ack, thanks for the heads up, appreciated. | |
| 13:20:43 | kashyap | stephenfin: Yes, it does. Sorry, that's what I meant. | |
| 13:20:51 | kashyap | Let me show you a quick screenshot | |
| 13:22:38 | kashyap | stephenfin: Here: http://kashyapc.fedorapeople.org/TLS-rST-rendering-just-for-stephenfin.png | |
| 13:24:47 | kashyap | stephenfin: Ah, here is the official rendering: http://logs.openstack.org/27/629627/2/check/openstack-tox-docs/dc52e37/html/admin/secure-live-migration-with-qemu-native-tls.html | |
| 13:44:33 | alex_xu | jaypipes: let me ping yonglihe | |
| 13:44:42 | yonglihe | i'm here | |
| 13:44:48 | yonglihe | working on that | |
| 13:44:56 | jaypipes | heya :) | |
| 13:45:41 | yonglihe | hi, good morning | |
| 13:45:42 | alex_xu | hah, cool | |
| 13:49:18 | stephenfin | kashyap: Ah, all good so | |
| 13:49:25 | stephenfin | One thing I do spot is the note here http://logs.openstack.org/27/629627/2/check/openstack-tox-docs/dc52e37/html/admin/secure-live-migration-with-qemu-native-tls.html#performing-the-migration | |
| 13:49:35 | stephenfin | Indent _is_ off for that | |
| 13:49:44 | stephenfin | (presumably, anyway) | |
| 13:49:57 | kashyap | stephenfin: Ah, that's why it didn't render cleanly | |
| 13:50:00 | kashyap | Good catch | |
| 13:50:09 | gibi | nova meeting starts in 10 minutes in #openstack-meeting | |
| 13:51:19 | kashyap | stephenfin: On that ~~~ vs ---, I checked the existing pattern and went with it | |
| 13:51:26 | stephenfin | yup, agreed | |
| 13:51:31 | stephenfin | I did the same | |
| 13:51:32 | kashyap | stephenfin: Since we're going to "fix it", should I change it to ---? | |
| 13:51:43 | stephenfin | eh, we'll do it all at once, I suspect | |
| 13:51:46 | stephenfin | local consistency first | |
| 13:51:50 | kashyap | Or stay consistent for now, and do a bulk thingie later? | |
| 13:51:52 | kashyap | Yep | |
| 13:51:57 | kashyap | I'll let it be for now. | |
| 13:54:10 | kashyap | stephenfin: Please remind me again -- on using lower case "nova" vs. upper case? | |
| 13:54:44 | stephenfin | kashyap: https://docs.openstack.org/doc-contrib-guide/writing-style/openstack-components.html | |
| 13:56:33 | kashyap | stephenfin: It doesn't tell _why_ | |
| 13:56:38 | openstackgerrit | Yongli He proposed openstack/nova-specs master: add 'show-server-group' spec https://review.openstack.org/612255 | |
| 13:56:43 | kashyap | I think it's in the "Service Project Naming" | |
| 13:56:56 | stephenfin | kashyap: For that, you'll have to ask #openstack-doc. I don't actually recall | |
| 13:57:08 | kashyap | [quote] | |
| 13:57:09 | kashyap | The history of this decision is that the documentation contributors wanted the least amount of cognitive overhead when writing and reviewing. Learning rules about case can be difficult across multiple projects with hundreds of documentation contributors and thousands of changes and additions. Lowercase for project names as a rule is then easiest to review and enforce at this scale and growth | |
| 13:57:15 | kashyap | pattern. | |
| 13:57:17 | kashyap | [/quote] | |
| 13:57:29 | kashyap | So it's to lower the cognitive overhead, at the cost of "impure English". Yikes! | |
| 13:58:00 | cdent | why do you think nova should be uppered? | |
| 13:58:07 | kashyap | That's also part of concentration & focus: using the correct capitalization, punctuation, etc. at the right place | |
| 13:58:19 | kashyap | cdent: It's a proper noun | |
| 13:58:32 | cdent | not all proper nouns are upper cased | |
| 13:59:07 | kashyap | True, though. But in this case "intuition" says so :D | |
| 13:59:14 | kashyap | And "Nova" is a special noun | |
| 13:59:25 | kashyap | But anyway, I'll go with the rule, now that I know the history of it. | |
| 14:00:16 | kashyap | cdent: Random internet person says this: https://grammar.yourdictionary.com/capitalization/rules-for-capitalizing-proper-nouns.html | |
| 14:00:34 | stephenfin | kashyap: Where was that quote from? | |
| 14:00:49 | cdent | kashyap: my response to that is "meh" ;) | |
| 14:00:51 | stephenfin | You might add it to that page I linked, if you find the time | |
| 14:00:53 | kashyap | stephenfin: Ha! I read the doc buried in the doc -- https://governance.openstack.org/tc/reference/service-project-naming.html | |
| 14:01:12 | stephenfin | ahh | |
| 14:01:14 | stephenfin | cool :) | |