Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-12-06
21:41:04 mriedem gaudenz: right in here https://github.com/openstack/devstack-plugin-ceph/blob/39de6df04130cf2f221fb5ba2a9b5ff597de332a/devstack/plugin.sh#L98
21:41:29 efried_cya_jan edleafe, cdent: It appears we're missing a gabbi test for a successful PUT /rps/{u}/inventories/{rc}
21:41:38 efried_cya_jan ...or it's not in that file
21:41:53 mriedem gaudenz: commented in the nova change on the steps
21:41:55 efried_cya_jan Maybe Sundar would like to propose that :)
21:42:10 efried_cya_jan okay, I'm going away again. o/
21:42:42 efried_cya_jan Oh, edleafe, thanks for covering the n-sch summary in the meeting.
21:42:44 Sundar efried_cya_jan: We are still seeing you in December. :/ That apart, https://developer.openstack.org/api-ref/placement/#update-resource-provider-inventories documents only PUT.
21:43:11 efried_cya_jan Sundar: Yes, the document is not clear on the fact that the inventory needs to exist first.
21:43:11 mriedem gaudenz: btw, i'm pretty sure cern was already working on this...
21:43:24 efried_cya_jan Sundar: But the error message on that 400 is.
21:43:25 dansmith Sundar: it's PUT on the provider that works regardless
21:43:33 mriedem gaudenz: melwitt: https://review.openstack.org/#/c/594273/
21:43:34 edleafe efried_cya_jan: I prepared that thinking that you were going to be a man of your word
21:43:35 mriedem so something is fishy
21:43:42 dansmith Sundar: PUT on a provider/class only works after it has been created via PUT on provider
21:44:08 Sundar mriedem: Sorry, didn't get your reference to the devstack-plugin-ceph job. Why is that involved here?
21:44:19 melwitt mriedem: whoa, huh
21:44:34 Sundar dansmith: Makes sense. I just went by the doc.
21:44:39 mriedem https://blueprints.launchpad.net/nova/+spec/extend-in-use-rbd-volumes
21:44:48 mriedem Sundar: that's for gaudenz, not you
21:44:50 efried_cya_jan Sundar: Right, as dansmith is saying, if you do PUT /rps/{u}/inventories with a payload like {'resource_provider_generation': $X, 'inventories': {$RC: {'total': $N, ...}}} then subsequent PUTs on /rps/{u}/inventories/{rc} ought to work.
21:45:53 melwitt o/ efried_cya_jan
21:46:36 melwitt mriedem: thanks for finding that. good to compare/consolidate on this cc gaudenz
21:47:07 gaudenz mriedem: Thanks, for the links. Will have a look.
21:47:08 mriedem i knew about the cern one originally, i thought this was that
21:47:19 mriedem dansmith: you got results https://review.openstack.org/#/c/623282/ it works \o/
21:47:26 mriedem not sure if you want to change that variable name
21:47:31 mriedem i suggest LOGGED_NO_COMPUTES
21:47:49 gaudenz mriedem, melwitt: I cooked up something as a blueprint just now: https://blueprints.launchpad.net/nova/+spec/extend-volume-net does this look good?
21:48:05 mriedem gaudenz: heh, well, there is already a blueprint for this...
21:48:10 mriedem https://blueprints.launchpad.net/nova/+spec/extend-in-use-rbd-volumes
21:48:21 mriedem so...we might as well just mark one superseded (the new one)
21:48:30 mriedem but need you and jose to sort out what the correct solution is here
21:50:02 melwitt I can do the launchpad updates
21:50:46 melwitt gaudenz: yeah, so just use the already existing https://blueprints.launchpad.net/nova/+spec/extend-in-use-rbd-volumes and collaborate with jose on the approach
21:50:47 gaudenz No problem. At least I did not invest too much time in writing the blueprint. I'm fine with marking mine as superseeded.
21:51:44 gaudenz I'll look at jose's patch and contact him. Thanks again for helping out.
21:54:37 mriedem dansmith: unit test failures in https://review.openstack.org/#/c/623283/1
21:54:45 mriedem http://logs.openstack.org/83/623283/1/check/openstack-tox-py27/d6a560e/testr_results.html.gz
21:55:19 melwitt gaudenz: sounds good, thanks
21:57:34 mriedem efried_cya_jan: before i dig into the fewer placement calls from _ensure patch, you've addressed jaypipes' ironic concerns from https://review.openstack.org/#/c/615677/9/nova/compute/resource_tracker.py@812 ?
21:57:48 mriedem i assume so, but want to make sure i'm not going to waste time
22:11:32 dansmith mriedem: hmm, okay, I switched the order at the last minute and then realized that was probably not the best idea an hour later, so that's probably why
22:11:44 dansmith they were all passing before I did that
22:39:27 mriedem coreycb: your wish is my command https://review.openstack.org/#/c/579004/
23:13:01 openstackgerrit Gaudenz Steinlin proposed openstack/nova master: Extend volume for libvirt network volumes (RBD) https://review.openstack.org/613039
23:23:21 openstackgerrit Matt Riedemann proposed openstack/nova stable/rocky: Add functional regression test for bug 1794996 https://review.openstack.org/623348
23:23:21 openstack bug 1794996 in OpenStack Compute (nova) rocky "_destroy_evacuated_instances fails and kills n-cpu startup if lazy-loading flavor on a deleted instance" [High,Triaged] https://launchpad.net/bugs/1794996
23:23:21 openstackgerrit Matt Riedemann proposed openstack/nova stable/rocky: Fix InstanceNotFound during _destroy_evacuated_instances https://review.openstack.org/623349
23:44:34 openstackgerrit Merged openstack/nova master: Remove ironic/pike note from *_allocation_ratio help https://review.openstack.org/620154
23:44:44 openstackgerrit Merged openstack/nova master: Change the default values of XXX_allocation_ratio https://review.openstack.org/602803
23:59:17 openstackgerrit Matt Riedemann proposed openstack/nova stable/queens: Add functional regression test for bug 1794996 https://review.openstack.org/623354
23:59:17 openstack bug 1794996 in OpenStack Compute (nova) rocky "_destroy_evacuated_instances fails and kills n-cpu startup if lazy-loading flavor on a deleted instance" [High,In progress] https://launchpad.net/bugs/1794996 - Assigned to Matt Riedemann (mriedem)
23:59:17 openstackgerrit Matt Riedemann proposed openstack/nova stable/queens: Fix InstanceNotFound during _destroy_evacuated_instances https://review.openstack.org/623355
23:59:17 mriedem omg
#openstack-nova - 2018-12-07
00:11:02 openstackgerrit melanie witt proposed openstack/nova master: Fixed concurrent access to direct io test file https://review.openstack.org/515091
00:40:39 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Add functional regression test for bug 1794996 https://review.openstack.org/623358
00:40:39 openstack bug 1794996 in OpenStack Compute (nova) rocky "_destroy_evacuated_instances fails and kills n-cpu startup if lazy-loading flavor on a deleted instance" [High,In progress] https://launchpad.net/bugs/1794996 - Assigned to Matt Riedemann (mriedem)
00:40:39 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Fix InstanceNotFound during _destroy_evacuated_instances https://review.openstack.org/623359
01:11:34 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Handle tags in _bury_in_cell0 https://review.openstack.org/621856
02:26:54 openstackgerrit melanie witt proposed openstack/nova-specs master: Propose counting quota usage from placement and API database https://review.openstack.org/509042
05:20:11 openstackgerrit Merged openstack/nova master: libvirt: Refactor handling of PCIe root ports https://review.openstack.org/620327
05:20:18 openstackgerrit Merged openstack/nova stable/queens: Make supports_direct_io work on 4096b sector size https://review.openstack.org/619220
05:20:27 openstackgerrit Merged openstack/nova stable/queens: Add regression test for bug #1764883 https://review.openstack.org/621199
05:20:27 openstack bug 1764883 in OpenStack Compute (nova) queens "Evacuation fails if the source host returns while the migration is still in progress" [Medium,In progress] https://launchpad.net/bugs/1764883 - Assigned to Lee Yarwood (lyarwood)
06:37:56 openstackgerrit Merged openstack/nova stable/queens: compute: Ensure pre-migrating instances are destroyed during init_host https://review.openstack.org/621200
06:39:33 openstackgerrit Merged openstack/nova stable/pike: Update docs for _destroy_evacuated_instances https://review.openstack.org/621203
09:30:50 openstackgerrit Balazs Gibizer proposed openstack/nova master: Ignore MoxStubout deprecation warnings https://review.openstack.org/623309
09:43:39 cdent stephenfin: I'm confused and frustrated and stuck on https://review.openstack.org/#/c/622972/ If you have any ideas, or can just fix it, that would be most helpful.
10:20:03 mdbooth lyarwood: https://review.openstack.org/#/c/618478/ I agree with melwitt's comment that instance.host checking is a risk. Could you audit it? We're hopefully ok.
10:21:08 lyarwood mdbooth: I've had a look already and I couldn't see a way for us to call cleanup on the source during a failure
10:21:40 lyarwood mdbooth: we would call it on the dest but the whole point of the workaround is to ensure the directory is cleaned when it _isn't_ shared
10:21:54 lyarwood mdbooth: so if it's enabled in that situation that's on the operator
10:22:06 mdbooth lyarwood: I would personally start by looking at everywhere in ComputeManager which sets instance.host, and work back from there. Don't assume it necessarily makes sense.
10:22:47 lyarwood mdbooth: there's zero point in looking at that if we don't call cleanup on the source during a failure
10:23:24 lyarwood mdbooth: which we wouldn't do for LM, either post-copy or pre-copy AFAIK
10:23:57 lyarwood I'll look again at where we are calling cleanup to confirm but I'm sure this isn't an issue
10:24:16 mdbooth lyarwood: I strongly suspect it isn't an issue.
10:25:53 lyarwood DNM 0 [-------x--] 1 LGTM
10:26:01 mdbooth lyarwood: +1
10:27:48 mdbooth lyarwood: Are there any circumstances where we could end up calling cleanup on the source (e.g. init_host, periodic) where instance.host is erroneously set to dest?
10:28:22 openstackgerrit Stephen Finucane proposed openstack/nova master: Correct lower-constraints.txt and the related tox job https://review.openstack.org/622972
10:31:28 lyarwood mdbooth: cleaning up evacuations that have failed in a weird way but again with this workaround enabled you'd only see console.log, kernel etc removed
10:31:57 lyarwood mdbooth: I can't say I've ever seen an evacuation fail in that way however
10:32:08 lyarwood mdbooth: instance.host updated but the instance is still on the source
10:32:22 mdbooth s/still on the source/isn't on the dest/
10:32:56 mdbooth although we still wouldn't have deleted the actual instance data as you say
10:33:02 mdbooth So probably not the worst.
10:49:16 openstackgerrit Surya Seetharaman proposed openstack/nova master: API microversion 2.68: Handles Down Cells https://review.openstack.org/591657
10:49:53 gibi alex_xu: have a nice vacation
11:36:59 openstackgerrit Dongcan Ye proposed openstack/nova master: Remove other volume snapshot type https://review.openstack.org/623456
12:22:46 openstackgerrit sean mooney proposed openstack/os-vif master: add isolate_vif config option https://review.openstack.org/612534
12:39:00 openstackgerrit Gaudenz Steinlin proposed openstack/nova master: Extend volume for libvirt network volumes (RBD) https://review.openstack.org/613039
12:47:13 cdent stephenfin: it looks like your change on the constraints job gets things to pass, which suggests that skipsdist is not working in a per-env setting?
12:47:37 stephenfin cdent: Yup, I think I called that out in a comment/the commit message?
12:47:39 cdent but it's also confusing that different behaviors are happening between my box and the gate.
12:47:46 stephenfin cdent: It's a global option
12:48:03 stephenfin I'd imagine it's the version of tox
12:48:14 cdent they are the same

Earlier   Later