| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-12-07 | |||
| 10:22:47 | lyarwood | mdbooth: there's zero point in looking at that if we don't call cleanup on the source during a failure | |
| 10:23:24 | lyarwood | mdbooth: which we wouldn't do for LM, either post-copy or pre-copy AFAIK | |
| 10:23:57 | lyarwood | I'll look again at where we are calling cleanup to confirm but I'm sure this isn't an issue | |
| 10:24:16 | mdbooth | lyarwood: I strongly suspect it isn't an issue. | |
| 10:25:53 | lyarwood | DNM 0 [-------x--] 1 LGTM | |
| 10:26:01 | mdbooth | lyarwood: +1 | |
| 10:27:48 | mdbooth | lyarwood: Are there any circumstances where we could end up calling cleanup on the source (e.g. init_host, periodic) where instance.host is erroneously set to dest? | |
| 10:28:22 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Correct lower-constraints.txt and the related tox job https://review.openstack.org/622972 | |
| 10:31:28 | lyarwood | mdbooth: cleaning up evacuations that have failed in a weird way but again with this workaround enabled you'd only see console.log, kernel etc removed | |
| 10:31:57 | lyarwood | mdbooth: I can't say I've ever seen an evacuation fail in that way however | |
| 10:32:08 | lyarwood | mdbooth: instance.host updated but the instance is still on the source | |
| 10:32:22 | mdbooth | s/still on the source/isn't on the dest/ | |
| 10:32:56 | mdbooth | although we still wouldn't have deleted the actual instance data as you say | |
| 10:33:02 | mdbooth | So probably not the worst. | |
| 10:49:16 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.68: Handles Down Cells https://review.openstack.org/591657 | |
| 10:49:53 | gibi | alex_xu: have a nice vacation | |
| 11:36:59 | openstackgerrit | Dongcan Ye proposed openstack/nova master: Remove other volume snapshot type https://review.openstack.org/623456 | |
| 12:22:46 | openstackgerrit | sean mooney proposed openstack/os-vif master: add isolate_vif config option https://review.openstack.org/612534 | |
| 12:39:00 | openstackgerrit | Gaudenz Steinlin proposed openstack/nova master: Extend volume for libvirt network volumes (RBD) https://review.openstack.org/613039 | |
| 12:47:13 | cdent | stephenfin: it looks like your change on the constraints job gets things to pass, which suggests that skipsdist is not working in a per-env setting? | |
| 12:47:37 | stephenfin | cdent: Yup, I think I called that out in a comment/the commit message? | |
| 12:47:39 | cdent | but it's also confusing that different behaviors are happening between my box and the gate. | |
| 12:47:46 | stephenfin | cdent: It's a global option | |
| 12:48:03 | stephenfin | I'd imagine it's the version of tox | |
| 12:48:14 | cdent | they are the same | |
| 12:48:19 | cdent | that's why it is confusing | |
| 12:48:54 | stephenfin | Hmm. Have you wiped your .tox directory? | |
| 12:49:19 | cdent | not the whole thing, but the specific env | |
| 12:49:43 | cdent | the vm I was using is at home, so I cant' look now, but will check when I'm back home | |
| 12:50:38 | stephenfin | I've no idea what's going on, in that case. Might be worth asking the tox devs, in case they've any ideas. The funkiness that pbr introduces could throw even them though | |
| 12:50:58 | cdent | I'll also check to make sure that the job is sitll working as designed | |
| 12:51:05 | cdent | yeah, pbr... | |
| 12:51:23 | cdent | if it's happy as is, I'm happy to just move ... | |
| 12:51:26 | cdent | on | |
| 12:51:49 | cdent | wasted way more time on this than I wanted | |
| 12:55:20 | cdent | "wasted way more time on this than I wanted" <- nova, defined | |
| 13:04:34 | openstackgerrit | Silvan Kaiser proposed openstack/nova master: Exec systemd-run without --user flag in Quobyte driver https://review.openstack.org/554195 | |
| 13:33:36 | openstackgerrit | Merged openstack/os-vif master: always create ovs port during plug https://review.openstack.org/602384 | |
| 13:34:29 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP compute: reject migration request when source compute is disabled https://review.openstack.org/623489 | |
| 13:39:38 | openstackgerrit | Merged openstack/nova master: Use tempest [compute]/build_timeout in evacuate tests https://review.openstack.org/623011 | |
| 13:50:14 | sc | I need some help w/ configuring PCI passthrough in a newton based installation, I followed the newton admin guide but the scheduler returns 0 of 6 hosts. | |
| 13:51:19 | sc | what do you suggest to look for? In the compute host dmesg reports the iommu as enabled and I see a nice list of PCI cards, including the GPU I would like to pass to my VM | |
| 14:31:08 | openstackgerrit | Silvan Kaiser proposed openstack/nova master: Exec systemd-run without --user flag in Quobyte driver https://review.openstack.org/554195 | |
| 14:49:26 | openstackgerrit | Merged openstack/nova master: Update compute API.get() stubs for test_*security_groups https://review.openstack.org/615344 | |
| 14:49:39 | openstackgerrit | Merged openstack/nova master: Update compute API.get() stubs for test_disk_config https://review.openstack.org/615345 | |
| 14:49:49 | openstackgerrit | Merged openstack/nova master: Update compute API.get() stubs in test_access_ips https://review.openstack.org/615346 | |
| 14:50:25 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Add secret=true to fixed_key configuration parameter https://review.openstack.org/623507 | |
| 14:51:00 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Add secret=true to fixed_key configuration parameter https://review.openstack.org/623509 | |
| 14:52:28 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: Add secret=true to fixed_key configuration parameter https://review.openstack.org/623510 | |
| 15:03:53 | openstackgerrit | Dan Smith proposed openstack/nova master: Only warn about not having computes nodes once in rpcapi https://review.openstack.org/623282 | |
| 15:03:53 | openstackgerrit | Dan Smith proposed openstack/nova master: Make compute rpcapi version calculation check all cells https://review.openstack.org/623284 | |
| 15:03:54 | openstackgerrit | Dan Smith proposed openstack/nova master: Make service.get_minimum_version_all_cells() cache the results https://review.openstack.org/623283 | |
| 15:04:23 | dansmith | mriedem: melwitt: ^ this should be good now I think. also fixed something in the base patch that was causing a non-deterministic run in the later patches | |
| 15:05:24 | melwitt | cool, thanks | |
| 15:07:21 | mriedem | on an unrelated note, i propose that we disable snapshot tests in the cells v1 job http://logs.openstack.org/47/623247/2/check/nova-cells-v1/18338f0/job-output.txt.gz | |
| 15:07:34 | mriedem | snapshot with cells v1 in tempest is historically racy https://bugs.launchpad.net/nova/+bug/1620761 | |
| 15:07:35 | openstack | Launchpad bug 1620761 in OpenStack Compute (nova) "test_create_second_image_when_first_image_is_being_saved intermittently times out in teardown in cells v1 job" [Undecided,Invalid] | |
| 15:07:48 | mriedem | given the deprecated nature of cells v1 and the state of the gate, the less we can fail on the better | |
| 15:08:33 | dansmith | mriedem: fine with me | |
| 15:08:47 | mriedem | alright then | |
| 15:09:26 | dansmith | I also wouldn't be opposed to making a statement in stein that cellsv1 is deprecated fully, we're not going to test it anymore, and we'll be ripping the code out at whatever pace we feel is achievable | |
| 15:09:59 | dansmith | we know that the removal of v1 and n-net aren't trivial, so the actual removal will take time, but I think we could go ahead and drive the stake through the heart | |
| 15:10:21 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.68: Handles Down Cells https://review.openstack.org/591657 | |
| 15:12:26 | mriedem | shrug. we neutered quite a bit of the n-net specific apis in rocky, there are a couple lingering that i think would be priority to remove first, and maybe the os-cells api | |
| 15:12:58 | mriedem | i also wouldn't want that to distract from the other stuff that's already not getting attention, so close to the 2nd milestone | |
| 15:13:15 | dansmith | that's why I'm saying we don't have to do anything, just remove the test and land a reno | |
| 15:13:22 | dansmith | but that's just MHO | |
| 15:13:34 | dansmith | the test job Imean | |
| 15:13:35 | mriedem | remove the entire nova-cells-v1 job you mean? | |
| 15:13:36 | mriedem | yeah | |
| 15:14:04 | mriedem | it is using neutron at this point, so it doesn't really help cern as a n-net 50% user to keep it around | |
| 15:14:11 | mriedem | since cern is cells v2 now | |
| 15:14:15 | dansmith | yeah | |
| 15:14:30 | dansmith | melwitt is on the worst call evar right now, so maybe just pause until she's done and can opine | |
| 15:15:17 | melwitt | haha :) yeah.... | |
| 15:17:27 | melwitt | mriedem: definitely ok with me to disable snapshot tests. and no strong opinion about removing the entire job. I think we'd be ok removing the job considering everyone's moved/moving off of it. I think nectar is the only other one? and mgagne_? | |
| 15:18:22 | mriedem | sorrison said they are on pike i think, and v1 but looking at v2 | |
| 15:18:29 | mriedem | mgagne_ i think is still on mitaka | |
| 15:18:55 | dansmith | removing the tests several releases ahead of both of those would help send a message that it's time | |
| 15:18:59 | dansmith | as if cern being on it wasn't enough | |
| 15:20:48 | dansmith | continuing to whittle away at what it tests is also fine, but looking at how stressed the gate is, one fewer devstack runs for each nova patch seems like a decent win to me | |
| 15:21:47 | melwitt | yeah, on one hand I think we could disable the snapshot tests and if all is well after that, then we have some coverage for sorrison and mgagne_ sake. but if the job keeps being a thorn and failing then look again at removing the entire job | |
| 15:21:49 | mriedem | fwiw it's also tempest and devstack that run it | |
| 15:22:22 | mriedem | alternative is, move it to experimental | |
| 15:22:24 | mriedem | so it's run on deman | |
| 15:22:26 | mriedem | *demand | |
| 15:22:29 | dansmith | mriedem: yeah, that would be good | |
| 15:22:44 | melwitt | yeah, that's a nice alternative I didn't think of | |
| 15:22:47 | mriedem | caught me with my pants down https://review.openstack.org/#/q/topic:rm-nova-cells-v1-job+(status:open+OR+status:merged) | |
| 15:22:51 | mriedem | ok i'll change those | |
| 15:22:51 | dansmith | nova, tempest and devstack is a lot of running a heavy job for something we're just going to disable if any tests fail :/ | |
| 15:42:40 | lei-zh | Hi jaypipes sean-k-mooney, would you take a look at https://review.openstack.org/#/c/601596/ and https://review.openstack.org/#/c/622893/ when you have spare time | |
| 15:44:16 | sean-k-mooney | lei-zh: yes ill add them to my review queue | |
| 15:44:47 | lei-zh | sean-k-mooney: thanks | |
| 15:45:02 | lei-zh | we have split the original spec into two specs, one general and one specific to libvirt driver implementation, hope this will be helpful for people to understand | |
| 15:45:23 | sean-k-mooney | lei-zh: do you know waht is the state of the code/ci for this is? | |
| 15:45:38 | sean-k-mooney | lei-zh: ok i was wondering why it was split but that makes sense | |
| 15:47:20 | lei-zh | sean-k-mooney: we have worked out some poc code and will continue to improve them | |
| 15:48:12 | sean-k-mooney | cool is as part of the poc is there a way to test this without real persitent memory . i belive qemu can fake it with a file backed correct | |
| 15:48:27 | sean-k-mooney | just wondering how feasibel testing this would be | |