| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-12-06 | |||
| 19:10:26 | sean-k-mooney | let me see if i can find that. | |
| 19:21:18 | sean-k-mooney | hum i must have been an intel only bug which aparently i cant see | |
| 19:28:02 | sean-k-mooney | cfriesen: i assume you cant see https://bugzilla.redhat.com/show_bug.cgi?id=1135668 | |
| 19:28:02 | openstack | sean-k-mooney: Error: Error getting bugzilla.redhat.com bug #1135668: NotPermitted | |
| 19:29:10 | cfriesen | sean-k-mooney: nope. :) | |
| 19:29:17 | sean-k-mooney | cfriesen: when we rant this by the libvirt people they were concerned that affinities the interups to the vm cores could cause alot of guest VM_exits to serivce the interupts | |
| 19:29:52 | cfriesen | sean-k-mooney: enough to outweigh the preloading of the cache? | |
| 19:30:39 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Only construct SchedulerReportClient on first access from API https://review.openstack.org/623246 | |
| 19:30:39 | openstackgerrit | Matt Riedemann proposed openstack/nova master: DRY up SchedulerReportClient init https://review.openstack.org/623247 | |
| 19:31:35 | sean-k-mooney | so this was created on 2014-08-29 so my memory is a little fuzzy but they wanted use to show that it would out way that overhead and at the time we did not have the capsity to test it in an openstack environmnt to messuer it | |
| 19:31:55 | sean-k-mooney | so it was drop becasue of lack of evidence to show ti was a usefull feature to add to libvirt | |
| 19:32:15 | sean-k-mooney | we abandonded our nova work as a result | |
| 19:32:45 | sean-k-mooney | what everyone did agree on is that affizing to the same numa node was a good idea | |
| 19:33:16 | cfriesen | okay, thanks | |
| 19:33:31 | sean-k-mooney | thinking about it now i think affinitizing to the emuplator thread or thread poll in isolate/shared mode might be better the to the vcpus | |
| 19:35:10 | sean-k-mooney | cfriesen: did you do any testing out of interest? | |
| 19:35:36 | sean-k-mooney | cfriesen: hehe oh look here is my orginal mail https://www.mail-archive.com/libvir-list@redhat.com/msg100707.html | |
| 19:36:05 | cfriesen | I'm actually not sure. we had an in-house nova commit to enable pinning, but I wasn't the one that implemented it. Kind of curious myself if they tested it. :) | |
| 19:36:33 | sean-k-mooney | wow that was before i got the intel leagal email footer remove form my acount that was along time ago | |
| 19:56:44 | coreycb | tobias-urdin: we have a placement package now | |
| 19:57:03 | coreycb | tobias-urdin: just fyi, i know you were asking for it a little while back | |
| 20:11:45 | lyarwood | coreycb: link? I'll wire that up in my puppet changes tomorrow | |
| 20:12:10 | openstackgerrit | Chris Dent proposed openstack/nova master: Correct lower-constraints.txt and the related tox job https://review.openstack.org/622972 | |
| 20:15:56 | mriedem | aspiers: will config drive work with sev guests? | |
| 20:16:04 | mriedem | sean asked in the spec review but i didn't see an answer | |
| 20:17:18 | coreycb | lyarwood: placement-api is the package name | |
| 20:25:48 | mriedem | aspiers: comments inline https://review.openstack.org/#/c/609779/ but +1 | |
| 20:26:59 | lyarwood | coreycb: https://review.openstack.org/623306 - loads of assumptions about the package but I'll take another look in the morning | |
| 20:29:42 | coreycb | lyarwood: that generally looks good to me. let me know how it goes and thanks for testing. | |
| 20:38:14 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Ignore MoxStubout deprecation warnings https://review.openstack.org/623309 | |
| 20:38:15 | mriedem | let's do this ^ | |
| 20:49:17 | artom | The hell, how do I dn sync cell1? | |
| 20:50:29 | artom | *db | |
| 20:50:43 | melwitt | nova meeting in 10 minutes | |
| 20:55:22 | coreycb | mriedem: hi, just a friendly ping to see if you can review this when you get a chance. looks like it has a +1 from another core dev: https://review.openstack.org/#/c/579004/ | |
| 20:55:23 | artom | Ah, just pass --config-file cell1.conf to nova-manage | |
| 20:55:26 | artom | (from https://docs.openstack.org/nova/pike/cli/nova-manage.html) | |
| 20:58:24 | mriedem | coreycb: it's got the star but yeah i need to spend some time on it | |
| 20:59:28 | coreycb | mriedem: ok thanks in advance | |
| 21:02:44 | Sundar | I'd appreciate if somebody can answer the question in: https://ask.openstack.org/en/question/117509/unable-to-update-rc-inventory-in-resource-provider/ . If openstack-discuss is a better place to pose that question, I'll bring it there. | |
| 21:22:32 | dansmith | Sundar: pretty sure your url there is wrong | |
| 21:23:09 | dansmith | Sundar: you might want to look at the nova functional tests or the placement gabbit | |
| 21:24:08 | dansmith | Sundar: you're trying to put inventory on a provider right? | |
| 21:24:09 | dansmith | Sundar: https://developer.openstack.org/api-ref/placement/#update-resource-provider-inventories | |
| 21:24:52 | dansmith | I guess I'm wrong and the url is right, but I surely didn't think that was how that worked | |
| 21:25:02 | dansmith | because: atomicity | |
| 21:25:42 | dansmith | ah right you can PUT on the provider itself do do multiples | |
| 21:26:23 | dansmith | https://developer.openstack.org/api-ref/placement/?expanded=update-resource-provider-inventories-detail#update-resource-provider-inventories | |
| 21:26:43 | mriedem | or just, openstack --debug resource provider inventory set ... | |
| 21:26:55 | mriedem | https://docs.openstack.org/osc-placement/latest/index.html | |
| 21:27:18 | dansmith | mriedem: yeah, that's how I'd be doing it.. I figured he had some reason for doing it with curl | |
| 21:35:57 | Sundar | dansmith: mriedem: I use curl by default. And I thought whatever works via openstack commands should also work via curl. Apparently not. :) Anyways, the openstack command worked. Thanks! | |
| 21:36:31 | dansmith | Sundar: of course you _can_ use curl, but you get into situations like you're in now where you get back a 400 because you typo'd something and it's hard to tell what that is :) | |
| 21:36:33 | mriedem | it should work via curl | |
| 21:36:40 | mriedem | right | |
| 21:36:58 | dansmith | it's why we don't all write in machine language in 2018 | |
| 21:37:36 | Sundar | Curl tends to be much faster than openstack commands, in my experience. | |
| 21:38:02 | dansmith | Sundar: you asked on Nov 21 and got an answer on Dec 6.. seems like pretty terrible performance to me :) | |
| 21:38:02 | mriedem | it fails very fast yes :) | |
| 21:38:30 | efried_cya_jan | Sundar: I just looked at the gabbits, and it appears as though in order for that PUT to work, the inventory of that resource class has to exist already. | |
| 21:38:43 | efried_cya_jan | I.e. the PUT is designed to modify an existing inventory, not create a new one. | |
| 21:38:44 | mriedem | PUT generally means updating something that exists | |
| 21:38:55 | efried_cya_jan | I think edleafe might disagree on that one | |
| 21:39:00 | Sundar | dansmith: I had a very long retry setting :) | |
| 21:39:14 | efried_cya_jan | Sundar: let me get you a link to the gabbit... | |
| 21:39:24 | edleafe | efried_cya_jan: damn straight | |
| 21:39:45 | edleafe | PUT replaces | |
| 21:40:00 | efried_cya_jan | Sundar: https://github.com/openstack/placement/blob/master/placement/tests/functional/gabbits/inventory.yaml#L234 | |
| 21:40:11 | efried_cya_jan | edleafe: In which case this operation is busted :( | |
| 21:40:11 | mriedem | gaudenz: you need to set this to true in the devstack-plugin-ceph job https://github.com/openstack/tempest/blob/b62baf7c16d4609ea92e2ffc974e2f3a0b1cec80/tempest/config.py#L896 | |
| 21:40:18 | mriedem | gaudenz: and make that patch depend on the nova chnage | |
| 21:40:21 | mriedem | and then you should be good | |
| 21:41:04 | mriedem | gaudenz: right in here https://github.com/openstack/devstack-plugin-ceph/blob/39de6df04130cf2f221fb5ba2a9b5ff597de332a/devstack/plugin.sh#L98 | |
| 21:41:29 | efried_cya_jan | edleafe, cdent: It appears we're missing a gabbi test for a successful PUT /rps/{u}/inventories/{rc} | |
| 21:41:38 | efried_cya_jan | ...or it's not in that file | |
| 21:41:53 | mriedem | gaudenz: commented in the nova change on the steps | |
| 21:41:55 | efried_cya_jan | Maybe Sundar would like to propose that :) | |
| 21:42:10 | efried_cya_jan | okay, I'm going away again. o/ | |
| 21:42:42 | efried_cya_jan | Oh, edleafe, thanks for covering the n-sch summary in the meeting. | |
| 21:42:44 | Sundar | efried_cya_jan: We are still seeing you in December. :/ That apart, https://developer.openstack.org/api-ref/placement/#update-resource-provider-inventories documents only PUT. | |
| 21:43:11 | efried_cya_jan | Sundar: Yes, the document is not clear on the fact that the inventory needs to exist first. | |
| 21:43:11 | mriedem | gaudenz: btw, i'm pretty sure cern was already working on this... | |
| 21:43:24 | efried_cya_jan | Sundar: But the error message on that 400 is. | |
| 21:43:25 | dansmith | Sundar: it's PUT on the provider that works regardless | |
| 21:43:33 | mriedem | gaudenz: melwitt: https://review.openstack.org/#/c/594273/ | |
| 21:43:34 | edleafe | efried_cya_jan: I prepared that thinking that you were going to be a man of your word | |
| 21:43:35 | mriedem | so something is fishy | |
| 21:43:42 | dansmith | Sundar: PUT on a provider/class only works after it has been created via PUT on provider | |
| 21:44:08 | Sundar | mriedem: Sorry, didn't get your reference to the devstack-plugin-ceph job. Why is that involved here? | |
| 21:44:19 | melwitt | mriedem: whoa, huh | |
| 21:44:34 | Sundar | dansmith: Makes sense. I just went by the doc. | |
| 21:44:39 | mriedem | https://blueprints.launchpad.net/nova/+spec/extend-in-use-rbd-volumes | |
| 21:44:48 | mriedem | Sundar: that's for gaudenz, not you | |
| 21:44:50 | efried_cya_jan | Sundar: Right, as dansmith is saying, if you do PUT /rps/{u}/inventories with a payload like {'resource_provider_generation': $X, 'inventories': {$RC: {'total': $N, ...}}} then subsequent PUTs on /rps/{u}/inventories/{rc} ought to work. | |
| 21:45:53 | melwitt | o/ efried_cya_jan | |
| 21:46:36 | melwitt | mriedem: thanks for finding that. good to compare/consolidate on this cc gaudenz | |
| 21:47:07 | gaudenz | mriedem: Thanks, for the links. Will have a look. | |
| 21:47:08 | mriedem | i knew about the cern one originally, i thought this was that | |
| 21:47:19 | mriedem | dansmith: you got results https://review.openstack.org/#/c/623282/ it works \o/ | |
| 21:47:26 | mriedem | not sure if you want to change that variable name | |