| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-10-15 | |||
| 14:47:36 | efried | s10: Did you add those reviewers on there? | |
| 14:47:48 | efried | You probably meant to add the stable team. | |
| 14:48:02 | efried | https://review.openstack.org/#/admin/groups/540,members | |
| 14:50:03 | openstackgerrit | Corey Bryant proposed openstack/os-vif master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610068 | |
| 14:50:16 | s10 | efried: I don't remember, I definitely added myself. Thank you. | |
| 14:51:14 | openstackgerrit | Corey Bryant proposed openstack/osc-placement master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610074 | |
| 14:52:02 | mriedem | when you cherry pick using the gerrit UI it adds the original reviewers | |
| 14:52:03 | mriedem | i think | |
| 14:52:08 | mriedem | i might be thinking of revert | |
| 14:52:24 | efried | yeah, cherry pick doesn't do that, but revert does. | |
| 14:52:26 | mriedem | you definitely don't need to explicitly add the entire stable core team to a change | |
| 14:52:32 | mriedem | ^ is kind of obnoxious | |
| 14:52:58 | dansmith | extremely | |
| 14:52:59 | s10 | efried: probably i did that. nova-stable-maint adds 17 people. | |
| 14:53:26 | s10 | efried: cherry pick adds only the author of patchset. | |
| 15:01:07 | openstackgerrit | Adam Spiers proposed openstack/nova-specs master: Add spec for libvirt driver launching AMD SEV-encrypted instances https://review.openstack.org/609779 | |
| 15:09:33 | aspiers | artom: thanks again for the feedback - I think patch set 5 of this ^^^^ is much better than 4 was | |
| 15:11:49 | mriedem | dansmith: don't forget https://review.openstack.org/#/c/610088/ :) | |
| 15:13:42 | dansmith | mriedem: oh sorry | |
| 15:14:23 | dansmith | thought I had already done that one last week | |
| 15:16:18 | mriedem | i need some nova core reviews for more upgrade checker docs for people working on the community wide goal https://review.openstack.org/#/c/604486/ | |
| 15:16:22 | mriedem | hopefully easy | |
| 15:16:33 | mriedem | at some point these probably move over to the upgrade check library docs | |
| 15:17:45 | stephenfin | mriedem: Docs? I can take a look | |
| 15:22:11 | openstackgerrit | Adam Spiers proposed openstack/nova-specs master: Add spec for libvirt driver launching AMD SEV-encrypted instances https://review.openstack.org/609779 | |
| 15:30:01 | dansmith | mriedem: are you going to fix stephenfin's literal nits/ | |
| 15:30:09 | dansmith | if so I'll wait and hit it when you do that | |
| 15:30:23 | dansmith | or i can fix it for you and then +W if you're in the middle of something else | |
| 15:32:54 | artom | aspiers, you're welcome - I'll read it over again soon (no firm date promises, sorry!) | |
| 15:35:44 | aspiers | artom: thanks! IIUC it would need to be merged by Oct 25 (s-1 milestone) in order to make it in for Stein, right? | |
| 15:36:06 | aspiers | really hoping that's possible - but I know it's tight ... | |
| 15:37:04 | artom | aspiers, it's doable - you basically have to harass the spec-cores ;) | |
| 15:37:13 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add some more docs for upgrade checkers https://review.openstack.org/604486 | |
| 15:37:16 | aspiers | artom: ah OK ;-) and who are those lucky people? | |
| 15:37:16 | mriedem | dansmith: done | |
| 15:37:18 | melwitt | ||
| 15:37:41 | artom | aspiers, https://review.openstack.org/#/admin/groups/302,members | |
| 15:37:56 | aspiers | yeah, I just realised Gerrit would probably tell me ... | |
| 15:38:05 | artom | For the traits stuff jaypipes would be your man, along with efried, though he's not specs-core (yet?) | |
| 15:39:43 | aspiers | OK cool, well jay, dansmith, johnthetubaguy, and mriedem are already on the reviewer list | |
| 15:40:10 | aspiers | I'm not sure whether it would be fair to spam the *whole* specs-core team ;-) | |
| 15:41:45 | artom | aspiers, it's a fine line between persistent and pest ;) | |
| 15:41:54 | aspiers | indeed X-D | |
| 15:42:01 | artom | Honestly though, it's hard | |
| 15:42:01 | efried | artom, aspiers: What are we talking about? | |
| 15:42:14 | aspiers | efried: https://review.openstack.org/#/c/609779/ | |
| 15:42:16 | efried | ... | |
| 15:42:36 | artom | efried, aspiers has a spec that deals with traits, I figures you might want to look | |
| 15:43:55 | efried | Just looking at the title, is this a thing like: | |
| 15:43:55 | efried | - virt driver sets a "I_CAN_HAZ_SEV" trait | |
| 15:43:55 | efried | - op sets trait:I_CAN_HAZ_SEV=required | |
| 15:43:55 | efried | - scheduler schedules to a host that has I_CAN_HAZ_SEV | |
| 15:43:55 | efried | - virt driver sees the trait and flips a switch in the VM | |
| 15:43:55 | efried | ? | |
| 15:44:21 | artom | efried, pretty much | |
| 15:44:28 | aspiers | yes | |
| 15:44:42 | efried | I see mriedem referred you to the HPET thread. If it's a similar deal, then structure it like that --^ and you should be able to get a reasonably fast approval. | |
| 15:45:06 | aspiers | exactly, except the switch to flip is *slightly* involved due to the extra libvirt XML required | |
| 15:45:29 | aspiers | and also it's not as simple as just looking for a flag in /proc/cpuinfo (but it's not that much more complicated either) | |
| 15:46:10 | mriedem | i haven't reviewed the hpet spec fwiw | |
| 15:46:15 | aspiers | efried: yeah, the recent patch sets of my spec already link to that HPET thread | |
| 15:46:39 | aspiers | and point out that the proposal aligns with the HPET consensus | |
| 15:46:41 | mriedem | speaking of, | |
| 15:46:45 | mriedem | why do we have two HPET specs? | |
| 15:46:50 | mriedem | https://review.openstack.org/#/c/571111/ https://review.openstack.org/#/c/607989/ | |
| 15:47:28 | efried | mriedem: TPM != HPET? | |
| 15:47:36 | aspiers | is https://wiki.openstack.org/wiki/Nova/Stein_Release_Schedule authoritative? | |
| 15:47:37 | mriedem | sob | |
| 15:47:43 | mriedem | aspiers: yes | |
| 15:47:46 | aspiers | OK cool | |
| 15:47:53 | aspiers | thought I heard somewhere else that s-1 milestone was Oct 22 | |
| 15:48:13 | aspiers | but Oct 25 gives me 3 extra days of precious breathing space ;-) | |
| 15:48:47 | efried | Spec freeze is 1/10 | |
| 15:48:57 | efried | at s-2 | |
| 15:49:40 | aspiers | oh, so it doesn't even need to be merged until Jan 10? | |
| 15:49:55 | mriedem | yes we have several months to ignore your spec | |
| 15:50:00 | aspiers | LOL | |
| 15:50:21 | aspiers | can't wait to enjoy those peaceful months! | |
| 15:50:41 | artom | You can't say that to new people! At least put an /s or ;) or something | |
| 15:50:47 | artom | /s ;) | |
| 15:50:48 | aspiers | hahahahaha | |
| 15:51:23 | aspiers | hrm, I might even be able to code the thing before Jan 10 | |
| 15:51:28 | mriedem | yes we have several months to ignore your spec >:( | |
| 15:51:30 | aspiers | I don't expect it's gonna be that hard | |
| 15:51:58 | aspiers | so maybe you'll even be able to ignore not just my spec, but my patches too! | |
| 15:52:29 | mriedem | that was supposed to be angry eyebrows | |
| 15:52:49 | aspiers | and if you need help with that, I remember corvus pointing out that gertty makes ignoring reviews easier than ever ;-) | |
| 15:53:29 | melwitt | speaking of ignoring specs, I've been thinking whether we should organize a spec review day for next week ahead of s-1 (even though s-1 is not the spec freeze) | |
| 15:53:31 | aspiers | maybe he can even add a -3 hotkey specially for jaypipes ... | |
| 15:59:44 | mriedem | melwitt: yes we likely need a spec review day; i know i haven't been doing a good job of reviewing specs for stein. | |
| 16:05:01 | melwitt | we usually do them on tuesday. are y'all game for a spec review day next tuesday oct 23? alex_xu dansmith efried johnthetubaguy stephenfin bauzas | |
| 16:05:35 | efried | wfm | |
| 16:18:45 | openstackgerrit | Corey Bryant proposed openstack/osc-placement master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610074 | |
| 16:19:53 | openstackgerrit | Corey Bryant proposed openstack/os-vif master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610068 | |
| 16:21:44 | openstackgerrit | Jan Gutter proposed openstack/os-vif master: Extend host_info to cover port profiles https://review.openstack.org/610636 | |
| 16:24:31 | openstackgerrit | Corey Bryant proposed openstack/os-traits master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610065 | |
| 16:40:02 | mriedem | tuesday the 23rd works for me | |
| 16:54:34 | melwitt | I'll send a mail to the ML proposing next tuesday to get some async responses | |
| 17:36:30 | openstackgerrit | Merged openstack/nova master: Use nova-consoleauth only if workaround enabled https://review.openstack.org/607068 | |
| 17:38:40 | openstackgerrit | melanie witt proposed openstack/nova stable/rocky: Use nova-consoleauth only if workaround enabled https://review.openstack.org/610673 | |