| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-10-15 | |||
| 15:40:10 | aspiers | I'm not sure whether it would be fair to spam the *whole* specs-core team ;-) | |
| 15:41:45 | artom | aspiers, it's a fine line between persistent and pest ;) | |
| 15:41:54 | aspiers | indeed X-D | |
| 15:42:01 | artom | Honestly though, it's hard | |
| 15:42:01 | efried | artom, aspiers: What are we talking about? | |
| 15:42:14 | aspiers | efried: https://review.openstack.org/#/c/609779/ | |
| 15:42:16 | efried | ... | |
| 15:42:36 | artom | efried, aspiers has a spec that deals with traits, I figures you might want to look | |
| 15:43:55 | efried | Just looking at the title, is this a thing like: | |
| 15:43:55 | efried | - virt driver sets a "I_CAN_HAZ_SEV" trait | |
| 15:43:55 | efried | - op sets trait:I_CAN_HAZ_SEV=required | |
| 15:43:55 | efried | - scheduler schedules to a host that has I_CAN_HAZ_SEV | |
| 15:43:55 | efried | - virt driver sees the trait and flips a switch in the VM | |
| 15:43:55 | efried | ? | |
| 15:44:21 | artom | efried, pretty much | |
| 15:44:28 | aspiers | yes | |
| 15:44:42 | efried | I see mriedem referred you to the HPET thread. If it's a similar deal, then structure it like that --^ and you should be able to get a reasonably fast approval. | |
| 15:45:06 | aspiers | exactly, except the switch to flip is *slightly* involved due to the extra libvirt XML required | |
| 15:45:29 | aspiers | and also it's not as simple as just looking for a flag in /proc/cpuinfo (but it's not that much more complicated either) | |
| 15:46:10 | mriedem | i haven't reviewed the hpet spec fwiw | |
| 15:46:15 | aspiers | efried: yeah, the recent patch sets of my spec already link to that HPET thread | |
| 15:46:39 | aspiers | and point out that the proposal aligns with the HPET consensus | |
| 15:46:41 | mriedem | speaking of, | |
| 15:46:45 | mriedem | why do we have two HPET specs? | |
| 15:46:50 | mriedem | https://review.openstack.org/#/c/571111/ https://review.openstack.org/#/c/607989/ | |
| 15:47:28 | efried | mriedem: TPM != HPET? | |
| 15:47:36 | aspiers | is https://wiki.openstack.org/wiki/Nova/Stein_Release_Schedule authoritative? | |
| 15:47:37 | mriedem | sob | |
| 15:47:43 | mriedem | aspiers: yes | |
| 15:47:46 | aspiers | OK cool | |
| 15:47:53 | aspiers | thought I heard somewhere else that s-1 milestone was Oct 22 | |
| 15:48:13 | aspiers | but Oct 25 gives me 3 extra days of precious breathing space ;-) | |
| 15:48:47 | efried | Spec freeze is 1/10 | |
| 15:48:57 | efried | at s-2 | |
| 15:49:40 | aspiers | oh, so it doesn't even need to be merged until Jan 10? | |
| 15:49:55 | mriedem | yes we have several months to ignore your spec | |
| 15:50:00 | aspiers | LOL | |
| 15:50:21 | aspiers | can't wait to enjoy those peaceful months! | |
| 15:50:41 | artom | You can't say that to new people! At least put an /s or ;) or something | |
| 15:50:47 | artom | /s ;) | |
| 15:50:48 | aspiers | hahahahaha | |
| 15:51:23 | aspiers | hrm, I might even be able to code the thing before Jan 10 | |
| 15:51:28 | mriedem | yes we have several months to ignore your spec >:( | |
| 15:51:30 | aspiers | I don't expect it's gonna be that hard | |
| 15:51:58 | aspiers | so maybe you'll even be able to ignore not just my spec, but my patches too! | |
| 15:52:29 | mriedem | that was supposed to be angry eyebrows | |
| 15:52:49 | aspiers | and if you need help with that, I remember corvus pointing out that gertty makes ignoring reviews easier than ever ;-) | |
| 15:53:29 | melwitt | speaking of ignoring specs, I've been thinking whether we should organize a spec review day for next week ahead of s-1 (even though s-1 is not the spec freeze) | |
| 15:53:31 | aspiers | maybe he can even add a -3 hotkey specially for jaypipes ... | |
| 15:59:44 | mriedem | melwitt: yes we likely need a spec review day; i know i haven't been doing a good job of reviewing specs for stein. | |
| 16:05:01 | melwitt | we usually do them on tuesday. are y'all game for a spec review day next tuesday oct 23? alex_xu dansmith efried johnthetubaguy stephenfin bauzas | |
| 16:05:35 | efried | wfm | |
| 16:18:45 | openstackgerrit | Corey Bryant proposed openstack/osc-placement master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610074 | |
| 16:19:53 | openstackgerrit | Corey Bryant proposed openstack/os-vif master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610068 | |
| 16:21:44 | openstackgerrit | Jan Gutter proposed openstack/os-vif master: Extend host_info to cover port profiles https://review.openstack.org/610636 | |
| 16:24:31 | openstackgerrit | Corey Bryant proposed openstack/os-traits master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610065 | |
| 16:40:02 | mriedem | tuesday the 23rd works for me | |
| 16:54:34 | melwitt | I'll send a mail to the ML proposing next tuesday to get some async responses | |
| 17:36:30 | openstackgerrit | Merged openstack/nova master: Use nova-consoleauth only if workaround enabled https://review.openstack.org/607068 | |
| 17:38:40 | openstackgerrit | melanie witt proposed openstack/nova stable/rocky: Use nova-consoleauth only if workaround enabled https://review.openstack.org/610673 | |
| 17:42:32 | openstackgerrit | Merged openstack/nova master: Add microversion 2.67 to rest api version history https://review.openstack.org/610349 | |
| 17:57:39 | mriedem | efried: jackding: a few things in https://review.openstack.org/#/c/607989/ | |
| 17:57:46 | mriedem | mostly to just tighten up that spec | |
| 18:00:19 | jackding | mriedem, will have a look thanks | |
| 18:07:07 | efried | mriedem, jackding: Responded to a few of them. | |
| 18:10:03 | openstackgerrit | Corey Bryant proposed openstack/osc-placement master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610074 | |
| 18:10:40 | openstackgerrit | Corey Bryant proposed openstack/os-traits master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610065 | |
| 18:11:02 | openstackgerrit | Corey Bryant proposed openstack/os-vif master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610068 | |
| 18:17:05 | coreycb | melwitt: hi, you may have noticed we started proposing patches to enable py37 unit tests and disable py35 unit tests. just wanted to give you a heads up to ensure it's not a surprise. just a few more to go. | |
| 18:18:07 | melwitt | coreycb: I have noticed and thank you for the heads up :) | |
| 18:19:51 | openstackgerrit | Corey Bryant proposed openstack/nova master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610694 | |
| 18:21:00 | mriedem | efried: it wasn't clear to me the compute code was going to be setting the trait | |
| 18:21:35 | efried | mriedem: Guess that's a thing to be called out in the spec, then :p | |
| 18:21:43 | mriedem | yeah | |
| 18:21:49 | mriedem | otherwise this is all straight-forward | |
| 18:22:39 | efried | I took it for granted based on the code, but that shouldn't be a prereq for understanding the spec of course | |
| 18:40:28 | mriedem | artom: a few small things in https://review.openstack.org/#/c/609517/ | |
| 18:41:08 | artom | mriedem, much thanks, will address now! | |
| 18:46:16 | mriedem | artom: also, something is a false positive in the tests | |
| 18:46:28 | artom | mriedem, how so? | |
| 18:46:48 | mriedem | i moved the try/except around only the terminate_connection call and both tests passed | |
| 18:46:54 | mriedem | but the attachment_delete one should have failed | |
| 18:47:21 | artom | Dammi :( OK, I'll look into that | |
| 18:47:41 | artom | (I *did* do that with a previous version, I swear!) | |
| 18:49:35 | openstackgerrit | Merged openstack/nova master: Add some more docs for upgrade checkers https://review.openstack.org/604486 | |
| 18:57:10 | mriedem | Kevin_Zheng: i replied to your -1 in https://review.openstack.org/#/c/608777/ - are you still -1 on that or can it be dropped? | |
| 19:04:21 | mriedem | this seems...excessive: http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22detaching%20network%20adapter%20failed.%3A%20libvirtError%3A%20internal%20error%3A%20End%20of%20file%20from%20qemu%20monitor%5C%22%20AND%20tags%3A%5C%22screen-n-cpu.txt%5C%22&from=7d | |
| 19:07:32 | mriedem | oh i see, | |
| 19:07:54 | mriedem | we're tearing down, we get a network-vif-deleted event right before the guest is deleted in the hypervisor | |
| 19:08:30 | mriedem | doesn't "End of file from qemu monitor" usually indicate the guest is gone? | |
| 19:13:19 | openstackgerrit | Jack Ding proposed openstack/nova-specs master: High Precision Event Timer (HPET) on x86 guests https://review.openstack.org/607989 | |
| 19:29:12 | artom | mriedem, ah, it's because my poor man's mock checks for volume_id, but is called with an attachment_id. | |
| 19:29:20 | artom | So it doesn't actually raise | |
| 19:30:56 | mriedem | yeah... | |
| 19:31:08 | mriedem | so track call count and raise count? | |
| 19:38:31 | mriedem | jackding: just a couple of small updates in that spec | |
| 19:38:33 | mriedem | for hpet | |
| 19:38:59 | mriedem | btw, how does the libvirt driver know it can report the hpet trait? | |
| 19:39:03 | mriedem | something on the host capabilities? | |
| 19:40:10 | dansmith | I think so yeah | |