| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-08-10 | |||
| 15:38:26 | mriedem | melwitt: now that we have a stable/rocky branch you get to create the stein series https://bugs.launchpad.net/nova | |
| 15:38:40 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: block_device: Rollback volumes to in-use on DeviceDetachFailed https://review.openstack.org/590803 | |
| 15:38:41 | melwitt | ok | |
| 15:39:28 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: block_device: Rollback volumes to in-use on DeviceDetachFailed https://review.openstack.org/590804 | |
| 15:39:44 | melwitt | mriedem: were you thinking of the DeviceDetachFailed one for rc2? from what I understand, we release rc2 from stable/rocky so we hold non-rc2 things until after the final rocky release deadline | |
| 15:40:55 | mriedem | melwitt: we can, but it's also extremely low risk | |
| 15:41:00 | mriedem | and we'll backport it anyway | |
| 15:41:13 | melwitt | ok, just making sure I understood | |
| 15:42:01 | SteelyDan | that one is a regression so it makes sense anyway right? | |
| 15:42:17 | melwitt | mriedem: I thought we already have a stein series? https://launchpad.net/nova/stein | |
| 15:42:38 | mriedem | SteelyDan: yes it is, and we also backported it to queens and pike | |
| 15:42:41 | mriedem | so it's going back either way | |
| 15:43:02 | SteelyDan | yeah | |
| 15:43:11 | mriedem | melwitt: hmm, bugs marked against rocky are marked as fixed even though these 2 aren't yet | |
| 15:43:16 | mriedem | might be the dev focus setting | |
| 15:43:23 | melwitt | \:| | |
| 15:43:57 | mriedem | melwitt: change stein status to active dev | |
| 15:44:02 | mriedem | and rocky to current stable or whatever | |
| 15:44:19 | melwitt | oh I see | |
| 15:44:24 | mriedem | and dev focus = stein | |
| 15:44:52 | mriedem | we can also mark r3 and rc1 as released in https://launchpad.net/nova/rocky and add a nrc2 | |
| 15:44:53 | melwitt | got the dev focus. looking for the current stable setting | |
| 15:45:04 | mriedem | that's on the rocky one | |
| 15:45:07 | mriedem | change the status | |
| 15:45:29 | melwitt | oh thanks. got it | |
| 15:46:01 | mriedem | eventually you'll want to register milestones for stein as well | |
| 15:46:11 | mriedem | based on the stein release schedule | |
| 15:46:16 | melwitt | ok | |
| 15:46:29 | mriedem | i don't think any of this is written down anywhere, | |
| 15:46:42 | mriedem | i never bothered to since it's once every 6 months and it's pretty straight-forward | |
| 15:48:58 | melwitt | hm, looks like I need to update the release notes link for rocky in openstack/releases | |
| 15:49:05 | mriedem | in other news, the guy in the row in front of me ate, i'm pretty sure, at least 4 mcdonalds breakfast sandwiches and now the entire back half of the plane smells like greasy sausage and biscuit | |
| 15:49:20 | mriedem | melwitt: yup - you can do that once we cut stable/rocky | |
| 15:49:38 | melwitt | stable/rocky has been cut automatically because of rc1 | |
| 15:49:43 | mriedem | right | |
| 15:49:47 | melwitt | oh | |
| 15:49:59 | mriedem | *you can do that now | |
| 15:50:07 | mriedem | i always 2-stepped that | |
| 15:50:25 | melwitt | what's the benefit of 2-stepping it? | |
| 15:50:27 | mriedem | because i don't think the docs link exists until after the branch is created | |
| 15:50:33 | melwitt | ah, ok | |
| 15:50:46 | mriedem | you could also work in smcginnis' marketing speak edits on the highlights | |
| 15:50:51 | openstackgerrit | Dan Smith proposed openstack/nova master: Revert "libvirt: slow live-migration to ensure network is ready" https://review.openstack.org/590538 | |
| 15:51:18 | melwitt | k | |
| 15:53:28 | mriedem | SteelyDan: +2 | |
| 16:00:44 | melwitt | mriedem: release note link and marketing speak proposed https://review.openstack.org/590812 | |
| 16:02:43 | melwitt | I set queens from "current stable release" => "supported" also | |
| 16:05:39 | mriedem | yeah good idea | |
| 16:07:32 | openstackgerrit | Eric Fried proposed openstack/nova master: Adds a test for _get_provider_ids_matching() https://review.openstack.org/590150 | |
| 16:07:33 | openstackgerrit | Eric Fried proposed openstack/nova master: placement: use simple code paths when possible https://review.openstack.org/590388 | |
| 16:07:34 | openstackgerrit | Eric Fried proposed openstack/nova master: split gigantor SQL placement query into multiple https://review.openstack.org/590041 | |
| 16:08:01 | mdb007h | Just reviewing https://review.openstack.org/#/c/504885/8 . Do we run the db migration check functional tests against a real mysql db in any CI job? | |
| 16:14:43 | mriedem | melwitt: commnts on that release patch | |
| 16:15:08 | melwitt | ok | |
| 16:18:44 | melwitt | I had thought I needed to make that change to *create* the docs at the rocky link. how wrong I was | |
| 16:23:37 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Revert "libvirt: add method to configure migration speed" https://review.openstack.org/590814 | |
| 16:24:14 | mriedem | might want to ask clarkb when those get generated from stable | |
| 16:24:17 | mriedem | or doug | |
| 16:24:43 | melwitt | ok | |
| 16:24:51 | mriedem | i bet we're missing a patch https://github.com/openstack/nova/blob/master/releasenotes/source/index.rst | |
| 16:25:12 | mriedem | https://review.openstack.org/#/c/590732/ | |
| 16:25:40 | melwitt | oh, oops | |
| 16:25:44 | mriedem | blam http://logs.openstack.org/32/590732/1/check/build-openstack-releasenotes/7dc073e/html/ | |
| 16:26:00 | melwitt | TIL | |
| 16:26:19 | mriedem | i don't know if we need that in stable/rocky/ | |
| 16:26:20 | mriedem | ? | |
| 16:26:25 | mriedem | question for doug | |
| 16:26:59 | mriedem | and we're landing.... | |
| 16:27:01 | mriedem | bbiab | |
| 16:31:04 | melwitt | doug says no, the release notes job always runs on master | |
| 16:41:33 | tbachman | no more purplerbot? | |
| 16:41:37 | melwitt | SteelyDan: doug recommends a fast-approve of this .gitreview update for stable/rocky, if you could pls take a look https://review.openstack.org/590730 | |
| 16:43:06 | SteelyDan | done | |
| 16:43:23 | melwitt | ty | |
| 17:35:56 | openstackgerrit | Chris Dent proposed openstack/nova master: Adds a test for _get_provider_ids_matching() https://review.openstack.org/590150 | |
| 17:35:57 | openstackgerrit | Chris Dent proposed openstack/nova master: placement: use simple code paths when possible https://review.openstack.org/590388 | |
| 17:35:58 | openstackgerrit | Chris Dent proposed openstack/nova master: split gigantor SQL placement query into multiple https://review.openstack.org/590041 | |
| 17:57:05 | openstackgerrit | Merged openstack/nova master: Update reno for stable/rocky https://review.openstack.org/590732 | |
| 17:57:11 | openstackgerrit | Merged openstack/nova stable/rocky: Update .gitreview for stable/rocky https://review.openstack.org/590730 | |
| 17:57:48 | openstackgerrit | Merged openstack/nova master: Quota details for key_pair "in_use" is 0. https://review.openstack.org/590081 | |
| 18:09:08 | openstackgerrit | Marcus Furlong proposed openstack/nova master: improve migration script https://review.openstack.org/591030 | |
| 18:29:39 | melwitt | SteelyDan: added comments to the revert patch. I think some unit test coverage specific to the speed limit patch was missed for reverting. let me know if I'm mistaken | |
| 18:30:27 | SteelyDan | looking through them now | |
| 18:31:08 | SteelyDan | most of this was conflicted out since these tests were all modified since this patch | |
| 18:31:33 | openstackgerrit | Konstantinos Samaras-Tsakiris proposed openstack/nova-specs master: Placement model for PCI devices https://review.openstack.org/591037 | |
| 18:31:41 | SteelyDan | it's not a straight revert regardless, so I guess I'm not sure I see the point of putting things back like the bandwidth thing as that pattern then got copied in the params stuff afterwards in some places | |
| 18:31:57 | SteelyDan | and like the virtapi thing makes no difference | |
| 18:32:04 | SteelyDan | and the networkinfo | |
| 18:32:13 | SteelyDan | but the things to collect the events are probably dead now | |
| 18:32:30 | SteelyDan | not sure I'm going to get to this before I have to relocate for the day but I'll try | |
| 18:32:35 | melwitt | okay, it just seems like test_live_migration_main and test_live_migration_ovs_vif are duplicates of one another, essentially | |
| 18:33:18 | SteelyDan | probably yeah | |
| 18:33:46 | melwitt | since the networkinfo part is taken out, that was the difference between them, I thought. ok, I can add a follow up to clean that part up since you've got to run soon | |
| 18:34:19 | melwitt | since it's just extra duplicated unit test coverage | |
| 18:34:25 | SteelyDan | I'll take a shot and let you know if I don't push something up | |
| 18:34:33 | melwitt | ok | |
| 18:34:41 | SteelyDan | yeah, the second test being a duplicate now makes sense | |
| 18:36:53 | openstackgerrit | Chris Dent proposed openstack/nova stable/ocata: [placement] Retry allocation writes server side https://review.openstack.org/591042 | |
| 18:38:34 | SteelyDan | maybe that will all just come out easy, lemme stash and try | |
| 18:45:43 | kosamara | efried: Hi! I've asked you some more questions on your spec. In the meantime I've published my take for review and expect to change it depending on your answers. | |