Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-08-10
15:49:20 mriedem melwitt: yup - you can do that once we cut stable/rocky
15:49:38 melwitt stable/rocky has been cut automatically because of rc1
15:49:43 mriedem right
15:49:47 melwitt oh
15:49:59 mriedem *you can do that now
15:50:07 mriedem i always 2-stepped that
15:50:25 melwitt what's the benefit of 2-stepping it?
15:50:27 mriedem because i don't think the docs link exists until after the branch is created
15:50:33 melwitt ah, ok
15:50:46 mriedem you could also work in smcginnis' marketing speak edits on the highlights
15:50:51 openstackgerrit Dan Smith proposed openstack/nova master: Revert "libvirt: slow live-migration to ensure network is ready" https://review.openstack.org/590538
15:51:18 melwitt k
15:53:28 mriedem SteelyDan: +2
16:00:44 melwitt mriedem: release note link and marketing speak proposed https://review.openstack.org/590812
16:02:43 melwitt I set queens from "current stable release" => "supported" also
16:05:39 mriedem yeah good idea
16:07:32 openstackgerrit Eric Fried proposed openstack/nova master: Adds a test for _get_provider_ids_matching() https://review.openstack.org/590150
16:07:33 openstackgerrit Eric Fried proposed openstack/nova master: placement: use simple code paths when possible https://review.openstack.org/590388
16:07:34 openstackgerrit Eric Fried proposed openstack/nova master: split gigantor SQL placement query into multiple https://review.openstack.org/590041
16:08:01 mdb007h Just reviewing https://review.openstack.org/#/c/504885/8 . Do we run the db migration check functional tests against a real mysql db in any CI job?
16:14:43 mriedem melwitt: commnts on that release patch
16:15:08 melwitt ok
16:18:44 melwitt I had thought I needed to make that change to *create* the docs at the rocky link. how wrong I was
16:23:37 openstackgerrit Matt Riedemann proposed openstack/nova master: Revert "libvirt: add method to configure migration speed" https://review.openstack.org/590814
16:24:14 mriedem might want to ask clarkb when those get generated from stable
16:24:17 mriedem or doug
16:24:43 melwitt ok
16:24:51 mriedem i bet we're missing a patch https://github.com/openstack/nova/blob/master/releasenotes/source/index.rst
16:25:12 mriedem https://review.openstack.org/#/c/590732/
16:25:40 melwitt oh, oops
16:25:44 mriedem blam http://logs.openstack.org/32/590732/1/check/build-openstack-releasenotes/7dc073e/html/
16:26:00 melwitt TIL
16:26:19 mriedem i don't know if we need that in stable/rocky/
16:26:20 mriedem ?
16:26:25 mriedem question for doug
16:26:59 mriedem and we're landing....
16:27:01 mriedem bbiab
16:31:04 melwitt doug says no, the release notes job always runs on master
16:41:33 tbachman no more purplerbot?
16:41:37 melwitt SteelyDan: doug recommends a fast-approve of this .gitreview update for stable/rocky, if you could pls take a look https://review.openstack.org/590730
16:43:06 SteelyDan done
16:43:23 melwitt ty
17:35:56 openstackgerrit Chris Dent proposed openstack/nova master: Adds a test for _get_provider_ids_matching() https://review.openstack.org/590150
17:35:57 openstackgerrit Chris Dent proposed openstack/nova master: placement: use simple code paths when possible https://review.openstack.org/590388
17:35:58 openstackgerrit Chris Dent proposed openstack/nova master: split gigantor SQL placement query into multiple https://review.openstack.org/590041
17:57:05 openstackgerrit Merged openstack/nova master: Update reno for stable/rocky https://review.openstack.org/590732
17:57:11 openstackgerrit Merged openstack/nova stable/rocky: Update .gitreview for stable/rocky https://review.openstack.org/590730
17:57:48 openstackgerrit Merged openstack/nova master: Quota details for key_pair "in_use" is 0. https://review.openstack.org/590081
18:09:08 openstackgerrit Marcus Furlong proposed openstack/nova master: improve migration script https://review.openstack.org/591030
18:29:39 melwitt SteelyDan: added comments to the revert patch. I think some unit test coverage specific to the speed limit patch was missed for reverting. let me know if I'm mistaken
18:30:27 SteelyDan looking through them now
18:31:08 SteelyDan most of this was conflicted out since these tests were all modified since this patch
18:31:33 openstackgerrit Konstantinos Samaras-Tsakiris proposed openstack/nova-specs master: Placement model for PCI devices https://review.openstack.org/591037
18:31:41 SteelyDan it's not a straight revert regardless, so I guess I'm not sure I see the point of putting things back like the bandwidth thing as that pattern then got copied in the params stuff afterwards in some places
18:31:57 SteelyDan and like the virtapi thing makes no difference
18:32:04 SteelyDan and the networkinfo
18:32:13 SteelyDan but the things to collect the events are probably dead now
18:32:30 SteelyDan not sure I'm going to get to this before I have to relocate for the day but I'll try
18:32:35 melwitt okay, it just seems like test_live_migration_main and test_live_migration_ovs_vif are duplicates of one another, essentially
18:33:18 SteelyDan probably yeah
18:33:46 melwitt since the networkinfo part is taken out, that was the difference between them, I thought. ok, I can add a follow up to clean that part up since you've got to run soon
18:34:19 melwitt since it's just extra duplicated unit test coverage
18:34:25 SteelyDan I'll take a shot and let you know if I don't push something up
18:34:33 melwitt ok
18:34:41 SteelyDan yeah, the second test being a duplicate now makes sense
18:36:53 openstackgerrit Chris Dent proposed openstack/nova stable/ocata: [placement] Retry allocation writes server side https://review.openstack.org/591042
18:38:34 SteelyDan maybe that will all just come out easy, lemme stash and try
18:45:43 kosamara efried: Hi! I've asked you some more questions on your spec. In the meantime I've published my take for review and expect to change it depending on your answers.
18:46:16 kosamara efried: https://review.openstack.org/#/c/591037/
18:46:17 fried_rolls kosamara: Neat, this one: https://review.openstack.org/591037 ?
18:46:20 fried_rolls okay, cool.
18:48:06 openstackgerrit Dan Smith proposed openstack/nova master: Revert "libvirt: slow live-migration to ensure network is ready" https://review.openstack.org/590538
19:18:46 openstackgerrit Dan Smith proposed openstack/nova master: Revert "libvirt: slow live-migration to ensure network is ready" https://review.openstack.org/590538
19:25:30 openstackgerrit Matthew Edmonds proposed openstack/nova master: Make Xen code py3-compatible https://review.openstack.org/591061
19:43:50 openstackgerrit Eric Fried proposed openstack/nova master: Test case for multiple forbidden traits https://review.openstack.org/591070
19:59:40 openstackgerrit Merged openstack/nova master: Add additional info to resource provider aggregates update API https://review.openstack.org/590243
20:04:23 openstackgerrit Matthew Edmonds proposed openstack/nova master: Make Xen code py3-compatible https://review.openstack.org/591061
20:11:15 openstackgerrit Jay Pipes proposed openstack/nova master: split gigantor SQL placement query into multiple https://review.openstack.org/590041
20:11:42 openstackgerrit Eric Fried proposed openstack/nova master: DNM: demo https://review.openstack.org/591073
20:12:57 leakypipes fried_rice: one sec. pulling your test patch onto the bottom.
20:13:26 fried_rice leakypipes: Cool beans. I just posted my comments, as well as --^ another patch demoing some of them
20:13:30 openstackgerrit Jay Pipes proposed openstack/nova master: placement: use simple code paths when possible https://review.openstack.org/590388
20:13:31 openstackgerrit Jay Pipes proposed openstack/nova master: split gigantor SQL placement query into multiple https://review.openstack.org/590041
20:13:32 openstackgerrit Jay Pipes proposed openstack/nova master: Adds a test for _get_provider_ids_matching() https://review.openstack.org/590150
20:13:33 openstackgerrit Jay Pipes proposed openstack/nova master: Test case for multiple forbidden traits https://review.openstack.org/591070
20:13:36 leakypipes fried_rice: et voila ^
20:14:36 fried_rice leakypipes: You put it on top
20:15:19 fried_rice leakypipes: You also reordered the other test patch to the top.
20:17:32 fried_rice leakypipes: For ease of backportage, perhaps we should squash both test patches into Gigantor.
20:19:58 openstackgerrit Jay Pipes proposed openstack/nova master: Adds a test for _get_provider_ids_matching() https://review.openstack.org/590150
20:19:59 openstackgerrit Jay Pipes proposed openstack/nova master: Test case for multiple forbidden traits https://review.openstack.org/591070
20:20:00 openstackgerrit Jay Pipes proposed openstack/nova master: placement: use simple code paths when possible https://review.openstack.org/590388
20:20:01 openstackgerrit Jay Pipes proposed openstack/nova master: split gigantor SQL placement query into multiple https://review.openstack.org/590041
20:20:11 leakypipes fried_rice: sorry bout that. fixed.
20:20:27 fried_rice leakypipes: Okay, please see comments in PS6 - at least one blocker remaining.
20:20:44 fried_rice s/at least//
20:35:59 openstackgerrit melanie witt proposed openstack/nova master: Handle unicode characters in migration params https://review.openstack.org/591080
21:00:45 openstackgerrit Merged openstack/nova master: Remove patching the mock lib https://review.openstack.org/590709
21:47:23 openstackgerrit Jay Pipes proposed openstack/nova master: split gigantor SQL placement query into multiple https://review.openstack.org/590041
21:48:05 leakypipes fried_rice: ^^

Earlier   Later