Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-08-06
16:50:11 mriedem first, that sounds borderline genocidal
16:50:22 mriedem second, i don't know what that means
16:50:32 mriedem an empty volume attachment reserves the volume
16:50:54 mriedem actually i think even a volume attachment that has a host connector is still not considering the volume as in-use,
16:51:02 mriedem that's why we have to call the 'complete' action on the attachment
16:51:06 mriedem to make the volume to in-use
16:51:20 mdbooth mriedem: Right. I'm just thinking of lyarwood's bug. The issue, IIUC, is that we create a 'reservation', which is an empty attachment, then the compute turns it into a real attachment, right?
16:51:29 mdbooth And the only way to get rid of that is to delete it.
16:51:46 mriedem depends on where we fail,
16:52:01 mriedem if we didn't get to the point of calling the complete action on the attachment, the volume is not in-use
16:52:02 mdbooth Sure, but if it's after we hydrated the attachment, this is how to rollback.
16:52:35 openstackgerrit Eric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider sane https://review.openstack.org/584598
16:52:35 openstackgerrit Eric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer https://review.openstack.org/584599
16:52:36 openstackgerrit Eric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648
16:52:37 openstackgerrit Eric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump https://review.openstack.org/585034
16:52:39 openstackgerrit Eric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape https://review.openstack.org/585049
16:52:40 openstackgerrit Eric Fried proposed openstack/nova master: Compute: Handle reshaped provider trees https://review.openstack.org/576236
16:52:46 mriedem i believe i talked to myself at length on an earlier PS on the review about how we could just simply not delete the attachment before rescheduling
16:53:08 mdbooth I'm pretty sure the answer's no, but I'm just wondering if there's any direct opposite to the compute's action which would cause the attachment to go back to being just a 'reservation'
16:53:21 mdbooth Ok, sounds like you already did that dance.
16:54:03 mriedem https://review.openstack.org/#/c/587071/3/nova/compute/manager.py@1631
16:55:41 mriedem tl;dr is i think this is no worse than what happened during reschedule *before* the attachments stuff,
16:55:57 mriedem we could go either way and there are pros/cons both ways
16:56:38 mriedem e.g. if compute doesn't delete the attachment, conductor would have to when we exhausted retries
16:58:23 mdbooth mriedem: Nice writeup, thanks.
17:00:04 mriedem if anyone knows about or cares about uefi instances, this might be a bug fix we need in nova https://github.com/starlingx-staging/stx-nova/commit/71acfeae0d1c59fdc77704527d763bd85a276f9a#diff-f4019782d93a196a0d026479e6aa61b1R8514
17:00:28 mriedem ah looky here https://bugs.launchpad.net/nova/+bug/1785123
17:00:28 openstack Launchpad bug 1785123 in OpenStack Compute (nova) "UEFI NVRAM lost on cold migration or resize" [Undecided,New]
17:23:33 melwitt .
17:24:02 mdbooth mriedem: I wonder if live migration handles that.
17:24:24 mdbooth mriedem: Pretty sure we care, btw.
17:53:00 mriedem mdbooth: they also have lvm thin pools; i looked up the patch to add that to nova and you nacked it saying we already have sparse lvms,
17:53:08 mriedem but sparse_logical_volumes was deprecated in rocky
17:55:38 mriedem they have quite a bit of support for lvm, not sure if that's just for their 1-2 node configs, and then use ceph for their 100 node deployment or what
17:57:09 mriedem and i'm done with the diff \o/
18:04:42 penick I saw the diff and backed away
18:16:58 openstackgerrit Radoslav Gerganov proposed openstack/nova stable/queens: Reload oslo_context after calling monkey_patch() https://review.openstack.org/589249
18:17:20 openstackgerrit Radoslav Gerganov proposed openstack/nova stable/queens: Reload oslo_context after calling monkey_patch() https://review.openstack.org/589249
18:18:05 openstackgerrit Radoslav Gerganov proposed openstack/nova stable/pike: Reload oslo_context after calling monkey_patch() https://review.openstack.org/589251
18:32:34 mriedem penick: here you go https://docs.google.com/spreadsheets/d/1ugp1FVWMsu4x3KgrmPf7HGX8Mh1n80v-KVzweSDZunU/edit?usp=sharing
18:36:52 penick damn, that's handy. Thanks!
18:38:54 mriedem now i'll figure out how to digest that a bit for some simple charts
19:59:36 openstackgerrit melanie witt proposed openstack/nova stable/ocata: [stable only] Add functional regression test for bug 1783613 https://review.openstack.org/588416
19:59:36 openstack bug 1783613 in OpenStack Compute (nova) ocata "[ocata only] quota usage not decremented during boot/delete race" [Undecided,In progress] https://launchpad.net/bugs/1783613 - Assigned to melanie witt (melwitt)
19:59:37 openstackgerrit melanie witt proposed openstack/nova stable/ocata: [stable only] Handle quota usage during create/delete races https://review.openstack.org/582413
20:05:34 dansmith mriedem: I dunno when this ^ regressed exactly, but it seems like a minor enough fix to be worth getting into the older releases that suffer from it
20:05:58 dansmith given where most people are, and to make sure anyone holding onto a non-counting-quotas release has a snowball's chance
20:07:00 mriedem ok
20:21:40 openstackgerrit Merged openstack/nova master: Increase max_unit in placement test fixture https://review.openstack.org/588158
20:46:25 openstackgerrit Merged openstack/nova master: [placement] Debug log per granular request group https://review.openstack.org/588350
21:02:30 openstackgerrit melanie witt proposed openstack/nova stable/ocata: [stable only] Add functional regression test for bug 1783613 https://review.openstack.org/588416
21:02:30 openstack bug 1783613 in OpenStack Compute (nova) ocata "[ocata only] quota usage not decremented during boot/delete race" [Undecided,In progress] https://launchpad.net/bugs/1783613 - Assigned to melanie witt (melwitt)
21:02:31 openstackgerrit melanie witt proposed openstack/nova stable/ocata: [stable only] Handle quota usage during create/delete races https://review.openstack.org/582413
22:18:36 jaypipes mriedem: looks like you had to spend a lot of time going through that starling-x diff. :(
22:29:19 mriedem definitely > 0
22:33:12 mriedem i put it off for a couple of weeks and then once i got going it was actually kind of interesting
22:33:36 mriedem although i'll say i glossed over a ton of the l3 cache and shared/pinned floating cpus and scaling (live resize) stuff
22:33:40 mriedem because it's just a ton of code
22:33:58 mriedem plus it's all super low-level in the hardware.py module which i avoid at all costs
22:42:55 melwitt nice job on the spreadsheet, lots of interesting info there
22:51:50 mriedem heh, maybe don't do this https://bugs.launchpad.net/nova/+bug/1785193
22:51:50 openstack Launchpad bug 1785193 in OpenStack Compute (nova) "changing a node's cell results in duplicate hypervisors" [Undecided,New] - Assigned to Chen (chenn2)
22:52:00 mriedem "it hurts when i do x." "then don't do x"
22:52:30 melwitt we need a safety fence
22:53:58 melwitt oh, they did it by editing nova.conf? heh. I had assumed it was through a nova-manage command of some sort
22:56:48 openstackgerrit melanie witt proposed openstack/nova master: Add a prelude release note for the 18.0.0 Rocky GA https://review.openstack.org/589303
23:00:59 mriedem well, this isn't really a cells thing
23:01:10 mriedem changing the db config at any point randomly would have caused weird issues
23:02:09 melwitt yeah, I hadn't yet read the bug and assumed a thing had occurred from use of a nova-manage command
23:02:39 melwitt when I said, "we need a safety fence"
23:06:01 mriedem nova is not enterprise ready
23:07:13 melwitt :)
#openstack-nova - 2018-08-07
00:13:25 openstackgerrit zhufl proposed openstack/nova master: Fix none-ascii char in doc https://review.openstack.org/588422
00:46:17 openstackgerrit Merged openstack/nova master: Refactor AllocationFixture in placement test https://review.openstack.org/588159
00:50:18 openstackgerrit Merged openstack/nova master: Adds a test for getting allocations API https://review.openstack.org/588886
01:11:40 openstackgerrit Merged openstack/nova master: Not use project table for user table https://review.openstack.org/588887
01:15:16 mriedem gibi: fyi i can't attend the notification meeting this week
01:40:05 openstackgerrit zhufl proposed openstack/nova master: xx_instance_type_id in list_migrations should be integer https://review.openstack.org/588481
02:04:12 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Use common functions in granular fixture https://review.openstack.org/588113
02:52:43 openstackgerrit melanie witt proposed openstack/nova-specs master: Add a script for counting blueprints https://review.openstack.org/581914
02:58:00 openstackgerrit Merged openstack/nova master: Define irrelevant-files for tempest-full-py3 job https://review.openstack.org/589039
04:56:02 openstackgerrit Merged openstack/python-novaclient master: Refactor the getid method in novaclient/base.py https://review.openstack.org/588983
05:01:49 openstackgerrit Merged openstack/nova master: Use common functions in NonSharedStorageFixture https://review.openstack.org/588114
06:24:25 openstackgerrit Chen proposed openstack/nova master: Trivial fix on migration doc https://review.openstack.org/589028
06:30:02 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Fix server strings in reboot operation https://review.openstack.org/588981
06:31:20 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Fix server strings in reboot operation https://review.openstack.org/588981
07:59:11 openstackgerrit Takashi NATSUME proposed openstack/nova master: [placement] Add version directives in the history doc https://review.openstack.org/589392
08:27:14 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Add /reshaper handler for POST https://review.openstack.org/576927
08:27:15 openstackgerrit Chris Dent proposed openstack/nova master: reshaper: Look up provider if not in inventories https://review.openstack.org/585033
08:27:16 openstackgerrit Chris Dent proposed openstack/nova master: Make get_allocations_for_resource_provider sane https://review.openstack.org/584598
08:27:17 openstackgerrit Chris Dent proposed openstack/nova master: Report client: Real get_allocs_for_consumer https://review.openstack.org/584599
08:27:18 openstackgerrit Chris Dent proposed openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648
08:27:19 openstackgerrit Chris Dent proposed openstack/nova master: Report client: _reshape helper, placement min bump https://review.openstack.org/585034
08:27:20 openstackgerrit Chris Dent proposed openstack/nova master: Report client: update_from_provider_tree w/reshape https://review.openstack.org/585049
08:27:21 openstackgerrit Chris Dent proposed openstack/nova master: Compute: Handle reshaped provider trees https://review.openstack.org/576236
08:38:03 mhen hello everybody! can you tell me the reason for using binascii.hexlify() to transform secrets into a hex representation before passing them to cryptsetup? example: https://github.com/openstack/nova/blob/25fa2470e220a83ce632fed70ad41e55aabda0da/nova/privsep/libvirt.py#L53
08:39:25 openstackgerrit zhufl proposed openstack/nova master: xx_instance_type_id in list_migrations should be integer https://review.openstack.org/588481
08:42:28 openstackgerrit Lee Yarwood proposed openstack/nova master: fixtures: Track volume attachments within CinderFixtureNewAttachFlow https://review.openstack.org/587013
08:42:29 openstackgerrit Lee Yarwood proposed openstack/nova master: Add regression test for bug#1784353 https://review.openstack.org/587014
08:42:30 openstackgerrit Lee Yarwood proposed openstack/nova master: conductor: Recreate volume attachments during a reschedule https://review.openstack.org/587071

Earlier   Later