Posted	Nick	Remark
#openstack-nova - 2018-08-06
22:29:19	mriedem	definitely > 0
22:33:12	mriedem	i put it off for a couple of weeks and then once i got going it was actually kind of interesting
22:33:36	mriedem	although i'll say i glossed over a ton of the l3 cache and shared/pinned floating cpus and scaling (live resize) stuff
22:33:40	mriedem	because it's just a ton of code
22:33:58	mriedem	plus it's all super low-level in the hardware.py module which i avoid at all costs
22:42:55	melwitt	nice job on the spreadsheet, lots of interesting info there
22:51:50	mriedem	heh, maybe don't do this https://bugs.launchpad.net/nova/+bug/1785193
22:51:50	openstack	Launchpad bug 1785193 in OpenStack Compute (nova) "changing a node's cell results in duplicate hypervisors" [Undecided,New] - Assigned to Chen (chenn2)
22:52:00	mriedem	"it hurts when i do x." "then don't do x"
22:52:30	melwitt	we need a safety fence
22:53:58	melwitt	oh, they did it by editing nova.conf? heh. I had assumed it was through a nova-manage command of some sort
22:56:48	openstackgerrit	melanie witt proposed openstack/nova master: Add a prelude release note for the 18.0.0 Rocky GA https://review.openstack.org/589303
23:00:59	mriedem	well, this isn't really a cells thing
23:01:10	mriedem	changing the db config at any point randomly would have caused weird issues
23:02:09	melwitt	yeah, I hadn't yet read the bug and assumed a thing had occurred from use of a nova-manage command
23:02:39	melwitt	when I said, "we need a safety fence"
23:06:01	mriedem	nova is not enterprise ready
23:07:13	melwitt	:)
#openstack-nova - 2018-08-07
00:13:25	openstackgerrit	zhufl proposed openstack/nova master: Fix none-ascii char in doc https://review.openstack.org/588422
00:46:17	openstackgerrit	Merged openstack/nova master: Refactor AllocationFixture in placement test https://review.openstack.org/588159
00:50:18	openstackgerrit	Merged openstack/nova master: Adds a test for getting allocations API https://review.openstack.org/588886
01:11:40	openstackgerrit	Merged openstack/nova master: Not use project table for user table https://review.openstack.org/588887
01:15:16	mriedem	gibi: fyi i can't attend the notification meeting this week
01:40:05	openstackgerrit	zhufl proposed openstack/nova master: xx_instance_type_id in list_migrations should be integer https://review.openstack.org/588481
02:04:12	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Use common functions in granular fixture https://review.openstack.org/588113
02:52:43	openstackgerrit	melanie witt proposed openstack/nova-specs master: Add a script for counting blueprints https://review.openstack.org/581914
02:58:00	openstackgerrit	Merged openstack/nova master: Define irrelevant-files for tempest-full-py3 job https://review.openstack.org/589039
04:56:02	openstackgerrit	Merged openstack/python-novaclient master: Refactor the getid method in novaclient/base.py https://review.openstack.org/588983
05:01:49	openstackgerrit	Merged openstack/nova master: Use common functions in NonSharedStorageFixture https://review.openstack.org/588114
06:24:25	openstackgerrit	Chen proposed openstack/nova master: Trivial fix on migration doc https://review.openstack.org/589028
06:30:02	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Fix server strings in reboot operation https://review.openstack.org/588981
06:31:20	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Fix server strings in reboot operation https://review.openstack.org/588981
07:59:11	openstackgerrit	Takashi NATSUME proposed openstack/nova master: [placement] Add version directives in the history doc https://review.openstack.org/589392
08:27:14	openstackgerrit	Chris Dent proposed openstack/nova master: [placement] Add /reshaper handler for POST https://review.openstack.org/576927
08:27:15	openstackgerrit	Chris Dent proposed openstack/nova master: reshaper: Look up provider if not in inventories https://review.openstack.org/585033
08:27:16	openstackgerrit	Chris Dent proposed openstack/nova master: Make get_allocations_for_resource_provider sane https://review.openstack.org/584598
08:27:17	openstackgerrit	Chris Dent proposed openstack/nova master: Report client: Real get_allocs_for_consumer https://review.openstack.org/584599
08:27:18	openstackgerrit	Chris Dent proposed openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648
08:27:19	openstackgerrit	Chris Dent proposed openstack/nova master: Report client: _reshape helper, placement min bump https://review.openstack.org/585034
08:27:20	openstackgerrit	Chris Dent proposed openstack/nova master: Report client: update_from_provider_tree w/reshape https://review.openstack.org/585049
08:27:21	openstackgerrit	Chris Dent proposed openstack/nova master: Compute: Handle reshaped provider trees https://review.openstack.org/576236
08:38:03	mhen	hello everybody! can you tell me the reason for using binascii.hexlify() to transform secrets into a hex representation before passing them to cryptsetup? example: https://github.com/openstack/nova/blob/25fa2470e220a83ce632fed70ad41e55aabda0da/nova/privsep/libvirt.py#L53
08:39:25	openstackgerrit	zhufl proposed openstack/nova master: xx_instance_type_id in list_migrations should be integer https://review.openstack.org/588481
08:42:28	openstackgerrit	Lee Yarwood proposed openstack/nova master: fixtures: Track volume attachments within CinderFixtureNewAttachFlow https://review.openstack.org/587013
08:42:29	openstackgerrit	Lee Yarwood proposed openstack/nova master: Add regression test for bug#1784353 https://review.openstack.org/587014
08:42:30	openstackgerrit	Lee Yarwood proposed openstack/nova master: conductor: Recreate volume attachments during a reschedule https://review.openstack.org/587071
08:43:57	lyarwood	mhen: so at present we are getting binary key from barbican that we need to turn into an ascii string to provide to cryptsetup / libvirt
08:44:35	lyarwood	mhen: the binascii calls are legacy code that we've not changed in order to not break existing users
08:44:56	lyarwood	mhen: really we need barbican to provide actual passphrases instead of binary keys to avoid using this in the future
08:45:55	lyarwood	mdbooth: ^ respun my changes above, thanks for catching the off by one mistake!
08:46:13	lyarwood	hopefully the py35-functional tests should also be fixed now
08:46:21	mhen	lyarwood, ok thanks I figured as much - is there any reason for using a hex encoding specifically? When talking about passphrases, you effectively double the string length since hex can only represent half as much in a single byte/character iirc.
08:46:39	mdbooth	lyarwood: :) Do you know where the attachment delete code is, btw?
08:46:52	mdbooth	lyarwood: Any reason it doesn't remove the attachment from the BDM.
08:46:54	mdbooth	?
08:47:56	lyarwood	mdbooth: yeah I left a comment, https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2503-L2505, is bdm.attachment_id is used all over the place to determine if we are using v3
08:48:09	mdbooth	lyarwood: Eurgh
08:48:10	lyarwood	but we'd still need this code to recreate the attachments even if we do remove it
08:48:23	lyarwood	as we don't get back up to the API where the initial attachments are created
08:48:48	mdbooth	lyarwood: Right, it's just that by getting out of whack we're opening ourselves to potential errors, and we also have to ping cinder to see if that's what we've done
08:49:06	mdbooth	That's not a problem in your patch, but it's unfortunate
08:49:08	lyarwood	mhen: I don't know of any reason, it's just a legacy choice that I've wanted to remove for ages but can't with existing users
08:49:51	lyarwood	mdbooth: yeah, I guess without the attachment_id we would need to do the v2 / v3 checks again in the conductor etc
08:50:22	mdbooth	lyarwood: Would you, though? Why wouldn't you just use v3 if conn_info and attachment_id are both unset?
08:51:07	lyarwood	mdbooth: iirc the API has a series of compute version checks it goes through before creating the attachments
08:54:55	mdbooth	lyarwood: Is it possible to have a reschedule *without* the original 'reservation' attachments having been deleted?
08:55:12	mdbooth	e.g. by an early failure which doesn't cause cleanup to go through _shutdown_instance?
08:56:26	lyarwood	mdbooth: yeah but that should be fine, the destination compute should just UPDATE the existing attachment at that point and an updated connection_info dict in return from cinder
08:58:22	lyarwood	mdbooth: nova/virt/block_device.py -> _volume_attach
08:59:42	gibi	dansmith: double checked the legacy allocation handling and we are lucky as the legacy codepath does the right thing for revert. Anyhow filled a bug https://bugs.launchpad.net/nova/+bug/1785776
08:59:42	openstack	Launchpad bug 1785776 in OpenStack Compute (nova) "resize revert still hitting the legacy allocation handling " [Undecided,New]
09:01:31	mhen	lyarwood, I assume that the hex representation was chosen to have a predictable and limited set of string characters in order to avoid any problems related to special characters?
09:01:53	lyarwood	mhen: yeah that could very well be the case
09:15:01	openstackgerrit	Takashi NATSUME proposed openstack/nova master: [placement] api-ref: add description for 1.29 https://review.openstack.org/589407
09:18:26	kosamara	efried: I studied your device-passthrough spec for nova-powervm. Do you plan to propose this or part of it in nova?
09:42:14	openstackgerrit	Rajesh Tailor proposed openstack/nova master: Fix host validity check for live-migration https://review.openstack.org/401009
09:50:28	mdbooth	lyarwood: I still think you're missing a test, btw. https://review.openstack.org/#/c/587071/8/nova/tests/unit/conductor/test_conductor.py
09:50:50	lyarwood	mdbooth: kk, where it exists?
09:51:02	lyarwood	mdbooth: either way the functional tests still aren't happy so I'll respin later today
09:51:39	mdbooth	lyarwood: yeah. I just checked the code and there's a reasonably wide window for errors which don't result in attachment deletion.
11:03:48	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Fix resize revert to use non-legacy alloc handling https://review.openstack.org/589425
11:04:26	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Fix resize revert to use non-legacy alloc handling https://review.openstack.org/589425
11:09:00	openstackgerrit	Merged openstack/nova master: Grease some more tests hitting RetryDecorator https://review.openstack.org/588391
11:09:06	openstackgerrit	Merged openstack/nova master: Grease test_try_deallocate_network_retry_direct https://review.openstack.org/588364
12:09:28	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Update installation guide to be more clear about cellsv2 https://review.openstack.org/584244
13:02:00	mdbooth	lyarwood: FYI, I accidentally started looking at your functional test failure, btw
13:02:23	mdbooth	lyarwood: Haven't fixed it yet, but I can continue or not as you like.
13:05:25	lyarwood	mdbooth: I've not got back around to it yet but I assume there are multiple attachments in the self.attachments[instance_uuid] list when I've used [0] to delete things from self.volume_to_attachment right?
13:05:40	lyarwood	mdbooth: if you already have something feel free to continue and push it up when you're done
13:05:57	mdbooth	lyarwood: Ok, will do.
13:07:34	mdbooth	lyarwood: What's the thinking here, btw:
13:07:37	mdbooth	def fake_get(self_api, context, volume_id, microversion=None):
13:07:37	mdbooth	+ attachment_id = self.volume_to_attachment.get(volume_id, volume_id)
13:07:54	mdbooth	Why would you want fake attachment_id to default to volume_id if not present?
13:09:10	mdbooth	Ah... that's what it did before
13:09:17	lyarwood	yarp
13:09:45	lyarwood	hmm this was working with a previous PS with that in place
13:10:51	mdbooth	lyarwood: I'm speculating. Issue is that we end up trying to fetch an attachment id not present. If the attachment id is a volume id ,that might be it.
13:11:08	mdbooth	I'm going to make it unique and stash it before returning.
13:12:16	lyarwood	mdbooth: https://review.openstack.org/#/c/587013/6..7/nova/tests/fixtures.py@1708 - I bet it's that line

Earlier   Later