| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-25 | |||
| 15:47:32 | bauzas | dansmith: mriedem: stephenfin: others: because of me, hard reboot no longer accepts to recreate a libvirt guest, but I fixed that by https://review.openstack.org/564257 | |
| 15:47:37 | melwitt | (in the test situation) | |
| 15:47:50 | bauzas | throw me tomatoes if you wish | |
| 15:48:06 | cdent | melwitt: the tests all end up getting None instead of the desire result | |
| 15:48:07 | bauzas | dansmith: mriedem: stephenfin: others: it'll also be a backport for Queens | |
| 15:48:27 | cdent | an invalid header operates as basically a header with no values | |
| 15:48:44 | melwitt | okay. I thought the lack of 'best_match' might have been because an invalid header was created. ignore me | |
| 15:48:58 | cdent | melwitt: ah, also: 1.1 is invalid too | |
| 15:49:10 | cdent | the valid range is 0 to 1 | |
| 15:49:17 | melwitt | oh, I had no idea | |
| 15:49:31 | cdent | I can update the commit message to make that more clear? | |
| 15:49:51 | melwitt | meh it's fine. I was just curious when I saw it | |
| 15:49:58 | cdent | ✔ | |
| 16:06:46 | jaypipes | mriedem, cdent: for the api-ref, what's the process for changing the documentation for a particular qstring parameter when that parameter was added in a prior microversion? | |
| 16:07:32 | jaypipes | mriedem, cdent: ref this patch: https://review.openstack.org/#/c/561315/ | |
| 16:08:11 | efried | jaypipes: In this case, I would add to the existing parameter entry. Let me find an example... | |
| 16:08:37 | jaypipes | mriedem, cdent: I see existing things in the api-ref like resource_provider_generation_1_19, etc. but is there a magic incantation to show a different description for a parameter once a specific microversion is reached? | |
| 16:08:55 | cdent | min_version | |
| 16:08:56 | efried | jaypipes: What do you mean "reached"? | |
| 16:09:23 | jaypipes | efried: sorry, I'm having trouble explaining this.. | |
| 16:09:24 | efried | jaypipes: But you're talking about member_of behaving differently at version Y than version X | |
| 16:09:29 | cdent | but what efried is saying is generally true for cases where the parameter is already around: add to the description "in microversion x you can do y" | |
| 16:09:33 | efried | https://developer.openstack.org/api-ref/placement/#list-allocation-candidates - see the `required` option. | |
| 16:09:37 | jaypipes | efried, cdent: yeah, what you just said eric :) | |
| 16:10:14 | efried | jaypipes: `required` uses both min_version (1.17) and an inline note about the additional functionality in 1.22. | |
| 16:10:39 | efried | jaypipes: So member_of will be similar. min_version 1.3, then new functionality in 1.2x | |
| 16:10:56 | jaypipes | efried: gotcha. inline note in the description field, then? | |
| 16:11:07 | efried | jaypipes: Yup | |
| 16:12:07 | jaypipes | efried: ok, thank you. | |
| 16:12:45 | mriedem | i've seen it both ways, | |
| 16:13:10 | mriedem | but yeah usually if the type doesn't change, we'd just add something to the parameter description saying, "starting with x, you can do foobars" | |
| 16:13:34 | efried | jaypipes: allocation_candidates_required and resource_provider_required_query are the ones cdent updated for forbidden traits. | |
| 16:13:46 | mriedem | in 2.53 we changed the id field in os-services and os-hypervisors from an integer to a string (uuid) so in that case we have 2 parameters in the table, one capped at 2.52 and one new for 2.53 | |
| 16:13:55 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: fix hard reboot issue with mdevs https://review.openstack.org/564257 | |
| 16:14:04 | mriedem | https://developer.openstack.org/api-ref/compute/#id377 | |
| 16:15:25 | bauzas | mriedem: thanks for the quick review on https://review.openstack.org/564257, new patch is up | |
| 16:16:28 | mriedem | bauzas: i just -1ed it again :) | |
| 16:17:14 | mriedem | i'm going to crack down on your usage of "that" | |
| 16:17:20 | mriedem | it's gotten out of hand | |
| 16:17:31 | jaypipes | mriedem: that is indeed that case. | |
| 16:17:46 | jaypipes | mriedem: and thx for the example on the api-ref. appreciated! | |
| 16:23:06 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process https://review.openstack.org/553857 | |
| 16:35:49 | openstackgerrit | Eric Fried proposed openstack/nova master: Bump pypowervm minimum to 1.1.15 https://review.openstack.org/564276 | |
| 16:37:10 | efried | edmondsw, esberglu: ^ | |
| 16:41:07 | openstackgerrit | Merged openstack/nova-specs master: fix blueprint related to the spec overhead-pin-set https://review.openstack.org/561916 | |
| 16:46:54 | openstackgerrit | Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315 | |
| 17:01:10 | openstackgerrit | Merged openstack/nova master: Fix invalid UUIDs in test https://review.openstack.org/564190 | |
| 17:05:04 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Wait for network-vif-plugged before starting live migration https://review.openstack.org/558001 | |
| 17:05:05 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add check if neutron "binding-extended" extension is available https://review.openstack.org/523548 | |
| 17:05:06 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "bind_ports_to_host" neutron API method https://review.openstack.org/523604 | |
| 17:05:07 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method https://review.openstack.org/552170 | |
| 17:05:08 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method https://review.openstack.org/555947 | |
| 17:05:09 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True https://review.openstack.org/556333 | |
| 17:05:10 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334 | |
| 17:05:11 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423 | |
| 17:05:12 | openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370 | |
| 17:05:13 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371 | |
| 17:05:14 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Port binding based on events during live migration https://review.openstack.org/434870 | |
| 17:05:15 | openstackgerrit | Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | |
| 17:06:11 | openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: fix hard reboot issue with mdevs https://review.openstack.org/564257 | |
| 17:28:50 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | |
| 17:28:51 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459 | |
| 17:43:39 | openstackgerrit | Merged openstack/nova master: Address issues raised in adding member_of to GET /a-c https://review.openstack.org/554357 | |
| 17:49:09 | esberglu | mriedem: Was working with efried an we aren't sure how this is working for the ironic driver | |
| 17:49:11 | esberglu | https://review.openstack.org/#/c/526094/46/nova/virt/powervm/driver.py@545 | |
| 17:49:57 | esberglu | When we get the bdm from the list of bdms it is regular dict | |
| 17:50:16 | esberglu | We are doing the same thing as ironic | |
| 17:50:51 | esberglu | Take the block_device_info (passed into spawn) and run block_device_info_get_mapping to get bdms | |
| 17:50:54 | esberglu | Then loop through them | |
| 17:52:05 | esberglu | Not sure what I'm missing, but I thought the bdm was supposed to be a DriverVolumeBlockDevice there | |
| 17:53:36 | esberglu | Here's what I'm actually seeing for the bdm at that point | |
| 17:53:37 | esberglu | http://paste.openstack.org/show/719946/ | |
| 17:55:48 | mriedem | esberglu: you have to rebase on top of efried's patch for the is_volume thing | |
| 17:55:58 | mriedem | https://review.openstack.org/#/c/564017/ | |
| 17:56:19 | mriedem | oh nvm i see what you're doing | |
| 17:56:46 | esberglu | mriedem: I've tried both with efrieds patch (bdm.is_volume) and without it (bdm._bdm_obj.is_volume) | |
| 17:56:57 | esberglu | Neither work in my test env. | |
| 17:57:13 | mriedem | are the unit tests using a list of DriverVolumeBlockDevice objects? | |
| 17:57:21 | esberglu | mriedem: yes | |
| 17:57:41 | esberglu | mriedem: https://review.openstack.org/#/c/526094/46/nova/tests/unit/virt/powervm/test_driver.py@487 | |
| 17:58:06 | esberglu | But it seems that we aren't getting a list of DriverVolumeBlockDevice objects live, just a list of dicts | |
| 17:58:52 | mriedem | well DriverVolumeBlockDevice is a dict | |
| 17:59:26 | mriedem | and it proxies through the special attributes for the wrapped bdm object | |
| 17:59:50 | mriedem | i see the unit tests are passing on your change.. | |
| 18:01:10 | esberglu | mriedem: Yeah, which is why it seems that we are getting something other than DriverVolumeBlockDevice live | |
| 18:01:27 | mriedem | you powervm guys need to stop saying "live" | |
| 18:02:11 | esberglu | *in my test environment :) | |
| 18:05:52 | mriedem | if only the 3rd party ci could test volume operations.... | |
| 18:09:57 | openstackgerrit | Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315 | |
| 18:10:54 | mriedem | esberglu: i pulled down efried's change, and then your change on top of it, and changed bdm._bdm_obj.is_volume to bdm.is_volume and the unit tests passed | |
| 18:11:01 | mriedem | so i'm not sure what is different about your test environment | |
| 18:11:16 | mriedem | but either your test env is wrong, or the unit tests aren't actually validating this correctly | |
| 18:13:19 | esberglu | mriedem: It seems to be something with a test env. Otherwise this would be broken for ironic too. | |
| 18:13:21 | esberglu | But like I said, we are running the exact same code to extract the bdm the they are | |
| 18:13:39 | mriedem | yeah i see that | |
| 18:13:40 | esberglu | Is there anything that could cause the block_device_info passed into spawn() to be different | |
| 18:23:51 | esberglu | mriedem: ^? | |
| 18:24:04 | mriedem | don't think so | |
| 18:24:08 | esberglu | efried: Yeah waiting for a reply | |
| 18:25:15 | mriedem | esberglu: spawn() gets the result of this https://github.com/openstack/nova/blob/936695221e7c22546cc09f0505a063744c1d38a2/nova/compute/manager.py#L2191 | |