Posted	Nick	Remark
#openstack-nova - 2018-04-25
16:15:25	bauzas	mriedem: thanks for the quick review on https://review.openstack.org/564257, new patch is up
16:16:28	mriedem	bauzas: i just -1ed it again :)
16:17:14	mriedem	i'm going to crack down on your usage of "that"
16:17:20	mriedem	it's gotten out of hand
16:17:31	jaypipes	mriedem: that is indeed that case.
16:17:46	jaypipes	mriedem: and thx for the example on the api-ref. appreciated!
16:23:06	openstackgerrit	Chris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process https://review.openstack.org/553857
16:35:49	openstackgerrit	Eric Fried proposed openstack/nova master: Bump pypowervm minimum to 1.1.15 https://review.openstack.org/564276
16:37:10	efried	edmondsw, esberglu: ^
16:41:07	openstackgerrit	Merged openstack/nova-specs master: fix blueprint related to the spec overhead-pin-set https://review.openstack.org/561916
16:46:54	openstackgerrit	Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315
17:01:10	openstackgerrit	Merged openstack/nova master: Fix invalid UUIDs in test https://review.openstack.org/564190
17:05:04	openstackgerrit	Matt Riedemann proposed openstack/nova master: Wait for network-vif-plugged before starting live migration https://review.openstack.org/558001
17:05:05	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add check if neutron "binding-extended" extension is available https://review.openstack.org/523548
17:05:06	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add "bind_ports_to_host" neutron API method https://review.openstack.org/523604
17:05:07	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method https://review.openstack.org/552170
17:05:08	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method https://review.openstack.org/555947
17:05:09	openstackgerrit	Matt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True https://review.openstack.org/556333
17:05:10	openstackgerrit	Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334
17:05:11	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423
17:05:12	openstackgerrit	Matt Riedemann proposed openstack/nova master: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370
17:05:13	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371
17:05:14	openstackgerrit	Matt Riedemann proposed openstack/nova master: Port binding based on events during live migration https://review.openstack.org/434870
17:05:15	openstackgerrit	Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537
17:06:11	openstackgerrit	Matt Riedemann proposed openstack/nova master: libvirt: fix hard reboot issue with mdevs https://review.openstack.org/564257
17:28:50	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297
17:28:51	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459
17:43:39	openstackgerrit	Merged openstack/nova master: Address issues raised in adding member_of to GET /a-c https://review.openstack.org/554357
17:49:09	esberglu	mriedem: Was working with efried an we aren't sure how this is working for the ironic driver
17:49:11	esberglu	https://review.openstack.org/#/c/526094/46/nova/virt/powervm/driver.py@545
17:49:57	esberglu	When we get the bdm from the list of bdms it is regular dict
17:50:16	esberglu	We are doing the same thing as ironic
17:50:51	esberglu	Take the block_device_info (passed into spawn) and run block_device_info_get_mapping to get bdms
17:50:54	esberglu	Then loop through them
17:52:05	esberglu	Not sure what I'm missing, but I thought the bdm was supposed to be a DriverVolumeBlockDevice there
17:53:36	esberglu	Here's what I'm actually seeing for the bdm at that point
17:53:37	esberglu	http://paste.openstack.org/show/719946/
17:55:48	mriedem	esberglu: you have to rebase on top of efried's patch for the is_volume thing
17:55:58	mriedem	https://review.openstack.org/#/c/564017/
17:56:19	mriedem	oh nvm i see what you're doing
17:56:46	esberglu	mriedem: I've tried both with efrieds patch (bdm.is_volume) and without it (bdm._bdm_obj.is_volume)
17:56:57	esberglu	Neither work in my test env.
17:57:13	mriedem	are the unit tests using a list of DriverVolumeBlockDevice objects?
17:57:21	esberglu	mriedem: yes
17:57:41	esberglu	mriedem: https://review.openstack.org/#/c/526094/46/nova/tests/unit/virt/powervm/test_driver.py@487
17:58:06	esberglu	But it seems that we aren't getting a list of DriverVolumeBlockDevice objects live, just a list of dicts
17:58:52	mriedem	well DriverVolumeBlockDevice is a dict
17:59:26	mriedem	and it proxies through the special attributes for the wrapped bdm object
17:59:50	mriedem	i see the unit tests are passing on your change..
18:01:10	esberglu	mriedem: Yeah, which is why it seems that we are getting something other than DriverVolumeBlockDevice live
18:01:27	mriedem	you powervm guys need to stop saying "live"
18:02:11	esberglu	*in my test environment :)
18:05:52	mriedem	if only the 3rd party ci could test volume operations....
18:09:57	openstackgerrit	Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315
18:10:54	mriedem	esberglu: i pulled down efried's change, and then your change on top of it, and changed bdm._bdm_obj.is_volume to bdm.is_volume and the unit tests passed
18:11:01	mriedem	so i'm not sure what is different about your test environment
18:11:16	mriedem	but either your test env is wrong, or the unit tests aren't actually validating this correctly
18:13:19	esberglu	mriedem: It seems to be something with a test env. Otherwise this would be broken for ironic too.
18:13:21	esberglu	But like I said, we are running the exact same code to extract the bdm the they are
18:13:39	mriedem	yeah i see that
18:13:40	esberglu	Is there anything that could cause the block_device_info passed into spawn() to be different
18:23:51	esberglu	mriedem: ^?
18:24:04	mriedem	don't think so
18:24:08	esberglu	efried: Yeah waiting for a reply
18:25:15	mriedem	esberglu: spawn() gets the result of this https://github.com/openstack/nova/blob/936695221e7c22546cc09f0505a063744c1d38a2/nova/compute/manager.py#L2191
18:25:29	mriedem	https://github.com/openstack/nova/blob/936695221e7c22546cc09f0505a063744c1d38a2/nova/compute/manager.py#L1563
18:25:48	mriedem	https://github.com/openstack/nova/blob/936695221e7c22546cc09f0505a063744c1d38a2/nova/virt/driver.py#L37
18:26:05	mriedem	^ takes a BlockDeviceMappingList and transforms the list into DriverVolumeBlockDevice objects
18:27:16	esberglu	efried: You have any ideas here? We're UTing with DriverVolumeBlockDevice objects, which are able to access the necessary fields
18:27:24	efried	mriedem: What does "live" mean to you? To me it means "not in a test suite". It doesn't necessarily imply "production".
18:27:42	mriedem	beyond that band from the 90s
18:27:43	mriedem	?
18:27:50	mriedem	or frampton
18:28:00	esberglu	And we should be getting DriverVolumeBlockDevice objects based on the last two links
18:28:06	esberglu	In the live environment
18:28:08	efried	esberglu: Yes, I agree.
18:28:16	esberglu	In the test env :)
18:28:19	efried	(including with your use of "live")
18:37:50	mriedem	esberglu: efried: i have no problems with these objects using efried's change http://paste.openstack.org/show/719952/
18:38:19	mriedem	>>> type(bdm_obj)
18:38:19	mriedem	<class 'nova.objects.block_device.BlockDeviceMapping'>
18:38:19	mriedem	>>> type(virt_bdm)
18:38:19	mriedem	<class 'nova.virt.block_device.DriverSnapshotBlockDevice'>
18:38:48	efried	mriedem: What, you're running on a real POWER system with NovaLink?
18:38:55	efried	mriedem: This is what we mean by "live" :P
18:39:12	efried	I think esberglu's problem was found when running in such an environment.
18:39:19	esberglu	efried: mriedem: Correct
18:39:37	efried	Though I'm getting skeptical
18:39:52	efried	...that pdb was actually telling you the right thing when you asked it `whatis`
18:40:12	cdent	why have a power system when you can have a POWER system?
18:40:38	efried	not helping
18:40:42	mriedem	efried: yeah i still have a tunnel into ibm
18:41:08	edleafe	cdent: STOP SHOUTING
18:41:23	mriedem	maybe you've got some stale pyc or pyo files or something, idk how your setup your test environments
18:41:30	mriedem	*you setup
18:41:58	mriedem	anywho, i don't even know if we should move forward with this if it can't get CI testing
18:42:42	mriedem	btw, what is an SSP cinder driver?
18:42:44	mriedem	what is SSP again?
18:42:49	efried	Shared Storage Pools
18:42:51	mriedem	super serious power

Earlier   Later