| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-24 | |||
| 22:35:48 | openstackgerrit | Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437 | |
| 22:35:49 | openstackgerrit | Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439 | |
| 22:35:50 | openstackgerrit | Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | |
| 22:54:28 | openstackgerrit | Arvind Nadendla proposed openstack/nova master: update scheduler to use image-traits https://review.openstack.org/560596 | |
| 22:56:22 | Kevin_Zheng | mriedem I can take the traceback BP, that one seems easy | |
| 22:58:41 | Kevin_Zheng | I already start working on migration one, had some poc in my pc, and setting up multi-node env for further testing last night, since we moved to our public cloud, I have to set up a new one:) | |
| #openstack-nova - 2018-04-25 | |||
| 00:35:50 | openstackgerrit | Merged openstack/nova master: Remove mox in unit/api/openstack/compute/test_hosts.py https://review.openstack.org/559266 | |
| 01:40:28 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Address nits in Iac23a574a05e62a99aab20ffce4265f4fb5a44d9 https://review.openstack.org/563802 | |
| 02:05:47 | openstackgerrit | Leopard Ma proposed openstack/nova master: fix paused instance not support shelve https://review.openstack.org/541660 | |
| 02:17:36 | openstackgerrit | Merged openstack/nova master: Use an independent transaction for _trait_sync https://review.openstack.org/558068 | |
| 02:20:56 | openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313 | |
| 03:20:53 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: WIP https://review.openstack.org/564092 | |
| 05:26:29 | openstackgerrit | Arvind Nadendla proposed openstack/nova master: update scheduler to use image-traits https://review.openstack.org/560596 | |
| 05:32:01 | openstackgerrit | Arvind Nadendla proposed openstack/nova master: update scheduler to use image-traits https://review.openstack.org/560596 | |
| 05:45:34 | TheJulia | jaypipes: w/r/t https://review.openstack.org/#/c/563722/ is your feeling still the same given the discussion yesterday. Curious because it looks like the discussion was winding down around the same time. | |
| 07:31:17 | openstackgerrit | Arvind Nadendla proposed openstack/nova master: update scheduler to use image-traits https://review.openstack.org/560596 | |
| 07:34:58 | alex_xu | gmann: for https://review.openstack.org/#/c/563728/1, I did a test, if we don't provide boot index, the boot from volume will fail, that sounds like a bug for API | |
| 07:36:00 | gmann | alex_xu: yea, i also tried to test this scenario in tempest test - https://review.openstack.org/#/c/563801/ | |
| 07:36:17 | gmann | alex_xu: it pass in ocata in pike and fail in queens and mastyer | |
| 07:37:30 | alex_xu | gmann: cool, sounds like we can revert that patch | |
| 07:38:31 | gmann | alex_xu: yea that is one option but matt is trying to fix it without revert -https://review.openstack.org/#/c/563732/2 | |
| 07:38:45 | Kevin_Zheng | ping gibi | |
| 07:39:08 | gmann | alex_xu: so either is ok for me revert and revert in queens also or backport the fix till queens | |
| 07:39:33 | gmann | alex_xu: not sure revert is possible for queens as it is bug since queens not just master | |
| 07:39:52 | alex_xu | gmann: got it | |
| 07:44:56 | openstackgerrit | Arvind Nadendla proposed openstack/nova master: update scheduler to use image-traits https://review.openstack.org/560596 | |
| 07:52:26 | gibi | Kevin_Zheng: pong | |
| 07:52:49 | Kevin_Zheng | hi, I saw your message today | |
| 07:53:31 | Kevin_Zheng | I'm willing to do it, I mean the traceback bp | |
| 07:54:05 | Kevin_Zheng | while I'm thinking about it, I found that it might be hard to test | |
| 07:54:12 | gibi | Kevin_Zheng: cool, thanks! Let me assigne the bp to you. | |
| 07:54:38 | Kevin_Zheng | you know, currently we compare samples with ture notify | |
| 07:54:52 | Kevin_Zheng | but for traceback, if the code line changes | |
| 07:55:03 | Kevin_Zheng | the traceback will also change | |
| 07:55:34 | gibi | Kevin_Zheng: true, I think we have to accept that we will only test parts of the traceback field | |
| 07:56:15 | Kevin_Zheng | I think that means changing the current test algorithm right? | |
| 07:56:58 | gibi | the current test framework allows overwriting what is in the sample for example in case of uuid we always overwrite what is in the samepl | |
| 07:57:02 | gibi | sample | |
| 07:57:30 | gibi | so we just need to set the replacement for traceback to ANY | |
| 07:58:00 | gibi | and then manually look into the traceback field in a single test and verify that some parts are present | |
| 08:00:33 | gibi | this code https://github.com/openstack/nova/blob/8a6665bc58d53f6ba0346760ba86d97d3437bfc5/nova/tests/functional/notification_sample_tests/test_instance.py#L379 does a lot of replacements | |
| 08:01:16 | kashyap | sean-k-mooney: Thanks for the review: https://review.openstack.org/#/c/563926/. Will address | |
| 08:01:23 | kashyap | Good you didn't catch anything more :-) | |
| 08:01:42 | gibi | Kevin_Zheng: and the test base class allows ANY as a replacement https://github.com/openstack/nova/blob/d4504302c99715508ed8b9822bf50ad485d34c96/nova/tests/functional/notification_sample_tests/notification_sample_base.py#L54 | |
| 08:01:54 | gibi | Kevin_Zheng: and that will match with anything | |
| 08:02:31 | gibi | Kevin_Zheng: https://github.com/openstack/nova/blob/d4504302c99715508ed8b9822bf50ad485d34c96/nova/tests/functional/notification_sample_tests/notification_sample_base.py#L128 | |
| 08:02:54 | Kevin_Zheng | cool， thanks for the info | |
| 08:06:25 | bauzas | morning stackers | |
| 08:26:40 | gibi | bauzas: morning | |
| 08:28:46 | openstackgerrit | Elod Illes proposed openstack/nova master: Functional test: cold migrate to compute down https://review.openstack.org/496280 | |
| 09:00:34 | openstackgerrit | Lei Zhang proposed openstack/nova master: Add method to get cpu traits https://review.openstack.org/560317 | |
| 09:27:04 | openstackgerrit | zhangyangyang proposed openstack/nova master: Remove ExactCoreFilter ExactDiskFilter ExactRamFilter https://review.openstack.org/508886 | |
| 09:27:12 | openstackgerrit | Michael Still proposed openstack/nova master: Use os.rename, not mv. https://review.openstack.org/562463 | |
| 09:27:13 | openstackgerrit | Michael Still proposed openstack/nova master: Convert fping API to processutils.execute() https://review.openstack.org/564144 | |
| 09:27:14 | openstackgerrit | Michael Still proposed openstack/nova master: Convert xenapi's xvp console to processutils. https://review.openstack.org/564145 | |
| 09:27:15 | openstackgerrit | Michael Still proposed openstack/nova master: Convert certificate generation to processutils. https://review.openstack.org/564146 | |
| 10:07:29 | openstackgerrit | MultipleCrashes proposed openstack/nova master: NCP-2367-deallocate-network-retry https://review.openstack.org/563418 | |
| 10:48:19 | stephenfin | jaypipes, bauzas: Either of you any idea what I'm doing wrong here? https://github.com/stephenfin/nova/commit/73b9d061551067e393eb5bfec296c64623c72b7c | |
| 10:49:16 | stephenfin | jaypipes, bauzas: My migration seems to be working. I ran 'nova-manage db sync' and can see the column in the instance_extra table. However, I'm getting the following exception from the super conductor http://paste.openstack.org/show/719901/ | |
| 10:49:56 | bauzas | stephenfin: heh, welcome to cells v2 | |
| 10:50:16 | bauzas | stephenfin: AFAIR, and if I'm not wrong, superconductor runs on the top API cell | |
| 10:50:26 | bauzas | stephenfin: hence it checking the API DB | |
| 10:51:48 | stephenfin | bauzas: Right, that's what I was thinking so I ran 'nova-manage api_db sync' too, to be safe. However, there's no 'instance_extra' table in the nova_api database | |
| 10:51:51 | bauzas | stephenfin: are you sure you correctly target a cell ? | |
| 10:52:02 | stephenfin | What do you mean? | |
| 10:52:12 | bauzas | there is a contextmanager | |
| 10:52:50 | stephenfin | bauzas, jaypipes: As an aside, here's my DB schema for the cell0 table http://paste.openstack.org/show/719902/ | |
| 10:52:54 | stephenfin | bauzas: Let me check | |
| 10:53:08 | bauzas | stephenfin: I'll need to go out | |
| 10:53:10 | bauzas | for eating | |
| 10:53:18 | stephenfin | bauzas: No problem. Let's pick this up after lunch | |
| 10:53:19 | bauzas | but lemme find some explanations | |
| 10:57:20 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Lift the restriction of choices for `cpu_model_extra_flags` https://review.openstack.org/563926 | |
| 10:57:21 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: Do-Not-Merge: Test 1GB Huge Pages https://review.openstack.org/564161 | |
| 10:59:38 | bauzas | stephenfin: in https://docs.openstack.org/nova/latest/user/cellsv2-layout.html#multiple-cells you can see the top-level superconductor using multiple MQs | |
| 11:09:09 | kashyap | sean-k-mooney: Respun the patch above, if you get a minute to ACK it today... | |
| 11:20:54 | bhagyashris | kashyap: Hi, I am trying to write the functional test for https://review.openstack.org/#/c/560444/ https://review.openstack.org/#/c/560459/ which related to libvirt change so can you guide me how should i write the test for the same. Basically this change is fixing related to scenario: As on current master, if user configured the shared resource provider along with the Compute Node resource providers on libvirt and boot the instance then the | |
| 11:20:54 | bhagyashris | DISK_GB used from the Compute Node resource provider. Expected that it should take the DISK_GB from the Shared Resource Provider and VCPU, MEMORY_MB from Compute Node resource provider. | |
| 11:27:46 | bhagyashris | kashyap: I have checked the existing functional test cases on master under /nova/tests/functional/libvirt/test_pci_sriov_servers.py but there they are directly building the instance using the post call but in my case i will need to resource provider to build the instance | |
| 11:28:32 | bhagyashris | kashyap: so can you guide? | |
| 11:29:49 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | |
| 12:05:38 | openstackgerrit | wanghongtao proposed openstack/nova master: Fix the metadata re to match the unicode https://review.openstack.org/536236 | |
| 12:09:36 | kashyap | bhagyashris: Was AFK, reading the scrollback now | |
| 12:10:26 | bhagyashris | kashyap: ok | |
| 12:11:06 | kashyap | bhagyashris: I haven't had a chance yet to use Resource Providers, so wouldn't really have great advice. Still, reading the change | |
| 12:11:47 | kashyap | bhagyashris: I think you wanted to address Eric's feedback: | |
| 12:11:51 | kashyap | "...or even better, don't mock - create an actual ProviderTree instance and assert its actual contents on the other side of the update_provider_tree call." | |
| 12:14:50 | bhagyashris | kashyap: no no Actually I have address the unit test cases related comments | |
| 12:15:27 | bhagyashris | kashyap: now i am talking about the fuctional test case part | |
| 12:18:14 | openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | |
| 12:18:15 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Add PLACEMENT_DB_ENABLED=True to the nova-next job https://review.openstack.org/564067 | |
| 12:18:35 | kashyap | bhagyashris: Ah, right | |
| 12:19:06 | openstackgerrit | Chris Dent proposed openstack/nova master: Isolate placement database config https://review.openstack.org/541435 | |
| 12:19:20 | kashyap | bhagyashris: So you don't have a precedent for functional test that uses Resource Provider to build an instance | |
| 12:19:43 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process https://review.openstack.org/553857 | |
| 12:24:15 | bhagyashris | kashyap: yeah as of now I haven't seen the functional like the resource providers are created and that are used to build the instance | |
| 12:24:57 | kashyap | bhagyashris: I'm afraid, I'm not really familiar with that area, so I can't help without extensive trial-and-error myself. Perhaps ask on the mailing list with [nova] tag? | |
| 12:25:45 | bhagyashris | kashyap: ok | |
| 12:27:00 | kashyap | bhagyashris: Since people are spread across time zones, you might get delayed (which is normal) responses on IRC. That's why I suggested the list. | |
| 12:28:35 | bhagyashris | kashyap: ok. currently i am struggling to write that so asking on IRC for quick response | |