Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-04-25
07:54:12 gibi Kevin_Zheng: cool, thanks! Let me assigne the bp to you.
07:54:38 Kevin_Zheng you know, currently we compare samples with ture notify
07:54:52 Kevin_Zheng but for traceback, if the code line changes
07:55:03 Kevin_Zheng the traceback will also change
07:55:34 gibi Kevin_Zheng: true, I think we have to accept that we will only test parts of the traceback field
07:56:15 Kevin_Zheng I think that means changing the current test algorithm right?
07:56:58 gibi the current test framework allows overwriting what is in the sample for example in case of uuid we always overwrite what is in the samepl
07:57:02 gibi sample
07:57:30 gibi so we just need to set the replacement for traceback to ANY
07:58:00 gibi and then manually look into the traceback field in a single test and verify that some parts are present
08:00:33 gibi this code https://github.com/openstack/nova/blob/8a6665bc58d53f6ba0346760ba86d97d3437bfc5/nova/tests/functional/notification_sample_tests/test_instance.py#L379 does a lot of replacements
08:01:16 kashyap sean-k-mooney: Thanks for the review: https://review.openstack.org/#/c/563926/. Will address
08:01:23 kashyap Good you didn't catch anything more :-)
08:01:42 gibi Kevin_Zheng: and the test base class allows ANY as a replacement https://github.com/openstack/nova/blob/d4504302c99715508ed8b9822bf50ad485d34c96/nova/tests/functional/notification_sample_tests/notification_sample_base.py#L54
08:01:54 gibi Kevin_Zheng: and that will match with anything
08:02:31 gibi Kevin_Zheng: https://github.com/openstack/nova/blob/d4504302c99715508ed8b9822bf50ad485d34c96/nova/tests/functional/notification_sample_tests/notification_sample_base.py#L128
08:02:54 Kevin_Zheng cool， thanks for the info
08:06:25 bauzas morning stackers
08:26:40 gibi bauzas: morning
08:28:46 openstackgerrit Elod Illes proposed openstack/nova master: Functional test: cold migrate to compute down https://review.openstack.org/496280
09:00:34 openstackgerrit Lei Zhang proposed openstack/nova master: Add method to get cpu traits https://review.openstack.org/560317
09:27:04 openstackgerrit zhangyangyang proposed openstack/nova master: Remove ExactCoreFilter ExactDiskFilter ExactRamFilter https://review.openstack.org/508886
09:27:12 openstackgerrit Michael Still proposed openstack/nova master: Use os.rename, not mv. https://review.openstack.org/562463
09:27:13 openstackgerrit Michael Still proposed openstack/nova master: Convert fping API to processutils.execute() https://review.openstack.org/564144
09:27:14 openstackgerrit Michael Still proposed openstack/nova master: Convert xenapi's xvp console to processutils. https://review.openstack.org/564145
09:27:15 openstackgerrit Michael Still proposed openstack/nova master: Convert certificate generation to processutils. https://review.openstack.org/564146
10:07:29 openstackgerrit MultipleCrashes proposed openstack/nova master: NCP-2367-deallocate-network-retry https://review.openstack.org/563418
10:48:19 stephenfin jaypipes, bauzas: Either of you any idea what I'm doing wrong here? https://github.com/stephenfin/nova/commit/73b9d061551067e393eb5bfec296c64623c72b7c
10:49:16 stephenfin jaypipes, bauzas: My migration seems to be working. I ran 'nova-manage db sync' and can see the column in the instance_extra table. However, I'm getting the following exception from the super conductor http://paste.openstack.org/show/719901/
10:49:56 bauzas stephenfin: heh, welcome to cells v2
10:50:16 bauzas stephenfin: AFAIR, and if I'm not wrong, superconductor runs on the top API cell
10:50:26 bauzas stephenfin: hence it checking the API DB
10:51:48 stephenfin bauzas: Right, that's what I was thinking so I ran 'nova-manage api_db sync' too, to be safe. However, there's no 'instance_extra' table in the nova_api database
10:51:51 bauzas stephenfin: are you sure you correctly target a cell ?
10:52:02 stephenfin What do you mean?
10:52:12 bauzas there is a contextmanager
10:52:50 stephenfin bauzas, jaypipes: As an aside, here's my DB schema for the cell0 table http://paste.openstack.org/show/719902/
10:52:54 stephenfin bauzas: Let me check
10:53:08 bauzas stephenfin: I'll need to go out
10:53:10 bauzas for eating
10:53:18 stephenfin bauzas: No problem. Let's pick this up after lunch
10:53:19 bauzas but lemme find some explanations
10:57:20 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Lift the restriction of choices for `cpu_model_extra_flags` https://review.openstack.org/563926
10:57:21 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: Do-Not-Merge: Test 1GB Huge Pages https://review.openstack.org/564161
10:59:38 bauzas stephenfin: in https://docs.openstack.org/nova/latest/user/cellsv2-layout.html#multiple-cells you can see the top-level superconductor using multiple MQs
11:09:09 kashyap sean-k-mooney: Respun the patch above, if you get a minute to ACK it today...
11:20:54 bhagyashris kashyap: Hi, I am trying to write the functional test for https://review.openstack.org/#/c/560444/ https://review.openstack.org/#/c/560459/ which related to libvirt change so can you guide me how should i write the test for the same. Basically this change is fixing related to scenario: As on current master, if user configured the shared resource provider along with the Compute Node resource providers on libvirt and boot the instance then the
11:20:54 bhagyashris DISK_GB used from the Compute Node resource provider. Expected that it should take the DISK_GB from the Shared Resource Provider and VCPU, MEMORY_MB from Compute Node resource provider.
11:27:46 bhagyashris kashyap: I have checked the existing functional test cases on master under /nova/tests/functional/libvirt/test_pci_sriov_servers.py but there they are directly building the instance using the post call but in my case i will need to resource provider to build the instance
11:28:32 bhagyashris kashyap: so can you guide?
11:29:49 openstackgerrit Balazs Gibizer proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660
12:05:38 openstackgerrit wanghongtao proposed openstack/nova master: Fix the metadata re to match the unicode https://review.openstack.org/536236
12:09:36 kashyap bhagyashris: Was AFK, reading the scrollback now
12:10:26 bhagyashris kashyap: ok
12:11:06 kashyap bhagyashris: I haven't had a chance yet to use Resource Providers, so wouldn't really have great advice. Still, reading the change
12:11:47 kashyap bhagyashris: I think you wanted to address Eric's feedback:
12:11:51 kashyap "...or even better, don't mock - create an actual ProviderTree instance and assert its actual contents on the other side of the update_provider_tree call."
12:14:50 bhagyashris kashyap: no no Actually I have address the unit test cases related comments
12:15:27 bhagyashris kashyap: now i am talking about the fuctional test case part
12:18:14 openstackgerrit Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766
12:18:15 openstackgerrit Chris Dent proposed openstack/nova master: WIP: Add PLACEMENT_DB_ENABLED=True to the nova-next job https://review.openstack.org/564067
12:18:35 kashyap bhagyashris: Ah, right
12:19:06 openstackgerrit Chris Dent proposed openstack/nova master: Isolate placement database config https://review.openstack.org/541435
12:19:20 kashyap bhagyashris: So you don't have a precedent for functional test that uses Resource Provider to build an instance
12:19:43 openstackgerrit Chris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process https://review.openstack.org/553857
12:24:15 bhagyashris kashyap: yeah as of now I haven't seen the functional like the resource providers are created and that are used to build the instance
12:24:57 kashyap bhagyashris: I'm afraid, I'm not really familiar with that area, so I can't help without extensive trial-and-error myself. Perhaps ask on the mailing list with [nova] tag?
12:25:45 bhagyashris kashyap: ok
12:27:00 kashyap bhagyashris: Since people are spread across time zones, you might get delayed (which is normal) responses on IRC. That's why I suggested the list.
12:28:35 bhagyashris kashyap: ok. currently i am struggling to write that so asking on IRC for quick response
12:28:49 kashyap Yeah, a combination is fine. bhagyashris How about this:
12:29:13 kashyap bhagyashris: Post what you have based on how far you've come, and then point that to a Resource Providers expert (maybe jaypipes) for more guidance?
12:30:16 kashyap Also, Zuul is still failing on your https://review.openstack.org/#/c/560459/.
12:30:31 bhagyashris kashyap: ok waiting for others will see
12:31:24 bhagyashris kashyap: yeah struggling for the same also randomly the tempest test are falling
12:32:58 bhagyashris kashyap: and all are failing with the error as No valid host is found. I have also checked the logs and at n-sch side it's showing that the Placement is returning allocation_candidates
12:33:05 kashyap I see
12:33:58 bhagyashris kashyap: I am not getting why the n-sch is not returning the allocation_candicates as my change is at nova compute side
12:34:29 bhagyashris kashyap: and on master evrthing is fine only on patch patches it's failing
12:35:08 bhagyashris kashyap: any idea/
12:35:10 bhagyashris ?
12:35:58 openstackgerrit Balazs Gibizer proposed openstack/nova master: Escalate UUID validation warning to error in test https://review.openstack.org/540386
12:35:59 openstackgerrit Balazs Gibizer proposed openstack/nova master: Fix invalid UUIDs in test https://review.openstack.org/564190
12:37:25 kashyap bhagyashris: Not without delving too deep. Please go through the traces systematically to find the root cause. I'm a bit buried with a couple of urgent things
12:37:54 bhagyashris kashyap: ok np thank you :)
12:38:34 bhagyashris jaypipes: Hi,
12:47:35 openstackgerrit Martin Midolesov proposed openstack/nova master: Validating video ram against the max video ram allowed https://review.openstack.org/564193
13:14:26 openstackgerrit Balazs Gibizer proposed openstack/nova master: Enhance service restart in functional env https://review.openstack.org/512552
13:14:28 openstackgerrit Balazs Gibizer proposed openstack/nova master: Reproduce bug 1724172 in the functional test env https://review.openstack.org/512553
13:14:28 openstack bug 1724172 in OpenStack Compute (nova) "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Undecided,In progress] https://launchpad.net/bugs/1724172 - Assigned to Balazs Gibizer (balazs-gibizer)
13:14:28 openstackgerrit Balazs Gibizer proposed openstack/nova master: cleanup evacuated instances not on hypervisor https://review.openstack.org/512623
13:29:29 openstackgerrit Sylvain Bauza proposed openstack/nova master: libvirt: mdevs returning parent and vendor PCI info https://review.openstack.org/562304
13:29:30 openstackgerrit Sylvain Bauza proposed openstack/nova master: libvirt: Configure multiple vGPU types https://review.openstack.org/564214
13:29:31 openstackgerrit Sylvain Bauza proposed openstack/nova master: WIP: libvirt: Get inventories per pGPU https://review.openstack.org/564215
13:38:05 mnaser super unrelated but i feel like this might be something devs have had to deal with
13:38:21 mnaser is there some sort of 'tcpdump for rabbitmq' toolset available anywhere (or part of rabbitmq)
13:43:44 stephenfin bauzas: OK, looked at that and it does seem like it's targeted. See line 35 from the paste paste.openstack.org/show/719901/
13:43:50 stephenfin and compare to https://github.com/stephenfin/nova/blob/bp/numa-aware-vswitches/nova/conductor/manager.py#L1172-L1175
13:46:41 stephenfin But wait - the *cell1* table wasn't migrated. Well that's annoying. I would have expected 'nova-manage sync' to do all cell tables unless I explicitly said otherwise http://paste.openstack.org/show/719912/
13:46:56 openstackgerrit Hamdy Khader proposed openstack/nova master: Adding NVMEoF for libvirt driver https://review.openstack.org/482640

Earlier   Later