| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-28 | |||
| 14:06:03 | cdent | 128-256 is not valid unicode | |
| 14:06:19 | mriedem | dansmith: or just link https://etherpad.openstack.org/p/rocky-nova-priorities-tracking in the channel topic and link the runways etherpad from the top of that | |
| 14:06:31 | mriedem | or a gerrit dashboard link, | |
| 14:06:42 | mriedem | where mel controls the starred patches per runway that go into said dashboard | |
| 14:06:43 | mriedem | or something | |
| 14:07:03 | dansmith | well, it'd just be nice to see names as reminders instead of the same url week to week, is what I meant | |
| 14:07:23 | dansmith | (hence the irc announcement part of that procedure) | |
| 14:07:36 | mriedem | so like, current runways: update-provider-tree, placement-req, foobars | |
| 14:07:41 | dansmith | cha | |
| 14:07:53 | openstackgerrit | Elod Illes proposed openstack/nova stable/ocata: Functional test for regression bug #1713783 https://review.openstack.org/505160 | |
| 14:07:53 | openstack | bug 1713783 in OpenStack Compute (nova) ocata "After failed evacuation the recovered source compute tries to delete the instance" [High,In progress] https://launchpad.net/bugs/1713783 - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 14:07:53 | openstackgerrit | Elod Illes proposed openstack/nova stable/ocata: Set error state after failed evacuation https://review.openstack.org/518733 | |
| 14:08:07 | mriedem | wfm | |
| 14:08:55 | efried | cdent: So JSON strings have to be unicode I take it. | |
| 14:08:57 | mriedem | so i guess next in line is privsep | |
| 14:09:22 | cdent | efried: it depends on which layer you're at, over the wire JSON is supposed to always be utf-8 encode unicode | |
| 14:09:52 | mriedem | mikal: please confirm your availability for https://blueprints.launchpad.net/nova/+spec/hurrah-for-privsep-again reviews for the next 2 weeks | |
| 14:10:25 | mriedem | likely not to hear about that for several hours | |
| 14:10:27 | dansmith | mriedem: heh, that answer won't come for 10 hours | |
| 14:10:28 | dansmith | yeah | |
| 14:10:45 | cdent | efried: once you see the results in python, it should be unicode strings (or numbers) | |
| 14:10:53 | dansmith | since the queue is fresh I tend to think we can assume in this case, but... | |
| 14:11:08 | mriedem | dansmith: please confirm your availability for https://blueprints.launchpad.net/nova/+spec/placement-req-filter reviews for the next 2 weeks | |
| 14:11:42 | dansmith | mriedem: I will be available with the exception of this coming friday which is a company holiday, but I don't anticipate that being significant | |
| 14:11:52 | mriedem | EASTER! | |
| 14:11:54 | efried | dansmith, mriedem: FWIW mikal has been responsive to those patches within a couple days up to this point. And with I think one or two exceptions, they've all been scrubbed to multiple-+1-ness at this point. | |
| 14:12:04 | dansmith | efried: aye | |
| 14:12:11 | mriedem | CONFIRMED | |
| 14:12:12 | edleafe | Heh - "slow" [t2LP0] | |
| 14:12:35 | edleafe | Lemme fix that [t 2LP0] | |
| 14:12:36 | purplerbot | ||
| 14:12:46 | dansmith | heh | |
| 14:13:22 | efried | dansmith: I happened to notice that mikal (whether on purpose or not) changed the commit message tags from 'hurrah-for-privsep-again' to 'hurrah-for-privsep' in the last spin. | |
| 14:13:34 | efried | I didn't go and check what the bp is actually called. | |
| 14:13:42 | dansmith | efried: that's likely git-review | |
| 14:13:52 | efried | it was in the commit message, not the topic | |
| 14:15:02 | dansmith | oh | |
| 14:18:10 | bhagyashris | mriedem, alex_xu_: Hi, Thanks for review! Addressed review comments on spec https://review.openstack.org/#/c/511825/ request to re-visit | |
| 14:18:59 | mriedem | ok | |
| 14:21:57 | kashyap | 20 is the lucky number, if anyone looking for a trivial feature to +2 (it already has +2 from Alex): https://review.openstack.org/#/c/534384/ | |
| 14:23:14 | kashyap | Zuul has to bless & kiss it, though | |
| 14:23:34 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: Remove usage of kwarg retry_on_request in API https://review.openstack.org/557348 | |
| 14:25:06 | bauzas | efried: I don't know if it's you that wrote https://etherpad.openstack.org/p/nova-runways-rocky L39 but I think virt driver changes using nested resources shoukdn't be using that slot | |
| 14:25:22 | mriedem | the placement aggregates api confuses me every time i look at it | |
| 14:25:24 | efried | bauzas: It was, and I agree they shouldn't. | |
| 14:25:38 | efried | mriedem: How so? Maybe we can fix the docs. | |
| 14:25:39 | bauzas | efried: because those need specific domain expertise, and I think it's a separate runway slot then | |
| 14:26:05 | efried | bauzas: They're also a separate piece of work, *using* the upt bp, not part of its implementation. | |
| 14:26:06 | mriedem | efried: i think it's just because there is no POST for aggregates | |
| 14:26:12 | mriedem | but i know that's intentional | |
| 14:26:22 | efried | mriedem: Yeah, they get created (but not deleted!) dynamically. | |
| 14:26:33 | mriedem | PUT /resource_providers/{uuid}/aggregates means to just associate a resource provider with an aggregate uuid which may or may not exist | |
| 14:27:12 | efried | cdent, mriedem: by the same token, I think https://review.openstack.org/#/c/556669/ is not technically part of bp/placement-aggregate-generation, in which case that bp can be marked as implemented. | |
| 14:27:26 | efried | bauzas: ^ | |
| 14:30:15 | efried | mriedem: disregard, I see it already is. | |
| 14:34:36 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: Remove usage of kwarg retry_on_request in API https://review.openstack.org/557348 | |
| 14:34:58 | cdent | efried: did you figure out the unicode thing? I'm timeslicing, so not sure if that loop is closed | |
| 14:35:31 | efried | cdent: I was about to go start playing with u'\xXXX' strings. I'll pester you again, I'm sure :) | |
| 14:35:50 | cdent | ✔ | |
| 14:45:06 | openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Add to contributor docs about handler testing https://review.openstack.org/557355 | |
| 14:45:27 | cdent | jaypipes, efried: the aforementioned to do list item related to handler unit testing ^ | |
| 14:47:51 | cdent | sigh, had to be at least one typo | |
| 14:48:48 | openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Add to contributor docs about handler testing https://review.openstack.org/557355 | |
| 14:50:14 | mriedem | i need a non-lee stable core to approve https://review.openstack.org/#/c/555029/ so we can do a queens release | |
| 14:50:33 | mriedem | there is also a bunch more https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/queens+label:Code-Review=2 | |
| 14:50:38 | mriedem | if someone were so inclined | |
| 14:51:24 | dansmith | mriedem: got that one | |
| 15:01:06 | efried | cdent: FYI, using unichr(x) let me run numbers over 127 just fine. | |
| 15:01:31 | efried | cdent, jaypipes: I created RPs with names up to unichr(64K) and they all succeeded. | |
| 15:01:38 | efried | JFYI. | |
| 15:02:22 | efried | which part was me not believing in python? | |
| 15:02:32 | cdent | is unichr codepoints or byte descriptions of unicode encodings | |
| 15:02:51 | efried | You're just talking gibberish now. | |
| 15:02:53 | edleafe | efried: please use six.unichr() | |
| 15:03:08 | edleafe | 'unichr' is undefined in python3 | |
| 15:03:09 | efried | I'm not using it for code edleafe, was just using it for testing purposes. | |
| 15:03:46 | cdent | efried: do you mean you don't know what a codepoint is? | |
| 15:03:47 | edleafe | efried: ok, I thought that this was going in your slugify stuff | |
| 15:03:58 | efried | though edleafe cdent it makes me wonder whether https://review.openstack.org/#/c/556628/ is going to DTRT when translating a unicode input. | |
| 15:04:08 | efried | cdent: I don't really even know what unicode is. | |
| 15:04:21 | efried | cdent: I mean, beyond "a big freaking table of character encodings" | |
| 15:04:24 | cdent | efried: then you've answered my question about beliving in python | |
| 15:04:54 | melwitt | dansmith, mriedem: I had been thinking that anyone in the core team could move things from the queue into the runways, not only me | |
| 15:05:48 | edleafe | cdent: to answer your question, bytes | |
| 15:05:53 | cdent | efried: I will look at that code for real when I get home, but it looks like overkill. Is there associated brokenness that demands it (other than length) | |
| 15:05:53 | efried | edleafe, cdent: Answer: it breaks handily. | |
| 15:05:55 | kashyap | mriedem: dansmith: Thanks for the thorough review, I'll address the comments tomm; today I have to head out early | |
| 15:06:40 | kashyap | dansmith: BTW, if I use a warning, instead of 'exception.Invalid', would you still want a test for that? -- https://review.openstack.org/#/c/534384/20/nova/virt/libvirt/driver.py | |
| 15:06:48 | efried | cdent: The commit message explains the need for it. Basically, I don't want every impl of update_provider_tree (or other things that need to generate names for placement entities) to have to be aware of character restrictions and length rules, and write their own slugifier. | |
| 15:06:55 | dansmith | kashyap: yes | |
| 15:06:56 | kashyap | dansmith: Not that I _don't_ want to write, just trying to keep things as minimal as possible :-) | |
| 15:07:30 | kashyap | dansmith: Alright | |
| 15:08:23 | kashyap | mriedem: Especially, appreciate the eagle eyes on wording. I agree with all those points. | |
| 15:10:40 | kashyap | mriedem: On expanding acroynms ... I have a handy little package (less than 1MB) on my linux distribution. That goes like: | |
| 15:11:00 | kashyap | $> wtf is wrt | |
| 15:11:00 | kashyap | WRT: with respect to | |
| 15:11:07 | kashyap | $> wtf is iirc | |
| 15:11:08 | kashyap | IIRC: if I {recall,remember} correctly | |
| 15:11:10 | kashyap | And lastly: | |
| 15:11:17 | kashyap | $> wtf is wtf | |