Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-03-28
14:21:57 kashyap 20 is the lucky number, if anyone looking for a trivial feature to +2 (it already has +2 from Alex): https://review.openstack.org/#/c/534384/
14:23:14 kashyap Zuul has to bless & kiss it, though
14:23:34 openstackgerrit Lee Yarwood proposed openstack/nova stable/pike: Remove usage of kwarg retry_on_request in API https://review.openstack.org/557348
14:25:06 bauzas efried: I don't know if it's you that wrote https://etherpad.openstack.org/p/nova-runways-rocky L39 but I think virt driver changes using nested resources shoukdn't be using that slot
14:25:22 mriedem the placement aggregates api confuses me every time i look at it
14:25:24 efried bauzas: It was, and I agree they shouldn't.
14:25:38 efried mriedem: How so? Maybe we can fix the docs.
14:25:39 bauzas efried: because those need specific domain expertise, and I think it's a separate runway slot then
14:26:05 efried bauzas: They're also a separate piece of work, *using* the upt bp, not part of its implementation.
14:26:06 mriedem efried: i think it's just because there is no POST for aggregates
14:26:12 mriedem but i know that's intentional
14:26:22 efried mriedem: Yeah, they get created (but not deleted!) dynamically.
14:26:33 mriedem PUT /resource_providers/{uuid}/aggregates means to just associate a resource provider with an aggregate uuid which may or may not exist
14:27:12 efried cdent, mriedem: by the same token, I think https://review.openstack.org/#/c/556669/ is not technically part of bp/placement-aggregate-generation, in which case that bp can be marked as implemented.
14:27:26 efried bauzas: ^
14:30:15 efried mriedem: disregard, I see it already is.
14:34:36 openstackgerrit Lee Yarwood proposed openstack/nova stable/pike: Remove usage of kwarg retry_on_request in API https://review.openstack.org/557348
14:34:58 cdent efried: did you figure out the unicode thing? I'm timeslicing, so not sure if that loop is closed
14:35:31 efried cdent: I was about to go start playing with u'\xXXX' strings. I'll pester you again, I'm sure :)
14:35:50 cdent ✔
14:45:06 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Add to contributor docs about handler testing https://review.openstack.org/557355
14:45:27 cdent jaypipes, efried: the aforementioned to do list item related to handler unit testing ^
14:47:51 cdent sigh, had to be at least one typo
14:48:48 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Add to contributor docs about handler testing https://review.openstack.org/557355
14:50:14 mriedem i need a non-lee stable core to approve https://review.openstack.org/#/c/555029/ so we can do a queens release
14:50:33 mriedem there is also a bunch more https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/queens+label:Code-Review=2
14:50:38 mriedem if someone were so inclined
14:51:24 dansmith mriedem: got that one
15:01:06 efried cdent: FYI, using unichr(x) let me run numbers over 127 just fine.
15:01:31 efried cdent, jaypipes: I created RPs with names up to unichr(64K) and they all succeeded.
15:01:38 efried JFYI.
15:02:22 efried which part was me not believing in python?
15:02:32 cdent is unichr codepoints or byte descriptions of unicode encodings
15:02:51 efried You're just talking gibberish now.
15:02:53 edleafe efried: please use six.unichr()
15:03:08 edleafe 'unichr' is undefined in python3
15:03:09 efried I'm not using it for code edleafe, was just using it for testing purposes.
15:03:46 cdent efried: do you mean you don't know what a codepoint is?
15:03:47 edleafe efried: ok, I thought that this was going in your slugify stuff
15:03:58 efried though edleafe cdent it makes me wonder whether https://review.openstack.org/#/c/556628/ is going to DTRT when translating a unicode input.
15:04:08 efried cdent: I don't really even know what unicode is.
15:04:21 efried cdent: I mean, beyond "a big freaking table of character encodings"
15:04:24 cdent efried: then you've answered my question about beliving in python
15:04:54 melwitt dansmith, mriedem: I had been thinking that anyone in the core team could move things from the queue into the runways, not only me
15:05:48 edleafe cdent: to answer your question, bytes
15:05:53 cdent efried: I will look at that code for real when I get home, but it looks like overkill. Is there associated brokenness that demands it (other than length)
15:05:53 efried edleafe, cdent: Answer: it breaks handily.
15:05:55 kashyap mriedem: dansmith: Thanks for the thorough review, I'll address the comments tomm; today I have to head out early
15:06:40 kashyap dansmith: BTW, if I use a warning, instead of 'exception.Invalid', would you still want a test for that? -- https://review.openstack.org/#/c/534384/20/nova/virt/libvirt/driver.py
15:06:48 efried cdent: The commit message explains the need for it. Basically, I don't want every impl of update_provider_tree (or other things that need to generate names for placement entities) to have to be aware of character restrictions and length rules, and write their own slugifier.
15:06:55 dansmith kashyap: yes
15:06:56 kashyap dansmith: Not that I _don't_ want to write, just trying to keep things as minimal as possible :-)
15:07:30 kashyap dansmith: Alright
15:08:23 kashyap mriedem: Especially, appreciate the eagle eyes on wording. I agree with all those points.
15:10:40 kashyap mriedem: On expanding acroynms ... I have a handy little package (less than 1MB) on my linux distribution. That goes like:
15:11:00 kashyap $> wtf is wrt
15:11:00 kashyap WRT: with respect to
15:11:07 kashyap $> wtf is iirc
15:11:08 kashyap IIRC: if I {recall,remember} correctly
15:11:10 kashyap And lastly:
15:11:17 kashyap $> wtf is wtf
15:11:18 kashyap WTF: where's the food
15:11:18 kashyap {what,when,where,who,why} the fuck
15:11:41 kashyap The RPM is called:
15:11:41 kashyap $> rpm -qf `which wtf`
15:11:42 kashyap bsd-games-2.17-53.fc26.x86_64
15:12:04 mriedem i know what wrt means
15:12:18 mriedem i wouldn't assume that all non-native english speakers have that nifty package
15:12:28 kashyap mriedem: Only joking; I know what you meant: "Be sensitive to non-native speakers"
15:13:27 bauzas mriedem: will look at stable changes soon or later
15:15:25 mriedem bauzas: that's a time range i can bank on
15:16:02 bauzas but for the moment, kids are too young to code
15:16:15 bauzas that's a shame
15:16:36 bauzas I'm pretty sure a 7-yo kid can code better than me
15:21:34 bauzas if you consider it that way, algorithms are easily understood by young children, and sometimes they can guess patterns better than adults
15:21:58 bauzas so yeah I affirm some kid can beat me on that
15:24:08 dansmith lyarwood: can you hit this? https://review.openstack.org/#/c/554600/
15:26:32 openstackgerrit Surya Seetharaman proposed openstack/nova-specs master: Handling a down cell https://review.openstack.org/557369
15:29:46 openstackgerrit Claudiu Belu proposed openstack/nova master: tests: fixes mock autospec usage https://review.openstack.org/447505
15:29:46 openstackgerrit Claudiu Belu proposed openstack/nova master: tests: autospecs all the mock.patch usages https://review.openstack.org/470775
15:29:47 openstackgerrit Claudiu Belu proposed openstack/nova master: WIP: replace spec with autospec https://review.openstack.org/557299
15:30:47 mriedem so i guess the placement api-ref hasn't been updated for 1.21 yet? https://docs.openstack.org/nova/latest/user/placement.html#support-member-of-aggregates-queryparam-on-get-allocation-candidates
15:30:57 mriedem https://developer.openstack.org/api-ref/placement/#list-allocation-candidates
15:31:02 claudiub welp, I've found a bug in the vmware driver because of the mock autospec patch. :D https://review.openstack.org/#/c/470775/28/nova/virt/vmwareapi/driver.py
15:31:26 claudiub should create a bug report.
15:31:27 mriedem bauzas: in the time you spent talking about your kid out-coding you, you could have just looked at those stable patches
15:32:31 bauzas for 2 mins ?
15:33:30 mriedem edleafe: can you push a fix for this? https://review.openstack.org/#/c/552098/9/placement-api-ref/source/allocation_candidates.inc@35
15:35:14 edleafe mriedem: in a meeting - will get to it soon
15:36:20 mriedem jaypipes-away: dansmith: alex_xu_: efried: edleafe: did i miss the point about https://review.openstack.org/#/c/555413/ being ok to change the member_of behavior in the 1.21 microversion?
15:36:52 dansmith mriedem: it's not going to change 1.21
15:37:01 efried mriedem: You're right, we weren't being particularly precise, but it was understood that we were going to cut a new microversion.
15:37:28 mriedem ok https://review.openstack.org/#/c/555413/3/specs/rocky/approved/alloc-candidates-member-of.rst@172
15:37:31 mriedem i see that now
15:37:33 openstackgerrit Artom Lifshitz proposed openstack/nova-specs master: NUMA-aware live migration https://review.openstack.org/552722
15:37:33 mriedem whew
15:38:28 melwitt dansmith: can you hit these queens backports pls https://review.openstack.org/#/c/555914
15:39:02 dansmith melwitt: when I'm done with downstream bug paperwork :/
15:39:13 melwitt :(
15:40:14 mriedem so i guess we should re-open https://blueprints.launchpad.net/nova/+spec/alloc-candidates-member-of

Earlier   Later