| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-08 | |||
| 14:49:29 | mdbooth | No, on success | |
| 14:49:37 | mriedem | ok you were saying rollback earlier | |
| 14:49:45 | mdbooth | Yeah, different bug :) | |
| 14:50:11 | mdbooth | I was looking at the success case, and noticed it looked like there was a related problem in the rollback case | |
| 14:50:25 | mdbooth | But I haven't verified that yet | |
| 14:51:04 | mdbooth | Anyway, as we call pre_live_migration synchronously, it occurred to me we don't need it to return to us the values before it modified them | |
| 14:51:18 | mdbooth | We can just stash them before calling pre_live_migration | |
| 14:51:49 | mriedem | i assume this is all a problem reported on like newton or something right? | |
| 14:51:56 | mriedem | i'm sure it's a latent bug for the old style volume attachments, | |
| 14:52:24 | mdbooth | Yeah, since Liberty I think | |
| 14:52:30 | mriedem | i think with the new style attachments, we don't have the same issue because live migration tracks the attachments for the source and dest host, and cinder stores the connection_info in the attachment records (in cinder), so we don't have the bdm.connection_info wonkaroo in nova | |
| 14:52:43 | mdbooth | Yep | |
| 14:53:23 | mriedem | simply refreshing the connection info for the old style attachments might do the trick | |
| 14:54:00 | mriedem | since that will initialize the connection (in cinder) for the host we're on (since we have to pass a host connector) and we'll get back a new connection_info from cinder which will get updated in the bdm.connection_info | |
| 14:56:11 | mdbooth | mriedem: True, except for the discovered inconsistent return value from initialize_connection | |
| 14:56:25 | mdbooth | Which I think the cinder folks are also treating as a bug, btw. | |
| 14:56:44 | mdbooth | But they hate the second call to initialize_connection regardless :) | |
| 14:57:06 | jaypipes | cdent: no, it's not a goer... gonna focus on mirroring. | |
| 14:58:14 | cdent | jaypipes: cool the spec came around for review on my todo list and saw it was a bit stale, so wasn't sure of state | |
| 15:02:31 | jaypipes | cdent: dansmith's pre-filter spec should take care of the agg affinity use cases for the most part. | |
| 15:15:53 | openstackgerrit | Eric M Gonzalez (tasker) proposed openstack/nova master: unquiesce instance after quiesce failure https://review.openstack.org/550865 | |
| 15:16:32 | mriedem | stephenfin: +2 on the keymap deprecation https://review.openstack.org/#/c/483994/ | |
| 15:16:39 | stephenfin | ta | |
| 15:16:57 | openstackgerrit | Merged openstack/nova master: Refactor WSGI apps and utils to limit imports https://review.openstack.org/533797 | |
| 15:17:10 | openstackgerrit | Merged openstack/nova stable/queens: hyper-v: Logs tips on PortBindingFailed https://review.openstack.org/550529 | |
| 15:17:19 | openstackgerrit | Merged openstack/nova stable/queens: Detach volumes when VM creation fails https://review.openstack.org/544144 | |
| 15:17:29 | openstackgerrit | Merged openstack/nova master: Allow to configure amount of PCIe ports https://review.openstack.org/545034 | |
| 15:19:03 | sean-k-mooney | jaypipes: hi yes if i write a spec for adding rquired traits to resouce providers ill assume it is post rocky. it is something i would not mind trying to add myself if i get the time if for no other reason then to test out the mechanium for solving the problem in a generic way. | |
| 15:22:03 | hrw | mriedem, stephenfin: now that pcie patch got merged into rocky what goes with blueprint? should it get reviewed or something? | |
| 15:22:11 | hrw | https://blueprints.launchpad.net/nova/+spec/configure-amount-of-pcie-ports one I mean | |
| 15:22:36 | mriedem | hrw: marked complete | |
| 15:22:43 | hrw | mriedem: thank you | |
| 15:23:12 | stephenfin | mriedem: While we're on the subject, how about this one? https://blueprints.launchpad.net/openstack/?searchtext=vcpu-weighter | |
| 15:23:37 | mriedem | stephenfin: how is that on the subject? | |
| 15:23:40 | stephenfin | In general, how does one bring up specless blueprints for review? | |
| 15:23:54 | stephenfin | We're talking about specless blueprints | |
| 15:24:11 | mriedem | stephenfin: welcome new contributor https://docs.openstack.org/nova/latest/contributor/blueprints.html | |
| 15:24:29 | hrw | stephenfin: I took mine to Nova meeting. | |
| 15:24:49 | stephenfin | You learn something new everyday | |
| 15:25:20 | hrw | stephenfin: you are just one hour too late | |
| 15:26:51 | mriedem | stephenfin: on https://review.openstack.org/#/c/550250/ i'm going to leave the metadata service stuff in the admin guide where it is for now due to there being nova-net specific stuff in there, | |
| 15:27:12 | mriedem | i'll put a todo or something in there to clean that up for neutron, if/when i can find any neutron-related docs for the metadata service | |
| 15:27:17 | mriedem | i'll address the other comments | |
| 15:28:19 | stephenfin | Sounds good to me | |
| 15:31:22 | openstackgerrit | Jay Pipes proposed openstack/os-traits master: Add HW_NIC_SRIOV_TRUSTED trait https://review.openstack.org/550873 | |
| 15:31:25 | jaypipes | sahid: ^^ | |
| 15:43:27 | openstackgerrit | Merged openstack/nova stable/pike: Handle glance exception during rotating instance backup https://review.openstack.org/533439 | |
| 15:45:31 | cdent | presumably if we are going to move the rp objects ( https://review.openstack.org/#/c/540049/ ) sooner in the cycle is better than later? | |
| 15:46:05 | edleafe | cdent: unless you want a ton of merge conflicts late in the cycle, of course | |
| 15:47:37 | mriedem | thinking about the resource class field, any reason we wouldn't just move that to o.vo instead of a new os-resource-classes library? | |
| 15:48:25 | openstackgerrit | Merged openstack/nova stable/pike: Fix SUSE Install Guide: Placement port https://review.openstack.org/545167 | |
| 15:48:26 | dansmith | I really wish that was split up | |
| 15:49:30 | jaypipes | dansmith: wish what was split up? | |
| 15:50:08 | dansmith | jaypipes: cdent's moving rp objects, reswizzling the fields, splitting them into separate files, etc | |
| 15:50:27 | jaypipes | dansmith: oh? is it all in one patch? | |
| 15:50:44 | dansmith | jaypipes: you +2d it :) | |
| 15:50:50 | dansmith | ...yesterday | |
| 15:51:21 | cdent | dansmith: happy to split it up, but not sure where the split boundaries are? | |
| 15:51:22 | jaypipes | dansmith: that patch didn't move rp objects... | |
| 15:51:33 | dansmith | jaypipes: yes it does | |
| 15:52:14 | cdent | mriedem: I suspect to avoid depending on ovo | |
| 15:52:23 | mriedem | cdent: we already depend on o.voc | |
| 15:52:25 | mriedem | *o.vo | |
| 15:52:38 | cdent | nova does | |
| 15:52:44 | cdent | other things need resource classes | |
| 15:52:46 | mriedem | and placement will | |
| 15:52:46 | jaypipes | dansmith: oh, sorry, you are referring to the resource **classes** | |
| 15:52:53 | cdent | besides placement | |
| 15:52:54 | jaypipes | dansmith: not nova.objects.resource_provider | |
| 15:53:09 | dansmith | jaypipes: no I mean the objects | |
| 15:53:10 | dansmith | Rnova/api/openstack/placement/objects/resource_provider.py | |
| 15:53:41 | jaypipes | oh ffs. | |
| 15:53:54 | jaypipes | I did not notice that moved the file location. :( | |
| 15:53:56 | jaypipes | sorry dansmith | |
| 15:53:58 | dansmith | cdent: I gave you like three seams in my snarky snarkage above :) | |
| 15:55:09 | cdent | dansmith: where have I split things into separate files (beyond for resource classes)? Or do you just mean that? | |
| 15:55:30 | dansmith | cdent: I'm commenting, I'll put some ideas in there | |
| 15:56:19 | jaypipes | cdent: I think dansmith is just wanting to segregate the changes that put the resource classes stuff into a separate file from the changes that moved the location of nova/objects/resource_provider.py | |
| 15:56:40 | jaypipes | dansmith: amirite? | |
| 15:56:47 | dansmith | at least that | |
| 15:57:26 | cdent | mriedem: As I said in the intro to http://lists.openstack.org/pipermail/openstack-dev/2018-March/128004.html the idea is to put everyting in the existing placement directory because a) the entire system is the api, so that directory will be _the_ directory in the future, b) enable a lift and shift with presered history from just one dir | |
| 15:58:36 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: cover migration cases with functional tests https://review.openstack.org/493865 | |
| 15:58:45 | cdent | thanks dansmith | |
| 15:58:54 | dansmith | man, gerrit is really (really) confused by this change | |
| 16:00:23 | mriedem | cdent: so when we have a separate placement repo, | |
| 16:00:30 | mriedem | there will be a single root dir and it's called 'api'? | |
| 16:00:42 | cdent | no it will be called placement, and there will be no dir called api | |
| 16:00:43 | mriedem | well, presumably 2 dirs, api and test | |
| 16:00:59 | cdent | in placement will be tests | |
| 16:01:30 | mriedem | so chop of the nova/api/openstack prefix and just everything below that becomes the new root | |
| 16:01:40 | cdent | yes | |
| 16:01:42 | mriedem | ok | |
| 16:01:59 | cdent | placement is "simple" enough for that to work | |
| 16:02:12 | cdent | (at least initially) | |
| 16:02:16 | mriedem | yeah that's fine | |
| 16:03:25 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | |
| 16:05:41 | Kevin_Zheng | dansmith hi, according to https://github.com/openstack/nova/blob/3a3b0f09db318faf1a1ea711a73bb365cab8b233/nova/context.py#L376 context.db_connection & context.mq_connection will be set to None, will that be a problem when access DB? or if it is None we will fallback to use the option in config file? | |
| 16:06:24 | dansmith | Kevin_Zheng: no, if they're none then it uses the global config, same as you have now | |
| 16:07:03 | Kevin_Zheng | OK, thanks | |
| 16:13:22 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add sample test for instance audit https://review.openstack.org/480955 | |