Earlier  
Posted Nick Remark
#openstack-nova - 2018-03-08
16:07:03 Kevin_Zheng OK, thanks
16:13:22 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add sample test for instance audit https://review.openstack.org/480955
16:14:26 cdent dansmith: the resource provider objects were pulled out of a test_objects long ago when we stopped versioning them. Or do you mean something else?
16:14:50 dansmith cdent: ah, right, we register_if(False)'d them right?
16:14:58 cdent yeah
16:15:13 dansmith okay then ignore the fingerprint comments :)
16:15:22 cdent roger :)
16:15:31 cdent rest of them make sense, will think on this a bit later
16:15:39 dansmith ack
16:20:28 mriedem stephenfin: is there a way to give different names for the :oslo.config:option: stuff?
16:20:42 mriedem because i have to put the group in the link but then i don't want that actually showing up in the name
16:20:49 mriedem i.e.
16:20:50 mriedem :oslo.config:option:`api.metadata_cache_expiration` = 15
16:20:57 mriedem shows up with "api.metadata_cache_expiration" as the name
16:21:26 stephenfin :oslo.config:option:`foobar <api.metadata_cache_expiration>` should work
16:21:34 mriedem yeah that's what i'm trying now, thanks
16:21:36 mriedem like any other ref
16:38:04 openstackgerrit Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486
16:55:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Re-work the metadata service docs https://review.openstack.org/550250
16:56:27 openstackgerrit Balazs Gibizer proposed openstack/nova master: Replace raise with self.fail() in unit test https://review.openstack.org/550914
17:15:23 openstackgerrit Merged openstack/nova master: Add simple db purge command https://review.openstack.org/550171
17:15:39 dansmith hoo boy
17:18:01 openstackgerrit Dan Smith proposed openstack/nova master: Add --purge helper flag to archive_deleted_rows https://review.openstack.org/550182
17:18:01 openstackgerrit Dan Smith proposed openstack/nova master: Make nova-manage db purge take --all-cells https://review.openstack.org/550502
17:18:14 dansmith mriedem: had to rebase ^ and fixed your comments on the final one
17:19:36 openstackgerrit Merged openstack/nova stable/pike: Lazy-load instance attributes with read_deleted=yes https://review.openstack.org/545988
17:22:39 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Rework '_get_cpu_topology_constraints' https://review.openstack.org/407173
17:22:40 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Rework get_number_of_serial_ports https://review.openstack.org/407174
17:23:06 stephenfin jaypipes: I made a silly typo in the first of those patches. Any chance you could re-add it to your review queue 🙈
17:23:31 stephenfin (You can't do all(a, b, c) - needs to be all((a, b, c)) )
17:25:46 mriedem dansmith: small thing in https://review.openstack.org/#/c/550502/9
17:26:11 dansmith ack
17:26:58 openstackgerrit Dan Smith proposed openstack/nova master: Make nova-manage db purge take --all-cells https://review.openstack.org/550502
17:27:03 dansmith mriedem: ^
17:27:25 mriedem +5
17:28:28 dansmith I'm going through Kevin_Zheng's revision now
17:29:37 mriedem i'm going to go through the cupboard
17:47:29 dansmith jaypipes: if you want to send this I can rebase Kevin_Zheng's conflicting patch on master for him when it merges: https://review.openstack.org/#/c/550502
17:47:45 dansmith it's just a minor --all-cells iteration of what you've already reviewed
17:48:22 dansmith and after that, we'll be able to actually purge cruft from our database, just eight short years after we started
18:05:55 mriedem just in time for spring
18:07:01 openstackgerrit Surya Seetharaman proposed openstack/nova master: Make archive_deleted_rows handle a missing CONF.api_database.connection https://review.openstack.org/550967
18:08:42 stephenfin mriedem: Am I correct in thinking that all filters (e.g. NUMATopologyFilter) run on whatever host is running 'nova-scheduler'?
18:09:15 mriedem umm, they don't care about the actual physical host that nova-scheduler is running on
18:09:24 mriedem but yes they all run in the nova-scheduler process
18:09:29 mriedem based on the enabled_filters config list
18:10:06 mriedem iow you can run nova-scheduler in a separate host, vm, venv, container whatever
18:10:24 stephenfin Coolness
18:10:32 mriedem just not a function in lambda yet
18:10:45 mriedem but intel is working on it
18:11:03 stephenfin (I'd defined a host-specific option on a nova-compute node and was wondering why the NUMATopologyFilter couldn't see it)
18:11:23 mriedem you'd have to pump that information up to the scheduler via the compute node
18:11:33 mriedem the HostState object in the scheduler is really a wrapper over a compute node
18:11:45 mriedem and the compute node record has all sorts of hook points for crap, like the stats dict
18:12:03 stephenfin Yup. I'm targeting the HostState object now
18:12:03 mriedem or, via traits or something in placement
18:12:08 mriedem if you want the new hotness
18:12:22 stephenfin jaypipes is going to _hate_ v1 of this NUMA-aware vSwitch code
18:12:26 mriedem but since we don't model numa nodes yet...
18:12:44 mriedem s/jaypipes/everyone/
18:12:44 stephenfin Nor network-NUMA affinity (from neutron)
18:12:51 stephenfin Hence that static config option
18:12:52 stephenfin :)
18:13:19 tssurya dansmith, mriedem : fix for the regression I caused - https://review.openstack.org/#/c/550967/ , hoping this was what was expected...
18:14:02 dansmith tssurya: I was just commenting on that
18:14:26 tssurya dansmith: ack
18:15:34 dansmith tssurya: in short, it is mostly what I expected, but the last couple days of working on purge and archive --all-cells has me thinking of a few other things
18:16:15 dansmith oh I see you also have WIP patches up for the cell disabling stuff, cool
18:16:31 tssurya dansmith: I totally agree that the mappings and specs can get orphaned
18:18:08 tssurya dansmith: yea just WIPs for now since the spec is not merged yet
18:18:14 dansmith awesome
18:18:22 tssurya and thanks for you review and time!
18:18:32 dansmith I +2d that spec earlier today
18:19:33 tssurya Yes , thanks for that
18:19:42 tssurya I am guessing a second core also needs to review right ?
18:19:56 mriedem dansmith: did you want this in ocata? https://review.openstack.org/#/c/542767/
18:20:01 mriedem it's a rhetorical questoin
18:20:08 mriedem tssurya: yes i've got it starred
18:20:34 tssurya mriedem : thank you
18:21:31 dansmith tssurya: fair warning: mriedem will try to find some spelling mistake in that spec to lodge a -1 against my +2
18:21:39 dansmith tssurya: but that's about me, not you, so don't take it personally :)
18:21:54 mriedem not for spelling,
18:21:59 mriedem but likely for something about tests for docs
18:22:14 dansmith tests for docs?
18:22:34 tssurya now I am confused
18:22:36 mriedem *or
18:22:39 mriedem heh
18:22:41 dansmith mriedem: oohhh :)
18:23:53 tssurya mriedem : I will wait for it then
18:42:38 dansmith I believe I have voted on all non-WIP tssurya patches as of this moment
18:43:34 dansmith two cookies!
18:45:49 mriedem what about your love for pizza too?
18:46:07 dansmith there it is.
18:46:08 mriedem and proper. punctuation.
18:54:58 cfriesen anyone aware of issues with the metadata service in devstack? does it need to be explicitly enabled?
19:48:29 mriedem cfriesen: add n-api-meta to ENABLED_SERVICES
19:48:38 mriedem although i think you can also just run it under n-api
19:48:47 mriedem but not sure
20:13:41 mriedem dansmith: you might want to reply on this thread http://lists.openstack.org/pipermail/openstack-operators/2018-March/014930.html
20:13:45 mriedem we talked about that last week

Earlier   Later