| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-08 | |||
| 14:00:45 | edleafe | dansmith: I'm here, but distracted with lots of non-OpenStack stuff | |
| 14:01:08 | dansmith | edleafe: ah, cool | |
| 14:01:19 | dansmith | edleafe: cdent reviewed some of my prefilter patches which reminded me you promised to do the placement api for that and I meant to say something last week about it | |
| 14:01:40 | sean-k-mooney | gibi: it shoudl be fairly simple but its a new api and needs a spec + placement team need to agree this is an api we want to supprot going forwoard | |
| 14:02:17 | dansmith | edleafe: jaypipes already got a spec for that merged, so the gates are open | |
| 14:02:22 | edleafe | dansmith: I remember. If you could point me to your patches it will help refresh the tired brain cells | |
| 14:02:43 | dansmith | edleafe: yep, here's the template of the client bit: https://review.openstack.org/#/c/547990/2 | |
| 14:02:49 | dansmith | edleafe: and the spec: https://review.openstack.org/#/c/544694/ | |
| 14:03:15 | edleafe | dansmith: ok. Probably won't have bandwidth until Monday, though | |
| 14:03:39 | dansmith | edleafe: ack | |
| 14:03:52 | openstackgerrit | Dan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method https://review.openstack.org/544728 | |
| 14:03:53 | openstackgerrit | Dan Smith proposed openstack/nova master: Add aggregates list to Destination object https://review.openstack.org/544729 | |
| 14:03:53 | openstackgerrit | Dan Smith proposed openstack/nova master: Add request filter functionality to scheduler https://review.openstack.org/544730 | |
| 14:03:54 | openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Make get_allocation_candidates() honor aggregate restrictions https://review.openstack.org/547990 | |
| 14:03:54 | openstackgerrit | Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002 | |
| 14:03:55 | openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282 | |
| 14:04:46 | jaypipes | sean-k-mooney: I'm amenable to reviewing a spec on it, but it won't be a priority for Rocky. just so you know. | |
| 14:10:21 | jaypipes | stephenfin: +2 | |
| 14:12:51 | stephenfin | jaypipes: ta | |
| 14:27:24 | mdbooth | mriedem: Just looking at a live migration bug which came up downstream, and I can't see anywhere we restore bdm.connection_info if we're forced to rollback. Any chance I missed it? That's not the downstream bug, btw, but it's in the same area. | |
| 14:29:15 | openstackgerrit | Merged openstack/nova master: Deprecate sparse LVs https://review.openstack.org/549771 | |
| 14:31:54 | hrw | bauzas, jaypipes, kashyap, mriedem, stephenfin: thanks for help with PCIe hotplug patch. | |
| 14:32:20 | kashyap` | Np | |
| 14:34:43 | gibi | sean-k-mooney: yeah. I think I will try to not make a dependency between the bandwidth spec and a new placement api spec if this is not really necessary | |
| 14:34:57 | gibi | sean-k-mooney: that spec is already a monster :) | |
| 14:40:45 | mriedem | mdbooth: not off the top of my head | |
| 14:41:04 | openstackgerrit | Dan Smith proposed openstack/nova master: Make nova-manage db purge take --all-cells https://review.openstack.org/550502 | |
| 14:41:18 | mdbooth | mriedem: NP, just thought I'd ask in case you had it cached. | |
| 14:41:20 | cdent | jaypipes: I can't remember; where did the aggregates-affinity plan end up? Is it a goer? https://review.openstack.org/#/c/529135/ | |
| 14:42:34 | mriedem | mdbooth: pre_live_migration on the dest host creates the bdms in the MigrateData object which is then passed back to the source | |
| 14:44:29 | mdbooth | mriedem: I suspect we're not restoring that stashed value to bdm.connection_info if we rollback. The volume would still be attached, but cinder v2 operations would fail I think. | |
| 14:44:48 | mdbooth | mriedem: This is code-inspection only. I'm going to try to verify and I'll raise a bug. | |
| 14:45:07 | openstackgerrit | Merged openstack/nova master: Handle IpAddressAlreadyAllocated exception https://review.openstack.org/535532 | |
| 14:45:16 | openstackgerrit | Merged openstack/nova master: install-guide: Wrap long console command https://review.openstack.org/544093 | |
| 14:45:18 | mriedem | i think i see where we update the bdm.connection_info to point at the dest host | |
| 14:45:25 | openstackgerrit | Merged openstack/nova master: [placement] use simple FaultWrapper https://review.openstack.org/533752 | |
| 14:45:46 | mriedem | mdbooth: this https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5957 | |
| 14:45:48 | mdbooth | We update it for the dest in pre_live_migration | |
| 14:45:55 | mriedem | with refresh_conn_info=True | |
| 14:45:57 | mriedem | right | |
| 14:46:03 | mriedem | if you're using old style migrations | |
| 14:46:07 | mdbooth | mdbooth: Yep, that's the one. | |
| 14:47:03 | mdbooth | Incidentally, the downstream bug relates to a cinder driver which doesn't consistently return identical values for initialize_connection | |
| 14:47:27 | mdbooth | I believe because of multipath, although I'm not 100% sure why not | |
| 14:48:15 | mdbooth | The impact is that when we try to detach on the source post live migration, we call initialize_connection to get the source conn_info, then call detach, which fails because the conn_info isn't exactly what we had before | |
| 14:49:18 | mriedem | detach on the source during rollback because live migration failed? | |
| 14:49:29 | mdbooth | No, on success | |
| 14:49:37 | mriedem | ok you were saying rollback earlier | |
| 14:49:45 | mdbooth | Yeah, different bug :) | |
| 14:50:11 | mdbooth | I was looking at the success case, and noticed it looked like there was a related problem in the rollback case | |
| 14:50:25 | mdbooth | But I haven't verified that yet | |
| 14:51:04 | mdbooth | Anyway, as we call pre_live_migration synchronously, it occurred to me we don't need it to return to us the values before it modified them | |
| 14:51:18 | mdbooth | We can just stash them before calling pre_live_migration | |
| 14:51:49 | mriedem | i assume this is all a problem reported on like newton or something right? | |
| 14:51:56 | mriedem | i'm sure it's a latent bug for the old style volume attachments, | |
| 14:52:24 | mdbooth | Yeah, since Liberty I think | |
| 14:52:30 | mriedem | i think with the new style attachments, we don't have the same issue because live migration tracks the attachments for the source and dest host, and cinder stores the connection_info in the attachment records (in cinder), so we don't have the bdm.connection_info wonkaroo in nova | |
| 14:52:43 | mdbooth | Yep | |
| 14:53:23 | mriedem | simply refreshing the connection info for the old style attachments might do the trick | |
| 14:54:00 | mriedem | since that will initialize the connection (in cinder) for the host we're on (since we have to pass a host connector) and we'll get back a new connection_info from cinder which will get updated in the bdm.connection_info | |
| 14:56:11 | mdbooth | mriedem: True, except for the discovered inconsistent return value from initialize_connection | |
| 14:56:25 | mdbooth | Which I think the cinder folks are also treating as a bug, btw. | |
| 14:56:44 | mdbooth | But they hate the second call to initialize_connection regardless :) | |
| 14:57:06 | jaypipes | cdent: no, it's not a goer... gonna focus on mirroring. | |
| 14:58:14 | cdent | jaypipes: cool the spec came around for review on my todo list and saw it was a bit stale, so wasn't sure of state | |
| 15:02:31 | jaypipes | cdent: dansmith's pre-filter spec should take care of the agg affinity use cases for the most part. | |
| 15:15:53 | openstackgerrit | Eric M Gonzalez (tasker) proposed openstack/nova master: unquiesce instance after quiesce failure https://review.openstack.org/550865 | |
| 15:16:32 | mriedem | stephenfin: +2 on the keymap deprecation https://review.openstack.org/#/c/483994/ | |
| 15:16:39 | stephenfin | ta | |
| 15:16:57 | openstackgerrit | Merged openstack/nova master: Refactor WSGI apps and utils to limit imports https://review.openstack.org/533797 | |
| 15:17:10 | openstackgerrit | Merged openstack/nova stable/queens: hyper-v: Logs tips on PortBindingFailed https://review.openstack.org/550529 | |
| 15:17:19 | openstackgerrit | Merged openstack/nova stable/queens: Detach volumes when VM creation fails https://review.openstack.org/544144 | |
| 15:17:29 | openstackgerrit | Merged openstack/nova master: Allow to configure amount of PCIe ports https://review.openstack.org/545034 | |
| 15:19:03 | sean-k-mooney | jaypipes: hi yes if i write a spec for adding rquired traits to resouce providers ill assume it is post rocky. it is something i would not mind trying to add myself if i get the time if for no other reason then to test out the mechanium for solving the problem in a generic way. | |
| 15:22:03 | hrw | mriedem, stephenfin: now that pcie patch got merged into rocky what goes with blueprint? should it get reviewed or something? | |
| 15:22:11 | hrw | https://blueprints.launchpad.net/nova/+spec/configure-amount-of-pcie-ports one I mean | |
| 15:22:36 | mriedem | hrw: marked complete | |
| 15:22:43 | hrw | mriedem: thank you | |
| 15:23:12 | stephenfin | mriedem: While we're on the subject, how about this one? https://blueprints.launchpad.net/openstack/?searchtext=vcpu-weighter | |
| 15:23:37 | mriedem | stephenfin: how is that on the subject? | |
| 15:23:40 | stephenfin | In general, how does one bring up specless blueprints for review? | |
| 15:23:54 | stephenfin | We're talking about specless blueprints | |
| 15:24:11 | mriedem | stephenfin: welcome new contributor https://docs.openstack.org/nova/latest/contributor/blueprints.html | |
| 15:24:29 | hrw | stephenfin: I took mine to Nova meeting. | |
| 15:24:49 | stephenfin | You learn something new everyday | |
| 15:25:20 | hrw | stephenfin: you are just one hour too late | |
| 15:26:51 | mriedem | stephenfin: on https://review.openstack.org/#/c/550250/ i'm going to leave the metadata service stuff in the admin guide where it is for now due to there being nova-net specific stuff in there, | |
| 15:27:12 | mriedem | i'll put a todo or something in there to clean that up for neutron, if/when i can find any neutron-related docs for the metadata service | |
| 15:27:17 | mriedem | i'll address the other comments | |
| 15:28:19 | stephenfin | Sounds good to me | |
| 15:31:22 | openstackgerrit | Jay Pipes proposed openstack/os-traits master: Add HW_NIC_SRIOV_TRUSTED trait https://review.openstack.org/550873 | |
| 15:31:25 | jaypipes | sahid: ^^ | |
| 15:43:27 | openstackgerrit | Merged openstack/nova stable/pike: Handle glance exception during rotating instance backup https://review.openstack.org/533439 | |
| 15:45:31 | cdent | presumably if we are going to move the rp objects ( https://review.openstack.org/#/c/540049/ ) sooner in the cycle is better than later? | |
| 15:46:05 | edleafe | cdent: unless you want a ton of merge conflicts late in the cycle, of course | |
| 15:47:37 | mriedem | thinking about the resource class field, any reason we wouldn't just move that to o.vo instead of a new os-resource-classes library? | |
| 15:48:25 | openstackgerrit | Merged openstack/nova stable/pike: Fix SUSE Install Guide: Placement port https://review.openstack.org/545167 | |
| 15:48:26 | dansmith | I really wish that was split up | |
| 15:49:30 | jaypipes | dansmith: wish what was split up? | |
| 15:50:08 | dansmith | jaypipes: cdent's moving rp objects, reswizzling the fields, splitting them into separate files, etc | |