Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-02-15
23:18:24 mriedem so you end up with 2 ports for the instance that nova created even though you're only using 1
23:18:42 mriedem in the case that you bring a port, nova doesn't unbind it before rescheduling, and that's why we fail to use it on the 2nd host
23:18:52 imacdonn seems plausible ... looks like a one-line change, so I can try to drop it in
23:18:55 mriedem imacdonn: you could try applying that patch and see if it resolves it
23:35:27 imacdonn mriedem: yup, that fixed it - thanks!
23:46:03 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608
23:46:37 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483
23:54:52 cfriesen does anyone know offhand what the rules are for using instance.info_cache.network_info vs calling self.network_api.get_instance_nw_info(context, instance) ?
#openstack-nova - 2018-02-16
00:03:12 tonyb mriedem: any chnace you can take a quick look at: https://review.openstack.org/#/c/543348 ?
00:09:21 openstackgerrit Nicolas Bock proposed openstack/nova stable/pike: Fix SUSE Install Guide: Placement port https://review.openstack.org/545167
00:11:42 melwitt mnaser, mriedem: I'm going through your comments on https://review.openstack.org/#/c/340614/18/nova/compute/api.py@2055 and I'm not seeing what the 'available' volume scenario is ...
00:13:00 melwitt that is, even back in liberty, if the instance failed on the host, _cleanup_volumes in the compute manager would have called volume_api.delete, so maybe that's why the detach would fail in the compute api local delete ... but that doesn't add up with having a volume left in 'available' state
00:13:58 mnaser melwitt: in that case you are right there wouldn’t be any possible scenario where you would end up in an available volume if it failed in compute
00:14:06 melwitt so I'm not really sure what case the new except block is handling
00:14:39 melwitt (I didn't add that part but back when this was going on in liberty, an operator we were working with added that saying they ran into it when they were testing the patch)
00:15:30 melwitt I'm trying to figure out whether to nix it from this patch or if there's some scenario I'm missing where we need to handle it like this
00:16:04 mnaser melwitt: I just got home so I’m on mobile but can you boot from volume with an existing volume that’s also delete on terminate?
00:16:32 mnaser That would be a scenario where you’d want us to delete it, assuming scheduling failed and we want to follow through and delete the volume as requested
00:16:47 mnaser Though that might be super confusing to the user and unexpected
00:20:03 cfriesen mnaser: in that case wouldn't the instance sit around in an ERROR state with the volume still attached?
00:20:26 cfriesen ie the volume should stay attached until the instance is deleted
00:21:34 melwitt mnaser: cfriesen it was that way until very recently https://review.openstack.org/#/c/528385/
00:23:04 mnaser Will the volume ever end up on attached state? I think it would be in attaching because it never reached the compute note to finish the attach
00:27:34 openstackgerrit Merged openstack/nova stable/queens: Refine waiting for vif plug events during _hard_reboot https://review.openstack.org/542738
00:27:40 openstackgerrit Merged openstack/nova stable/queens: Don't JSON encode instance_info.traits for ironic https://review.openstack.org/545037
00:27:48 openstackgerrit Merged openstack/nova stable/queens: Use correct arguments in task inits https://review.openstack.org/544109
00:28:00 openstackgerrit Merged openstack/nova stable/queens: Update UPPER_CONSTRAINTS_FILE for stable/queens https://review.openstack.org/542657
00:28:05 melwitt mnaser: yeah, you're right, in the scenario you're describing, BFV with already existing volume + delete_on_termination, if scheduling fails, the volume would never have been attached
00:28:58 melwitt so it would be available, so detach would fail, so we would want to delete the volume.
00:29:37 melwitt er, detach might just do a no-op if available, but I'm not sure on that
00:31:37 mnaser melwitt: wouldn’t it actually be in “attaching” state because the API layer reserves the volume
00:32:00 melwitt mnaser: oh, yeah good point. it will be whatever the reserve did
00:32:52 mnaser melwitt: yeah so it would have an attachment or reservation depending on flow, same issue we’re trying to resolve here
00:34:06 mnaser melwitt: I do think the extra try except added in this patch is useless if detach is noop
00:34:39 mnaser If detach is noop, nothing will happen. If it fails because the volume doesn’t exist, then we won’t try to delete it anyways
00:34:53 melwitt yeah. that's where I'm at too
00:35:22 mnaser Now put multiattach in that equation lol..
00:35:27 melwitt but at least I think now I understand why it was added long ago, if detach didn't used to do a no-op if not attached
00:36:11 mnaser Yeah it’s a bit of old code
01:51:36 openstackgerrit Merged openstack/nova stable/queens: Cleanup the manage-volumes admin doc https://review.openstack.org/545141
01:51:46 openstackgerrit Merged openstack/nova stable/queens: Add admin guide doc on volume multiattach support https://review.openstack.org/545142
02:29:50 mriedem1 cfriesen: the method on the instance is just a helper method
02:30:02 mriedem melwitt: mnaser: did you sort out the available volume thing?
02:30:51 mriedem tonyb: done
02:32:27 tonyb mriedem: Thanks.
02:34:23 mriedem imacdonn: if you can, leave a comment on the patch that fixed the issue for you to support it's greatness
02:34:53 mriedem imacdonn: nvm i see you already did, thanks
02:35:36 mriedem lyarwood: can you hit the +2ed stable/queens backports in your morning? https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/queens - then we'll cut RC2
02:35:44 mriedem tonyb: or i guess you could do that ^
02:36:25 tonyb mriedem: Oh I can? I didn't think I could between rc1 and release
02:36:39 mriedem smcginnis was able to, so i assume you can
02:36:51 tonyb mriedem: Oh look at that ...
02:41:22 mnaser mriedem: i think so?
02:45:47 tonyb mriedem: done
02:50:42 mriedem tonyb: nice thanks
02:51:32 tonyb mriedem: If you create the tag request with a -W I can update it with the final SHA once they merge ... or we can wait 'til next week
02:54:58 openstackgerrit Merged openstack/osc-placement master: tox.ini settings for global constraints are out of date https://review.openstack.org/543348
02:55:30 mriedem i shall do so
02:56:47 tonyb mriedem: cool
02:59:18 tonyb mriedem, stephenfin, melwitt: I seem to recall that we said for backports of docs only changes we'd only require 1 stable-core to approve. Did I make that up?
03:02:07 mriedem idk
03:02:22 mriedem if it's a docs bug fix then i think that's probably ok
03:02:44 mriedem if it's another stable core that backported it then i'm also ok with fast approve on those
03:06:44 mriedem alright gotta go
04:52:08 openstackgerrit Merged openstack/nova stable/queens: Bindep does not catch missing libpcre3-dev on Ubuntu https://review.openstack.org/544108
04:52:14 openstackgerrit Merged openstack/nova stable/queens: doc: fix the link for the evacuate cli https://review.openstack.org/543507
04:52:21 openstackgerrit Merged openstack/nova stable/queens: Add regression test for BFV+IsolatedHostsFilter failure https://review.openstack.org/543594
05:00:11 openstackgerrit Merged openstack/nova stable/queens: Handle volume-backed instances in IsolatedHostsFilter https://review.openstack.org/543595
05:00:22 openstackgerrit Merged openstack/nova stable/queens: Fix docs for IsolatedHostsFilter https://review.openstack.org/543596
05:15:49 openstackgerrit Merged openstack/nova stable/queens: Make bdms querying in multi-cell use scatter-gather and ignore down cell https://review.openstack.org/543489
05:16:27 openstackgerrit Merged openstack/nova stable/queens: VGPU: Modify the example of vgpu white_list set https://review.openstack.org/542882
06:13:21 openstackgerrit melanie witt proposed openstack/nova master: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/340614
06:13:22 openstackgerrit melanie witt proposed openstack/nova master: Add functional recreate test of deleting a BFV server pre-scheduling https://review.openstack.org/545123
06:13:22 openstackgerrit melanie witt proposed openstack/nova master: Detach volumes when deleting a BFV server pre-scheduling https://review.openstack.org/545132
06:37:36 openstackgerrit melanie witt proposed openstack/nova master: Add periodic task to clean expired console tokens https://review.openstack.org/325381
06:37:36 openstackgerrit melanie witt proposed openstack/nova master: Use ConsoleAuthToken object to generate authorizations https://review.openstack.org/325414
06:37:37 openstackgerrit melanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation https://review.openstack.org/333990
07:43:16 stelucz_ Hello, is there nova client command to delete resource_provider from database? After running nova service-delete <id>, record for compute node still exists in resource_providers table, thus reprovisioning of compute node ends up in message: Another thread already created a resource provider with the UUID 7b01cc27-c101-4c05-aaed-5958ef1270a1. Grabbing that record from the placement API.
07:57:08 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/541561
08:01:51 openstackgerrit Hiroaki Kobayashi proposed openstack/osc-placement master: Use jsonutils of oslo_serialization https://review.openstack.org/545231
08:47:20 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_numa_memnode() https://review.openstack.org/529906
08:47:21 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_XXXpin_cpuset() https://review.openstack.org/527631
08:47:21 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Add NumaTopology support for libvirt/qemu driver https://review.openstack.org/530451
08:47:22 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: disable cpu pinning with libvirt/qemu driver https://review.openstack.org/531049
09:05:21 hrw how to mock nova.conf option in tests?
09:30:38 bauwser good Friday everyone
09:36:37 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: trivial: omit condition evaluations https://review.openstack.org/545248
09:41:17 gmann_ hrw: you can by set_override - https://github.com/openstack/nova/blob/bfae5f28a4c3b39f7978d5f3015c1b32be81215d/nova/tests/functional/api_sample_tests/test_hide_server_addresses.py#L30
09:41:37 hrw gmann_: thx
09:44:09 hrw oslo_config.cfg.NoSuchOptError: no such option num_of_pcie_slots in group [libvirt]
09:44:26 hrw now just have to find where tests fake whole nova.conf ;d
10:07:29 openstackgerrit Marcin Juszkiewicz proposed openstack/nova master: Allow to configure amount of PCIe ports in aarch64 instance https://review.openstack.org/545034
10:08:41 hrw this one adds test and new config option
10:11:01 stelucz_ Hello, is there nova client command to delete resource_provider from database? After running nova service-delete <id>, record for compute node still exists in resource_providers table, thus reprovisioning of compute node ends up in message: Another thread already created a resource provider with the UUID 7b01cc27-c101-4c05-aaed-5958ef1270a1. Grabbing that record from the placement API.
11:15:17 openstackgerrit Merged openstack/nova master: api-ref: provide more detail on what a provider aggregate is https://review.openstack.org/539033
11:45:08 openstackgerrit Marcin Juszkiewicz proposed openstack/nova master: Allow to configure amount of PCIe ports in aarch64 instance https://review.openstack.org/545034
11:48:41 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Move __init__ function https://review.openstack.org/538223
11:48:41 openstackgerrit Stephen Finucane proposed openstack/nova master: tox: Add mypy target https://review.openstack.org/538221
11:48:42 openstackgerrit Stephen Finucane proposed openstack/nova master: tox: Store list of converted files https://review.openstack.org/538222
11:48:42 openstackgerrit Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.openstack.org/538224

Earlier   Later