Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-02-01
09:48:11 bauzas I know that asking 0 vCPUs is crazy
09:48:18 bauzas like asking for 0 GB of RAM
09:48:30 bauzas but asking for a diskless instance can be understandable
09:48:56 maciejjozefczyk bauzas: you're right, I agree
09:49:10 bauzas tbh, if I was you, I'd decouple the normalization thing from the minimum ratio modification
09:49:13 Roamer` lyarwood, I actually restarted the job as soon as it managed to fail, it has been running some Tempest tests, it should be done in less than an hour now, then we'll know; the failing test is almost the last one to run :/
09:49:28 maciejjozefczyk bauzas: eg. this host is for only 'volume' vms
09:50:03 Roamer` lyarwood, and yeah, I did some internal clean-up of the Jenkins job to make it fail much earlier if it fails to cherry-pick the changes (and review.o.o has been a bit flaky yesterday and today, at least from that Hetzner-based host)
09:50:05 bauzas maciejjozefczyk: well, I was thinking more about the long-standing issue we have with calculating disk spaces, in particular for BFV instances
09:50:40 bauzas sometimes, you hack like how you can
09:51:06 bauzas once we have the full monty with shared resource providers, that problem will be solved
09:51:13 bauzas but that's like 4 cycles we're working on that
09:54:10 maciejjozefczyk ok, to summarize about that change: do backport compatibility in obj_make_compatible() like we discussed, remove minimum from config files, then we gonna think twice about it, agree?
09:54:18 openstackgerrit Claudiu Belu proposed openstack/nova master: tests: refactors and cleans up test_rbd.py https://review.openstack.org/538022
09:54:18 openstackgerrit Claudiu Belu proposed openstack/nova master: tests: fixes mock autospec usage https://review.openstack.org/447505
09:54:19 openstackgerrit Claudiu Belu proposed openstack/nova master: tests: autospecs all the mock.patch usages https://review.openstack.org/470775
09:54:19 openstackgerrit Claudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated https://review.openstack.org/342211
09:54:58 kashyap mriedem: We should just rewrite it: saying that "libvirt supports enumerating the information about the supported types for a given device via `virsh nodedev-dumpxml` (or the equivalent API)"
09:56:35 bauzas maciejjozefczyk: I'd say just touch the default value in the conf opt, that's it
09:56:40 bauzas leave as it what is is now
09:56:46 bauzas (speaking of the min)
09:57:08 bauzas maciejjozefczyk: for the obj_make_compatible() hack, I think you need to check the object versions
09:57:15 bauzas and see if you need a new one
09:57:28 bauzas which could be tricky if that's only for signaling
09:57:39 openstackgerrit Ameed Ashour proposed openstack/nova stable/ocata: add "--until-complete" option for nova-manage db archive_deleted_rows. https://review.openstack.org/539878
09:58:40 bauzas maciejjozefczyk: hah, you're doomed
09:59:00 maciejjozefczyk bauzas: :)
09:59:00 bauzas ComputeNode version 1.17 (adding the mapped field) was merged in Pike
09:59:11 bauzas https://github.com/openstack/nova/commit/0ce4dff4
09:59:27 bauzas so you can't rely on it for checking the release version
10:01:06 maciejjozefczyk bauzas: damn..., anyway going to meeting
10:02:42 bauzas maciejjozefczyk: let's punt that discussion until this afternoon
10:02:55 bauzas I need to do other things and other people could double-check my idea
10:02:57 openstackgerrit Merged openstack/nova master: trivial: Fix typos in release notes https://review.openstack.org/539490
10:04:56 openstackgerrit Ameed Ashour proposed openstack/nova stable/pike: add "--until-complete" option for nova-manage db archive_deleted_rows. https://review.openstack.org/539880
10:15:01 Roamer` lyarwood, melwitt, mriedem's quick fix did help - our CI successfully ran on an os-brick change: http://logs.ci-openstack.storpool.com/73/539773/1/check/dsvm-tempest-storpool/0ca4a8e/console.html Once it's done a couple more runs, I'll drop a note in the bug and on the change itself. Thanks a lot for the analysis and the quick fix, and sorry I had to go to bed and couldn't run it last night!
10:15:44 openstackgerrit Merged openstack/os-traits master: Update Usage information https://review.openstack.org/539761
10:33:46 lyarwood Roamer`: cool, np, did you manually pull the change in somewhere?
10:35:53 Roamer` lyarwood, actually yes, I should've mentioned last night that our CI system is kind of used to cherry-picking unmerged patches from Gerrit when it needs to
10:36:37 Roamer` lyarwood, sorry I put it a bit too obscurely: yes, the Jenkins job cherry-picks a manually supplied list of patches before running devstack
10:36:45 lyarwood Roamer`: kk np, can you post an example passing run in the nova fix?
10:37:31 Roamer` lyarwood, yes, I will, I just wonder whether it wouldn't be better to give it one more chance, wait for an hour or so for another run... although maybe not, I guess the fix ix good enough for us at least, so I'll do it right now
10:38:44 lyarwood Roamer`: yeah I don't mind waiting, a direct link to a passing run or a generic link showing multiple job results would be good either way to prove that this is working :)
10:39:40 maciejjozefczyk bauzas: ok
10:40:06 bauzas maciejjozefczyk: I need to go but see my last comment
10:40:14 bauzas maciejjozefczyk: maybe all of this is unnecessary
10:40:29 bauzas just change the default and keep the backwards-compat code
10:40:31 maciejjozefczyk bauzas: jest checking
10:40:39 bauzas with the 0.0 thing
10:40:52 maciejjozefczyk bauzas: okey
10:40:58 bauzas so later in Rocky, we can just kill the whole thing
10:41:08 bauzas bbiab
10:41:25 maciejjozefczyk bauzas: yes, that could be easier to do in next release
10:44:07 tetsuro stephen: are you around?
10:45:43 tetsuro stephen: sorry, nothing.
10:46:10 stephenfin tetsuro: Looking for me?
10:47:25 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM: Test LM with encrypted volumes https://review.openstack.org/536350
10:48:45 openstackgerrit Lee Yarwood proposed openstack/nova master: Enable test_volume_backed_live_migration in tempest https://review.openstack.org/528104
10:53:17 tetsuro if emulator_threads_isolated: if object_numa_cell.cpuset_reserved: emupcpus.extend(object_numa_cell.cpuset_reserved) does work.
10:53:33 tetsuro if emulator_threads_isolated and object_numa_cell.cpuset_reserved: emupcpus.extend(object_numa_cell.cpuset_reserved) doesn’t work.
10:54:13 tetsuro stephen: This is okay, but I don’t understand why… python 101?
10:59:46 hrw how to run one test from all nova tests?
11:00:17 stephenfin tetsuro: That's how oslo.versionedobjects work, unfortunately. If you don't set an attribute to _something_, then it's totally unset
11:00:32 Spaz-Work hrw: tox -e py27 -- nova.tests.unit.path.to.module.then.func
11:00:39 hrw thanks Spaz-Work
11:00:54 stephenfin tetsuro: 'if emulator_threads_isolated and 'cpuset_reserved' in object_numa_cell and object_numa_cell.cpuset_reserved' would work
11:01:13 stephenfin but that's getting a little ridiculous :) Hmm, lemme have another look at that
11:01:28 hrw "tox -e py27 -- nova.tests.unit.virt.libvirt.test_get_guest_config_aarch64" then d:
11:01:46 Spaz-Work That's correct. Remember to include Classes
11:03:40 stephenfin Yeah, you need to include the class, so 'tox -e py27 nova.tests.unit.virt.libvirt.LibvirtConnTestCase.test_get_guest_config_aarch64'
11:04:07 stephenfin pytest lets you use filenames. Not testr, unfortunately
11:04:26 hrw nova.tests.unit.virt.libvirt.test_driver.LibvirtConnTestCase.test_get_guest_config_aarch64
11:04:38 stephenfin Whoops, yeah :)
11:04:46 hrw now it fails but atleast in proper test ;D
11:07:36 hrw passed. but I do not like the code :D
11:07:56 hrw test_get_guest_config*ppc* tests are not good ones to learn from
11:08:25 tetsuro stephenfin: Okay thanks… and I think we can just assume 'cpuset_reserved' is in object_numa_cell when users specify emulator_threads_isolated and tha code path reaches here?
11:09:17 stephenfin tetsuro: You mean we can assume that _if_ we use your patch, right?
11:09:37 stephenfin Because at the moment, we're assuming that it's present even if it's not guaranteed to be
11:09:46 stephenfin e.g. in the multiple instance NUMA cell case
11:17:05 openstackgerrit Marcin Juszkiewicz proposed openstack/nova master: Make sure that we have USB Host controller for USB tablet https://review.openstack.org/538003
11:17:33 hrw stephenfin, mriedem, sahid: can you review ^^? test code is included
11:18:20 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Add 'move-nova-cmds-to-cliff' spec https://review.openstack.org/433603
11:18:43 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: trivial: Resolve Python 3 issues https://review.openstack.org/539907
11:24:00 hrw I think that this version is as simple as it can be
11:26:11 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: add check before adding cpus to cpuset_reserved https://review.openstack.org/539865
11:28:03 tetsuro stephenfun: Hm? getting lost… Anyway I’ve updated the patch. Let’s talk here^
11:30:49 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: add check before adding cpus to cpuset_reserved https://review.openstack.org/539865
11:31:59 tetsuro Today, I’m going home… good night.
11:32:12 stephenfin o/
11:33:46 openstackgerrit Hironori Shiina proposed openstack/nova master: virt/ironic: Implement rescue and unrescue https://review.openstack.org/416487
11:38:44 openstackgerrit Marcin Juszkiewicz proposed openstack/nova master: Make sure that we have USB Host controller for USB tablet https://review.openstack.org/538003
11:46:54 openstackgerrit Claudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated https://review.openstack.org/342211
11:56:35 yikun https://review.openstack.org/#/c/522161/
11:56:39 yikun ^ Creating a VM with a non-ASCII name(such as chinese name) results in an error.
11:56:44 yikun This patch is are submited by @jiangpf, but it seems stuck beacuse the testcase problem.
11:56:48 yikun I try to complete it by mocking a emulate method, but I'm not sure this way is okay or not
11:57:04 yikun so, if anyone have time, could take a look on it.
11:58:46 stephenfin yikun: Sure, I'll take a look after lunch
11:59:17 yikun stephenfin, thanks :)

Earlier   Later