| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-02-01 | |||
| 10:40:29 | bauzas | just change the default and keep the backwards-compat code | |
| 10:40:31 | maciejjozefczyk | bauzas: jest checking | |
| 10:40:39 | bauzas | with the 0.0 thing | |
| 10:40:52 | maciejjozefczyk | bauzas: okey | |
| 10:40:58 | bauzas | so later in Rocky, we can just kill the whole thing | |
| 10:41:08 | bauzas | bbiab | |
| 10:41:25 | maciejjozefczyk | bauzas: yes, that could be easier to do in next release | |
| 10:44:07 | tetsuro | stephen: are you around? | |
| 10:45:43 | tetsuro | stephen: sorry, nothing. | |
| 10:46:10 | stephenfin | tetsuro: Looking for me? | |
| 10:47:25 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM: Test LM with encrypted volumes https://review.openstack.org/536350 | |
| 10:48:45 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Enable test_volume_backed_live_migration in tempest https://review.openstack.org/528104 | |
| 10:53:17 | tetsuro | if emulator_threads_isolated: if object_numa_cell.cpuset_reserved: emupcpus.extend(object_numa_cell.cpuset_reserved) does work. | |
| 10:53:33 | tetsuro | if emulator_threads_isolated and object_numa_cell.cpuset_reserved: emupcpus.extend(object_numa_cell.cpuset_reserved) doesn’t work. | |
| 10:54:13 | tetsuro | stephen: This is okay, but I don’t understand why… python 101? | |
| 10:59:46 | hrw | how to run one test from all nova tests? | |
| 11:00:17 | stephenfin | tetsuro: That's how oslo.versionedobjects work, unfortunately. If you don't set an attribute to _something_, then it's totally unset | |
| 11:00:32 | Spaz-Work | hrw: tox -e py27 -- nova.tests.unit.path.to.module.then.func | |
| 11:00:39 | hrw | thanks Spaz-Work | |
| 11:00:54 | stephenfin | tetsuro: 'if emulator_threads_isolated and 'cpuset_reserved' in object_numa_cell and object_numa_cell.cpuset_reserved' would work | |
| 11:01:13 | stephenfin | but that's getting a little ridiculous :) Hmm, lemme have another look at that | |
| 11:01:28 | hrw | "tox -e py27 -- nova.tests.unit.virt.libvirt.test_get_guest_config_aarch64" then d: | |
| 11:01:46 | Spaz-Work | That's correct. Remember to include Classes | |
| 11:03:40 | stephenfin | Yeah, you need to include the class, so 'tox -e py27 nova.tests.unit.virt.libvirt.LibvirtConnTestCase.test_get_guest_config_aarch64' | |
| 11:04:07 | stephenfin | pytest lets you use filenames. Not testr, unfortunately | |
| 11:04:26 | hrw | nova.tests.unit.virt.libvirt.test_driver.LibvirtConnTestCase.test_get_guest_config_aarch64 | |
| 11:04:38 | stephenfin | Whoops, yeah :) | |
| 11:04:46 | hrw | now it fails but atleast in proper test ;D | |
| 11:07:36 | hrw | passed. but I do not like the code :D | |
| 11:07:56 | hrw | test_get_guest_config*ppc* tests are not good ones to learn from | |
| 11:08:25 | tetsuro | stephenfin: Okay thanks… and I think we can just assume 'cpuset_reserved' is in object_numa_cell when users specify emulator_threads_isolated and tha code path reaches here? | |
| 11:09:17 | stephenfin | tetsuro: You mean we can assume that _if_ we use your patch, right? | |
| 11:09:37 | stephenfin | Because at the moment, we're assuming that it's present even if it's not guaranteed to be | |
| 11:09:46 | stephenfin | e.g. in the multiple instance NUMA cell case | |
| 11:17:05 | openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: Make sure that we have USB Host controller for USB tablet https://review.openstack.org/538003 | |
| 11:17:33 | hrw | stephenfin, mriedem, sahid: can you review ^^? test code is included | |
| 11:18:20 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Add 'move-nova-cmds-to-cliff' spec https://review.openstack.org/433603 | |
| 11:18:43 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: trivial: Resolve Python 3 issues https://review.openstack.org/539907 | |
| 11:24:00 | hrw | I think that this version is as simple as it can be | |
| 11:26:11 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: add check before adding cpus to cpuset_reserved https://review.openstack.org/539865 | |
| 11:28:03 | tetsuro | stephenfun: Hm? getting lost… Anyway I’ve updated the patch. Let’s talk here^ | |
| 11:30:49 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: add check before adding cpus to cpuset_reserved https://review.openstack.org/539865 | |
| 11:31:59 | tetsuro | Today, I’m going home… good night. | |
| 11:32:12 | stephenfin | o/ | |
| 11:33:46 | openstackgerrit | Hironori Shiina proposed openstack/nova master: virt/ironic: Implement rescue and unrescue https://review.openstack.org/416487 | |
| 11:38:44 | openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: Make sure that we have USB Host controller for USB tablet https://review.openstack.org/538003 | |
| 11:46:54 | openstackgerrit | Claudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated https://review.openstack.org/342211 | |
| 11:56:35 | yikun | https://review.openstack.org/#/c/522161/ | |
| 11:56:39 | yikun | ^ Creating a VM with a non-ASCII name(such as chinese name) results in an error. | |
| 11:56:44 | yikun | This patch is are submited by @jiangpf, but it seems stuck beacuse the testcase problem. | |
| 11:56:48 | yikun | I try to complete it by mocking a emulate method, but I'm not sure this way is okay or not | |
| 11:57:04 | yikun | so, if anyone have time, could take a look on it. | |
| 11:58:46 | stephenfin | yikun: Sure, I'll take a look after lunch | |
| 11:59:17 | yikun | stephenfin, thanks :) | |
| 12:27:54 | ameeda | please check this out https://review.openstack.org/#/c/526900/ . please notice the last comment | |
| 12:48:40 | openstackgerrit | Claudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated https://review.openstack.org/342211 | |
| 13:46:05 | bhujay | hi all with suse compute node can we use rbd as backend ? although pike release doc says no , i was checking the ceph-ansible upsteram has some commits related to suse . Hence asking this | |
| 13:46:07 | hrw | you know what is worst in code reviews? | |
| 13:46:54 | hrw | all those moments when you adapt code to everyone's comments to get good acceptable version and then someone arrive and asks for another changes ;d | |
| 13:47:39 | bhujay | sorry , asked in wrong channel | |
| 13:48:01 | bauzas | hrw: is that a problem ? I don't think so | |
| 13:48:12 | bauzas | code reviews FTW | |
| 13:48:27 | hrw | bauzas: it is not. just amusing sometimes | |
| 13:49:17 | Spaz-Work | It's definately humbling.. that's the word i'd choose | |
| 13:49:43 | hrw | stephenfin: replied to your comments | |
| 13:50:09 | hrw | Spaz-Work: I would not | |
| 13:53:29 | efried | edleafe: yt? | |
| 13:59:26 | mriedem | melwitt: i guess https://review.openstack.org/#/c/539739/ fixes the storpool encrypted luks issue | |
| 13:59:39 | lyarwood | https://review.openstack.org/#/c/538103/ - any cores able to review this, logging required to move https://bugs.launchpad.net/neutron/+bug/1744361 forward | |
| 13:59:40 | openstack | Launchpad bug 1744361 in neutron "test_server_security_groups failed to reboot with "Domain not found: no domain with matching uuid" because of missing vif event from linuxbridge agent" [Undecided,Confirmed] | |
| 13:59:57 | lyarwood | mriedem: morning, yeah appears it does, thanks again :) | |
| 14:00:12 | gibi | lyarwood: looking | |
| 14:00:44 | hrw | mriedem: good morning | |
| 14:02:03 | openstackgerrit | Elod Illes proposed openstack/nova master: Functional test: evacuate with no compute https://review.openstack.org/498482 | |
| 14:02:15 | ameeda | can you please check this out https://review.openstack.org/#/c/526900/ . please notice the last comment | |
| 14:03:10 | hrw | mriedem: 7th version of https://review.openstack.org/#/c/538003/ is closer to perfection than yesterday ones were. please take a look once you have time | |
| 14:03:33 | edleafe | efried: ?? | |
| 14:04:16 | efried | edleafe: Was wondering if you would be willing to jump on a short call this afternoon to give an overview of the alt hosts feature. | |
| 14:04:18 | Roamer` | mriedem, good morning, and thanks and sorry again for bailing out last night three minutes before you got the patch ready | |
| 14:05:03 | edleafe | efried: depends on the time. Meetings and such, y'know | |
| 14:05:12 | cdent | edleafe, efried: would something written be better (or at least a written summary of the call) so that other people can benefit? | |
| 14:05:36 | edleafe | cdent: sure. | |
| 14:05:48 | edleafe | Anything in particular to cover? | |
| 14:05:57 | edleafe | Or just a general overview | |
| 14:06:02 | ameeda | mriedem: good morning :) what do you think about this bug https://bugs.launchpad.net/nova/+bug/1489304 ? | |
| 14:06:03 | openstack | Launchpad bug 1489304 in OpenStack Compute (nova) "Lack of volume status checks when detaching volume in rebuild." [Medium,Confirmed] | |
| 14:06:49 | efried | edleafe: Product building on nova, wants to assess the impact of the feature, if/how it can use it, etc. | |
| 14:09:52 | edleafe | efried: cdent: OK, maybe a blog post on a general overview of alt hosts would be in order | |
| 14:10:16 | efried | Sounds good to me. | |
| 14:22:30 | mriedem | stephenfin: i'm not sure it's good to update release notes for ones that have already been tagged https://review.openstack.org/#/c/539490/ | |
| 14:22:59 | stephenfin | mriedem: I built it locally and it displayed as expected | |
| 14:23:06 | stephenfin | i.e. no "new" release notes | |
| 14:23:09 | mriedem | ok, those used to get duplicated | |
| 14:23:21 | stephenfin | Yeah, I think it's branches that still cause issues | |
| 14:23:27 | stephenfin | although even that may be fixed now | |
| 14:29:56 | bauzas | mriedem: AFAIR, you can do that -ie. relnotes that have been tagged for a milestone | |
| 14:30:26 | bauzas | you can even modify an existing relnote from a stable branch, which was something not working for Newton :p | |
| 14:30:40 | bauzas | (if you remember the prelude issue we had) | |
| 14:35:21 | edleafe | gibi: Responded to your comments on https://review.openstack.org/#/c/539254/ | |
| 14:37:22 | bauzas | artom: mriedem_afk: oh man, just noticed a long chat on https://review.openstack.org/#/c/539266 | |