| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-30 | |||
| 14:07:20 | Spazmotic | exciting, I love your logic.. wanna go steady? :p | |
| 14:07:52 | gibi | ameeda: gate is broken | |
| 14:08:07 | gibi | ameeda: infra is working on it | |
| 14:08:39 | Spazmotic | Is there an infra channel btw? | |
| 14:10:20 | gibi | Spazmotic: #openstack-infra | |
| 14:10:26 | Spazmotic | Thank ya sir | |
| 14:11:39 | ameeda | gibi: thank you ! | |
| 14:11:59 | ameeda | gibi: can you please review this for me ? https://review.openstack.org/#/c/528385/ | |
| 14:19:01 | Kvisle | is it normal for nova-compute to use the public endpoint of the placement api, and not the internal one? | |
| 14:24:17 | openstackgerrit | Radoslav Gerganov proposed openstack/nova master: ProviderTree.new_child: parent is either uuid or name https://review.openstack.org/538264 | |
| 14:25:23 | cdent | Kvisle: that's the default (for historical reasons) but you can configure it. | |
| 14:27:20 | cdent | Kvisle: os_interface is the old way, valid_interfaces is the new way | |
| 14:27:53 | bauzas | Spazmotic: also, I haven't commented on that, but you know that with Python you can't recursively call more than 30 times the same method by default, right ? | |
| 14:28:20 | ameeda | mriedem: please check my comment here https://review.openstack.org/#/c/528385/10 | |
| 14:29:47 | Kvisle | cdent: thanks (starting queens I see) | |
| 14:29:55 | ameeda | mriedem: if you have questions please let me know | |
| 14:32:46 | bauzas | Spazmotic: oops, my bad, by default, it's 999 times | |
| 14:33:27 | bauzas | Spazmotic: http://paste.openstack.org/show/658017/ | |
| 14:37:34 | efried | Kvisle: Yes; the old way is deprecated but will still work in Q. | |
| 14:41:18 | openstackgerrit | Ruby Loo proposed openstack/os-traits master: Add code hosting URL https://review.openstack.org/539224 | |
| 14:48:27 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform live_migration_post_dest notification https://review.openstack.org/469784 | |
| 14:50:15 | mriedem | ameeda: replied | |
| 14:53:23 | efried | jaypipes: Looks like I've got a unit test tweak to make, but otherwise the update_provider_tree series is now done and ready for review. | |
| 14:53:51 | efried | jaypipes: Realizing of course that it waits for Rocky; but we could land it early if it's already had a looksee. | |
| 14:55:00 | rgerganov | efried, which part of the series is for Rocky? | |
| 14:55:22 | efried | rgerganov: Well, that depends whether the six currently-approved patches ever make it through the gate. | |
| 14:56:01 | efried | https://review.openstack.org/#/c/533808/ is the current bottom of the whole series; it and the next five are approved and just waiting for zuul to stop being a dick. | |
| 14:56:46 | efried | Then starting with https://review.openstack.org/#/c/537648/ is what we would land early in Rocky. | |
| 14:57:10 | efried | rgerganov: Notably the piece that ties everything together and makes it so update_provider_tree is actually used. | |
| 14:57:27 | rgerganov | efried, so there is no chance to use this stuff in queens | |
| 14:57:27 | efried | Which is this one: https://review.openstack.org/#/c/520246/ | |
| 14:57:39 | mriedem | we won't be merging anything probably until https://review.openstack.org/#/c/537933/ can merge | |
| 14:57:48 | efried | rgerganov: No. Not sure there was a chance of that anyway, considering we're past FF. | |
| 14:57:59 | bauzas | hold your breath, starting to look at the 47 new bugs | |
| 14:58:15 | bauzas | since the gate is super late, I won't review changes unless it's prioritary | |
| 14:58:18 | mriedem | bauzas: did you put up a patch for the vgpu feature support matrix change? | |
| 14:58:23 | bauzas | mriedem: not yet | |
| 14:58:33 | bauzas | mriedem: I can do it super quickly | |
| 14:58:45 | bauzas | but I was distracted by the infra issues | |
| 14:59:01 | bauzas | mriedem: I guess you're also planning to write a prelude ? | |
| 14:59:07 | mriedem | yes | |
| 14:59:20 | bauzas | cool | |
| 14:59:32 | mriedem | probably not this week | |
| 14:59:40 | bauzas | since I wasn't really present during Queens, the floor is yours | |
| 14:59:48 | mriedem | how gracious of you :) | |
| 14:59:58 | bauzas | I'm French | |
| 15:00:07 | bauzas | all French people are gracious and kind | |
| 15:00:13 | mriedem | ha | |
| 15:00:39 | ameeda | mriedem: replied | |
| 15:01:19 | ameeda | bauzas: you're right :) | |
| 15:02:28 | bauzas | I wish I would :) | |
| 15:06:20 | Spaz-Work | ugh I wish I saw this solution | |
| 15:06:25 | Spaz-Work | it's so much more elegant | |
| 15:06:56 | Spaz-Work | bauzas: can you clarity what the "unnecessary" comment was for? | |
| 15:09:28 | bauzas | Spaz-Work: you mean about the recursion limit ? | |
| 15:09:59 | bauzas | Spaz-Work: I was confused, I thought it was 30 times, so I was a bit concerned to see us looping over more than 30 devices | |
| 15:10:29 | jaypipes | efried: ack | |
| 15:10:37 | bauzas | but since it's 999 times by default, I think it's harmless unless the instance has crazy 999 volumes attached to it | |
| 15:12:55 | Spaz-Work | Ah I see.. I don't want to rewrite the method entirely too much and blow the scope of this commit.. but there's so man ythings in this driver that need attention paid to them | |
| 15:13:10 | Spaz-Work | like the Assert migrate only being called with block migrations in LM.. bleh.. another day another problem heh | |
| 15:13:17 | Spaz-Work | Thanks sir, i'll keep working.. am happy with your notes.. much sexy | |
| 15:18:24 | mriedem | gibi: looks like gordc needs a link to your versioned notification transformation burndown chart in the ML | |
| 15:18:36 | mriedem | found it http://burndown.peermore.com/nova-notification/ | |
| 15:23:30 | gibi | mriedem: thanks for distributing it :) | |
| 15:24:03 | mriedem | gibi: thanks for adding the versioned notification transformation stuff here https://wiki.openstack.org/wiki/GSoC2018#Internship_ideas - i was just about to do that :) | |
| 15:24:24 | gibi | mriedem: yeah, I was approached | |
| 15:24:31 | Spaz-Work | Regarding another commit, if i'm going to do a version check against something with microversions.. would openstack stnadards rather me import oslo.utils.versionutils or jenk the versions into a tuple to compare | |
| 15:24:46 | Spaz-Work | Prevent overhead or look better i guess i the option | |
| 15:25:00 | gibi | mriedem: Would like to sign up as a co-mentor? | |
| 15:25:24 | mriedem | Spaz-Work: nova.compute.api.openstack.api_version_request | |
| 15:25:34 | mriedem | Spaz-Work: assuming it's something you're checking within the api code | |
| 15:25:47 | mriedem | *nova.api.openstack.api_version_request | |
| 15:25:49 | Spaz-Work | Ah awesome, thanks sir i'll pull that | |
| 15:26:03 | mriedem | gibi: nope :) i was also approached and that's why i was going to add the entry and then call for a mentor | |
| 15:26:33 | gibi | mriedem: sorry for steeling your idea :) | |
| 15:27:03 | mriedem | i could add 'remove all the mox from tests since it's going to be a community goal for rocky' but i wouldn't wish that on an intern | |
| 15:28:50 | gibi | mriedem: yeah, especially the test_neturonv2 side of it | |
| 15:31:43 | openstackgerrit | Merged openstack/os-traits master: Add code hosting URL https://review.openstack.org/539224 | |
| 15:36:41 | cfriesen | there's a novaclient patch up at https://review.openstack.org/#/c/520187/ that's sitting with a single +2 if any core feels like taking a look. Basically adding strict hostname matching. | |
| 15:38:00 | cfriesen | mriedem: thanks, I'll pester the author. | |
| 15:41:14 | bkero- | mdbooth: ping, is your nova-compute-maintenance.py script maintained anywhere, or is it just a gist? | |
| 15:42:58 | mriedem | dansmith: alex's patch to handle the old/new style allocation candidates in the scheduler report client merged, did you want to rebase https://review.openstack.org/#/c/531517/ ? | |
| 15:43:19 | dansmith | mriedem: I don't want to, no, but .. I will | |
| 15:44:26 | mdbooth | bkero-: It's not maintained. What's the interest in it? | |
| 15:46:51 | bkero- | mdbooth: using it to evacuate compute hosts for maintenance :) | |
| 15:47:06 | mdbooth | bkero-: Heh, that's what it's for :) | |
| 15:47:08 | bkero- | since host-evacuate-live leaves a bit to be desired | |
| 15:47:23 | bkero- | mdbooth: I've had to fix a few things, like add 'all_tenants' and make the auth work | |
| 15:47:27 | mdbooth | I was wondering if you wanted to incorporate it into another tool. | |
| 15:47:48 | bkero- | I'm incorporating it into ansible playbooks to do rolling maintenance | |
| 15:49:00 | bkero- | I think so too. Maybe that is too many batteries included though. | |
| 15:49:06 | mdbooth | It's much better than host-evacuate-live, for eg | |
| 15:49:18 | bkero- | I'm basically evacuating a host, doing maintenance (hint: kernel upgrade), then moving onto next host | |
| 15:50:28 | bkero- | I started writing my own tool for this, then found your tool and it saved me a bunch of time. | |
| 15:50:37 | mriedem | efried: the consistent ksa endpoint stuff might be worth a cross-project goal at some point | |
| 15:50:59 | mriedem | standard config for services to talk to each other | |
| 15:51:08 | mriedem | seems more valuable to me than removing mox | |
| 15:51:16 | efried | mriedem: I agree. I think mordred might have been gonna push that. | |
| 15:51:27 | mriedem | he pushed standard paging links | |
| 15:51:43 | mordred | what'd I do? | |