Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-01-30
14:59:20 bauzas cool
14:59:32 mriedem probably not this week
14:59:40 bauzas since I wasn't really present during Queens, the floor is yours
14:59:48 mriedem how gracious of you :)
14:59:58 bauzas I'm French
15:00:07 bauzas all French people are gracious and kind
15:00:13 mriedem ha
15:00:39 ameeda mriedem: replied
15:01:19 ameeda bauzas: you're right :)
15:02:28 bauzas I wish I would :)
15:06:20 Spaz-Work ugh I wish I saw this solution
15:06:25 Spaz-Work it's so much more elegant
15:06:56 Spaz-Work bauzas: can you clarity what the "unnecessary" comment was for?
15:09:28 bauzas Spaz-Work: you mean about the recursion limit ?
15:09:59 bauzas Spaz-Work: I was confused, I thought it was 30 times, so I was a bit concerned to see us looping over more than 30 devices
15:10:29 jaypipes efried: ack
15:10:37 bauzas but since it's 999 times by default, I think it's harmless unless the instance has crazy 999 volumes attached to it
15:12:55 Spaz-Work Ah I see.. I don't want to rewrite the method entirely too much and blow the scope of this commit.. but there's so man ythings in this driver that need attention paid to them
15:13:10 Spaz-Work like the Assert migrate only being called with block migrations in LM.. bleh.. another day another problem heh
15:13:17 Spaz-Work Thanks sir, i'll keep working.. am happy with your notes.. much sexy
15:18:24 mriedem gibi: looks like gordc needs a link to your versioned notification transformation burndown chart in the ML
15:18:36 mriedem found it http://burndown.peermore.com/nova-notification/
15:23:30 gibi mriedem: thanks for distributing it :)
15:24:03 mriedem gibi: thanks for adding the versioned notification transformation stuff here https://wiki.openstack.org/wiki/GSoC2018#Internship_ideas - i was just about to do that :)
15:24:24 gibi mriedem: yeah, I was approached
15:24:31 Spaz-Work Regarding another commit, if i'm going to do a version check against something with microversions.. would openstack stnadards rather me import oslo.utils.versionutils or jenk the versions into a tuple to compare
15:24:46 Spaz-Work Prevent overhead or look better i guess i the option
15:25:00 gibi mriedem: Would like to sign up as a co-mentor?
15:25:24 mriedem Spaz-Work: nova.compute.api.openstack.api_version_request
15:25:34 mriedem Spaz-Work: assuming it's something you're checking within the api code
15:25:47 mriedem *nova.api.openstack.api_version_request
15:25:49 Spaz-Work Ah awesome, thanks sir i'll pull that
15:26:03 mriedem gibi: nope :) i was also approached and that's why i was going to add the entry and then call for a mentor
15:26:33 gibi mriedem: sorry for steeling your idea :)
15:27:03 mriedem i could add 'remove all the mox from tests since it's going to be a community goal for rocky' but i wouldn't wish that on an intern
15:28:50 gibi mriedem: yeah, especially the test_neturonv2 side of it
15:31:43 openstackgerrit Merged openstack/os-traits master: Add code hosting URL https://review.openstack.org/539224
15:36:41 cfriesen there's a novaclient patch up at https://review.openstack.org/#/c/520187/ that's sitting with a single +2 if any core feels like taking a look. Basically adding strict hostname matching.
15:38:00 cfriesen mriedem: thanks, I'll pester the author.
15:41:14 bkero- mdbooth: ping, is your nova-compute-maintenance.py script maintained anywhere, or is it just a gist?
15:42:58 mriedem dansmith: alex's patch to handle the old/new style allocation candidates in the scheduler report client merged, did you want to rebase https://review.openstack.org/#/c/531517/ ?
15:43:19 dansmith mriedem: I don't want to, no, but .. I will
15:44:26 mdbooth bkero-: It's not maintained. What's the interest in it?
15:46:51 bkero- mdbooth: using it to evacuate compute hosts for maintenance :)
15:47:06 mdbooth bkero-: Heh, that's what it's for :)
15:47:08 bkero- since host-evacuate-live leaves a bit to be desired
15:47:23 bkero- mdbooth: I've had to fix a few things, like add 'all_tenants' and make the auth work
15:47:27 mdbooth I was wondering if you wanted to incorporate it into another tool.
15:47:48 bkero- I'm incorporating it into ansible playbooks to do rolling maintenance
15:49:00 bkero- I think so too. Maybe that is too many batteries included though.
15:49:06 mdbooth It's much better than host-evacuate-live, for eg
15:49:18 bkero- I'm basically evacuating a host, doing maintenance (hint: kernel upgrade), then moving onto next host
15:50:28 bkero- I started writing my own tool for this, then found your tool and it saved me a bunch of time.
15:50:37 mriedem efried: the consistent ksa endpoint stuff might be worth a cross-project goal at some point
15:50:59 mriedem standard config for services to talk to each other
15:51:08 mriedem seems more valuable to me than removing mox
15:51:16 efried mriedem: I agree. I think mordred might have been gonna push that.
15:51:27 mriedem he pushed standard paging links
15:51:43 mordred what'd I do?
15:51:55 efried TBH, I wouldn't be likely to have the bandwidth to push a cross-project goal like that.
15:52:11 mordred efried: bah. you have unlimited bandwidth
15:52:17 mriedem mordred: i told efried that https://specs.openstack.org/openstack/nova-specs/specs/queens/approved/use-ksa-adapter-for-endpoints.html would be a good cross-project goal
15:52:29 mriedem consistent config for inter-service communication
15:52:47 mordred mriedem: yes - I agree
15:53:00 mriedem nova's done it for all but cinder config, so there are examples, and it's tested in the gate
15:53:10 mordred ++
15:53:10 mriedem *and castellan i guess
15:53:22 efried We figured out that castellan was n/a
15:53:38 mriedem i'll at least throw something into the cross-project goal etherpad of doom
15:53:44 mordred efried: also - sorry, I never got the os-service-types integration added to keystoneauth this past cycle
15:53:44 efried mordred: You were talking about taking it a step further IIRC, getting rid of "clients" altogether and just using the adapter (which we would spin up in a standard way)
15:54:06 efried mordred: Me neither :)
15:54:34 efried mordred: I started focusing more selfishly on placement stuff.
15:54:55 mordred efried: yah. honestly the use of the python client libs for inter-service communication just makes things harder - but I haven't actually gotten far enough along on my list of rocks to push up hill to start on that one yet - maybe post-rocky
15:56:43 efried mordred: I started to feel like that might be a bit too idealistic, really. The clients can add some project-specific value - though there's certainly consolidation/refactoring that could be done.
15:56:58 mordred efried: the work to align on what you've done in nova - with using keystoneauth to register the oslo.config options and to consume the options is great in either case ... and should allow us to later refactor to use not-client-lib easily without any operator impact, should we choose to
15:57:15 efried Yuh
15:57:59 mordred efried: my experience is that they provide negative value as soon as you are a consumer of more than one service because each one 'adds value' in their own special way that you have to figure out - whereas the REST APIs themselves are ACTUALLY quite good and are surprisingly consistent already
15:58:12 mriedem mordred: efried: L463 https://etherpad.openstack.org/p/community-goals
15:58:14 efried mm
15:58:59 mordred efried: like, I thought openstack's rest apis were worse than they are back when my only consumption of them was the client libs - but as soon as I switch to REST, I realized that the openstack developers had actually done a great job in making me some excellent apis
15:59:14 efried mriedem: ack
16:17:55 openstackgerrit Hongbin Lu proposed openstack/nova master: Handle RPC timeout on get_console_output https://review.openstack.org/525335
16:19:59 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove unused tempest-dsvm-lxc-rc https://review.openstack.org/539244
16:22:54 openstackgerrit Ed Leafe proposed openstack/nova master: Fix invalid UUIDs in test_compute.py https://review.openstack.org/531479
16:33:11 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Fix invalid UUIDs https://review.openstack.org/539247
16:33:25 stephenfin edleafe: I'd been working on something similar, thankfully with no overlap ^
16:35:33 edleafe stephenfin: heh, I'm just about ready to push a fix for the rest. Bet there's overlap there
16:35:34 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Don't use 'Test' prefix for non-TestCase classes https://review.openstack.org/539251
16:35:35 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Resolve "X is renamed to Y" warnings https://review.openstack.org/539252
16:35:35 openstackgerrit Stephen Finucane proposed openstack/nova master: Don't modify objects directly https://review.openstack.org/539253
16:35:55 stephenfin edleafe: Go for it. I'm guessing mine has issue anyway
16:36:00 stephenfin *issues
16:36:13 mriedem melwitt: i saw you posted backports for https://review.openstack.org/#/c/533371/ - i left some comments about impacts to the CachingScheduler, of which i'm not sure there are any, but it'd be nice to get a 2nd set of eyes on that part of it.
16:36:47 stephenfin ...as all code written on a Friday evening is likely to have
16:37:07 Spaz-Work really don't like this test...
16:37:18 Spaz-Work mock patching hurting my brain
16:37:27 openstackgerrit Ed Leafe proposed openstack/nova master: Fix invalid UUIDs in remaining tests https://review.openstack.org/539254
16:37:32 edleafe stephenfin: ^^
16:38:35 mdbooth stephenfin: https://review.openstack.org/#/c/539247/1/nova/tests/unit/virt/libvirt/test_vif.py does nova.network.model use o.v.o. ?

Earlier   Later