| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-30 | |||
| 09:49:53 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Integrate Mypy Type Checking https://review.openstack.org/538217 | |
| 09:49:56 | bauzas | huh, 18 hours from the top change to be merged in the gate | |
| 09:50:05 | bauzas | that's going to be a long long day | |
| 09:50:17 | Spazmotic | yikes | |
| 09:50:27 | Spazmotic | Gate still bogged down after the zuul restart? | |
| 09:50:37 | bauzas | huge delay at least | |
| 09:51:32 | Spazmotic | Welp.. time for my morning begging session again. Will throw out this review if anyone gets some free cycles to look at it. https://review.openstack.org/#/c/533168/ | |
| 09:51:36 | Spazmotic | And imma go drink some coffee :) | |
| 09:52:34 | bauzas | well, looks like it's just a delay problem AFAICT http://status.openstack.org/openstack-health/#/ | |
| 09:59:50 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Invalid query parameter could lead to HTTP 500 https://review.openstack.org/539164 | |
| 10:00:36 | openstackgerrit | Stephen Finucane proposed openstack/nova master: zuul: Add 'mypy' job https://review.openstack.org/539168 | |
| 10:02:47 | bauzas | Spazmotic: stupid question but does the XenServer CI covers your change ? https://review.openstack.org/#/c/533168/ | |
| 10:05:59 | mgoddard_ | alex_xu: hi, is there documentation for usage of traits as flavor extra specs? https://review.openstack.org/#/c/536085/9 | |
| 10:09:36 | bauzas | mgoddard_: for the moment, see the relnote https://review.openstack.org/#/c/536085/9/releasenotes/notes/request-traits-in-nova-ffcb00f76229b6e9.yaml | |
| 10:09:54 | bauzas | some nova documentation could be made I agree | |
| 10:11:35 | mgoddard_ | bauzas: that would be nice. I can't see anything about custom resource classes on flavors either. | |
| 10:12:04 | mgoddard_ | bauzas: something in here: https://docs.openstack.org/nova/latest/user/flavors.html? | |
| 10:13:01 | Spazmotic | sorry bauzas was grabbing coffee | |
| 10:14:07 | bauzas | Spazmotic: no excuses. | |
| 10:14:10 | Spazmotic | hehehehe | |
| 10:14:25 | Spazmotic | I was looking through the CIs tests the other day actaully i'm not too sure, it should if it has the standard suite with moving multiple volumes | |
| 10:15:58 | bauzas | mgoddard_: we generally document in https://docs.openstack.org/nova/latest/user/placement.html for end-user and operator concerns | |
| 10:18:52 | Spazmotic | alrhough the tests would be under the compute stuff, so i'm looking now at its tempest set | |
| 10:20:39 | mgoddard_ | bauzas: flavors don't exist in placement, do they? | |
| 10:20:53 | bauzas | mgoddard_: no, they don't, you're right | |
| 10:21:28 | mgoddard_ | ok, well thanks bauzas | |
| 10:21:54 | bauzas | mgoddard_: we just use flavors as a way to notify which specific resource classes and traits a user asks | |
| 10:22:10 | bauzas | in order to keep the Nova API stable | |
| 10:22:41 | bauzas | that's translated into traits and resource classes queries by the scheduler which calls out the Placement API | |
| 10:23:51 | Spazmotic | bauzas - Think it's a no. There are only like 3 migration tests in this suite | |
| 10:25:02 | Spazmotic | and are just tests for the cold migrate feature | |
| 10:28:09 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't filter out sibling sets with one core https://review.openstack.org/537361 | |
| 10:28:10 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Ensure emulator threads are always calculated https://review.openstack.org/537363 | |
| 10:28:10 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Always pass 'NUMACell.siblings' to _pack_instance_onto_cores' https://review.openstack.org/537364 | |
| 10:28:11 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivialfix: cleanup _pack_instance_onto_cores() https://review.openstack.org/538698 | |
| 10:28:11 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add unit tests for EmulatorThreadsTestCase https://review.openstack.org/538699 | |
| 10:28:12 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Not use thread alloc policy for emulator thread https://review.openstack.org/538700 | |
| 10:37:20 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: [WIP] libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/534384 | |
| 10:39:16 | Spazmotic | thanks bauzas :D | |
| 10:39:44 | bauzas | Spazmotic: not a firm -1, just general advice for maintenability | |
| 10:39:52 | bauzas | I need to disappear now | |
| 10:39:57 | Spazmotic | Understandable, i'll get it fixed soon | |
| 10:40:08 | bauzas | cool | |
| 10:43:54 | Spazmotic | super appreciate it and great advice, thanks again bauzas. Doesn't sound harsh at all, great ideas. | |
| 10:44:02 | Spazmotic | Enjoy your disappearing | |
| 11:05:04 | openstackgerrit | Naichuan Sun proposed openstack/nova master: VGPU: Modify the example of vgpu white_list set https://review.openstack.org/539183 | |
| 11:18:55 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_vcpu_realtime_scheduler() https://review.openstack.org/527630 | |
| 11:18:56 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_XXXpin_cpuset() https://review.openstack.org/527631 | |
| 11:18:56 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_numa_memnode() https://review.openstack.org/529906 | |
| 11:18:57 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: disable cpu pinning with libvirt/qemu driver https://review.openstack.org/531049 | |
| 11:18:57 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add NumaTopology support for libvirt/qemu driver https://review.openstack.org/530451 | |
| 11:48:55 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Fix hypervisor_type in /os-hypervisors/details https://review.openstack.org/531328 | |
| 11:48:55 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: [libvirt] Filter hypervisor_type by virt_type https://review.openstack.org/531347 | |
| 12:27:31 | gibi | seem that the novnc package is broken on the gate: http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Unable%20to%20correct%20problems%2C%20you%20have%20held%20broken%20packages%3A%5C%22 | |
| 12:27:50 | gibi | http://logs.openstack.org/53/512553/5/check/tempest-full/ac042d5/job-output.txt.gz#_2018-01-30_09_50_23_127790 | |
| 12:28:46 | gibi | infra knows about the problem | |
| 12:32:08 | cdent | infra is the all seeing eye | |
| 13:06:18 | jaypipes | good morning supernovas | |
| 13:09:03 | jaypipes | stephenfin: mornin, mate. | |
| 13:10:19 | gibi | jaypipes: good morning | |
| 13:10:41 | jaypipes | stephenfin: I'm presuming the many failures in functional test jobs in https://review.openstack.org/#/c/537361/ are actually not related to that patch.. | |
| 13:10:47 | jaypipes | gibi: mornin :) | |
| 13:18:27 | gibi | jaypipes: the failures in ^^ are caused by a broken package: http://logs.openstack.org/61/537361/4/check/tempest-full/13f575b/job-output.txt.gz#_2018-01-30_11_20_19_108323 | |
| 13:20:13 | gibi | jaypipes: infra knows about it http://eavesdrop.openstack.org/irclogs/%23openstack-infra/%23openstack-infra.2018-01-30.log.html#t2018-01-30T12:36:43 | |
| 13:20:26 | jaypipes | gibi: got it. thank you sir. | |
| 13:31:41 | stephenfin | jaypipes: That would sounds correct, yes | |
| 13:31:54 | stephenfin | Wow, the gate is not happy | |
| 13:33:26 | stephenfin | jaypipes: Thanks for reviewing those too (y) | |
| 13:39:14 | jaypipes | stephenfin: no problemo. | |
| 13:46:42 | izombie | does running nova from virtual environment needs extra steps? few services aren't starting because nova-rootwrap is in virtualenv scope. | |
| 13:47:33 | Spazmotic | bauzas, was relaxing on the couch with the fiancee and think I realized what you wanted in your comments.. very elegant if my mind is correct here.. will commit it within the next few hours. | |
| 13:51:14 | Spazmotic | I'm concerned with utilizing the current iS_booted method but i definately do understand the desire not to double up on methodws. My plans was to follow the commitg with a deprecation of that and use the new one.. but instead can just change its name | |
| 14:06:16 | ameeda | jaypipes: can you please check this https://review.openstack.org/#/c/526900/, it has a lot of zuul failures , I think that is something wrong with zuul ? | |
| 14:07:03 | bauzas | Spazmotic: okay, no worries | |
| 14:07:20 | Spazmotic | exciting, I love your logic.. wanna go steady? :p | |
| 14:07:52 | gibi | ameeda: gate is broken | |
| 14:08:07 | gibi | ameeda: infra is working on it | |
| 14:08:39 | Spazmotic | Is there an infra channel btw? | |
| 14:10:20 | gibi | Spazmotic: #openstack-infra | |
| 14:10:26 | Spazmotic | Thank ya sir | |
| 14:11:39 | ameeda | gibi: thank you ! | |
| 14:11:59 | ameeda | gibi: can you please review this for me ? https://review.openstack.org/#/c/528385/ | |
| 14:19:01 | Kvisle | is it normal for nova-compute to use the public endpoint of the placement api, and not the internal one? | |
| 14:24:17 | openstackgerrit | Radoslav Gerganov proposed openstack/nova master: ProviderTree.new_child: parent is either uuid or name https://review.openstack.org/538264 | |
| 14:25:23 | cdent | Kvisle: that's the default (for historical reasons) but you can configure it. | |
| 14:27:20 | cdent | Kvisle: os_interface is the old way, valid_interfaces is the new way | |
| 14:27:53 | bauzas | Spazmotic: also, I haven't commented on that, but you know that with Python you can't recursively call more than 30 times the same method by default, right ? | |
| 14:28:20 | ameeda | mriedem: please check my comment here https://review.openstack.org/#/c/528385/10 | |
| 14:29:47 | Kvisle | cdent: thanks (starting queens I see) | |
| 14:29:55 | ameeda | mriedem: if you have questions please let me know | |
| 14:32:46 | bauzas | Spazmotic: oops, my bad, by default, it's 999 times | |
| 14:33:27 | bauzas | Spazmotic: http://paste.openstack.org/show/658017/ | |
| 14:37:34 | efried | Kvisle: Yes; the old way is deprecated but will still work in Q. | |
| 14:41:18 | openstackgerrit | Ruby Loo proposed openstack/os-traits master: Add code hosting URL https://review.openstack.org/539224 | |
| 14:48:27 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform live_migration_post_dest notification https://review.openstack.org/469784 | |
| 14:50:15 | mriedem | ameeda: replied | |
| 14:53:23 | efried | jaypipes: Looks like I've got a unit test tweak to make, but otherwise the update_provider_tree series is now done and ready for review. | |
| 14:53:51 | efried | jaypipes: Realizing of course that it waits for Rocky; but we could land it early if it's already had a looksee. | |
| 14:55:00 | rgerganov | efried, which part of the series is for Rocky? | |
| 14:55:22 | efried | rgerganov: Well, that depends whether the six currently-approved patches ever make it through the gate. | |