| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-15 | |||
| 06:45:03 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.59 - Migrations list pagination https://review.openstack.org/516168 | |
| 06:56:38 | openstackgerrit | jichenjc proposed openstack/nova master: WIP: Add zvm CI information https://review.openstack.org/533512 | |
| 07:33:17 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Fix 500 in test_resize_server_negative_invalid_state https://review.openstack.org/531117 | |
| 07:33:18 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add index(instance_uuid, updated_at) on instance_actions table https://review.openstack.org/530429 | |
| 07:35:59 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.59 - Migrations list pagination https://review.openstack.org/516168 | |
| 08:06:25 | ameeda | Hi | |
| 08:06:42 | ameeda | how can I update image properties in regression test function ? "self.image["properties"] = {key: value}" | |
| 08:57:59 | bauzas | morning Novaers | |
| 08:58:12 | bauzas | busy days | |
| 08:58:18 | gibi | morning bauzas | |
| 08:59:30 | bauzas | :) | |
| 09:16:10 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/python-novaclient master: Add missing spaces in `nova list --changes-since` help https://review.openstack.org/533575 | |
| 09:18:55 | ameeda | bauzas: how can I update image properties in regression test function ? "self.image["properties"] = {key: value}" | |
| 09:19:05 | ameeda | gibi: how can I update image properties in regression test function ? "self.image["properties"] = {key: value}" | |
| 09:25:24 | bauzas | ameeda: you'd like to test some specific image properties ? | |
| 09:25:45 | bauzas | is that in a unit test or a functional test ? | |
| 09:26:04 | bauzas | if so, you'd mock the image | |
| 09:28:44 | ameeda | bauzas: this is functional test, I want to update image properties then check if the value is changes "truncates" or not. | |
| 09:29:12 | bauzas | ameeda: if that's for a functional test, you should just pass a specific image | |
| 09:29:31 | openstackgerrit | Édouard Thuleau proposed openstack/nova master: Update plugs Contrail methods to work with privsep https://review.openstack.org/533212 | |
| 09:31:51 | ameeda | bauzas: you can see what I do here "http://paste.openstack.org/show/644825/" | |
| 09:32:57 | ameeda | bauzas: I have to check if image properties of original image is same as image properties of snapshot image. | |
| 09:33:58 | ameeda | bauzas: so I have to update image['properties'] , but I did that like this " image['properties']={key: value}, it doesn't works | |
| 09:35:17 | Spazmotic | morning friends | |
| 09:35:52 | bauzas | ameeda: I'd rather generate an image that would contain the property I'd like to test, and check eventually what I give | |
| 09:35:55 | bauzas | s/give/get | |
| 09:36:07 | bauzas | morning | |
| 09:37:15 | ameeda | bauzas: when I tried to do client api.post_image(image) that give me API not found | |
| 09:37:18 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: Handle glance exception during rotating instance backup https://review.openstack.org/533439 | |
| 09:37:32 | bauzas | ameeda: there is a fake Glance service that you can use for your purpose https://github.com/openstack/nova/blob/master/nova/tests/unit/image/fake.py | |
| 09:37:54 | bauzas | then, you need to stub that service in the functional test | |
| 09:38:36 | ameeda | bauzas: thank you for your time. do you have an example of stub ? | |
| 09:38:50 | bauzas | like https://github.com/openstack/nova/blob/master/nova/tests/functional/test_servers.py#L1369 | |
| 09:39:19 | ameeda | bauzas: thanks! | |
| 09:39:30 | bauzas | that should give you a "fake Glance" where you could create an image like you wish and pass the image ref to the Nova call you wish | |
| 09:40:21 | bauzas | ameeda: HTH | |
| 09:40:56 | ameeda | bauzas: let me check , I will ask you if I have another question :$ | |
| 09:40:58 | ameeda | Thanks | |
| 09:42:08 | bauzas | ameeda: np and good luck | |
| 09:46:12 | ratailor | Can anyone review https://review.openstack.org/#/c/498334/ | |
| 09:46:22 | ratailor | It goes in merge conflict every now and then.. | |
| 09:49:16 | mdbooth | ratailor: I'll look fwiw. | |
| 09:55:44 | Spazmotic | whew... that was a good meal | |
| 09:57:52 | Spazmotic | Did Gerritt go through any major changes in the past year? I logged in to make my first commit in a long time and old commits were gone | |
| 09:58:00 | Spazmotic | wondering if i just accidentallied an ew user ㅋㅋㅋㅋ | |
| 09:58:48 | Spazmotic | Not that it matters too terribly.. just curious | |
| 10:08:07 | mdbooth | Spazmotic: Don't think so. Were they just abandoned for you? | |
| 10:08:21 | Spazmotic | Possible.. was also a whole different release so maybe just something there. | |
| 10:10:13 | Spazmotic | i'll pull up the commit some time later to see just how dumb I am.. too lazy and full now :D | |
| 10:10:39 | Spazmotic | Cheat day.. so many carbs.. so many | |
| 10:36:42 | ameeda | bauzas: Thank you very much, its work !! | |
| 10:36:50 | ameeda | Regarding this gerrit https://review.openstack.org/#/c/528385 | |
| 10:36:53 | bauzas | cool | |
| 10:37:03 | ameeda | I have another issue | |
| 10:37:13 | ameeda | I was added the detach_volume function outside of _cleanup_volumes to avoid regression, | |
| 10:37:18 | ameeda | since this function used in many places. | |
| 10:37:21 | ameeda | as you see, two code-reviewers asked me why I added that outside. | |
| 10:37:25 | ameeda | https://review.openstack.org/#/c/528385/4/nova/compute/manager.py | |
| 10:37:29 | ameeda | So I move my code to be inside of _cleanup_volumes as here | |
| 10:37:34 | ameeda | https://review.openstack.org/#/c/528385/5/nova/compute/manager.py | |
| 10:37:39 | ameeda | but I faced many issues with py27 and I solve them all. now, I faced many issues with functional test, | |
| 10:37:44 | ameeda | what if I return my code to be outside of _cleanup_volumes? | |
| 10:42:09 | kashyap | PSA: If you're hitting: "devstackf27 httpd[5096]: AH00534: httpd: Configuration error: More than one MPM loaded." with DevStack, there's apparently a fix merged for Apache this morning | |
| 10:42:18 | kashyap | https://bugs.launchpad.net/devstack/+bug/1740194 | |
| 10:42:19 | openstack | Launchpad bug 1740194 in devstack "Apache2 unable to start as 2 MPM modules enabled on Fedora 27" [Undecided,Fix released] - Assigned to Attila Fazekas (afazekas) | |
| 10:51:28 | elmaciej | Hi! | |
| 10:56:46 | ameeda | bauzas: can you help me with that ? | |
| 11:34:43 | lyarwood | https://review.openstack.org/#/c/531407/ - Any stable cores able to +2/+W this? I'd rather not fast approve something with my name all over it :) | |
| 11:36:26 | Spazmotic | It's not so muc hthat it's a problem that it's there, ameeda, but you're making that particular function set have an incorrect purpose by placing it inside. of the build process. | |
| 11:36:32 | Spazmotic | When there is already a cleanup process | |
| 11:37:04 | Spazmotic | Especially since it already calls cleanup, would be a ..cleaner system to let cleanup do the...cleanup.. sorry it's late hehe | |
| 11:40:09 | Spazmotic | If you can provide a good reason to have it out of there i'm sure people will understand, but unfortuantely to appease the unit test heavens is going to be a tough sell | |
| 11:56:50 | ameeda | Spazmotic: I still beginner with Openstack, I am not sure by what I said "to avoid regression, since the _cleanup_volumes used in another places", So you guess that I have to keep the code as its now , I mean inside cleanup and fix tests failures ? | |
| 12:00:46 | kashyap | Does anyone have a link to DevStack Ceph job, please? | |
| 12:01:08 | kashyap | Okay, that's it: "gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial" | |
| 12:02:08 | Spazmotic | I'm sorry, these patch sets are so different from each other i'm struggling to keep up here.. give me a few to read it | |
| 12:03:38 | ameeda | I'm sorry for that | |
| 12:03:41 | Spazmotic | Ok I've got it. | |
| 12:06:05 | ameeda | great | |
| 12:06:20 | ameeda | so what do you think ? | |
| 12:06:31 | Spazmotic | reading the code | |
| 12:06:40 | ameeda | sorry, take your time | |
| 12:06:47 | Spazmotic | interesting bug... wouldn't midn testing it myself, but reading | |
| 12:07:39 | ameeda | sure :) | |
| 12:08:37 | Spazmotic | I think I agree there's no reason to throw if instance in there btw since you have already checked for this in the try/except it should be guarunteed to be there | |
| 12:08:59 | ameeda | ok, I agree with you too | |
| 12:09:01 | Spazmotic | I would also recommend leaving it here in cleanup and not try to move it back out.. this is definately hwere it belongs | |
| 12:09:32 | ameeda | so I have to complete my work to fix all failures of tests | |
| 12:09:37 | Spazmotic | i glanced through the console log of zuul.. some nasty exceptiosn in there you're going to have to paly with. my guess is since this ia pretty big change to the cleanup method you may need to adjust the test a bit.. but remember not to Mock your way to victory.. .make sure it makes sense for your new conditions :) | |
| 12:09:41 | Spazmotic | back in aw hile | |
| 12:10:34 | ameeda | take your time | |
| 12:13:36 | mdbooth | ratailor: Hey, just commented on your patch. Did you respond to bauzas comments oob at any point? I was going to make the same point, but saw he'd already done it. | |
| 12:29:38 | gmann | alex_xu: can you check this - https://review.openstack.org/#/c/522918/ | |
| 12:36:06 | cdent | efried: aren't you supposed to be on holiday? | |
| 12:36:12 | efried | cdent gibi Thanks for the rechecks. Zuul had a really bad week last week; let's hope this one is better. | |
| 12:36:16 | efried | cdent No? | |
| 12:36:32 | efried | I believe mriedem is on holiday this week. | |
| 12:37:01 | cdent | It's mlk day. I guess that's not an enforced US holiday. I think my us employer-colleagues are taking it off. I can never remember. | |
| 12:37:12 | efried | ohhh, right. | |
| 12:37:19 | cdent | zuul probably wants sacrifices | |