| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-15 | |||
| 10:56:46 | ameeda | bauzas: can you help me with that ? | |
| 11:34:43 | lyarwood | https://review.openstack.org/#/c/531407/ - Any stable cores able to +2/+W this? I'd rather not fast approve something with my name all over it :) | |
| 11:36:26 | Spazmotic | It's not so muc hthat it's a problem that it's there, ameeda, but you're making that particular function set have an incorrect purpose by placing it inside. of the build process. | |
| 11:36:32 | Spazmotic | When there is already a cleanup process | |
| 11:37:04 | Spazmotic | Especially since it already calls cleanup, would be a ..cleaner system to let cleanup do the...cleanup.. sorry it's late hehe | |
| 11:40:09 | Spazmotic | If you can provide a good reason to have it out of there i'm sure people will understand, but unfortuantely to appease the unit test heavens is going to be a tough sell | |
| 11:56:50 | ameeda | Spazmotic: I still beginner with Openstack, I am not sure by what I said "to avoid regression, since the _cleanup_volumes used in another places", So you guess that I have to keep the code as its now , I mean inside cleanup and fix tests failures ? | |
| 12:00:46 | kashyap | Does anyone have a link to DevStack Ceph job, please? | |
| 12:01:08 | kashyap | Okay, that's it: "gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial" | |
| 12:02:08 | Spazmotic | I'm sorry, these patch sets are so different from each other i'm struggling to keep up here.. give me a few to read it | |
| 12:03:38 | ameeda | I'm sorry for that | |
| 12:03:41 | Spazmotic | Ok I've got it. | |
| 12:06:05 | ameeda | great | |
| 12:06:20 | ameeda | so what do you think ? | |
| 12:06:31 | Spazmotic | reading the code | |
| 12:06:40 | ameeda | sorry, take your time | |
| 12:06:47 | Spazmotic | interesting bug... wouldn't midn testing it myself, but reading | |
| 12:07:39 | ameeda | sure :) | |
| 12:08:37 | Spazmotic | I think I agree there's no reason to throw if instance in there btw since you have already checked for this in the try/except it should be guarunteed to be there | |
| 12:08:59 | ameeda | ok, I agree with you too | |
| 12:09:01 | Spazmotic | I would also recommend leaving it here in cleanup and not try to move it back out.. this is definately hwere it belongs | |
| 12:09:32 | ameeda | so I have to complete my work to fix all failures of tests | |
| 12:09:37 | Spazmotic | i glanced through the console log of zuul.. some nasty exceptiosn in there you're going to have to paly with. my guess is since this ia pretty big change to the cleanup method you may need to adjust the test a bit.. but remember not to Mock your way to victory.. .make sure it makes sense for your new conditions :) | |
| 12:09:41 | Spazmotic | back in aw hile | |
| 12:10:34 | ameeda | take your time | |
| 12:13:36 | mdbooth | ratailor: Hey, just commented on your patch. Did you respond to bauzas comments oob at any point? I was going to make the same point, but saw he'd already done it. | |
| 12:29:38 | gmann | alex_xu: can you check this - https://review.openstack.org/#/c/522918/ | |
| 12:36:06 | cdent | efried: aren't you supposed to be on holiday? | |
| 12:36:12 | efried | cdent gibi Thanks for the rechecks. Zuul had a really bad week last week; let's hope this one is better. | |
| 12:36:16 | efried | cdent No? | |
| 12:36:32 | efried | I believe mriedem is on holiday this week. | |
| 12:37:01 | cdent | It's mlk day. I guess that's not an enforced US holiday. I think my us employer-colleagues are taking it off. I can never remember. | |
| 12:37:12 | efried | ohhh, right. | |
| 12:37:19 | cdent | zuul probably wants sacrifices | |
| 12:37:20 | efried | I don't think this is one of those, but let me check... | |
| 12:37:44 | efried | nope, doesn't look like it. I've got pto scheduled for tomorrow, though. | |
| 12:37:57 | efried | My kids are off. But not me. | |
| 12:39:38 | kashyap | mdbooth: Hey, when you get a sec, is there a way I can see a Gate job result for an instance boot with an ephemeral disk? | |
| 12:41:26 | mdbooth | kashyap: Almost certainly, but I wouldn't know off the top of my head which tempest tests cover ephemerals. | |
| 12:42:02 | kashyap | mdbooth: No problem, I'll plough through them. | |
| 12:45:53 | Spazmotic | My commit handles ephs, one sec | |
| 12:46:29 | Spazmotic | Ah you wanted gate, not initial check didn't you | |
| 12:48:02 | kashyap | Spazmotic: I want to see the libvirt XML on any of the Gate jobs with an instance boot with ephemeral disk | |
| 12:48:34 | kashyap | Okido, my local DevStack run just finished after 24 minutes (real 24m49.794s), so I'll try locally | |
| 12:49:17 | Spazmotic | Ahhh I see, I cannot help so much with that, hehe. Sorry i'll go back into the shadows | |
| 12:49:27 | kashyap | Heh, np. | |
| 13:03:11 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make sure that functional test triggered on sample changes https://review.openstack.org/533210 | |
| 13:04:05 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM: Testing if funct test is triggered https://review.openstack.org/533211 | |
| 13:10:04 | elmaciej | Hi! Maybe someone can point me how to start contributing to openstack. I made some fix to allow live migration on lvm based shared storage and don't know if it's worthly to put it official or not. Where should I get started. | |
| 13:10:23 | zioproto | sdague: ping, is it business hours in your timezone now ? :) | |
| 13:11:24 | zioproto | elmaciej: you need to "git review" your patch. More info here https://docs.openstack.org/infra/manual/developers.html | |
| 13:11:50 | elmaciej | zioproto - so I can create my own branch, push to it and call the review? just like that? | |
| 13:11:58 | zioproto | elmaciej: you need to "Sign the appropriate Individual Contributor License Agreement" | |
| 13:12:05 | zioproto | elmaciej: it is exaplained in that page | |
| 13:12:08 | zioproto | then you can push | |
| 13:12:14 | zioproto | and somebody will review your patch | |
| 13:12:22 | zioproto | you dont need to create a branch | |
| 13:12:28 | zioproto | all the work should be in 1 single commit | |
| 13:12:36 | zioproto | then on your shell | |
| 13:12:38 | zioproto | just type | |
| 13:12:40 | zioproto | git review | |
| 13:12:51 | zioproto | this will automatically create a branch | |
| 13:13:04 | elmaciej | ok,got this, thanks, will take a look at evening then. | |
| 13:13:22 | zioproto | elmaciej: thanks for contributing to openstack | |
| 13:13:34 | Spazmotic | Really no need to create a local branch? have always done it :D | |
| 13:13:45 | elmaciej | it's a pleasure :) I needed live migration on lvm :) buisness requirment | |
| 13:23:05 | cdent | bauzas, gibi: 500 fix, already one +2, about 6 months old, would be nice to have: https://review.openstack.org/#/c/389798/ | |
| 13:28:53 | jaypipes | cdent: done. | |
| 13:29:25 | cdent | danke jaypipes wasn't sure if you were a) still alive, b) here today, c) here yet | |
| 13:29:29 | cdent | feeling better? | |
| 13:29:42 | jaypipes | cdent: much, thank you. I'm back around 75% I think. | |
| 13:30:00 | cdent | flu sucks | |
| 13:30:36 | cdent | (I think it was diana on much of that thing, I just did a rebase towards the end) | |
| 13:32:16 | gibi | jaypipes: welcome back! | |
| 13:32:38 | jaypipes | gibi: thanks mate :) | |
| 13:32:49 | jaypipes | feels good to be able to work again. | |
| 13:33:19 | lyarwood | bauzas: so https://review.openstack.org/#/c/531407/ wasn't really my change FWIW, mdbooth and melwitt rewrote most of it in master so we should be good to +W this now. | |
| 13:35:18 | efried | jaypipes Howdy sir, welcome back to the land of the living. | |
| 13:37:45 | jaypipes | efried: thanks :) | |
| 13:41:47 | mdbooth | lyarwood: IIUC we're expecting failures in https://review.openstack.org/#/c/523958/ because we're assuming c-vol has done its thing, which it hasn't, right? | |
| 13:42:21 | mdbooth | lyarwood: i.e. A lack of tempest failures would indicate a lack of test coverage? | |
| 13:42:40 | mdbooth | And we need a couple of Depends-On: for c-vol patches which don't exist, yet? | |
| 13:43:27 | lyarwood | mdbooth: yes and yes, there's some additional coverage in the barbican plugin but there's also alot missing from standard tempest | |
| 13:43:44 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: create vGPU for instance https://review.openstack.org/528832 | |
| 13:43:45 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Recreate mediated devices on reboot https://review.openstack.org/533642 | |
| 13:43:54 | bauzas | AFAIK, mriedem is not around today, right? | |
| 13:43:58 | mdbooth | lyarwood: Ok, thanks. | |
| 13:48:52 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Recreate mediated devices on reboot https://review.openstack.org/533642 | |
| 13:49:35 | cdent | edleafe, efried: can I assume we are having the usual scheduler meeting? | |
| 13:50:18 | jaypipes | cdent: yes, but edleafe is commuting. | |
| 13:50:29 | jaypipes | cdent: unless he's off for MLK day? | |
| 13:50:32 | jaypipes | not sure.. | |
| 13:51:25 | efried | IBM doesn't have MLK as a site holiday. But edleafe asked me to run it, so either he's off anyway, or he's commuting. | |
| 13:56:10 | efried | cdent You didn't find the first paragraph of the commit message adequately explanatory? https://review.openstack.org/#/c/533244/ | |
| 13:56:39 | cdent | efried: imagine you didn't know what a _Provider is? | |
| 13:56:50 | cdent | That's what I mean by "in isolation" | |
| 13:57:29 | efried | okay. | |
| 13:58:08 | cdent | efried: I know it is tedious, and I know I dont do that to everyone, but a) I should, b) I feel like you'll take it in good intent intended | |
| 13:58:42 | cdent | (also I didn't -1 it, just commented) | |
| 13:59:22 | efried | cdent I'm planning to slot this change into the existing series, so that would give it some context. But I'll add some words. | |