Posted	Nick	Remark
#openstack-nova - 2018-01-12
21:40:10	mriedem	ok, well that's excellent news
21:40:29	mriedem	then i think the only major thing is the migration obj lookup
21:40:44	figleaf	mriedem: https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L1136
21:41:26	figleaf	I added a filter on status, and also added some allocation tests to verify that only the host that succeeds has allocations
21:41:27	mriedem	figleaf: https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L1096
21:41:47	mriedem	are you sure we don't hit https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L1132 and it thinks we're doing a move
21:41:52	mriedem	and double the allocations for the instance again?
21:42:18	figleaf	mriedem: I put a break on that line and never hit it. Let me run it again to be sure
21:43:14	mriedem	and your test is asserting the failed hosts don't have any allocations on them when we're done rescheduling?
21:43:34	mriedem	i guess you said that already
21:43:48	figleaf	yeah
21:44:21	mriedem	the other thing is, dest_alloc_req is going to be in the new format here now https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L180
21:44:29	mriedem	so i'd expect to hit some issues there, like superdan did in his patch
21:44:40	figleaf	I just re-ran the functional test with debug output for the current_allocs in the code, and it's empty every time
21:44:43	mriedem	i could have sworn we talked about this during the reschedules on the server create path
21:44:45	mriedem	*patch
21:45:39	mriedem	idk, doesn't make sense to me that that report client code doesn't think we're doing a move operation b/c the instance should still have the allocation on the originally chosen dest node
21:45:56	figleaf	mriedem: got the new format covered: https://review.openstack.org/#/c/526436/23/nova/tests/functional/test_servers.py@2730
21:46:00	mriedem	unless something is deleting that before we get there
21:46:54	mriedem	figleaf: i don't understand why your functional test needs to stub any of that out
21:47:01	mriedem	kind of defeats the purpose of using a functional test
21:48:15	mriedem	anyway, i'm on serious vacation brain mode at this point and trying to wrap up some stuff around the house before i turn things off
21:48:19	mriedem	so can't really dig into this in detail
21:50:03	figleaf	mriedem: the only things that are stubbed/mocked are a) the prep_resize, so I can force it to pass/fail, and select_destinations, so I can return the selections and also verify that it only called once (i.e., alternates are used)
21:50:35	mriedem	we shouldn't have to stub out select_destinations
21:50:39	mriedem	i left a comment in the patch,
21:50:48	mriedem	if you need predictable sort order on the hosts, add a custom weigher to the test
21:50:54	mriedem	there are some examples in other tests
21:51:12	figleaf	and how can I verify that it isn't called repeatedly?
21:52:22	mriedem	if prep_resize is called > len(hosts) then you'd know right?
21:52:32	mriedem	or max_attempts or whatever
21:54:08	figleaf	prep_resize will be called once for each attempted migration
21:54:27	figleaf	select_destinations is called from the task
22:14:51	mriedem	figleaf: i think you were right about _revert_allocation,
22:15:10	mriedem	i think that deletes the allocation for the migration record on the source node, and overwrites the instance allocation to only be on the source node,
22:15:30	mriedem	i remember why you were hitting the format issue where the reschedules on build thought we were doubling up again when claiming on the alterante,
22:15:44	mriedem	and it was because we hit that before the compute had removed the allocation the instance had on the failed node
22:15:55	mriedem	https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4091
22:16:02	mriedem	"either way we need to cleanup any allocations created # by the scheduler for the destination node."
22:16:25	mriedem	so yeah, that's why on the reschedule, claim_resources doesn't think we're doubling, because the instance doesn't have a claim on the old failed dest node
22:17:03	figleaf	mriedem: yeah, that was the racy part that I fixed by moving it earlier before the cast
22:17:39	figleaf	I ran some traces, and set_and_clear_allocations() is being called for each reschedule
22:22:14	openstackgerrit	Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436
22:22:28	figleaf	mriedem: ^^ if you still have brain cycles
22:22:59	fried_rice	figleaf It occurs to me I should be prepping the agenda for the sched meeting. Is ^ the only remaining thing for alternates?
22:23:58	figleaf	fried_rice: yes
22:24:08	fried_rice	k
22:27:39	mriedem	figleaf: comments inline,
22:27:52	mriedem	figleaf: plus a question about ordering, something for probably superdan to look at on monday for a 2nd opinion
22:30:03	figleaf	mriedem: ok, thx
22:30:21	figleaf	mriedem: now turn off your brain and enjoy your holiday
22:45:41	openstackgerrit	Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436
22:48:27	ildikov	mriedem: if you have any homework for me too lemme know otherwise have fun!!! :)
22:50:02	mriedem	can't think of any
22:50:27	mriedem	melwitt: i updated the novaclient release patch to depend on the top of the series for the novaclient removal changes, once those are merged we'd just need to modify the hash in the release patch and then that should be good to go
23:27:26	openstackgerrit	Eric Fried proposed openstack/nova master: ProviderTree.snapshot => ProviderSnapshot https://review.openstack.org/533244
#openstack-nova - 2018-01-15
00:49:41	prometheanfire	nova doesn't look like it supports the new os_vif https://review.openstack.org/532987
01:01:55	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Fix allocation_candidates not to ignore shared RPs https://review.openstack.org/533396
01:01:56	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Support relay RP for allocation candidates https://review.openstack.org/533437
01:25:27	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: [placement] Fix resource provider delete https://review.openstack.org/529519
01:36:51	openstackgerrit	Wangpan proposed openstack/nova stable/pike: Handle glance exception during rotating instance backup https://review.openstack.org/533439
02:02:40	openstackgerrit	Huang Rui proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387
02:09:29	openstackgerrit	Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608
02:47:44	openstackgerrit	Huang Rui proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387
03:03:34	openstackgerrit	Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers.inc https://review.openstack.org/528201
03:04:00	openstackgerrit	Takashi NATSUME proposed openstack/nova master: api-ref: Example verification for servers.inc https://review.openstack.org/529520
04:16:32	openstackgerrit	Chen Hanxiao proposed openstack/nova master: test: Use assertEqual() instead of assertXXXEqual() https://review.openstack.org/533493
05:06:05	openstackgerrit	Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483
05:09:40	openstackgerrit	Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483
05:27:11	openstackgerrit	Takashi NATSUME proposed openstack/nova master: [placement] Add functional tests for resource class API https://review.openstack.org/524506
05:27:24	openstackgerrit	Takashi NATSUME proposed openstack/nova master: [placement] Add functional tests for resource class API https://review.openstack.org/524506
05:47:16	openstackgerrit	Huang Rui proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387
06:00:02	openstackgerrit	Rajesh Tailor proposed openstack/nova master: Host addition host-aggregate should be case-sensitive https://review.openstack.org/498334
06:45:02	openstackgerrit	Yikun Jiang (Kero) proposed openstack/python-novaclient master: Add support for the 2.57 microversion https://review.openstack.org/528128
06:45:02	openstackgerrit	Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.58 - Instance actions list pagination https://review.openstack.org/528601
06:45:03	openstackgerrit	Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.59 - Migrations list pagination https://review.openstack.org/516168
06:56:38	openstackgerrit	jichenjc proposed openstack/nova master: WIP: Add zvm CI information https://review.openstack.org/533512
07:33:17	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Fix 500 in test_resize_server_negative_invalid_state https://review.openstack.org/531117
07:33:18	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Add index(instance_uuid, updated_at) on instance_actions table https://review.openstack.org/530429
07:35:59	openstackgerrit	Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.59 - Migrations list pagination https://review.openstack.org/516168
08:06:25	ameeda	Hi
08:06:42	ameeda	how can I update image properties in regression test function ? "self.image["properties"] = {key: value}"
08:57:59	bauzas	morning Novaers
08:58:12	bauzas	busy days
08:58:18	gibi	morning bauzas
08:59:30	bauzas	:)
09:16:10	openstackgerrit	Yikun Jiang (Kero) proposed openstack/python-novaclient master: Add missing spaces in `nova list --changes-since` help https://review.openstack.org/533575
09:18:55	ameeda	bauzas: how can I update image properties in regression test function ? "self.image["properties"] = {key: value}"
09:19:05	ameeda	gibi: how can I update image properties in regression test function ? "self.image["properties"] = {key: value}"
09:25:24	bauzas	ameeda: you'd like to test some specific image properties ?
09:25:45	bauzas	is that in a unit test or a functional test ?
09:26:04	bauzas	if so, you'd mock the image
09:28:44	ameeda	bauzas: this is functional test, I want to update image properties then check if the value is changes "truncates" or not.
09:29:12	bauzas	ameeda: if that's for a functional test, you should just pass a specific image
09:29:31	openstackgerrit	Édouard Thuleau proposed openstack/nova master: Update plugs Contrail methods to work with privsep https://review.openstack.org/533212
09:31:51	ameeda	bauzas: you can see what I do here "http://paste.openstack.org/show/644825/"
09:32:57	ameeda	bauzas: I have to check if image properties of original image is same as image properties of snapshot image.
09:33:58	ameeda	bauzas: so I have to update image['properties'] , but I did that like this " image['properties']={key: value}, it doesn't works
09:35:17	Spazmotic	morning friends
09:35:52	bauzas	ameeda: I'd rather generate an image that would contain the property I'd like to test, and check eventually what I give

Earlier   Later