Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-11-15
15:13:08 tasker 'allo.
15:14:59 openstackgerrit Jay Pipes proposed openstack/nova master: XenAPI: get vGPU stats from hypervisor https://review.openstack.org/512965
15:15:29 jaypipes jianghuaw: ^^ just a rebase...
15:16:12 openstackgerrit Jay Pipes proposed openstack/nova master: XenAPI: provide vGPU inventory in compute node https://review.openstack.org/516217
15:16:22 openstackgerrit Jay Pipes proposed openstack/nova master: XenAPI: create vGPU for instance https://review.openstack.org/516899
15:16:58 tasker my application has the potential to frequently trigger snapshots of two instances at the same time. regarding the future of bug#1731986, I'm concerned that checking cinder quota / limits prior to asking it for volume snapshots will casue many problems for me.
15:17:51 tasker i don't know Nova as well as you, and I know less about Cinder. maybe we can schedule some time with a cinder dev to discuss things? I'm hoping that since I'm here helping to implement this, I can guide it a bit to suit my needs.
15:19:29 tasker I'm in no rush; the major part of unqiescing the instance is done and I can implement some of these safeguards in my code.
15:22:04 mriedem tasker: i'm working a patch for the up-front quota check now, since i think that's sane and easy as a start, and then we can build on the cleanup stuff after that - what you had in your original patch. as noted, my concerns are with volume backends like NFS which call back to nova to complete a snapshot - i don't know how robust cinder handles deleting a snapshot while it's being created
15:22:12 mriedem my guess is there are no guarantees about behavior
15:22:28 mriedem just like deleting an instance in nova - you can do it at any point, but it's hard to test
15:26:17 tasker gotchya.
15:27:42 openstackgerrit Balazs Gibizer proposed openstack/nova master: Document the real behavior of notify_on_state_change https://review.openstack.org/516264
15:31:02 gibi mriedem: hi! I replied to your comments in https://review.openstack.org/#/c/516264
15:33:00 mriedem ack
15:53:15 efried jaypipes jianghuaw_ I was thinking to get started on the update_inventory virt driver method. Any concerns with that? (Or anyone already started?)
15:53:37 mriedem sdague: gibi's got a +2 on the flavor description api change - https://review.openstack.org/#/c/515213/ - would be cool if you could peruse that, given your familiarity with the spec
15:55:56 openstackgerrit Eric Berglund proposed openstack/nova master: Use NoDBTestCase for powervm driver tests https://review.openstack.org/520118
15:59:19 tasker mriedem: what's the command to merge your changes to the patchset locally?
16:00:00 jaypipes efried: it needs to go at the end of the n-r-p series, but if you want to take that on, I'd be cool with it.
16:00:05 mriedem tasker: like my commit message change?
16:00:11 efried jaypipes Rockin
16:00:34 tasker yeah. minor, but I want to get my code up-to-date with what exists in the review system.
16:01:08 openstackgerrit Matt Riedemann proposed openstack/nova master: unquiesce instance on volume snapshot failure https://review.openstack.org/519464
16:01:08 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add the ability to get absolute limits from Cinder https://review.openstack.org/520122
16:01:55 mriedem tasker: i would normally just delete my local branch and use git review -d 519464 to pull the latest patch set from gerrit
16:05:03 sdague mriedem: I can, after lunch. I have to be out the door in a few minutes, and want to be able to give it a good look over
16:06:12 mriedem wfm, thanks
16:07:21 sdague starred it so I won't forget
16:08:42 openstackgerrit Matt Riedemann proposed openstack/nova stable/newton: Pass requested_destination in filter_properties https://review.openstack.org/516119
16:09:10 openstackgerrit Matt Riedemann proposed openstack/nova stable/newton: Validate new image via scheduler during rebuild https://review.openstack.org/519684
16:10:14 openstackgerrit Matt Riedemann proposed openstack/nova stable/newton: Set group_members when converting to legacy request spec https://review.openstack.org/517868
16:13:41 efried mriedem Is there a novaclient patch for the flavor description thing yet?
16:13:58 mriedem efried: no
16:14:00 mriedem but,
16:14:07 mriedem it's not the first microversion in queens,
16:14:12 mriedem the rebuild + keypair one is, 2.54
16:14:17 mriedem i don't know if there is a patch up for that yet
16:14:33 efried mriedem Okay. Was going through the ol' checklist, and that's the only thing I didn't see covered.
16:14:46 efried mriedem (Obviously it wouldn't be in this patch)
16:14:58 mriedem i'll get to it, but it's lower priority until the actual microversion change happens
16:15:03 mriedem otherwise i just have to keep rebasing it
16:15:09 mriedem https://review.openstack.org/#/q/python-novaclient
16:15:15 mriedem so someone needs to write 2.54 into novaclient
16:15:23 mriedem it'll be me if liu doesn't get to it
16:17:15 mriedem currently working on getting these newton changes out the door so we can eol the branch
16:17:32 mriedem efried: https://review.openstack.org/#/c/520095/ if you didn't see yet
16:24:07 efried mriedem Anal shell style comments added.
16:26:24 efried mriedem Actually found a functional nit too. Recognizing that the tags you're looking for will usually not be the ones with dots in 'em.
16:26:30 efried but still
16:53:56 openstackgerrit Matt Riedemann proposed openstack/nova master: Add the ability to get absolute limits from Cinder https://review.openstack.org/520122
17:11:32 openstackgerrit Eric Fried proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs https://review.openstack.org/519380
17:11:32 openstackgerrit Eric Fried proposed openstack/nova master: Test alloc_cands with one RP shared between two RPs https://review.openstack.org/519617
17:11:33 openstackgerrit Eric Fried proposed openstack/nova master: Test allocation candidates: multiple aggregates https://review.openstack.org/518633
17:11:33 openstackgerrit Eric Fried proposed openstack/nova master: Test helper: validate provider summaries https://review.openstack.org/518982
17:44:42 openstackgerrit Merged openstack/nova stable/pike: libvirt: Don't VIR_MIGRATE_NON_SHARED_INC without migrate_disks https://review.openstack.org/519632
17:48:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Check quota before creating volume snapshots https://review.openstack.org/520158
17:48:44 mriedem tasker: ^
18:05:22 mriedem efried: thanks for the review. i'm not too worried about a . being in an eol tag, since i don't think we have those anywhere, ever, but i can make the changes
18:14:08 tasker mriedem: thanks!
19:01:38 dansmith mriedem: tssurya: should we do a cells meeting today? melwitt is out and I'm on a wild goose chase at the moment
19:01:58 mriedem skip it
19:02:58 dansmith sweet
19:14:23 tssurya_ dansmith : yea let's skip it :D
19:49:30 openstackgerrit Sen Yang proposed openstack/python-novaclient master: Implement hypervisor hostname exact patten match for server cold migrate https://review.openstack.org/520187
20:09:47 mriedem edleafe: sorry it's taken so long but i finally went through https://review.openstack.org/#/c/495854/
20:10:09 mriedem edleafe: i'm mostly concerned about the refactor that went into the filter scheduler code
20:13:02 edleafe mriedem: ok, will read your comments soon
20:24:40 openstackgerrit Matt Riedemann proposed openstack/nova master: Document the real behavior of notify_on_state_change https://review.openstack.org/516264
20:30:21 openstackgerrit Merged openstack/nova master: Remove metadata/system_metadata filter handling from get_all https://review.openstack.org/509819
20:30:28 openstackgerrit Merged openstack/nova master: Fix indent in configuring-migrations.rst https://review.openstack.org/516013
20:34:11 edleafe mriedem: that rebase failure you noted was because this has been sitting for so long that the code changed from under it. I'll rebase the whole series
20:34:58 mriedem yeah that one is an easy fix
20:37:25 edleafe So for the chance scheduler, is it worth adding the cell restriction for the alternates? I mean, does anyone really use that?
20:37:56 mriedem no, not for chance, there is a todo in there from dan about restricting by cell,
20:38:03 mriedem i think if we care about that, we handle the todo later separately
20:38:20 edleafe ok, I'll add a note there.
20:41:56 openstackgerrit Matt Riedemann proposed openstack/nova master: Add a note about versioned notification samples being per-release https://review.openstack.org/520193
20:42:07 openstackgerrit Matt Riedemann proposed openstack/nova master: Add a note about versioned notification samples being per-release https://review.openstack.org/520193
20:48:48 edleafe mriedem: Not sure what the concern about the refactor is. Would it be better to duplicate the code in this patch, and then add a new patch that does the refactor?
20:49:14 sdague mriedem: +A on https://review.openstack.org/#/c/515213/
20:49:47 mriedem sdague: thanks
20:49:58 mriedem edleafe: well, (1) why is the refactor needed?
20:50:15 mriedem because as i said in my comments, the change, per the commit message, is about returning Selection objects from the driver rather than HostState objects
20:50:17 mriedem but this is doing more
20:51:22 mriedem edleafe: in other words, why is _ensure_sufficient_hosts needed? why move that check from select_destinations? is it because by the time we get to select_destinations to validate, we don't have the correct *type* of object?
20:51:28 mriedem i'm guessing host.updated = None is the issue
20:51:36 mriedem because that is for a HostState object, not a Selection object
20:53:27 mriedem edleafe: if _ensure_sufficient_hosts is needed because of $reason_given_by_me_just_now, then i'm requesting that you split that refactor that introduces _ensure_sufficient_hosts into a patch before https://review.openstack.org/#/c/495854/ in the series
20:53:34 mriedem where we're still dealing with HostState objects
20:53:46 mriedem it would just make review easier to know if we are changing any behavior
20:54:47 edleafe mriedem: ok, I'll add a patch before this one.
20:55:08 mriedem cool, thanks
20:55:18 mriedem i think eventually that also allows us to just merge the select_destinations and _schedule methods in the FilterScheduler
20:55:23 mriedem collapse them
20:55:27 mriedem but - later
20:58:38 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix docstring for GET /os-migrations and related DB API https://review.openstack.org/520200
21:16:11 efried jaypipes http://paste.openstack.org/raw/626443/
21:16:41 jaypipes efried: told ya :) big difference.
21:16:46 efried jaypipes ++

Earlier   Later