| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-11-15 | |||
| 16:15:15 | mriedem | so someone needs to write 2.54 into novaclient | |
| 16:15:23 | mriedem | it'll be me if liu doesn't get to it | |
| 16:17:15 | mriedem | currently working on getting these newton changes out the door so we can eol the branch | |
| 16:17:32 | mriedem | efried: https://review.openstack.org/#/c/520095/ if you didn't see yet | |
| 16:24:07 | efried | mriedem Anal shell style comments added. | |
| 16:26:24 | efried | mriedem Actually found a functional nit too. Recognizing that the tags you're looking for will usually not be the ones with dots in 'em. | |
| 16:26:30 | efried | but still | |
| 16:53:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add the ability to get absolute limits from Cinder https://review.openstack.org/520122 | |
| 17:11:32 | openstackgerrit | Eric Fried proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs https://review.openstack.org/519380 | |
| 17:11:32 | openstackgerrit | Eric Fried proposed openstack/nova master: Test alloc_cands with one RP shared between two RPs https://review.openstack.org/519617 | |
| 17:11:33 | openstackgerrit | Eric Fried proposed openstack/nova master: Test allocation candidates: multiple aggregates https://review.openstack.org/518633 | |
| 17:11:33 | openstackgerrit | Eric Fried proposed openstack/nova master: Test helper: validate provider summaries https://review.openstack.org/518982 | |
| 17:44:42 | openstackgerrit | Merged openstack/nova stable/pike: libvirt: Don't VIR_MIGRATE_NON_SHARED_INC without migrate_disks https://review.openstack.org/519632 | |
| 17:48:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Check quota before creating volume snapshots https://review.openstack.org/520158 | |
| 17:48:44 | mriedem | tasker: ^ | |
| 18:05:22 | mriedem | efried: thanks for the review. i'm not too worried about a . being in an eol tag, since i don't think we have those anywhere, ever, but i can make the changes | |
| 18:14:08 | tasker | mriedem: thanks! | |
| 19:01:38 | dansmith | mriedem: tssurya: should we do a cells meeting today? melwitt is out and I'm on a wild goose chase at the moment | |
| 19:01:58 | mriedem | skip it | |
| 19:02:58 | dansmith | sweet | |
| 19:14:23 | tssurya_ | dansmith : yea let's skip it :D | |
| 19:49:30 | openstackgerrit | Sen Yang proposed openstack/python-novaclient master: Implement hypervisor hostname exact patten match for server cold migrate https://review.openstack.org/520187 | |
| 20:09:47 | mriedem | edleafe: sorry it's taken so long but i finally went through https://review.openstack.org/#/c/495854/ | |
| 20:10:09 | mriedem | edleafe: i'm mostly concerned about the refactor that went into the filter scheduler code | |
| 20:13:02 | edleafe | mriedem: ok, will read your comments soon | |
| 20:24:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Document the real behavior of notify_on_state_change https://review.openstack.org/516264 | |
| 20:30:21 | openstackgerrit | Merged openstack/nova master: Remove metadata/system_metadata filter handling from get_all https://review.openstack.org/509819 | |
| 20:30:28 | openstackgerrit | Merged openstack/nova master: Fix indent in configuring-migrations.rst https://review.openstack.org/516013 | |
| 20:34:11 | edleafe | mriedem: that rebase failure you noted was because this has been sitting for so long that the code changed from under it. I'll rebase the whole series | |
| 20:34:58 | mriedem | yeah that one is an easy fix | |
| 20:37:25 | edleafe | So for the chance scheduler, is it worth adding the cell restriction for the alternates? I mean, does anyone really use that? | |
| 20:37:56 | mriedem | no, not for chance, there is a todo in there from dan about restricting by cell, | |
| 20:38:03 | mriedem | i think if we care about that, we handle the todo later separately | |
| 20:38:20 | edleafe | ok, I'll add a note there. | |
| 20:41:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add a note about versioned notification samples being per-release https://review.openstack.org/520193 | |
| 20:42:07 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add a note about versioned notification samples being per-release https://review.openstack.org/520193 | |
| 20:48:48 | edleafe | mriedem: Not sure what the concern about the refactor is. Would it be better to duplicate the code in this patch, and then add a new patch that does the refactor? | |
| 20:49:14 | sdague | mriedem: +A on https://review.openstack.org/#/c/515213/ | |
| 20:49:47 | mriedem | sdague: thanks | |
| 20:49:58 | mriedem | edleafe: well, (1) why is the refactor needed? | |
| 20:50:15 | mriedem | because as i said in my comments, the change, per the commit message, is about returning Selection objects from the driver rather than HostState objects | |
| 20:50:17 | mriedem | but this is doing more | |
| 20:51:22 | mriedem | edleafe: in other words, why is _ensure_sufficient_hosts needed? why move that check from select_destinations? is it because by the time we get to select_destinations to validate, we don't have the correct *type* of object? | |
| 20:51:28 | mriedem | i'm guessing host.updated = None is the issue | |
| 20:51:36 | mriedem | because that is for a HostState object, not a Selection object | |
| 20:53:27 | mriedem | edleafe: if _ensure_sufficient_hosts is needed because of $reason_given_by_me_just_now, then i'm requesting that you split that refactor that introduces _ensure_sufficient_hosts into a patch before https://review.openstack.org/#/c/495854/ in the series | |
| 20:53:34 | mriedem | where we're still dealing with HostState objects | |
| 20:53:46 | mriedem | it would just make review easier to know if we are changing any behavior | |
| 20:54:47 | edleafe | mriedem: ok, I'll add a patch before this one. | |
| 20:55:08 | mriedem | cool, thanks | |
| 20:55:18 | mriedem | i think eventually that also allows us to just merge the select_destinations and _schedule methods in the FilterScheduler | |
| 20:55:23 | mriedem | collapse them | |
| 20:55:27 | mriedem | but - later | |
| 20:58:38 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix docstring for GET /os-migrations and related DB API https://review.openstack.org/520200 | |
| 21:16:11 | efried | jaypipes http://paste.openstack.org/raw/626443/ | |
| 21:16:41 | jaypipes | efried: told ya :) big difference. | |
| 21:16:46 | efried | jaypipes ++ | |
| 21:35:27 | efried | jaypipes Is it your vision that update_inventory be mutually exclusive with get_inventory? That is, if a virt driver implements the former, the latter is ignored? | |
| 21:36:49 | efried | jaypipes I had thought that implementing get_inventory caused get_available_resource to be ignored, but it kinda looks like that's not the case? | |
| 21:37:27 | jaypipes | efried: unfortunately, we need to continue supporting get_available_resource() until all resource classes are handled by placement. | |
| 21:37:42 | jaypipes | efried: it was my vision that update_inventory() would override get_inventory() when present, yes. | |
| 21:37:52 | efried | jaypipes Okay. | |
| 21:41:28 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add migration_get_by_uuid in db api. https://review.openstack.org/511421 | |
| 21:41:29 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904 | |
| 21:41:29 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement query param schema for migration index https://review.openstack.org/518644 | |
| 21:41:30 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Extract SortContext/SortWrapper of instance_list into utils https://review.openstack.org/518871 | |
| 21:41:30 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273 | |
| 21:41:31 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | |
| 22:08:34 | openstackgerrit | Merged openstack/nova master: Trivial grammar fix https://review.openstack.org/517283 | |
| 22:10:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add microversion to allow setting flavor description https://review.openstack.org/515213 | |
| 22:10:59 | mriedem | sdague: ^ i rebased to kick it into the gate, it didn't go through for some reason | |
| 22:17:23 | openstackgerrit | Eric Berglund proposed openstack/nova master: WIP(5): PowerVM driver: ovs vif https://review.openstack.org/422512 | |
| 22:54:55 | eandersson | Is there a reason why this flag is always set to False? https://github.com/openstack/nova/blob/mitaka-eol/nova/virt/driver.py#L1249 | |
| 22:56:14 | eandersson | In certain scenarios when nova-compute fails to schedule it does not clean up the network ports | |
| 22:56:35 | eandersson | e.g. when hitting > qemu-kvm: cannot set up guest memory 'pc.ram': Cannot allocate memory | |
| 22:57:10 | mriedem | eandersson: it's apparently specific to baremetal | |
| 22:57:15 | mriedem | in how it's used anyway | |
| 22:58:19 | mriedem | otherwise i think ports created for an instance will go with the instance and be bound on the next host | |
| 22:58:34 | eandersson | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1880 | |
| 22:58:50 | eandersson | It's used in this code path | |
| 22:59:10 | mriedem | yeah i'm looking at it locally | |
| 22:59:13 | eandersson | and basically if this function is called self._cleanup_allocated_networks | |
| 22:59:17 | eandersson | it will clean it up properly | |
| 22:59:33 | mriedem | what do you actually need cleaned up before the reschedule? | |
| 22:59:48 | mriedem | the ports should not be bound to that host at that point | |
| 22:59:56 | eandersson | Well the problem we are hitting is that each time it gets re-scheduled, a new ip is assigned | |
| 23:00:03 | mriedem | is a new port created? | |
| 23:00:08 | eandersson | Yea | |
| 23:00:15 | mriedem | ok, that's a problem, and i think an old one | |
| 23:00:29 | mriedem | i'm sure i could find some bugs if i dug for a bit | |
| 23:00:49 | eandersson | I am reproducing it with this http://paste.openstack.org/show/626450/ | |
| 23:00:55 | mriedem | https://bugs.launchpad.net/nova/+bug/1703540 | |
| 23:00:55 | openstack | Launchpad bug 1703540 in OpenStack Compute (nova) "Reschedule with libvirt exception leaves dangling neutron ports" [High,Triaged] | |
| 23:01:08 | mriedem | https://bugs.launchpad.net/nova/+bug/1531022 | |
| 23:01:09 | openstack | Launchpad bug 1531022 in OpenStack Compute (nova) "libvirt driver doesn't cleanup the tap interface on vm re-schedule" [Low,Confirmed] | |
| 23:01:24 | eandersson | oh not sure why I didn't find that one | |
| 23:01:59 | mriedem | yeah see comment #3 on https://bugs.launchpad.net/nova/+bug/1703540 | |
| 23:02:00 | openstack | Launchpad bug 1703540 in OpenStack Compute (nova) "Reschedule with libvirt exception leaves dangling neutron ports" [High,Triaged] | |
| 23:02:23 | eandersson | Yep - perfect | |
| 23:02:31 | eandersson | that is the exact same conclusion I came to | |