Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-11-15
06:12:40 openstackgerrit Yikun Jiang proposed openstack/nova master: [WIP] Add pagination and changes-since for instance-actions https://review.openstack.org/326326
07:05:45 alex_xu gmann: are you around?
07:09:59 openstackgerrit Spencer Yu proposed openstack/nova master: Use defusedxml.ElementTree function instead of lxml.etree https://review.openstack.org/519291
07:27:45 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Add a description of 'key_name' in rebuild https://review.openstack.org/519993
07:35:17 openstackgerrit Li Yingjun proposed openstack/nova master: Versioned notifications for service create and delete https://review.openstack.org/519588
07:44:02 openstackgerrit Alex Xu proposed openstack/nova master: Remove the objects which related to the old v2 API implementation https://review.openstack.org/519997
07:44:03 openstackgerrit Alex Xu proposed openstack/nova master: Remove the objects for describing the extension for v2.1 API https://review.openstack.org/519998
07:45:21 openstackgerrit Xuanzhou Perry Dong proposed openstack/python-novaclient master: Check for volume size https://review.openstack.org/519999
08:06:29 openstackgerrit licanwei proposed openstack/nova master: cli 'nova-manage db sync' can't upgrade cell1 https://review.openstack.org/519275
08:56:32 openstackgerrit Spencer Yu proposed openstack/nova master: Use subprocess securely https://review.openstack.org/520013
09:16:25 openstackgerrit Spencer Yu proposed openstack/nova master: Use defusedxml.ElementTree function instead of lxml.etree https://review.openstack.org/519291
09:37:54 openstackgerrit Maciej Jozefczyk proposed openstack/nova master: Update compute resources only once per update_available_resource() call https://review.openstack.org/520024
09:41:55 openstackgerrit Maciej Jozefczyk proposed openstack/nova master: Update resources once in update_available_resource https://review.openstack.org/520024
09:45:59 openstackgerrit Maciej Jozefczyk proposed openstack/nova master: Update resources once in update_available_resource https://review.openstack.org/520024
09:47:31 maciejjozefczyk mriedem: thats what we talked about earlier, https://review.openstack.org/#/c/520024
11:40:22 openstackgerrit Merged openstack/nova stable/pike: libvirt: bandwidth param should be set in guest migrate https://review.openstack.org/519631
13:08:31 efried alex_xu yt?
13:11:30 alex_xu efried: yea
13:12:03 efried alex_xu Are you okay with https://review.openstack.org/#/c/516778/ at this point?
13:12:29 efried alex_xu We really need to get this series moving.
13:13:14 efried alex_xu We can do the sql refactor in a subsequent patch - I'd like to start doing those on the top of the series, since the extra tests will help flush out bugs.
13:13:46 alex_xu efried: i'm ok with sql refactor later
13:14:08 efried alex_xu I removed the comment and the code block that it referenced - seemed to have no effect anyway.
13:16:58 alex_xu efried: i'm not sure we should remove that check
13:17:19 alex_xu efried: that check can return faster when there is nothing return from the query
13:17:22 alex_xu right?
13:17:38 efried alex_xu But we actually *want* to support scenarios where we get resources from only sharing RPs.
13:18:11 alex_xu efried: yes, but that check is also usefull for fast return?
13:18:32 efried I don't know
13:18:45 efried AFAICT the code *ought* to be doing what the comment said, which is something we don't want. Putting it in is not having the desired effect.
13:20:53 alex_xu efried: emm..., I think we should have check like "if not all_rp_ids: return [], []"
13:21:16 alex_xu efried: I think I agree that check should be removed, that isn't totally for fast return
13:24:31 efried alex_xu Where `all_rp_ids` is set(sharing_providers) | non_sharing_rp_ids ?
13:24:48 efried alex_xu Oh, never mind, I see it defined below.
13:26:20 alex_xu efried: https://review.openstack.org/#/c/516778/9/nova/objects/resource_provider.py@2616
13:26:57 alex_xu the last word "this is the list of resource provider IDs that are NOT sharing resource" doesn't sound true also
13:27:31 efried alex_xu How so?
13:27:48 alex_xu if only request shared resources, "non_sharing_rp_ids" includes the RPs with that shared resources
13:28:16 efried Is that why we're passing those test cases when we don't expect to be? :)
13:28:26 alex_xu efried: yes
13:29:02 efried alex_xu I don't think that's for lack of trying. Looking at the if/else above, that comment *should* be true.
13:29:09 alex_xu efried: how about append a word to say "non_sharing_rp_ids" also includes the shared rp when there only request shared resource?
13:29:27 efried alex_xu If that were the case, we would want to rename that variable.
13:29:40 alex_xu efried: yea :(
13:30:01 alex_xu non_sharing_rp_ids_but_some_time_not
13:31:26 efried alex_xu The bug must be in one of the helpers - one or both of the following must be true: 1) _get_providers_with_shared_capacity is returning non-sharing RPs; 2) _get_all_with_shared is returning sharing RPs.
13:32:08 alex_xu yes
13:32:19 efried alex_xu I'll go write some functional tests to hit just those helpers and see which is the case. Thanks for talking through it with me.
13:32:42 alex_xu efried: cool
13:35:02 efried alex_xu How about this series? https://review.openstack.org/#/c/377138/
13:36:02 alex_xu efried: I will try to review that seriews tomorrow
13:36:12 efried alex_xu Okay, thanks.
13:36:16 alex_xu efried: np
13:36:26 alex_xu efried: the next is holiday in US?
13:36:32 alex_xu sorry, next week
13:43:34 efried alex_xu Yes. Next Thursday (and many folks get Friday as well).
13:52:24 efried alex_xu _get_providers_with_shared_capacity appears to be okay.
13:53:27 alex_xu efried: what means okay?
13:53:49 efried alex_xu It's working as expected. There was a hole in the test case, but when I fixed it, the test still passed. So I think it's doing what it's supposed to.
13:55:53 efried alex_xu I also just looked over the test case for _get_all_with_shared and I'm convinced it's okay too.
13:56:26 efried alex_xu How else could we be getting sharing RPs in that var?
13:59:41 alex_xu efried: I don't another case to getting sharing rps in that var
14:00:53 efried alex_xu So how would you like to proceed? We know we have bugs in the stack; are we going to try to fix them in the series, or start merging code and attack them after?
14:11:59 alex_xu efried: which bug you reference?
14:12:25 efried alex_xu There are several. All the test patches on the top of this series.
14:12:36 efried alex_xu The good news is that *somewhere* in the series, we've fixed some of them.
14:13:03 efried At this point I think we have two main ones: One where we're getting candidates that cross aggregates; and one where we're getting duplicate candidates returned.
14:14:13 openstackgerrit Eric Fried proposed openstack/nova master: begin refactor AllocCandidates._get_by_filters() https://review.openstack.org/516778
14:14:14 openstackgerrit Eric Fried proposed openstack/nova master: build ProviderSummary objects in sep function https://review.openstack.org/516779
14:14:15 openstackgerrit Eric Fried proposed openstack/nova master: build alloc request resources for shared resources https://review.openstack.org/516780
14:14:15 openstackgerrit Eric Fried proposed openstack/nova master: create allocation request for single provider https://review.openstack.org/516781
14:14:16 openstackgerrit Eric Fried proposed openstack/nova master: finish refactor AllocCandidates._get_by_filters() https://review.openstack.org/516782
14:14:16 openstackgerrit Eric Fried proposed openstack/nova master: required traits for no sharing providers https://review.openstack.org/517027
14:14:17 openstackgerrit Eric Fried proposed openstack/nova master: Add ProviderSummary.resource_class_names @property https://review.openstack.org/517646
14:14:17 openstackgerrit Eric Fried proposed openstack/nova master: handle traits with sharing providers https://review.openstack.org/517119
14:14:18 openstackgerrit Eric Fried proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs https://review.openstack.org/519380
14:14:18 openstackgerrit Eric Fried proposed openstack/nova master: Test alloc_cands with one RP shared between two RPs https://review.openstack.org/519617
14:14:18 alex_xu efried: probably we should guarantee the basic use-case works first
14:14:19 openstackgerrit Eric Fried proposed openstack/nova master: Test allocation candidates: multiple aggregates https://review.openstack.org/518633
14:14:19 openstackgerrit Eric Fried proposed openstack/nova master: Test helper: validate provider summaries https://review.openstack.org/518982
14:14:34 efried alex_xu Here it is with that extra short-circuit you suggested, and the enhanced test case, and test fixes for the middle of the series. ^
14:14:45 efried alex_xu Depends what you mean by "basic" :)
14:14:59 alex_xu efried: something like, compute node have local and shared storage at sometime, actually doesn't support by the nova
14:15:25 efried alex_xu Right, at the moment we don't even claim support for shared RPs at all.
14:15:26 alex_xu s/sometime/sametime/
14:15:33 alex_xu efried: yea
14:16:15 efried alex_xu Taking that out of the picture - essentially just talking about compute-node-as-single-RP - I believe the code is working as expected.
14:16:33 efried jaypipes Good morning. Hope you didn't have local changes to any of your patches :)
14:17:06 jaypipes efried: no, had to take the afternoon off yesterday to deal with some family stuff. apologies.
14:17:25 efried jaypipes No worries, just happy I didn't step on your work. Hope everything is okay.
14:28:51 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Change 'InstancePCIRequest' spec field https://review.openstack.org/449257
14:30:09 openstackgerrit Balazs Gibizer proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs https://review.openstack.org/519601
14:33:57 efried gibi Thanks ^ - I wasn't positive where that guy should sit in the pile (though I don't suppose it mattered much).
14:36:26 gibi efried: I think it is OK at the end
14:36:32 efried nod
14:43:03 mriedem tonyb: yeah i see ianw's -1, so i guess i'll take a look at changing devstack-gate today instead
14:49:08 openstackgerrit Merged openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/519806
14:57:30 openstackgerrit Matt Riedemann proposed openstack/nova stable/newton: Correct log message when removing a security group https://review.openstack.org/519586
15:11:17 mriedem tasker: oh hi
15:13:08 tasker 'allo.

Earlier   Later