Posted	Nick	Remark
#openstack-nova - 2017-11-15
01:27:15	openstackgerrit	Merged openstack/nova master: Modify incorrect debug meaasge in _inject_data https://review.openstack.org/517227
01:29:04	openstackgerrit	OpenStack Proposal Bot proposed openstack/os-vif stable/pike: Updated from global requirements https://review.openstack.org/493146
01:39:42	mriedem	tonyb: damn
01:39:43	mriedem	http://logs.openstack.org/58/519758/6/check/legacy-tempest-dsvm-neutron-full/8dd27b1/logs/devstacklog.txt.gz#_2017-11-15_00_40_53_489
01:39:47	mriedem	http://logs.openstack.org/58/519758/6/check/legacy-tempest-dsvm-neutron-full/8dd27b1/logs/devstacklog.txt.gz#_2017-11-15_00_40_53_489
01:39:50	mriedem	oops
01:39:56	mriedem	fatal: No such remote 'origin'
01:40:23	mriedem	wth, why is it pointing at keystone?
01:40:53	mriedem	oh because it's keystone :)
01:40:57	mriedem	which is now newton-eol
01:42:13	mriedem	i wonder if i should just punt and do git checkout $eol_tag
01:47:46	mriedem	git remote add origin $remote might work
01:47:56	mriedem	i copied from the reclone block, but in this case we're not doing a reclone
01:48:09	openstackgerrit	OpenStack Proposal Bot proposed openstack/os-vif stable/pike: Updated from global requirements https://review.openstack.org/493146
01:53:35	openstackgerrit	OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/519806
02:06:26	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add microversion to allow setting flavor description https://review.openstack.org/515213
02:12:13	tonyb	I don't get why git_update_tag $eol_tag was wrong that works for me
02:14:20	openstackgerrit	Matt Riedemann proposed openstack/nova master: Fix the formatting for the 2.54 microversion REST API version history https://review.openstack.org/519940
02:14:36	tonyb	mriedem: Ahh now I see. I think you just want git checkout -f $eol_tag
02:14:45	mriedem	see the latest version
02:14:57	mriedem	i was copying from the reclone block but i don't think that's what i want
02:15:15	mriedem	i'm honestly not sure how the /opt/stack/new/keystone directory gets created, unless zuulv3 does that here:
02:15:15	mriedem	http://logs.openstack.org/58/519758/6/check/legacy-tempest-dsvm-neutron-full/8dd27b1/job-output.txt.gz#_2017-11-15_00_33_31_611200
02:15:33	mriedem	if that's the case, then i don't need to git clone/pull/fetch at all, i can just check if the tag is in the repo and check it out if so
02:16:12	tonyb	Yeah but PS 8 is doing git checkout $git_ref which is stable/newton IIUC
02:16:19	mriedem	oh gdi
02:16:25	mriedem	copy/paste
02:16:30	tonyb	okay
02:16:51	mriedem	fixed
02:23:04	openstackgerrit	Matt Riedemann proposed openstack/nova stable/pike: Don't update RT in _allocate_network https://review.openstack.org/519942
02:23:22	openstackgerrit	Matt Riedemann proposed openstack/nova stable/ocata: Don't update RT in _allocate_network https://review.openstack.org/519943
02:31:14	openstackgerrit	Matt Riedemann proposed openstack/nova master: unquiesce instance on volume snapshot failure https://review.openstack.org/519464
02:47:49	openstackgerrit	guanzuoyu proposed openstack/nova stable/ocata: Modify incorrect debug meaasge in _inject_data https://review.openstack.org/519950
02:48:33	openstackgerrit	guanzuoyu proposed openstack/nova stable/pike: Modify incorrect debug meaasge in _inject_data https://review.openstack.org/519951
02:59:08	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.55 - List/Show all server migration types https://review.openstack.org/430839
03:05:11	openstackgerrit	Li Yingjun proposed openstack/nova master: Versioned notifications for service create and delete https://review.openstack.org/519588
03:34:48	openstackgerrit	Jianghua Wang proposed openstack/nova master: vgpu: add enabled white list https://review.openstack.org/512580
03:34:48	openstackgerrit	Jianghua Wang proposed openstack/nova master: XenAPI: get vGPU stats from hypervisor https://review.openstack.org/512965
03:40:49	mriedem	tonyb: ok i think 9th time is the charm
03:40:59	mriedem	tempest is running so it got through stack.sh
04:09:53	openstackgerrit	Yikun Jiang proposed openstack/nova master: [WIP] Add pagination and changes-since for instance-actions https://review.openstack.org/326326
04:11:13	openstackgerrit	Jianghua Wang proposed openstack/nova master: XenAPI: get vGPU stats from hypervisor https://review.openstack.org/512965
04:11:13	openstackgerrit	Jianghua Wang proposed openstack/nova master: XenAPI: provide vGPU inventory in compute node https://review.openstack.org/516217
04:11:14	openstackgerrit	Jianghua Wang proposed openstack/nova master: XenAPI: create vGPU for instance https://review.openstack.org/516899
04:12:38	tonyb	mriedem: yeah I'm watching in the background
04:22:49	mriedem	tonyb: alright, i'm going to bed,
04:22:59	mriedem	i guess either push things through or i'll take a look in the morning
04:23:15	mriedem	https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/newton
04:23:24	mriedem	https://review.openstack.org/#/c/516119/ has to be re-approved
06:05:31	tonyb	mriedem, dansmith: everything is baacked up behind the devstack change :(
06:12:02	openstackgerrit	Yikun Jiang proposed openstack/nova master: Update Instance action's updated_at when action event updated. https://review.openstack.org/507473
06:12:40	openstackgerrit	Yikun Jiang proposed openstack/nova master: [WIP] Add pagination and changes-since for instance-actions https://review.openstack.org/326326
07:05:45	alex_xu	gmann: are you around?
07:09:59	openstackgerrit	Spencer Yu proposed openstack/nova master: Use defusedxml.ElementTree function instead of lxml.etree https://review.openstack.org/519291
07:27:45	openstackgerrit	Takashi NATSUME proposed openstack/nova master: api-ref: Add a description of 'key_name' in rebuild https://review.openstack.org/519993
07:35:17	openstackgerrit	Li Yingjun proposed openstack/nova master: Versioned notifications for service create and delete https://review.openstack.org/519588
07:44:02	openstackgerrit	Alex Xu proposed openstack/nova master: Remove the objects which related to the old v2 API implementation https://review.openstack.org/519997
07:44:03	openstackgerrit	Alex Xu proposed openstack/nova master: Remove the objects for describing the extension for v2.1 API https://review.openstack.org/519998
07:45:21	openstackgerrit	Xuanzhou Perry Dong proposed openstack/python-novaclient master: Check for volume size https://review.openstack.org/519999
08:06:29	openstackgerrit	licanwei proposed openstack/nova master: cli 'nova-manage db sync' can't upgrade cell1 https://review.openstack.org/519275
08:56:32	openstackgerrit	Spencer Yu proposed openstack/nova master: Use subprocess securely https://review.openstack.org/520013
09:16:25	openstackgerrit	Spencer Yu proposed openstack/nova master: Use defusedxml.ElementTree function instead of lxml.etree https://review.openstack.org/519291
09:37:54	openstackgerrit	Maciej Jozefczyk proposed openstack/nova master: Update compute resources only once per update_available_resource() call https://review.openstack.org/520024
09:41:55	openstackgerrit	Maciej Jozefczyk proposed openstack/nova master: Update resources once in update_available_resource https://review.openstack.org/520024
09:45:59	openstackgerrit	Maciej Jozefczyk proposed openstack/nova master: Update resources once in update_available_resource https://review.openstack.org/520024
09:47:31	maciejjozefczyk	mriedem: thats what we talked about earlier, https://review.openstack.org/#/c/520024
11:40:22	openstackgerrit	Merged openstack/nova stable/pike: libvirt: bandwidth param should be set in guest migrate https://review.openstack.org/519631
13:08:31	efried	alex_xu yt?
13:11:30	alex_xu	efried: yea
13:12:03	efried	alex_xu Are you okay with https://review.openstack.org/#/c/516778/ at this point?
13:12:29	efried	alex_xu We really need to get this series moving.
13:13:14	efried	alex_xu We can do the sql refactor in a subsequent patch - I'd like to start doing those on the top of the series, since the extra tests will help flush out bugs.
13:13:46	alex_xu	efried: i'm ok with sql refactor later
13:14:08	efried	alex_xu I removed the comment and the code block that it referenced - seemed to have no effect anyway.
13:16:58	alex_xu	efried: i'm not sure we should remove that check
13:17:19	alex_xu	efried: that check can return faster when there is nothing return from the query
13:17:22	alex_xu	right?
13:17:38	efried	alex_xu But we actually *want* to support scenarios where we get resources from only sharing RPs.
13:18:11	alex_xu	efried: yes, but that check is also usefull for fast return?
13:18:32	efried	I don't know
13:18:45	efried	AFAICT the code *ought* to be doing what the comment said, which is something we don't want. Putting it in is not having the desired effect.
13:20:53	alex_xu	efried: emm..., I think we should have check like "if not all_rp_ids: return [], []"
13:21:16	alex_xu	efried: I think I agree that check should be removed, that isn't totally for fast return
13:24:31	efried	alex_xu Where `all_rp_ids` is set(sharing_providers) | non_sharing_rp_ids ?
13:24:48	efried	alex_xu Oh, never mind, I see it defined below.
13:26:20	alex_xu	efried: https://review.openstack.org/#/c/516778/9/nova/objects/resource_provider.py@2616
13:26:57	alex_xu	the last word "this is the list of resource provider IDs that are NOT sharing resource" doesn't sound true also
13:27:31	efried	alex_xu How so?
13:27:48	alex_xu	if only request shared resources, "non_sharing_rp_ids" includes the RPs with that shared resources
13:28:16	efried	Is that why we're passing those test cases when we don't expect to be? :)
13:28:26	alex_xu	efried: yes
13:29:02	efried	alex_xu I don't think that's for lack of trying. Looking at the if/else above, that comment *should* be true.
13:29:09	alex_xu	efried: how about append a word to say "non_sharing_rp_ids" also includes the shared rp when there only request shared resource?
13:29:27	efried	alex_xu If that were the case, we would want to rename that variable.
13:29:40	alex_xu	efried: yea :(
13:30:01	alex_xu	non_sharing_rp_ids_but_some_time_not
13:31:26	efried	alex_xu The bug must be in one of the helpers - one or both of the following must be true: 1) _get_providers_with_shared_capacity is returning non-sharing RPs; 2) _get_all_with_shared is returning sharing RPs.
13:32:08	alex_xu	yes
13:32:19	efried	alex_xu I'll go write some functional tests to hit just those helpers and see which is the case. Thanks for talking through it with me.
13:32:42	alex_xu	efried: cool

Earlier   Later