Posted	Nick	Remark
#openstack-nova - 2017-11-02
18:37:27	mriedem	easy fix https://review.openstack.org/#/c/511459/
18:54:42	melwitt	mriedem: I noticed there are several other places in the file (in log calls) where the exception message isn't converted to unicode. is that because the log statement won't raise in that case? and the more important thing are the ones that are messages in exceptions we'll raise?
18:58:31	mriedem	not sure, i thought six.text_type(ex) handled a lot of this for us,
18:58:37	mriedem	but might have been a different type of error
18:58:59	melwitt	oh, does LOG.x do text_type() underneath?
18:59:12	mriedem	no
18:59:26	openstackgerrit	Merged openstack/nova master: Implement power_off/power_on for the FakeDriver https://review.openstack.org/509935
19:00:27	mriedem	melwitt: e.g. https://github.com/openstack/nova/commit/73fcf4628089dd784889062e916b80d3fc9988a2#diff-d362bac3c354dd65e061ca91a8d1e14e
19:01:10	melwitt	k. just curious
19:01:12	mriedem	so might just be a case where we used to cast things using str()
19:01:26	mriedem	which makes me nervous about https://github.com/openstack/nova/commit/8fa97d91c005147cd3eba7c6f03136ade84ba46d#diff-d362bac3c354dd65e061ca91a8d1e14e
19:02:07	mriedem	which landed in queens, which means no one in asia has probably tried testing with that yet
19:03:21	mriedem	heh, i guess that was in the run up to https://review.openstack.org/#/c/507202/
19:03:28	mriedem	but i don't see how it's related
19:04:36	melwitt	oh, this part huh https://github.com/openstack/nova/commit/8fa97d91c005147cd3eba7c6f03136ade84ba46d#diff-ec64afccc111bbe81f5c85b27d73b41bR652 should be a to_unicode call?
19:05:03	melwitt	er, the comment says should not be unicode. I guess only if it's a name or such
19:05:49	mriedem	idk, i don't speak unicode
19:09:11	mriedem	edleafe: http status code question
19:09:59	mriedem	here is the scenario:
19:10:10	mriedem	admin tries to migrate/evacuate an instance with a specified destination host,
19:10:32	mriedem	for the dest host machinery to work, we need to put it into the *existing* request spec for the instance and pass that through api->conductor->scheduler
19:11:13	mriedem	we have some compat code from newton where if the instance request spec isn't found, we silently create one (without the requested dest host) and pass it to the scheduler, and you might accidentally migrate the instance to what you specified, but it's definitely not intentional
19:11:45	mriedem	so, if i were going to change that "if not request_spec: create one and fake it" thing to be a hard error in the API, is that a 400 response? i don't think 409 is correct because the user can't fix it.
19:20:32	openstackgerrit	Eric Berglund proposed openstack/nova master: PowerVM Driver: config drive https://review.openstack.org/409404
19:21:05	edleafe	mriedem: so it wouldn't matter which host they specified?
19:21:13	edleafe	mriedem: if not, then yeah, 400
19:22:29	mriedem	right, request 1 with host: 400: we don't have a request spec to do this, request 2 w/o host: cool, we pick a host for you as before
19:22:54	mriedem	the 400 would have to say something about not being able to support migrating with a target host
19:22:59	mriedem	as a hint you need to remove the host and retry
19:23:55	openstackgerrit	Eric Berglund proposed openstack/nova master: PowerVM Driver: config drive https://review.openstack.org/409404
19:25:35	openstackgerrit	Merged openstack/nova master: Add 'done' to migration_get_in_progress_by_host_and_node filter https://review.openstack.org/511351
19:25:59	edleafe	Oh, so it *would* succeed if they modify the request
19:26:30	mriedem	yeah, is that a 409 then?
19:26:34	edleafe	Then I would go with the 409, with an explanation about not supporting a target host for that instance
19:26:38	mriedem	409: can't migrate with a target host
19:26:42	mriedem	ok
19:27:21	edleafe	Yeah, 400 usually means that the client request is malformed or otherwise invalid
19:29:09	mriedem	bauzas: have we ever consider *not* persistent RequestSpec.requested_destination()
19:29:18	mriedem	since that seems to be a per-request kind of thing only for move operatoins
19:30:44	mriedem	or, we should null out reqspec.requested_destination.host/node in reset_forced_destinations
19:31:54	openstackgerrit	OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
19:40:37	openstackgerrit	OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
20:33:24	openstackgerrit	Eric Fried proposed openstack/nova master: placement: Parse granular resources & traits https://review.openstack.org/514091
20:33:25	openstackgerrit	Eric Fried proposed openstack/nova master: WIP: Numbered groupings to GET /allocation_candidates https://review.openstack.org/514092
20:33:36	efried	jaypipes Placement side ^
20:45:42	openstackgerrit	Merged openstack/nova master: libvirt: properly decode error message from qemu guest agent https://review.openstack.org/511459
20:53:35	openstackgerrit	Eric Fried proposed openstack/nova master: Parse granular resources/traits from extra_specs https://review.openstack.org/515151
20:53:35	openstackgerrit	Eric Fried proposed openstack/nova master: Granularize resources_from_{flavor|request_spec} https://review.openstack.org/515223
20:53:36	openstackgerrit	Eric Fried proposed openstack/nova master: ResourceRequest.to_querystring() https://review.openstack.org/515811
20:53:43	efried	jaypipes Scheduler side ^
20:58:37	mnaser	darn
20:58:43	mnaser	another cell v2 quirk
20:59:03	mnaser	we have a few instances that started to get cell_id=NULL assigned in mappings
20:59:19	mnaser	but they exist in the cell with status=error
20:59:40	mnaser	so they appear in lists but cannot be retrieved
21:00:12	melwitt	mnaser: are they instances that failed to schedule? if so, they are indeed not assigned to a cell, but are inside the cell0 database
21:00:50	mnaser	melwitt: but i believe they should at least be delete-able or i should be able to query them
21:00:56	mnaser	its doing that thing where it returns 404 when you get it
21:01:02	mnaser	im digging logs
21:01:35	melwitt	oh, hm, yeah they are supposed to be deletable and should 'nova show' something
21:02:37	mnaser	hmm
21:02:47	mnaser	i wonder if this was the bug we caught last time and we have a controller thats out of date
21:03:38	mnaser	2017-11-01 00:01:07.889 831 WARNING nova.scheduler.utils [req-0341b51e-123e-4124-87d0-dbf0329756cb abbd3bf716b246a5852723c2b4f71cb3 f0026af631194452acc2ba29da931ced - default default] [instance: 216219aa-95cd-47c4-ab43-d3d943d73cbd] Setting instance to ERROR state.: TooManyInstances: Quota exceeded for cores: Requested 4, but already used 20 of 20 cores
21:04:04	mnaser	yeah.. this controller is out of date, im pretty sure thats the same bug we ran into last time
21:04:11	mnaser	openstack-nova-api-16.0.0-1.el7.noarch
21:04:13	mnaser	sorry for the noise :(
21:04:38	melwitt	no worries, glad it's not a new bug :)
21:04:52	mnaser	:D thanks for your help melwitt
21:37:32	openstackgerrit	Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/516707
21:37:32	openstackgerrit	Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357
21:37:33	openstackgerrit	Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358
23:21:54	openstackgerrit	OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
#openstack-nova - 2017-11-03
00:56:30	openstackgerrit	OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/517489
01:02:16	openstackgerrit	OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
01:10:43	openstackgerrit	OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/517489
01:22:50	openstackgerrit	OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
02:16:36	openstackgerrit	Moshe Levi proposed openstack/nova master: Don't overwrite binding-profile https://review.openstack.org/505613
02:32:53	openstackgerrit	Yikun Jiang proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904
02:35:11	openstackgerrit	Michael Still proposed openstack/nova master: Convert ext filesystem resizes to privsep. https://review.openstack.org/517516
02:40:19	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach/swap volumes https://review.openstack.org/517205
02:54:42	openstackgerrit	Yikun Jiang proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904
02:59:04	openstackgerrit	Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
03:26:55	openstackgerrit	Yikun Jiang proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904
03:27:46	openstackgerrit	Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
03:46:11	openstackgerrit	Yikun Jiang proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904
03:50:14	openstackgerrit	Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
06:17:10	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach/swap volumes https://review.openstack.org/517205
06:54:20	openstackgerrit	Chen Hanxiao proposed openstack/nova master: libvirt: do unicode conversion for error messages. https://review.openstack.org/517555
09:33:12	openstackgerrit	Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
09:36:14	openstackgerrit	Matthew Booth proposed openstack/nova master: libvirt: Don't VIR_MIGRATE_NON_SHARED_INC without migrate_disks https://review.openstack.org/507202
09:41:19	openstackgerrit	Jianghua Wang proposed openstack/nova master: XenAPI: create vGPU for instance https://review.openstack.org/516899
09:43:21	openstackgerrit	Rong Han proposed openstack/nova master: Fixed the known vcpuset description of CPUPinningUnknown https://review.openstack.org/517592
09:51:42	tomsou_	openstack: ping
11:01:25	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data https://review.openstack.org/452818
11:01:25	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (2) https://review.openstack.org/452819
11:01:26	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Deduplicated instance.(un)pause notification samples https://review.openstack.org/452820
11:01:26	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Deduplicate instance.power-off notification samples https://review.openstack.org/475860
11:01:27	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Deduplicate instance.interface_attach samples https://review.openstack.org/515740
11:01:27	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Deduplicate instance.live_migration notification samples https://review.openstack.org/515745
11:01:28	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Deduplicate instance.reboot notification samples https://review.openstack.org/515751

Earlier   Later