Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-11-02
19:09:59 mriedem here is the scenario:
19:10:10 mriedem admin tries to migrate/evacuate an instance with a specified destination host,
19:10:32 mriedem for the dest host machinery to work, we need to put it into the *existing* request spec for the instance and pass that through api->conductor->scheduler
19:11:13 mriedem we have some compat code from newton where if the instance request spec isn't found, we silently create one (without the requested dest host) and pass it to the scheduler, and you might accidentally migrate the instance to what you specified, but it's definitely not intentional
19:11:45 mriedem so, if i were going to change that "if not request_spec: create one and fake it" thing to be a hard error in the API, is that a 400 response? i don't think 409 is correct because the user can't fix it.
19:20:32 openstackgerrit Eric Berglund proposed openstack/nova master: PowerVM Driver: config drive https://review.openstack.org/409404
19:21:05 edleafe mriedem: so it wouldn't matter which host they specified?
19:21:13 edleafe mriedem: if not, then yeah, 400
19:22:29 mriedem right, request 1 with host: 400: we don't have a request spec to do this, request 2 w/o host: cool, we pick a host for you as before
19:22:54 mriedem the 400 would have to say something about not being able to support migrating with a target host
19:22:59 mriedem as a hint you need to remove the host and retry
19:23:55 openstackgerrit Eric Berglund proposed openstack/nova master: PowerVM Driver: config drive https://review.openstack.org/409404
19:25:35 openstackgerrit Merged openstack/nova master: Add 'done' to migration_get_in_progress_by_host_and_node filter https://review.openstack.org/511351
19:25:59 edleafe Oh, so it *would* succeed if they modify the request
19:26:30 mriedem yeah, is that a 409 then?
19:26:34 edleafe Then I would go with the 409, with an explanation about not supporting a target host for that instance
19:26:38 mriedem 409: can't migrate with a target host
19:26:42 mriedem ok
19:27:21 edleafe Yeah, 400 usually means that the client request is malformed or otherwise invalid
19:29:09 mriedem bauzas: have we ever consider *not* persistent RequestSpec.requested_destination()
19:29:18 mriedem since that seems to be a per-request kind of thing only for move operatoins
19:30:44 mriedem or, we should null out reqspec.requested_destination.host/node in reset_forced_destinations
19:31:54 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
19:40:37 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
20:33:24 openstackgerrit Eric Fried proposed openstack/nova master: placement: Parse granular resources & traits https://review.openstack.org/514091
20:33:25 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Numbered groupings to GET /allocation_candidates https://review.openstack.org/514092
20:33:36 efried jaypipes Placement side ^
20:45:42 openstackgerrit Merged openstack/nova master: libvirt: properly decode error message from qemu guest agent https://review.openstack.org/511459
20:53:35 openstackgerrit Eric Fried proposed openstack/nova master: Parse granular resources/traits from extra_specs https://review.openstack.org/515151
20:53:35 openstackgerrit Eric Fried proposed openstack/nova master: Granularize resources_from_{flavor|request_spec} https://review.openstack.org/515223
20:53:36 openstackgerrit Eric Fried proposed openstack/nova master: ResourceRequest.to_querystring() https://review.openstack.org/515811
20:53:43 efried jaypipes Scheduler side ^
20:58:37 mnaser darn
20:58:43 mnaser another cell v2 quirk
20:59:03 mnaser we have a few instances that started to get cell_id=NULL assigned in mappings
20:59:19 mnaser but they exist in the cell with status=error
20:59:40 mnaser so they appear in lists but cannot be retrieved
21:00:12 melwitt mnaser: are they instances that failed to schedule? if so, they are indeed not assigned to a cell, but are inside the cell0 database
21:00:50 mnaser melwitt: but i believe they should at least be delete-able or i should be able to query them
21:00:56 mnaser its doing that thing where it returns 404 when you get it
21:01:02 mnaser im digging logs
21:01:35 melwitt oh, hm, yeah they are supposed to be deletable and should 'nova show' something
21:02:37 mnaser hmm
21:02:47 mnaser i wonder if this was the bug we caught last time and we have a controller thats out of date
21:03:38 mnaser 2017-11-01 00:01:07.889 831 WARNING nova.scheduler.utils [req-0341b51e-123e-4124-87d0-dbf0329756cb abbd3bf716b246a5852723c2b4f71cb3 f0026af631194452acc2ba29da931ced - default default] [instance: 216219aa-95cd-47c4-ab43-d3d943d73cbd] Setting instance to ERROR state.: TooManyInstances: Quota exceeded for cores: Requested 4, but already used 20 of 20 cores
21:04:04 mnaser yeah.. this controller is out of date, im pretty sure thats the same bug we ran into last time
21:04:11 mnaser openstack-nova-api-16.0.0-1.el7.noarch
21:04:13 mnaser sorry for the noise :(
21:04:38 melwitt no worries, glad it's not a new bug :)
21:04:52 mnaser :D thanks for your help melwitt
21:37:32 openstackgerrit Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/516707
21:37:32 openstackgerrit Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357
21:37:33 openstackgerrit Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358
23:21:54 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
#openstack-nova - 2017-11-03
00:56:30 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/517489
01:02:16 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
01:10:43 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/517489
01:22:50 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
02:16:36 openstackgerrit Moshe Levi proposed openstack/nova master: Don't overwrite binding-profile https://review.openstack.org/505613
02:32:53 openstackgerrit Yikun Jiang proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904
02:35:11 openstackgerrit Michael Still proposed openstack/nova master: Convert ext filesystem resizes to privsep. https://review.openstack.org/517516
02:40:19 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach/swap volumes https://review.openstack.org/517205
02:54:42 openstackgerrit Yikun Jiang proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904
02:59:04 openstackgerrit Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
03:26:55 openstackgerrit Yikun Jiang proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904
03:27:46 openstackgerrit Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
03:46:11 openstackgerrit Yikun Jiang proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904
03:50:14 openstackgerrit Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
06:17:10 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach/swap volumes https://review.openstack.org/517205
06:54:20 openstackgerrit Chen Hanxiao proposed openstack/nova master: libvirt: do unicode conversion for error messages. https://review.openstack.org/517555
09:33:12 openstackgerrit Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
09:36:14 openstackgerrit Matthew Booth proposed openstack/nova master: libvirt: Don't VIR_MIGRATE_NON_SHARED_INC without migrate_disks https://review.openstack.org/507202
09:41:19 openstackgerrit Jianghua Wang proposed openstack/nova master: XenAPI: create vGPU for instance https://review.openstack.org/516899
09:43:21 openstackgerrit Rong Han proposed openstack/nova master: Fixed the known vcpuset description of CPUPinningUnknown https://review.openstack.org/517592
09:51:42 tomsou_ openstack: ping
11:01:25 openstackgerrit Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data https://review.openstack.org/452818
11:01:25 openstackgerrit Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (2) https://review.openstack.org/452819
11:01:26 openstackgerrit Balazs Gibizer proposed openstack/nova master: Deduplicated instance.(un)pause notification samples https://review.openstack.org/452820
11:01:26 openstackgerrit Balazs Gibizer proposed openstack/nova master: Deduplicate instance.power-off notification samples https://review.openstack.org/475860
11:01:27 openstackgerrit Balazs Gibizer proposed openstack/nova master: Deduplicate instance.interface_attach samples https://review.openstack.org/515740
11:01:27 openstackgerrit Balazs Gibizer proposed openstack/nova master: Deduplicate instance.live_migration notification samples https://review.openstack.org/515745
11:01:28 openstackgerrit Balazs Gibizer proposed openstack/nova master: Deduplicate instance.reboot notification samples https://review.openstack.org/515751
11:55:18 fried_rice gibi for https://review.openstack.org/#/c/517364/ - I'm just gonna remove the __eq__ method and rebase the other patches to do the equality in the UT modules themselves. That cool with you?
12:11:17 fried_rice leakypipes Good morning!
12:11:34 leakypipes fried_rice: good morning, my non-Sydney colleague :)
12:12:05 fried_rice I would say I'm sad I'm not in Sydney, if that was true.
12:12:43 leakypipes fried_rice: ack
12:13:45 fried_rice leakypipes I'm going to restack the forked series to address gibi's comment on the common RequestGroup thingy. I had some questions for you on https://review.openstack.org/#/c/515151/ if you have a chance to look real quick; then I can do it all together.
12:14:05 leakypipes fried_rice: yup, totes
12:14:42 fried_rice leakypipes BTW, my plan is just to rip out that __eq__ method - it was just for testing anyway, so I'm going to fold it into the UT code itself. You on board with that?
12:14:59 leakypipes fried_rice: absolutely.
12:15:01 fried_rice k
12:15:09 leakypipes gibi's comment made sense
12:21:32 openstackgerrit Eric Fried proposed openstack/nova master: RequestGroup class for placement & consumers https://review.openstack.org/517364
12:21:33 openstackgerrit Eric Fried proposed openstack/nova master: placement: Parse granular resources & traits https://review.openstack.org/514091
12:21:33 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Numbered groupings to GET /allocation_candidates https://review.openstack.org/514092
12:21:41 leakypipes mikal: as requested. :) https://review.openstack.org/#/c/517617/
12:42:55 leakypipes alex_xu: not sure if you're around, but if you are, let me know your thoughts on my response to your comment on https://review.openstack.org/#/c/516779/
12:45:05 leakypipes fried_rice: your opinion on ^ would be great, too
12:45:17 fried_rice leakypipes ack

Earlier   Later