| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-10-11 | |||
| 12:44:18 | bauzas | avolkov: ta. FWIW, I wrote a very old spec for that but looks like the consensus is that it's not needing a microversion | |
| 12:45:39 | stephenfin | sahid: Want to take a look at https://review.openstack.org/#/c/361140/ ? | |
| 12:50:41 | alex_xu | s/15 mins/10 mins/... | |
| 12:50:51 | sahid | stephenfin: yes i will, ok | |
| 12:53:22 | stephenfin | lyarwood, mdbooth: Fancy taking a look at this? Looks sane to me, at least https://review.openstack.org/#/c/290793/ | |
| 12:55:28 | mdbooth | stephenfin: Looking | |
| 12:58:33 | stephenfin | ralonsoh_: About? Got a question on https://review.openstack.org/#/c/484726/ | |
| 13:06:56 | ralonsoh_ | stephenfin: sure! but this is an ongoing patch. Once we have the os-vif migration patches uploaded, you'll see why this object is needed | |
| 13:07:40 | ralonsoh_ | stephenfin: as soon as I have the rest of the code uploaded, I'll complete the bug description and I'll link this patch to them | |
| 13:07:52 | ralonsoh_ | I'm on it] | |
| 13:08:34 | stephenfin | ralonsoh_: Cool cool :) Maybe stick it in WIP until then? | |
| 13:08:50 | ralonsoh_ | sure! I'll do this now | |
| 13:09:16 | efried | gibi I posted another response on https://review.openstack.org/#/c/510244/ -- please let me know if you disagree or would like to discuss further. Thanks! | |
| 13:09:30 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: [WIP] Add Open vSwitch patch port https://review.openstack.org/485228 | |
| 13:09:42 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: [WIP] Add Virtual Ethernet device pair https://review.openstack.org/484726 | |
| 13:12:20 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: nova-manage map_instances is not using the cells info from the API database https://review.openstack.org/510844 | |
| 13:28:20 | mriedem | gibi: https://review.openstack.org/#/c/510938/ | |
| 13:33:11 | sahid | stephenfin: it's not clear for me how are you make working "preferred", I mean in a technical POV | |
| 13:33:17 | sahid | https://review.openstack.org/#/c/361140/28/specs/queens/approved/share-pci-between-numa-nodes.rst | |
| 13:33:42 | sahid | stephenfin: you are probably going to use a weigher? | |
| 13:33:49 | gmann | mriedem: is it ok for you now - https://review.openstack.org/#/c/459483/33/nova/api/openstack/compute/server_migrations.py@58 | |
| 13:34:07 | gmann | mriedem: not having whitelist to add 'type' in response | |
| 13:34:37 | stephenfin | sahid: What aspect of it? | |
| 13:34:47 | sahid | scheduling | |
| 13:36:02 | sahid | stephenfin: from how i see that you need two pass, and i don't think it"s something that the current scheduler provides | |
| 13:37:19 | stephenfin | sahid: Yeah, I think you might be right there. We're probably going to stick with making it configurable at the host leve | |
| 13:37:44 | stephenfin | i.e. you use the first host that is given to you by the scheduler | |
| 13:38:02 | sahid | stephenfin: seems more reasonable yes | |
| 13:38:06 | stephenfin | I don't think the two-pass solution is possible either. jaypipes might have suggestions though | |
| 13:38:19 | stephenfin | sahid: Cool. I can update the spec accordingly | |
| 13:38:58 | sahid | mriedem, jaypipes can one of you look ACK this this https://review.openstack.org/#/c/497457/ ? | |
| 13:41:38 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: nova-manage map_instances is not using the cells info from the API database https://review.openstack.org/510844 | |
| 13:43:40 | mriedem | sahid: need to see the live migration job pass on that first | |
| 13:43:46 | mriedem | stephenfin: ^ | |
| 13:47:07 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: nova-manage map_instances is not using the cells info from the API database https://review.openstack.org/510844 | |
| 13:49:34 | sahid | jaypipes: i replied to you about the sriov-trusted-vfs (in case you did not notice it) | |
| 14:02:37 | mdbooth | stephenfin: Can't say I'm a fan of that change. Haven't put a -1 only because it's *probably* better than what we have now. Not sure if the added complexity is worth it, though. | |
| 14:04:48 | mriedem | sahid: which hypervisors don't support this flag? https://libvirt.org/html/libvirt-libvirt-domain.html#VIR_MIGRATE_PARAM_BANDWIDTH | |
| 14:08:11 | sahid | mriedem: hum.. let me check that point | |
| 14:09:47 | openstackgerrit | Merged openstack/nova master: Don't fix protocol-less glance api_servers anymore https://review.openstack.org/505317 | |
| 14:12:02 | sahid | mriedem: according to a simple grep in libvirt source it seems that vz and QEMU are supporting it | |
| 14:12:31 | sahid | but but nothing about vmware, hyperv.. | |
| 14:13:22 | mriedem | sahid: well we wouldn't care about vmware or hyperv in the libvirt driver | |
| 14:13:37 | mriedem | but we care about xen, although i'm not sure if libvirt+xen is listed as supporting live migration anyway | |
| 14:13:57 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Granular Resource Request Syntax https://review.openstack.org/510244 | |
| 14:13:59 | mriedem | according to this it says we do https://docs.openstack.org/nova/latest/user/support-matrix.html#operation_live_migrate | |
| 14:14:31 | openstackgerrit | Merged openstack/nova master: Move user_data max length check to schema https://review.openstack.org/510704 | |
| 14:14:55 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: nova-manage map_instances is not using the cells info from the API database https://review.openstack.org/510844 | |
| 14:18:51 | sahid | mriedem: we always use that parameter (bandwiddh) for live-migration | |
| 14:19:09 | sahid | do you have a suggestion on how the code should be? | |
| 14:19:26 | mriedem | it must work for xen then | |
| 14:19:33 | sahid | I guess yes | |
| 14:19:33 | mriedem | libvirt+xen i mean | |
| 14:19:37 | sahid | but I can't ensure that | |
| 14:19:54 | mriedem | anthonyper: do you know what the current state of libvirt+xen live migration is? working? | |
| 14:19:58 | mriedem | has anyone tested lately? | |
| 14:25:41 | anthonyper | mriedem: I have no idea :( | |
| 14:33:46 | anthonyper | mriedem: I'll ask other people to try to find out if they have tested live migration recently. | |
| 14:34:36 | mriedem | anthonyper: ok thanks | |
| 14:36:09 | sahid | dansmith: if the wait_for_instance_event has been desgined has you are suggesting so it's not working | |
| 14:38:04 | dansmith | sahid: I'm not sure what you're saying | |
| 14:38:27 | jaypipes | sahid: yep, noticed it. sorry, been spending my last days rebasing the nested resource providers series. | |
| 14:38:42 | jaypipes | sahid: I'll review that slow live-migration patch this morning. | |
| 14:38:50 | openstackgerrit | Merged openstack/nova master: Add connection pool size to vSphere settings https://review.openstack.org/414085 | |
| 14:39:12 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: nova-manage map_instances is not using the cells info from the API database https://review.openstack.org/510844 | |
| 14:39:20 | sahid | jaypipes: no worries and thanks if you can have a look | |
| 14:39:34 | openstackgerrit | Merged openstack/nova master: Clarify conf/compute.py help text for ListOpts https://review.openstack.org/468538 | |
| 14:39:53 | sahid | dansmith: related to one of your comment on https://review.openstack.org/#/c/497457/ | |
| 14:40:20 | sahid | the other one are just nits, right? | |
| 14:41:35 | dansmith | sahid: no, breaking n-net migrations is not a nit :) | |
| 14:42:39 | sahid | dansmith: can you clearly put a suggestion? do you me to add a condition in the code? | |
| 14:43:17 | dansmith | sahid: you can handle it like the spawn code does for if neutron isn't enabled | |
| 14:43:31 | mriedem | if (self._conn_supports_start_paused and | |
| 14:43:31 | mriedem | utils.is_neutron() and not | |
| 14:43:31 | mriedem | vifs_already_plugged and power_on and timeout): | |
| 14:43:31 | mriedem | events = self._get_neutron_events(network_info) | |
| 14:43:31 | mriedem | else: | |
| 14:43:32 | mriedem | events = [] | |
| 14:43:32 | mriedem | yeah | |
| 14:43:44 | mriedem | if this and that and the other thing else something different | |
| 14:43:49 | sahid | dansmith: seems reasonable | |
| 14:44:58 | dansmith | sahid: I also want to know which specific action starts the chain of events that will result in neutron sending an event to nova, so that you can properly wrap that thing with the waiter | |
| 14:45:56 | sahid | dansmith: depending of the mech used, i added a comment in the code | |
| 14:47:24 | dansmith | sahid: ah, so two different places depending on OVS or linuxbridge? that's going to be a mess to handle properly | |
| 14:47:30 | dansmith | but what you have isn't right for either | |
| 14:47:35 | dansmith | although it's much much wronger for OVS | |
| 14:50:01 | sahid | dansmith: i guess you are going to elaborate? | |
| 14:50:43 | dansmith | sahid: I did in my comments | |
| 14:50:48 | dansmith | nova events are not queued | |
| 14:50:58 | dansmith | if you don't have a waiter running before an event arrives, it is dropped | |
| 14:51:20 | dansmith | if you don't want to race, you need to have a waiter set up before you do the thing that triggers the event from the other service | |
| 14:51:46 | dansmith | delaying live migration for five minutes, timeout, log error and then continue is not a good thing to do just because you raced with neutron | |
| 14:54:47 | mdbooth | mriedem: To spec, or not to spec: https://blueprints.launchpad.net/nova/+spec/local-disk-serial-numbers ? | |
| 14:55:19 | mdbooth | dansmith: Same question ^^^ | |
| 14:55:26 | sahid | dansmith: i see so we will have to add this specificly for ovs during pre-live-migration when we are creating the bridge on dest | |
| 14:55:43 | sahid | and when we start calling libvirt.migrateToURI for LB | |
| 14:56:15 | dansmith | sahid: neither option seems very ideal to me, but yes, that's the issue with what you have here | |
| 14:57:00 | dansmith | mdbooth: probably a spec so we can argue about your id generation method | |
| 14:57:21 | mdbooth | dansmith: Yeay! I do love a good opportunity to argue about stuff. | |
| 14:57:26 | mdbooth | Ok | |