Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-10-11
14:39:53 sahid dansmith: related to one of your comment on https://review.openstack.org/#/c/497457/
14:40:20 sahid the other one are just nits, right?
14:41:35 dansmith sahid: no, breaking n-net migrations is not a nit :)
14:42:39 sahid dansmith: can you clearly put a suggestion? do you me to add a condition in the code?
14:43:17 dansmith sahid: you can handle it like the spawn code does for if neutron isn't enabled
14:43:31 mriedem if (self._conn_supports_start_paused and
14:43:31 mriedem utils.is_neutron() and not
14:43:31 mriedem vifs_already_plugged and power_on and timeout):
14:43:31 mriedem events = self._get_neutron_events(network_info)
14:43:31 mriedem else:
14:43:32 mriedem events = []
14:43:32 mriedem yeah
14:43:44 mriedem if this and that and the other thing else something different
14:43:49 sahid dansmith: seems reasonable
14:44:58 dansmith sahid: I also want to know which specific action starts the chain of events that will result in neutron sending an event to nova, so that you can properly wrap that thing with the waiter
14:45:56 sahid dansmith: depending of the mech used, i added a comment in the code
14:47:24 dansmith sahid: ah, so two different places depending on OVS or linuxbridge? that's going to be a mess to handle properly
14:47:30 dansmith but what you have isn't right for either
14:47:35 dansmith although it's much much wronger for OVS
14:50:01 sahid dansmith: i guess you are going to elaborate?
14:50:43 dansmith sahid: I did in my comments
14:50:48 dansmith nova events are not queued
14:50:58 dansmith if you don't have a waiter running before an event arrives, it is dropped
14:51:20 dansmith if you don't want to race, you need to have a waiter set up before you do the thing that triggers the event from the other service
14:51:46 dansmith delaying live migration for five minutes, timeout, log error and then continue is not a good thing to do just because you raced with neutron
14:54:47 mdbooth mriedem: To spec, or not to spec: https://blueprints.launchpad.net/nova/+spec/local-disk-serial-numbers ?
14:55:19 mdbooth dansmith: Same question ^^^
14:55:26 sahid dansmith: i see so we will have to add this specificly for ovs during pre-live-migration when we are creating the bridge on dest
14:55:43 sahid and when we start calling libvirt.migrateToURI for LB
14:56:15 dansmith sahid: neither option seems very ideal to me, but yes, that's the issue with what you have here
14:57:00 dansmith mdbooth: probably a spec so we can argue about your id generation method
14:57:21 mdbooth dansmith: Yeay! I do love a good opportunity to argue about stuff.
14:57:26 mdbooth Ok
14:58:25 mriedem gmann_afk: commented in that change and the one below it
15:07:47 sahid dansmith: since we are now using the events, do you see a blocker at moving plug_vifs() from pre-live-migration to migration step?
15:07:50 mriedem sahid: i looked at one of the live migration job runs on your patch and it's never waiting for any events
15:08:07 openstackgerrit Eric Fried proposed openstack/nova master: Nix bug msg from ConfGroupForServiceTypeNotFound https://review.openstack.org/511261
15:08:17 efried mriedem ^ cleanup as requested.
15:08:45 sahid mriedem: what is the mech? for linux bridge we need that patch on neutron side
15:08:48 sahid https://review.openstack.org/#/c/506182/
15:09:27 mriedem sahid: the depends-on will pull the change in via zuul
15:09:41 mriedem sahid: it's literally building an empty list of events
15:09:47 mriedem meaning there are no vifs in the instance.info_cache
15:09:53 mriedem this would be ovs
15:10:08 mriedem http://logs.openstack.org/57/497457/11/check/legacy-tempest-dsvm-multinode-live-migration/9cd842e/logs/screen-n-cpu.txt.gz#_Oct_02_11_04_06_172675
15:10:20 sahid mriedem: hm... if there is no vifs so yes i guess it's normal
15:11:36 mriedem hmm wtf http://logs.openstack.org/57/497457/11/check/legacy-tempest-dsvm-multinode-live-migration/9cd842e/logs/screen-n-cpu.txt.gz#_Oct_02_11_04_01_315354
15:11:59 mriedem cfriesen: ^ this probably explains why i never saw any improvement in the network-changed event queueing patch for live migration
15:12:00 sahid hum...
15:12:29 mriedem cfriesen: this one https://review.openstack.org/#/c/465787/
15:17:02 efried We needing to pay attention to bogus Zuul merge conflicts at this point?
15:17:09 mriedem no
15:17:16 mriedem well, idk, but i'm not
15:17:25 dansmith today we do
15:17:28 efried Thought they cut over this morning.
15:17:31 dansmith once the cutover starts
15:35:54 jianghuaw_ jaypipes, per the previous, we should populate the inventory for vgpu in the function of get_inventory. So we should re-open this abandoned patch: https://review.openstack.org/#/c/339204/. Is it correct?
15:38:38 openstackgerrit Merged openstack/nova master: Updated from global requirements https://review.openstack.org/511021
15:40:39 bauzas jianghuaw: I tend to say yes
15:40:42 jaypipes jianghuaw_: yes
15:40:50 bauzas jianghuaw: FWIW, I'm working on the libvirt side
15:40:51 jaypipes jianghuaw_: feel free to take it.
15:41:18 jaypipes jianghuaw_: I restored it just now. feel free to git review -d 339204 and take over ownership
15:41:36 jaypipes jianghuaw_: or cherry-pick it as you want\
15:41:39 jianghuaw_ bauzas, jaypipes: great. Thanks.
15:42:47 openstackgerrit Eric Fried proposed openstack/nova master: Get auth from context for glance endpoint https://review.openstack.org/490057
15:44:18 openstackgerrit Eric Fried proposed openstack/nova master: Use ksa adapter for keystone conf & requests https://review.openstack.org/507693
15:44:33 openstackgerrit Eric Fried proposed openstack/nova master: Use ksa adapter for cinder client https://review.openstack.org/508345
15:44:46 openstackgerrit Eric Fried proposed openstack/nova master: Use ksa adapter for neutron client https://review.openstack.org/509892
15:45:58 openstackgerrit melanie witt proposed openstack/nova master: Fix target_cell usage for scatter_gather_cells https://review.openstack.org/510691
15:45:59 openstackgerrit melanie witt proposed openstack/nova master: Elevate existing RequestContext to get bandwidth usage https://review.openstack.org/509968
15:45:59 openstackgerrit melanie witt proposed openstack/nova master: Make expected notifications output easier to read in tests https://review.openstack.org/510823
15:46:00 openstackgerrit melanie witt proposed openstack/nova master: Improve the CellDatabases test fixture and usage https://review.openstack.org/508432
15:48:08 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Fix connection info refresh for reboot https://review.openstack.org/511209
15:52:09 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285
15:52:09 openstackgerrit Ildiko Vancsa proposed openstack/nova master: DNM: Fail if we try to update volume connections during reboot https://review.openstack.org/511031
15:52:52 ildikov mriedem: attempt to fix the attachment_update mystery ^^
15:54:33 mriedem ildikov: HA!
15:54:38 mriedem holy shit nice catch
15:55:31 ildikov mriedem: my pleasure :)
15:56:07 ildikov jgriffith: it seems we're off the hook this time :) ^^
15:56:23 mriedem there is another one like that in here
15:56:27 mriedem might as well fix that one too
16:03:58 openstackgerrit Jay Pipes proposed openstack/nova master: rp: remove CRUD operations on Inventory class https://review.openstack.org/509029
16:03:58 openstackgerrit Jay Pipes proposed openstack/nova master: rp: streamline InventoryList.get_all_by_rp_uuid() https://review.openstack.org/509030
16:03:59 openstackgerrit Jay Pipes proposed openstack/nova master: rp: remove dead code in Allocation._create_in_db() https://review.openstack.org/509031
16:03:59 openstackgerrit Jay Pipes proposed openstack/nova master: rp: remove ability to delete 1 allocation record https://review.openstack.org/509032
16:04:00 openstackgerrit Jay Pipes proposed openstack/nova master: rp: fix up AllocList.get_by_resource_provider_uuid https://review.openstack.org/509033
16:04:00 openstackgerrit Jay Pipes proposed openstack/nova master: rp: rework AllocList.get_all_by_consumer_id() https://review.openstack.org/509035
16:04:01 openstackgerrit Jay Pipes proposed openstack/nova master: placement: set/check if inventory change in tree https://review.openstack.org/470575
16:04:01 openstackgerrit Jay Pipes proposed openstack/nova master: placement: integrate ProviderTree to report client https://review.openstack.org/415921
16:04:02 openstackgerrit Jay Pipes proposed openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138
16:04:02 openstackgerrit Jay Pipes proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215
16:04:05 openstackgerrit Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807
16:04:05 openstackgerrit Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693
16:07:59 ildikov mriedem: will do, thanks
16:08:22 ildikov mriedem: I was too eager to get a clean run on the new attach patch :)
16:11:57 openstackgerrit sean mooney proposed openstack/nova-specs master: Use neutron's new port binding API https://review.openstack.org/375580
16:12:50 dansmith mdbooth: if you want that bdm uuid patch for the serial number thing, I think we should slam it in soonly
16:13:09 dansmith I think everyone knows it's a good idea and uncontentious, it's just never been in the critical path for anyone for long enough

Earlier   Later