| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-09-22 | |||
| 14:55:02 | liuyulong | s/ether/either | |
| 14:55:29 | mriedem | liuyulong: if you boot a new vm, you're providing a new keypair anyway | |
| 14:55:58 | mriedem | the user does'nt change the cloud-init config, that's up to the deployer | |
| 14:56:47 | liuyulong | ha, we are talking back to rebuild API again. | |
| 14:57:10 | mriedem | its very simple, if all you want to do is rebuild and have a new keypair, (1) update the keypair on the instance, (2) rebuild the instance | |
| 14:57:28 | mriedem | if (2) is something else, like cold migrate, unshelve, resize, reboot, then you can do that because of (1) | |
| 14:57:58 | liuyulong | What if cloud-init does not running in every boot ? | |
| 14:58:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rename cellsv2_layout -> cellsv2-layout https://review.openstack.org/498821 | |
| 14:58:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Cleanup of existing index pages https://review.openstack.org/498819 | |
| 14:58:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP! doc: Add contents page https://review.openstack.org/498820 | |
| 14:59:07 | liuyulong | rebuild is something like `recreate`, the new VM disk cloud-init may not cache the old instance id. So it can be running. | |
| 14:59:48 | liuyulong | But booting actions like reboot, resize, unshelve do not have such situation. | |
| 15:00:34 | sdague | mriedem: https://review.openstack.org/#/c/454323/ has seen a lot of rechecks / rebases and the full stack testing is looking pretty solid | |
| 15:00:55 | sdague | that's the live snapshot by default | |
| 15:05:35 | mriedem | sdague: there is something new in there | |
| 15:05:37 | mriedem | unless i'm blind | |
| 15:08:15 | liuyulong | Allow me to rephrase: And for the running instance. If user does not change the cloud-init config. They create image and then boot a new VM. Even the entire cloud platform images have been updated, new API can not avoid inconsistent for this new VM. | |
| 15:13:08 | openstackgerrit | konstantin proposed openstack/nova master: don't add device address if there is no any units https://review.openstack.org/506686 | |
| 15:13:09 | openstackgerrit | konstantin proposed openstack/nova master: switch from filesystem to disk for parallels containers https://review.openstack.org/506687 | |
| 15:13:28 | sdague | mriedem: there are test changes | |
| 15:13:38 | sdague | and there is the bit you changed in patch #2 | |
| 15:13:40 | mriedem | no, the PAUSED thing | |
| 15:13:52 | sdague | so PS #2 are your changes | |
| 15:14:01 | mriedem | i don't remember that | |
| 15:14:10 | mriedem | you hacked my account back in april | |
| 15:14:27 | sdague | I can slice them out again | |
| 15:14:36 | mriedem | https://review.openstack.org/#/c/454323/1..2/nova/virt/libvirt/driver.py | |
| 15:14:37 | mriedem | wtf | |
| 15:14:58 | mriedem | it was probably needed for something | |
| 15:16:38 | sdague | here is a version with that deleted back out | |
| 15:16:40 | openstackgerrit | Sean Dague proposed openstack/nova master: Change livesnapshot to true by default https://review.openstack.org/454323 | |
| 15:16:57 | mriedem | suspend does a managedSave | |
| 15:17:00 | mriedem | but pause doesn't | |
| 15:17:00 | sdague | I do think there is a state transition which is wrong in a tempest test | |
| 15:17:08 | sdague | ok | |
| 15:17:38 | sdague | well, I have to go do a preschool pickup, so ponder what's needed there, as you made that slice of changes :) | |
| 15:19:49 | mriedem | yeah idk, don't get it, would probably have to see if tests fail, or ask kashyap | |
| 15:20:20 | mriedem | i think we have a tempest test that will snapshot a paused instance and it will fail, but we'll see | |
| 15:20:43 | mriedem | https://wiki.openstack.org/wiki/Kvm-Pause-Suspend | |
| 15:20:45 | mriedem | oops | |
| 15:20:49 | mriedem | test_create_image_from_paused_server | |
| 15:20:50 | mriedem | that's the one | |
| 15:21:49 | liuyulong | mriedem, sdague, Kevin_Zheng, so I hope that both spec can landed in queens cycle. I will continue to focus on these developments. Thank you guys. | |
| 15:40:11 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Remove 'vendordata_driver' opt https://review.openstack.org/397835 | |
| 15:43:26 | mriedem | finucannot: drop the 'enough' in the release note there and i'm +2 | |
| 15:44:09 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Remove 'vendordata_driver' opt https://review.openstack.org/397835 | |
| 15:44:15 | finucannot | mriedem: done | |
| 15:47:37 | mriedem | i take that back :) | |
| 15:47:39 | mriedem | comments inline | |
| 15:47:46 | mriedem | we need to talk to mikal | |
| 15:48:07 | mriedem | fine with the removal, but looks like we can remove that vddriver stuff and just default vendordata_providers to StaticJSON | |
| 15:59:33 | finucannot | mriedem: That's fair. Let's wait and see what mikal comes back with | |
| 16:00:50 | MikeW | Hey can you guys help me figure out where this nova error is coming from? It only happens when I use an ephemeral based flavor (ceph is my backend): https://pastebin.com/C5Ra74Wi | |
| 16:01:31 | MikeW | I'm not an amazing programmer and dug into those python files and couldn't see what was really going on | |
| 16:13:41 | openstackgerrit | Ed Leafe proposed openstack/nova master: Add alternate hosts https://review.openstack.org/486215 | |
| 16:13:42 | openstackgerrit | Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239 | |
| 16:13:52 | figleaf | superdan: leakypipes: ^^ updated | |
| 16:14:02 | leakypipes | kk | |
| 16:14:09 | figleaf | note that tests will fail; didn't update them pending further changes | |
| 16:14:58 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Spec for flavor description https://review.openstack.org/501017 | |
| 16:21:05 | openstackgerrit | Dan Smith proposed openstack/nova master: Move allocation manipulation out of drop_move_claim() https://review.openstack.org/498947 | |
| 16:21:06 | openstackgerrit | Dan Smith proposed openstack/nova master: Make allocation cleanup honor new by-migration rules https://review.openstack.org/498948 | |
| 16:21:06 | openstackgerrit | Dan Smith proposed openstack/nova master: Pre-create migration object https://review.openstack.org/498950 | |
| 16:21:07 | openstackgerrit | Dan Smith proposed openstack/nova master: Revert allocations by migration uuid https://review.openstack.org/498949 | |
| 16:21:07 | openstackgerrit | Dan Smith proposed openstack/nova master: Refactor resource tracker to account for migration allocations https://review.openstack.org/506419 | |
| 16:21:08 | openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420 | |
| 16:21:55 | superdan | leakypipes: I think these earlier patches are starting to converge on decent ^.. I won't mind if we pin the first one until the later one is done, but would appreciate an early spin through the set to make sure it makes sense to you | |
| 16:22:16 | leakypipes | superdan: will do :) | |
| 16:24:05 | openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/506640 | |
| 16:28:12 | openstackgerrit | Merged openstack/nova master: docs: Rename cellsv2_layout -> cellsv2-layout https://review.openstack.org/498821 | |
| 16:35:14 | mriedem | superdan: on that note, i've got the unshelve fail allocation test and fix lined up here https://review.openstack.org/#/c/506458/ | |
| 16:35:18 | mriedem | which will get backported | |
| 16:35:27 | mriedem | still need to do one for bug 1715182 | |
| 16:35:28 | openstack | bug 1715182 in OpenStack Compute (nova) pike "_rollback_live_migration does not remove allocations from destination node" [High,Triaged] https://launchpad.net/bugs/1715182 | |
| 16:35:51 | openstackgerrit | Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239 | |
| 16:37:03 | superdan | mriedem: okay | |
| 16:37:43 | sdague | mriedem: ok, fixing the release notes. I suppose I should probably take your fix in as a dedicated fix up front? | |
| 16:38:13 | mriedem | sdague: idk, did that tempest test fail? | |
| 16:39:07 | sdague | mriedem: I guess it didn't | |
| 16:39:46 | sdague | I'll let the current round of tests pass, then push the reno fix | |
| 16:39:55 | sdague | then we've got more passing tests on things | |
| 16:41:53 | superdan | figleaf: does the late call of _get_sorted_hosts() give us a new set of hosts that haven't been claimed in the first loop? | |
| 16:44:07 | superdan | that must be right | |
| 16:45:04 | mriedem | leakypipes: i think this is fine, but wanted you to take a look since i know you fixed a bug with bad performance on loading instance faults at one point https://review.openstack.org/#/c/505391/ | |
| 16:45:15 | mriedem | in the instance_fault_get_by_instance_uuids method that is | |
| 16:48:27 | superdan | mriedem: I use the thing leakypipes added which gets just the latest fault | |
| 16:48:35 | mriedem | yeah i know | |
| 16:48:37 | superdan | for each instance in a list | |
| 16:48:37 | superdan | okay | |
| 16:48:48 | mriedem | just remembered it being a thing once | |
| 16:51:06 | leakypipes | looking now. | |
| 16:52:48 | superdan | mriedem: leakypipes: note that right now we're getting instance faults either one by one, or later from the api if it does a fill_faults on the InstanceList | |
| 16:53:04 | superdan | this is really just doing the latter from the lower layer if it was requested | |
| 16:53:27 | superdan | fill_faults from the api the way it is today won't work because it doesn't know about things in different cells | |
| 16:53:50 | superdan | which is a bug in pike I guess, but fixing it would not be super easy | |
| 16:54:04 | mriedem | hmm, probably worth at least reporting that so we know about it | |
| 16:54:13 | mriedem | could also doc as a known issue if nothing else | |
| 16:54:16 | mriedem | *always | |
| 16:54:27 | mriedem | shite, lunch tie | |
| 16:54:28 | mriedem | *time | |