Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-09-22
15:47:37 mriedem i take that back :)
15:47:39 mriedem comments inline
15:47:46 mriedem we need to talk to mikal
15:48:07 mriedem fine with the removal, but looks like we can remove that vddriver stuff and just default vendordata_providers to StaticJSON
15:59:33 finucannot mriedem: That's fair. Let's wait and see what mikal comes back with
16:00:50 MikeW Hey can you guys help me figure out where this nova error is coming from? It only happens when I use an ephemeral based flavor (ceph is my backend): https://pastebin.com/C5Ra74Wi
16:01:31 MikeW I'm not an amazing programmer and dug into those python files and couldn't see what was really going on
16:13:41 openstackgerrit Ed Leafe proposed openstack/nova master: Add alternate hosts https://review.openstack.org/486215
16:13:42 openstackgerrit Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239
16:13:52 figleaf superdan: leakypipes: ^^ updated
16:14:02 leakypipes kk
16:14:09 figleaf note that tests will fail; didn't update them pending further changes
16:14:58 openstackgerrit Matt Riedemann proposed openstack/nova-specs master: Spec for flavor description https://review.openstack.org/501017
16:21:05 openstackgerrit Dan Smith proposed openstack/nova master: Move allocation manipulation out of drop_move_claim() https://review.openstack.org/498947
16:21:06 openstackgerrit Dan Smith proposed openstack/nova master: Make allocation cleanup honor new by-migration rules https://review.openstack.org/498948
16:21:06 openstackgerrit Dan Smith proposed openstack/nova master: Pre-create migration object https://review.openstack.org/498950
16:21:07 openstackgerrit Dan Smith proposed openstack/nova master: Revert allocations by migration uuid https://review.openstack.org/498949
16:21:07 openstackgerrit Dan Smith proposed openstack/nova master: Refactor resource tracker to account for migration allocations https://review.openstack.org/506419
16:21:08 openstackgerrit Dan Smith proposed openstack/nova master: WIP: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420
16:21:55 superdan leakypipes: I think these earlier patches are starting to converge on decent ^.. I won't mind if we pin the first one until the later one is done, but would appreciate an early spin through the set to make sure it makes sense to you
16:22:16 leakypipes superdan: will do :)
16:24:05 openstackgerrit Merged openstack/nova master: Updated from global requirements https://review.openstack.org/506640
16:28:12 openstackgerrit Merged openstack/nova master: docs: Rename cellsv2_layout -> cellsv2-layout https://review.openstack.org/498821
16:35:14 mriedem superdan: on that note, i've got the unshelve fail allocation test and fix lined up here https://review.openstack.org/#/c/506458/
16:35:18 mriedem which will get backported
16:35:27 mriedem still need to do one for bug 1715182
16:35:28 openstack bug 1715182 in OpenStack Compute (nova) pike "_rollback_live_migration does not remove allocations from destination node" [High,Triaged] https://launchpad.net/bugs/1715182
16:35:51 openstackgerrit Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239
16:37:03 superdan mriedem: okay
16:37:43 sdague mriedem: ok, fixing the release notes. I suppose I should probably take your fix in as a dedicated fix up front?
16:38:13 mriedem sdague: idk, did that tempest test fail?
16:39:07 sdague mriedem: I guess it didn't
16:39:46 sdague I'll let the current round of tests pass, then push the reno fix
16:39:55 sdague then we've got more passing tests on things
16:41:53 superdan figleaf: does the late call of _get_sorted_hosts() give us a new set of hosts that haven't been claimed in the first loop?
16:44:07 superdan that must be right
16:45:04 mriedem leakypipes: i think this is fine, but wanted you to take a look since i know you fixed a bug with bad performance on loading instance faults at one point https://review.openstack.org/#/c/505391/
16:45:15 mriedem in the instance_fault_get_by_instance_uuids method that is
16:48:27 superdan mriedem: I use the thing leakypipes added which gets just the latest fault
16:48:35 mriedem yeah i know
16:48:37 superdan for each instance in a list
16:48:37 superdan okay
16:48:48 mriedem just remembered it being a thing once
16:51:06 leakypipes looking now.
16:52:48 superdan mriedem: leakypipes: note that right now we're getting instance faults either one by one, or later from the api if it does a fill_faults on the InstanceList
16:53:04 superdan this is really just doing the latter from the lower layer if it was requested
16:53:27 superdan fill_faults from the api the way it is today won't work because it doesn't know about things in different cells
16:53:50 superdan which is a bug in pike I guess, but fixing it would not be super easy
16:54:04 mriedem hmm, probably worth at least reporting that so we know about it
16:54:13 mriedem could also doc as a known issue if nothing else
16:54:16 mriedem *always
16:54:27 mriedem shite, lunch tie
16:54:28 mriedem *time
16:54:35 superdan lemme see if I can write a test to poke that
17:00:38 figleaf superdan: the claimed hosts will still be in the list unless a filter tosses them. Since we aren't using resource filters, it's not likely that it would be removed from the list of hosts, but the sorting for alternates will certainly change
17:01:42 superdan figleaf: okay, but would it remove hosts that no longer fit after the primary consume operation was made?
17:02:11 superdan figleaf: meaning if we choose an almost-full host as a primary for one instance and consume_from_instance it or whatever, is it no longer a candidate for the last loop at the bottom to look for alternates?
17:02:46 figleaf superdan: depends on the weighers used, right? E.g., pack-vs-spread
17:03:07 openstackgerrit Kashyap Chamarthy proposed openstack/nova-specs master: [WIP] Add ability for OVMF Secure Boot https://review.openstack.org/506720
17:03:44 figleaf superdan: it won't get removed, since resource constraints are handled in the placement call
17:03:47 superdan figleaf: well I meant if we consumed some resource, but I guess we don't have things like RamFilter in there by default anymore, so this just randomizes the result (if configured) and could hit all the same ones
17:03:49 superdan yeah
17:04:17 superdan hrm. seems like we're asking for trouble there
17:04:53 figleaf superdan: well, none of the claimed hosts will be added as alternates
17:05:15 leakypipes superdan: did you catch my request on the previous revision of your drop_allocation_for_move() patch about not using the internal RT compute_nodes dict data?
17:05:16 superdan figleaf: that's what I was just asking.. what prevents that?
17:05:28 superdan leakypipes: apparently not
17:05:51 figleaf superdan: Line 285: if host.cell_uuid == cell_uuid and host not in claimed_hosts:
17:06:03 superdan figleaf: heh, oh.. THAT
17:06:24 superdan I just saw the cell check and short-circuited the rest of the line
17:06:50 figleaf superdan: I can switch the order of that line if it helps :)
17:06:56 superdan no
17:09:20 leakypipes superdan: added some more info to the latest rev
17:09:30 superdan leakypipes: okay
17:09:31 superdan thanks
17:15:31 jose-phillips d
17:21:41 superdan mriedem: oh, no it'll work because if we fail to fill, we go one by one and grab the fault, targeted to the cell
17:21:48 superdan which is terribad, but it'll work
17:25:57 openstackgerrit Sean Dague proposed openstack/nova master: Change livesnapshot to true by default https://review.openstack.org/454323
17:33:14 figleaf leakypipes: it's not just tests that use dicts from _schedule_instances: https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L572-L573
17:34:03 leakypipes figleaf: removing that code block successfully identifies the culprits though, no? :)
17:35:05 figleaf leakypipes: yeah, but it means changing it here, and then in a later patch, changing it again to use Selection objects.
17:35:09 openstackgerrit Dan Smith proposed openstack/nova master: Move allocation manipulation out of drop_move_claim() https://review.openstack.org/498947
17:35:09 openstackgerrit Dan Smith proposed openstack/nova master: Make allocation cleanup honor new by-migration rules https://review.openstack.org/498948
17:35:10 openstackgerrit Dan Smith proposed openstack/nova master: Pre-create migration object https://review.openstack.org/498950
17:35:10 openstackgerrit Dan Smith proposed openstack/nova master: Revert allocations by migration uuid https://review.openstack.org/498949
17:35:11 openstackgerrit Dan Smith proposed openstack/nova master: Refactor resource tracker to account for migration allocations https://review.openstack.org/506419
17:35:11 openstackgerrit Dan Smith proposed openstack/nova master: WIP: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420
17:35:12 openstackgerrit Dan Smith proposed openstack/nova master: Add get_node_uuid() helper to ResourceTracker https://review.openstack.org/506730
17:35:19 figleaf leakypipes: So what if we leave this, knowing that it will be removed in a later patch?
17:35:29 figleaf this == host state dicts
17:35:57 leakypipes figleaf: that's cool with me. just make a note to address in a later patch is fine.
17:36:15 openstackgerrit Merged openstack/nova master: Fix 500 if list servers called with empty regex pattern https://review.openstack.org/506585
17:36:20 figleaf leakypipes: okie dokie
17:38:11 superdan figleaf: leakypipes: best way to do that is throw a patch up with the removal at the end
17:38:18 superdan clearly broken, but a tombstone reminder :)
17:38:28 leakypipes superdan: yep
17:38:44 superdan otherwise I doubt we'll come back to it
17:43:27 figleaf superdan: not sure that's necessary, since we'll be changing the return value from a host (dict or HostState) to a Selection object. All the code that touches select_destinations() will be affected
17:45:08 superdan figleaf: okay I guess I thought this was in the middle before the point at which we'd be forming out Selection objects

Earlier   Later