| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-09-14 | |||
| 20:40:03 | mriedem | tasker: oh, um, no probably different issue | |
| 20:40:26 | mriedem | john's spec is for new functionality | |
| 20:40:38 | tasker | ah. the two were coincidentally close. | |
| 20:57:38 | openstackgerrit | Michael Still proposed openstack/nova master: Have one list of reboot task_states https://review.openstack.org/219981 | |
| 20:58:07 | tasker | in the line preceding the TypeError, port_profile = p.get(BINDING_PROFILE, {}), this returns None, which implies that p[BINDING_PROFILE] is None itself. | |
| 21:00:04 | tasker | and, occassioanlly, it doesn't have that value, and returns the empty dictionary {} defined in the .get() | |
| 21:01:54 | tasker | it returns {} when there is no "binding:profile" key in the port dictionary | |
| 21:02:11 | tasker | it returns None when there is a "binding:profile", but when it's set to None. | |
| 21:02:37 | tasker | time to find out where the port is defined. hopefully I can find out why it's sometimes not there and other time is None. | |
| 21:07:23 | tasker | well, it's because the port itself has no "profile". | |
| 21:07:33 | tasker | so it looks like my issue is with neutron, not nova. | |
| 21:13:37 | openstackgerrit | Merged openstack/nova-specs master: Enable cold migration with target host https://review.openstack.org/489031 | |
| 21:17:10 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Refactor encryptor attach and detach calls https://review.openstack.org/460243 | |
| 21:18:07 | tasker | was "binding:profile" introduced in newton? | |
| 21:18:27 | tasker | I'm looking at a mitaka cluster and I don't see that on any of my ports. did nova start looking for in newton? | |
| 21:18:36 | tasker | is "binding:profile" a nova thing? | |
| 21:25:17 | mriedem | tasker: that was introduced here https://review.openstack.org/#/c/275073/ | |
| 21:25:18 | mriedem | in newton | |
| 21:25:25 | openstackgerrit | Merged openstack/nova master: Revert "Enable test_iscsi_volume in live migration job" https://review.openstack.org/504143 | |
| 21:27:05 | mriedem | i don't see why you'd get a NoneType here https://review.openstack.org/#/c/275073/45/nova/network/neutronv2/api.py@289 | |
| 21:27:41 | mriedem | since the port_profile should default to {}, UNLESS the port has binding:profile=None... | |
| 21:27:46 | mriedem | that's probably what's broken | |
| 21:27:46 | tasker | because of my ports. they are actually define with "binding:profile | None" | |
| 21:27:49 | tasker | yes | |
| 21:27:51 | tasker | and! | |
| 21:27:56 | mriedem | it should be: port_profile = p.get(BINDING_PROFILE, {}) or {} | |
| 21:28:15 | mriedem | tasker: ok, can you report a bug? | |
| 21:28:22 | mriedem | we'll have to start with the fix on master and get it backported | |
| 21:28:25 | tasker | I discoverd that the ports don't always have binding:profile -- it's presence changes between lookups. | |
| 21:28:29 | tasker | sure. | |
| 21:28:42 | openstackgerrit | Merged openstack/nova master: Default the service version in the notification tests https://review.openstack.org/499957 | |
| 21:29:38 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: Handle keypair not found from metadata server using cells https://review.openstack.org/500953 | |
| 21:36:34 | tasker | https://bugs.launchpad.net/nova/+bug/1717365 | |
| 21:36:35 | openstack | Launchpad bug 1717365 in OpenStack Compute (nova) "binding:profile is None breaks migration" [Undecided,New] | |
| 21:36:44 | tasker | I hope that's descriptive enough. | |
| 21:37:02 | tasker | I also took the liberty of attaching a patch. | |
| 21:38:03 | mriedem | tasker: works for me, thanks | |
| 21:38:34 | tasker | ok .. now why do my ports sometimes have "binding:profile" and sometimes not. this I think is a question for neutron. | |
| 21:39:22 | mriedem | yup | |
| 21:40:33 | tasker | mriedem: thanks for your help with the nova piece | |
| 21:40:36 | mriedem | tasker: oh it might have something to do with pci devices on the instance | |
| 21:40:43 | tasker | eh? | |
| 21:41:09 | tasker | are they magically disappearing and reappearing between each port lookup? | |
| 21:41:38 | mriedem | tasker: was looking at https://review.openstack.org/#/c/275073/45/nova/network/neutronv2/api.py@1037 | |
| 21:43:12 | tasker | oh, interesting. | |
| 21:43:49 | tasker | but I'm asking neutron about the port via `port-show` and sometimes it's there and sometimes it's not. even just a few seconds later. | |
| 21:44:10 | tasker | does neutron ask nova about some info when shows a port? | |
| 21:44:14 | mriedem | hmm, not sure, maybe some kind of race | |
| 21:44:18 | mriedem | no | |
| 21:44:22 | tasker | didn't think so. | |
| 21:44:56 | mriedem | i don't know enough about neutron, but could be something overwriting the profile from an agent or something coming in with a late update? idk | |
| 21:45:40 | tasker | yeah. thanks anyway for the point to the pci device. | |
| 21:49:02 | dansmith | mriedem: sdague: am I remembering that there is something non-intuitive about name-based referencing of instances, like that it's really a pattern match and not an exact string match? | |
| 21:49:38 | mriedem | instance_name_template | |
| 21:49:39 | mriedem | ? | |
| 21:49:45 | mriedem | or the actual db api query? | |
| 21:50:40 | melwitt | only certain fields (in the DB API) will do an exact match IIUC | |
| 21:51:06 | dansmith | no I mean for something like "nova show foo" | |
| 21:51:42 | sdague | dansmith: yeh, it's a regex by default | |
| 21:51:49 | melwitt | like this https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L2245-L2250 | |
| 21:51:50 | sdague | iirc | |
| 21:52:08 | melwitt | dansmith: you mean for matching the 'foo' of a nova show? | |
| 21:52:13 | dansmith | sdague: so if I have multiple instances that match the thing I ask for, it tells me there's no specific server that matches for a nova show right? | |
| 21:52:30 | dansmith | melwitt: yeah, like if I have foo1 and foo11, I can't do "nova show foo1" anymore | |
| 21:52:39 | sdague | dansmith: that might be | |
| 21:52:43 | melwitt | oh, yeah. | |
| 21:52:54 | sdague | dansmith: nova show "foo1$" | |
| 21:52:56 | sdague | ? | |
| 21:53:07 | dansmith | so... nova show '.*i.*' doesn't show my instance with an i in the name | |
| 21:54:36 | sdague | well, it's going into a LIKE clause, so it's not actually a regex | |
| 21:55:09 | dansmith | are we sure about that? | |
| 21:55:27 | dansmith | I'm looking at a bug that makes it sound like it's doing a LIKE, but I can't repro that in my local environment | |
| 21:56:03 | sdague | actualy never mind | |
| 21:56:17 | sdague | https://github.com/openstack/nova/blob/cfdec41eeec5fab220702efefdaafc45559aeb14/nova/db/sqlalchemy/api.py#L2312-L2351 | |
| 21:56:26 | sdague | we are in the ELSE | |
| 21:59:04 | bauzas | Venn diagram FTW. | |
| 22:01:53 | sdague | I expect what is happening with nova show is that it does a nova list behind the scenes with the name filter and getting > 1 result goes funky | |
| 22:03:43 | melwitt | yeah, I was thinking the same | |
| 22:03:47 | mriedem | tasker: what's your email for a co-authored-by on this patch? | |
| 22:04:02 | sdague | https://github.com/openstack/python-novaclient/blob/57c397d822a77d2f832ce9ddae349e5d4073c271/novaclient/v2/shell.py#L2337-L2338 | |
| 22:04:09 | sdague | it's supposed to give you an error back | |
| 22:08:03 | sdague | dansmith: the GET /server/{id} api does validate that to be a uuid or int, this is all novaclient logic | |
| 22:08:18 | openstackgerrit | Matt Riedemann proposed openstack/nova master: neutron: handle binding:profile=None during migration https://review.openstack.org/504260 | |
| 22:08:21 | dansmith | sdague: yeah, figuring that out now | |
| 22:14:03 | mriedem | stephenfin: please remove the TODO you slipped into this https://review.openstack.org/#/c/480674/ | |
| 22:15:01 | tasker | mriedem: should be linked to my account. | |
| 22:15:18 | mriedem | email was hidden | |
| 22:15:22 | tasker | oh. | |
| 22:16:59 | openstackgerrit | Matt Riedemann proposed openstack/nova master: neutron: handle binding:profile=None during migration https://review.openstack.org/504260 | |
| 22:17:02 | mriedem | tasker: ^ | |
| 22:17:52 | tasker | thanks! | |
| 22:20:57 | openstackgerrit | jichenjc proposed openstack/nova master: enhance api-ref for os-server-external-events https://review.openstack.org/504263 | |
| 22:21:25 | openstackgerrit | Merged openstack/nova master: [placement] Correct a comment in _set_allocations https://review.openstack.org/502167 | |
| 22:21:54 | openstackgerrit | Merged openstack/nova master: Add attachment_complete call to volume/cinder.py https://review.openstack.org/493323 | |
| 22:23:18 | openstackgerrit | Merged openstack/nova master: Tweak connection_info translation for the new Cinder attach/detach API https://review.openstack.org/493324 | |
| 22:33:25 | openstackgerrit | Merged openstack/nova master: Call terminate_connection when shelve_offloading https://review.openstack.org/257275 | |
| 22:35:39 | sdague | stephenfin: https://review.openstack.org/#/c/496160 question on that, mostly I think we hit the minimums for testing now, right? | |
| 22:39:04 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Call terminate_connection when shelve_offloading https://review.openstack.org/504270 | |
| 22:44:00 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | |
| 22:46:43 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Call terminate_connection when shelve_offloading https://review.openstack.org/504273 | |